- 29 May, 2020 15 commits
-
-
François Degros authored
BUG=912236 TEST=browser_tests --gtest_filter="ZipFiles/*" TEST=browser_tests --gtest_filter="*/FilesApp*" Change-Id: Ica61d18e69555fa1d1fc136e51b462c16ad83d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217766Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#772965}
-
Klaus Weidner authored
The EGL_ANDROID_native_fence_sync isn't reported as present to applications, so Chrome uses heuristics to infer if it's present. It's not usable in emulation or for SwiftShader. SurfaceControl assumes that GpuFence support is available, so don't use it if native fence sync is unavailable since that's used to implement GpuFence on Android. This check already existed but duplicated logic from gl_surface_egl, replace this with a feature check. Bug: 1086736 Change-Id: Ie2db42f605cb3eb90726b36b1bb264b4190bef80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217036Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#772964}
-
Karandeep Bhatia authored
Extension installation through the webstore involves creation of a dummy extension with an empty extension root path. The empty extension root path causes DNRManifestHandler::Parse to incorrectly raise an error while validating the paths for the extensions' ruleset files. This happens because ExtensionResource::empty() just checks whether the extension root path is empty. Fix this by replacing the ExtensionResource::empty() check with a more comprehensive check. BUG=1087348 TEST=Ensure https://chrome.google.com/webstore/detail/ajfdfkmbjmdjekckfgibicedaabjoong installs correctly. TBR=rdevlin.chronin@chromium.org Change-Id: I4e58cef19da771b17cc1d1541ccc7424b5b6f3af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219779 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772963}
-
Xiyuan Xia authored
EventGenerator uses WindowEventDispatcherObserver to throttle the mouse events. This does not work with nested loops in window moving/resizing or drag-n-drop. The mouse move event that triggers the nest loop does not finish until the nest loop quits. However, without further mouse events, the operation stalls and the nested loop would not quit. This CL revises the throttling part. It assumes that hitting the message pump implies the processing of the current event finishes and schedules the next event when that happens. Bug: 1032766 Change-Id: Ib32f06aa6d93b36372ea2b21d941e04293dbde2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220655Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772962}
-
Darren Shen authored
This CL is a followup of https://crrev.com/c/2212198. IMEBridge is only used for Chrome OS, so move IMEBridge to a Chrome OS specific folder. Note, this CL changes the word NULL in comments to nullptr to pass a presubmit check. Bug: 1083803 Change-Id: I8e962996f59c7cebf7a95503ec957e5f57065f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214590 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#772961}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99cdc265. With Chromium commits locally applied on WPT: 6956d3da "Avoid repeating a single row/column of tiled background images" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ia33ccf13537959dff7a6400cf9e7e3638c35d3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217877Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772960}
-
Christian Biesinger authored
This fixes a DCHECK, see https://crbug.com/991096#c29 Bug: 991096 Change-Id: I94bad7bc6a637754dbaf5b402d166cb27ab36574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220283 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#772959}
-
Sigurdur Asgeirsson authored
Bug: 1080672 Change-Id: Ib075e13fc02c8527f14e6e2e86eaa0a627c54f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218542 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#772958}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4504fd580a5f..090475cde4fa 2020-05-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6ad58ce0ae58c61f5cde1f50cf2a9bd6b6a22002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772957}
-
Dan Harrington authored
After all surfaces are detached, the model is eventually unloaded. The timeout used is configurable via finch parameter. Bug: 1044139 Change-Id: I015945215c1a0cc25fff92ccf20a5d72f52c7309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216037 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#772956}
-
Patrick Monette authored
This CL adds the ability for observers to know when a navigation for a window controllee commits to a RenderFrameHost. This is needed in the performance manager so that it is possible to connect service worker nodes to the frames it controls. The current OnControlleeAdded() notification does not include which render frame host this navigation is associated to because it is not known at the time OnControlleeAdded() is invoked. Bug: 993029 Change-Id: I91032a3ad606aceb98ae346e5f76bfec01cd4cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212808 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#772955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8fcb597f7e06..251f6d529453 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,dbertoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1021757 Tbr: lgrey@google.com,dbertoni@google.com Change-Id: I68897d827adab83e3731163f540c5d282d3579e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220583Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772954}
-
Amruth Raj authored
Sometimes, the Browser process tags events with kRelativeMotionEvent. For e.g. during pointer lock, it recenters cursor by warping so that cursor does not hit the screen boundary. In such a case the renderer is only supposed to update it's co-ordinates and not send these fake events to the DOM. This patch correctly suppresses pointerrawupdate events tagged with kRelativeMotionEvent from getting forwarded to the DOM. Bug: 1066544 Bug: 868660 Change-Id: Ib0a7337e3535a9719182bb1153038af11b6e9742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217928Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772953}
-
Matt Menke authored
In particular, separate out the HSTS and ExpectCT data tables (addressing an old TODO) and switch from a dictionary of dictionaries to a list of dictionaries, so that ExpectCT entries can be keyed on NetworkIsolationKey in addition to domain hash in a followup CL. The current plan is not to partition HSTS information by NetworkIsolationKey, but this CL also switches it to using a list, to be similar to the ExpectCT table. This CL also adds a version number to the saved data format, and adds an empty NetworkIsolationKey field to ExpectCT entries, so that entries won't be lost when that field is added (though entries may be lost when switching from an empty NIK to actually applying NIKs, which is an issue for another day). Bug: 969893 Change-Id: If723386b7ebc447ae78cb393b6b9d6719441759d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216040 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#772952}
-
Johann authored
Work has been done already to ensure the frame associated with the controller is not null. Following this down allows making Start() and Stop() protected which also removes the need to protect against various combinations of states. Bug: 850619 Change-Id: Ie1165322b231d72cb216645cde6f379ca52ed903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214975Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#772951}
-
- 28 May, 2020 25 commits
-
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I89b70ded15144650048b5b5415cd78fdedb82614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220229Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#772950}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e60ccbbb1b1d..a075151a2121 2020-05-28 oksamyt@google.com Parameterize raw_metrics_per_core with table name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:156788923 Tbr: perfetto-bugs@google.com Change-Id: I5418509dec46f1c272ec8f1214a3057eec8df59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220654Reviewed-by:
-
Kyle Horimoto authored
This CL returns parent results (i.e., section or subpage results corresponding to the parent of another result). Two new parameters are added to the API: max_num_results (self-explanatory) and parent_result_behavior, which indicates whether the client would like to receive parent results or not. This CL modifies the settings UI to request parent results but defaults Launcher search back to the behavior before this CL, since Launcher search uses custom logic for this behavior. Fixed: 1082249 Change-Id: Ic714fe025c05062ca587ad1069698a8fedb75a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220486Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772948}
-
Brandon Wylie authored
Bug: 1083917 Change-Id: I742c1fd6c698887a186df4f8ae28244a6db4a1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215453 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772947}
-
Lei Zhang authored
It's probably not useful, since LeakTracker::CheckForLeaks() isn't being called. Change-Id: I96b226e43698a859c934e45916514d5369927ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219177Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#772946}
-
Collin Baker authored
This reverts commit a1906b31. Reason for revert: left in debug log statements Original change's description: > Extract capture state machine > > This moves much of the capturing logic to ThumbnailCaptureDriver which > doesn't depend on WebContents or video capture details. Instead, it > expects calls from its client on state changes and calls back into a > client interface to request, start, and stop capture. > > Since the new class is testable, this also adds unit tests. > > Bug: 1073141 > Change-Id: I5e458ce4e7ab04f2091e1af4c76ad701d6eda0d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208547 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Collin Baker <collinbaker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772842} TBR=dfried@chromium.org,collinbaker@chromium.org Change-Id: I21fd1f4887d1b45fa8ebd3948c7c9658fb3d8144 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220807Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#772945}
-
Brian Sheedy authored
Switches the GPU DirectComposition pixel tests off the permissive Sobel parameters and onto more specific parameters. As a prerequisite, also adds support for Gold's new ignored border thickness parameter when doing inexact matching, which significantly improves the usefulness of the Sobel filter in certain cases since the Sobel filter is not applied to the pixels along the border of the image. Bug: 1078914 Change-Id: I3ccef878ad53bf456dcfeabe7fd5bc04472dcd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218708 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
Previously, dcomp surface draw offset was handled by hacks in validating and passthrough GL command decoders, but that approach doesn't work with SkiaRenderer since it doesn't call GL through a command decoder. Hence the ability to specify a texture offset was added to ANGLE for pbuffer surfaces created from the dcomp surface texture. This CL makes Chrome use the ANGLE extension for texture offset, and removes the hacks and plumbing for surface draw offset. It is dependent on the following ANGLE CL: https://chromium-review.googlesource.com/c/angle/angle/+/2186176 Bug: 1078551 Change-Id: I9b7350d77770c1d19fecb38286faff86f6a857ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199725 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772943}
-
Matthew Mourgos authored
Bug: 1071687 Change-Id: I2535e6faa6136829d94454f725ac3fdce61568ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218555 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#772942}
-
Nick Burris authored
Adds the TimeToScrollToTop metric which records the latency from when the match is scrolled into view until the user subsequently scrolls back to the top of the page. This provides a signal for whether a match was useful, based on the idea that the user will scroll back up to the top of the page quickly if they don't understand why the page is scrolled. This patch also fixes a recent bug in the TimeToScrollIntoView metric, which used the TextFragmentAnchor creation time as the search start time. The difference was negligible until crrev.com/c/2196932 which introduced waiting until the page is visible before starting the search. With this patch, we update the search_start_time_ in TextFragmentAnchor::Invoke() to more accurately reflect the start time. Bug: 1006364 Change-Id: Ibc8dda64d60d0ead31eddc69d0580640e692c5e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210677Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Tom Anderson authored
This fixes copy/paste for large images, and usage of large custom icons. BUG=1066670,1085836 R=msisov CC=sky Change-Id: Iac71a4f7c11729f0cb2add0cf6e70671d77fbdfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219160 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#772940}
-
Jeremie Boulic authored
RoundByteSize might not have a well-defined behavior if 0 is passed. As a follow-up to CL 2074821, this case is now handled explicitly. Test: unit_tests --gtest_filter=StorageHandlerTest.RoundByteSize Bug: 1056507 Change-Id: I9734f812e55a525e8370573bb0d70e90461948f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217939Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#772939}
-
Lei Zhang authored
There are a few static_assert() calls in pdfium_engine.cc. Consolidate them into pdfium_assert_matching_enums.cc. Change-Id: Ica2328418fd6e73d8cdc1390b53bccb8bf006386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220332 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#772938}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b81e6678a91b..1a4975642bf9 2020-05-28 philipp.hancke@googlemail.com fix typos in comments If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7e23f3acdd58be44cb341515d9db12e118e28483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220649Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0652d0d6df2a..209cf8fa408b 2020-05-28 flibitijibibo@gmail.com GGP: Check and enable VK_GGP_frame_token 2020-05-28 jonahr@google.com Port disable_timestamp_queries GPU workaround to ANGLE 2020-05-28 ianelliott@google.com Vulkan: Rotate gl_PointCoord for Android pre-rotation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1075876,chromium:811661 Tbr: ynovikov@google.com Change-Id: Iaf4b272e3b60bdf8b2d2f767733f64bb7435d783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220338Reviewed-by:
-
Tommy Nyquist authored
The following tests are being disabled: StartSurfaceLayoutPerfTest#testGridToTabToOtherNTP StartSurfaceLayoutPerfTest#testGridToTabToCurrentLive They have become slow and flaky. See bug for details. Bug: 1087608 TBR=wychen@chromium.org Change-Id: Iee6e32b32a8b4640a5766d9334bb1a9d366ffa51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220613Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#772935}
-
Sinan Sahin authored
Currently, if the status indicator is destroyed while there are running animations, we still get an #onAnimationEnd call causing NPEs. To prevent this, this CL cancels all animations in #destroy(). Also, it adds some null checks in TabbedRootUiCoordinator where we can potentially try to access null mActivity and ActivityTabProvider. Bug: 1087010 Change-Id: I60a199cdebad160b2ef3f63719552cc54cce87a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219348Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#772934}
-
Wenyu Fu authored
Adding another interface for tracker to tell if the IPH feature is ever shown. This is different than getTriggerState as it counts the times the event triggered for IPH that would trigger more than one time. Bug: 1068831, 1084292 Change-Id: Ie7ef70364f02300668eb87aa771616323267449f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206969 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
Will Cassella authored
There's a crash occurring from a call to memcpy in |AudioBuffer::ReadFrames|, and it's not entirely clear what's causing it. This CL upgrades the DHECKs in that function to CHECKs to diagnose the issue. Bug: 991984 Change-Id: I94e6d0801a91a11967228a68f2b43a83792647cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219309 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#772932}
-
Kevin Marshall authored
Prevents excessive logspam from being emitted to the Fuchsia logging service from third party JS logging code. Improves application runtime performance and Archivist memory footprint. Bug: b/157682779 Change-Id: I5304c52962d980d60be612696bcab8846cb52677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220360 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772931}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3122be177b4f22579c42d37e18aeac753b6779f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220630Reviewed-by:
-
Shengfa Lin authored
Check binaries in storage path after running release script Bug: chromedriver:3496 Change-Id: I6b7492eff60d0afa29e38f7690f694ba5a03e847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220632Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#772929}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I95e5895875093f559deba0e6ace03881ab0290a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220553Reviewed-by:
-
spdonghao authored
Creates a new loading layout for feeds during pre-native. Bug: 1076139 Change-Id: I64cc8a6772effdbf4f15da2310cfb71ee8c9aeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170853 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772927}
-
Li Lin authored
Bug: b/120559778 Test: Manual Change-Id: I4498ec1160508afd6fccc9489a6e1fbe96bcc127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219352Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772926}
-
