- 12 Sep, 2019 40 commits
-
-
Christopher Grant authored
- Add a new test case to exercise a native library. - Generalize the display of the result dialog for multiple test cases. - Specify a "pass" or "fail" in the results dialog text, to be parsed by the test, and also aid in manual testing (where the test activity may be spawned manually). - Component build coverage is stubbed out; it will be added once the component build places feature libs in DFMs. Bug: 989646 Change-Id: I724d0725f71ad7897ceb7b81d9fe7d22183889ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796308 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#696035}
-
Yi Gu authored
The fuzzer may produce invalid FrameSinkId for hit test regions which incorrectly breaks a DCHECK in HitTestQuery. Bug: 1001552 Change-Id: I0207dc7c1594f847e8fd3801c121ff04cd938e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796114Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696034}
-
Vasilii Sukhanov authored
Bug: 1003362 Change-Id: Ic403601498287275fbfbe6a511ace44cd8dede83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800989Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#696033}
-
Anton Bikineev authored
Change-Id: I8a5af2eed40d7a378680cad4af08ffcd5d51aaad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800865Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#696032}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dc7d2c6fd7ca..69f8c42d2c95 git log dc7d2c6fd7ca..69f8c42d2c95 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 henrika@webrtc.org [RELAND] Add support of AudioRecord.Builder in the ADM for Android Created with: gclient setdep -r src/third_party/webrtc@69f8c42d2c95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I5447943541cce627f7e95c5b59e06045789dc0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801028Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696031}
-
Peter Kasting authored
This was first turned on for Android back in 2014. According to crbug.com/419051 the binary size impact was minimal. According to danakj on https://chromium-review.googlesource.com/c/chromium/src/+/1790724/3/ui/gfx/geometry/quad_f.h#66 this is part of the gfx critical path, so it makes sense to optimize it for all platforms in non-debug. That also matches the condition set we use most other places we enable -O2. Bug: none Change-Id: I67e9d50e10d7c21d686226caf6172dc7d64713b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799312 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#696030}
-
Yi Gu authored
Prior to crrev.com/c/1452790, a cc::Layer created by ui::Layer was hit testable if its type_ != LAYER_NOT_DRAWN. That patch updated the logic with new hit testable critia but it missed the initial assignment. This patch addresses that issue and defines a helper function to check hit testability to avoid breakage in the future. Bug: 924294 Change-Id: I6957539cbfddc12ae24a35c451186c21ff85246c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785080Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696029}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9c6e48a6. With Chromium commits locally applied on WPT: 20133397 "[sensor] Upstream sensor layout tests to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iedd633c6c4765a114e343c4f447c24c403568082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801064Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696028}
-
Anton Bikineev authored
Blink GC plugin has been updated with a new option -no-gc-finalized. Bug: 990913 Change-Id: I8bc320162e936bb85be9e53e2beaec63163768ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798609Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696027}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/subresource_filter. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=pkalinnikov@chromium.org Bug: 891670 Change-Id: I2b50b464bf35451ba478a29b25888b4c4ee97854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786808 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#696026}
-
Gabriel Charette authored
Backport some tests in /content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=mcasas@chromium.org Bug: 891670 Change-Id: I0b56ac7f2bf659f28ebdbf8a04e425301033b9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787114 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#696025}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/metrics. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=nikunjb@chromium.org Bug: 891670 Change-Id: Ia47c792059528981fcbe3b0ca40baadfece43154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786976 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#696024}
-
Khushal authored
There is no ordering guarentee in the destruction order for objects in thread local storage. Since Thread and SharedGpuContext are both in thread local storage and destruction of CanvasResource can be triggered by SharedGpuContext being destroyed, we shouldn't access Thread in the CanvasResource dtor since it may have already been destroyed. R=fserb@chromium.org Change-Id: Id7efe3eb51fa242382f7446b731f0531c6bd9816 Bug: 1002792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799223 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#696023}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/updater. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=borisv@chromium.org Bug: 891670 Change-Id: I4c7eee29b7dcd6b8f553dbaab0e168faec4fede7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786981 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#696022}
-
Miyoung Shin authored
This CL converts FingerprintObserverPtr and FingerprintObserverRequest in chrome, services and ui to the new Mojo type, and uses pending_remote<FingerprintObserver> in fingerprint.mojom. Bug: 955171 Change-Id: Ide42fdb94bc69b100b5fce68f672cc86ef6f7c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792464 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#696021}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3fe6946d..7a7bda6a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8bbe836f4945cbbc8914dd217dfe15af318e0d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801065Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696020}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/578c88f047ec..429f0d380c28 git log 578c88f047ec..429f0d380c28 --date=short --no-merges --format='%ad %ae %s' 2019-09-12 robertphillips@google.com Add kRG_1616 and kAlpha_16 SkColorTypes Created with: gclient setdep -r src/third_party/skia@429f0d380c28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=mtklein@google.com Bug: None Change-Id: Iaf2a81e2d80917959bb5ac64039535ff8d8439a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801027Reviewed-by:
-
Anqing Zhao authored
Introduce two new data structs in DeviceStatusReportRequest. - cpu_tuilization_infos : CpuUtilizationInfo - system_ram_free_infos : SystemFreeRamInfo They both contains additional timestamp information compared with existing fields. We plan to deprecate the usage of following two fields after back-end servers are switched to new implementation. - cpu_utilization_pct_samples : int32 - system_ram_free_samples : int64 Bug: 1001391 Change-Id: Iae911d3657c75e52c75decbd4b28154e2185a63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795245 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#696018}
-
vitaliii authored
Disable LocalCardMigrationBrowserTestForStatusChip.ClickingOmniboxIconReshowsBubble on Linux, because crashes flakily. TBR=cfroussios@chromium.org Bug: 999510 Change-Id: I51b6e8995217a60ee90b6eda18483d2b4743486a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801144Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#696017}
-
Pavel Shmakov authored
The last piece of code that begs to be extracted from CustomTabActivity one that keeps the client connection alive and reports the status. Change-Id: I1e24fea219dcaa72ed0a07d3da66f131c9fa5235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798705 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#696016}
-
vitaliii authored
Disable WebViewPointerLockInteractiveTest.PointerLock because timeouts flakily. TBR=ekaramad@chromium.org Bug: 1003345 Change-Id: Ia1b4b23e88c31da01264be21f1a29d6e8f7628cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800305Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/626f7ff2bb8d..dc7d2c6fd7ca git log 626f7ff2bb8d..dc7d2c6fd7ca --date=short --no-merges --format='%ad %ae %s' 2019-09-12 perkj@webrtc.org Backoff to acked bitrate during first overuse detection Created with: gclient setdep -r src/third_party/webrtc@dc7d2c6fd7ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I3c2dd6199c7b1124fe291d9022ee7f1f43864ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801026Reviewed-by:
-
vikassoni authored
The usage of base::Optional was buggy which was causing CHECK to fail in the base::Optional. This CL fixes the bug. Change-Id: I3be9995ce69859ec2acfbfa118978b785d103e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799303 Auto-Submit: vikas soni <vikassoni@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#696013}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da5dbc1bca3e..02a52463b483 Created with: gclient setdep -r src-internal@02a52463b483 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9465387fabedf3d55dc42646bbf4e098f726265d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801025Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696012}
-
Carlos Caballero authored
Bug: 891670 Change-Id: I6c30caccbf040366505a46ffe9619fc6adf15105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778053Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#696011}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9fb2ed7f23e8..b077afffb867 git log 9fb2ed7f23e8..b077afffb867 --date=short --no-merges --format='%ad %ae %s' 2019-09-11 ilkos@google.com Use scraped thread names in trace processor if available Created with: gclient setdep -r src/third_party/perfetto@b077afffb867 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:b/140862422 Change-Id: Iab61ad66d4c0dbfe5c85fbf3d3614717c8021ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800724Reviewed-by:
-
Carlos Caballero authored
No need for a custom RenderFrameHostId which is the same as GlobalRoutingId Change-Id: I4bbf1e8d53c3e42c03cab23ab57874a4bbf8f09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796669Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#696009}
-
Henrique Ferreiro authored
Convert the implementation and all users of the blink::mojom::FileUtilitiesHost interface to the new Mojo types. Bug: 955171, 978694 Change-Id: Ifc340e266f28c4a8122b54302824257b8cfe887c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787387Reviewed-by:
-
Henrique Ferreiro authored
Convert the implementation and all users of the ash::mojom::AssistantVolumeControl and VolumeObserver interfaces. Bug: 955171 Change-Id: Id4fd8931ecc2d29eaff0b25defb909bf0f491aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795422Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#696007}
-
vitaliii authored
TBR=afakhry@chromium.org Bug: 1003339 Change-Id: I2dfa6fb14bf43e641fc53a9fba849fc43848d76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800985Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/916720b02c76..3a8b3dc2ed7c git log 916720b02c76..3a8b3dc2ed7c --date=short --no-merges --format='%ad %ae %s' 2019-09-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 664ad418f845..fdd13ca10ffc (1 commits) Created with: gclient setdep -r src/third_party/angle@3a8b3dc2ed7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:None Change-Id: I4b896128fd15e48983ae67f1a8751033bfbb2289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800506Reviewed-by:
-
Rune Lillesveen authored
LayoutTheme::SystemColor implementation return different colors for different color-schemes. All browsers return different values here. Changed colors based on which of the system colors Safari returns different colors for when the used color-scheme is dark. ButtonFace is used for rendering form buttons, which needed a darker background for the white text used in dark color-scheme. Bug: 939811 Change-Id: I02c9254225f721f8e6101269f57a51fb47b90944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795822 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#696004}
-
Eric Willigers authored
The web app installability check now verifies that the entire web app manifest scope is within a service worker's scope, instead of simply checking the start url. Bug: 809837 Change-Id: Ia4a957aae3e3d1737401376d2188c6f8dd85837e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799649Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#696003}
-
Thomas Tangl authored
A parameterized browser test is added to simulate a click for each button. Each button click is expected to record a sample from ProfileMenuView::ActionableItem in the histogram Profile.Menu.ClickedActionableItem. Additional fix: - The identity image is set to kUserAccountAvatarIcon if the passed image is empty. This can happen in tests and when the account image hasn't been fetched yet. Bug: 995720 Change-Id: I36122417e0cc3b685397aac8d975ed9ad94fd137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798610 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#696002}
-
Pavel Shmakov authored
This feature has been cancelled long ago, so let's cut down some complexity and method count. Change-Id: I8d8eebd82258a09396cf333b283cd43c9fbd7c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798663Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
vitaliii authored
PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/0 PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/1 PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/2 PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/0 PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/1 PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/2 PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ConnectExternalDisplay/0 PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/0 PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/2 PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/0 PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/1 PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/2 PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.SetAndUnsetPolicy/0 PolicyDeviceDisplayResolution/DisplayResolutionBootTest.Reboot/0 TBR=antrim@chromium.org Bug: 1000694 Change-Id: I58373a317fc917f79ff440ec14c62dc9d84cda6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800409Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e373bb6ea58b..626f7ff2bb8d git log e373bb6ea58b..626f7ff2bb8d --date=short --no-merges --format='%ad %ae %s' 2019-09-12 ssilkin@webrtc.org Update video_replay. Created with: gclient setdep -r src/third_party/webrtc@626f7ff2bb8d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I33a02467eba97f3a364a752a78bdf29f9b67a493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800507Reviewed-by:
-
Denis Solonkov authored
This change implements step 2 of the script: moving all of its program headers to the end of the file and zeroing the previous position. Bug: 998082 Change-Id: I66726398d0789938239648728b3bdeed2b715f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778495Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Denis Solonkov <solonkovda@google.com> Cr-Commit-Position: refs/heads/master@{#695998}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ba7ffaef. With Chromium commits locally applied on WPT: 20133397 "[sensor] Upstream sensor layout tests to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen kojii@chromium.org: external/wpt/css/CSS2/linebox NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6f1c623732ff5fe5afc8f7547d2df04ec191163d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800824Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/34915c5e..3fe6946d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6020e8c8d60ad174ec33fdc6c91f141cf989b4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800825Reviewed-by:
-
