- 19 Sep, 2017 40 commits
-
-
Koji Ishii authored
This patch moves the logic for the 'word-wrap' property from HandleText() to its lower function, BreakText(). Since HandleOverflow() directly calls BreakText(), this change fixes the logic to properly kick in not only when scanning forward but also when rewinding. fast/text/basic/015.html is rebaselined because its expected image for the current line breaker breaks at the incorrect position (the 2nd block breaks after 'i', not after 'u'.) Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1f3c809411417329420b6af8269b1cceb8796b54 Reviewed-on: https://chromium-review.googlesource.com/672167Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#502853}
-
Mohamad Ahmadi authored
Avoids disabling the PAY button in the payment items page when the PAY or the cancel buttons are tapped. Besides the unwanted visual change in the PAY button's appearance when it is tapped until the animation is completed, this may be contributing to why the PAY button doesn't predictably work when voice over is on. Bug: 766453 Change-Id: Ia795b77489710564bc9a1507c3ac2515b4c0463d Reviewed-on: https://chromium-review.googlesource.com/672608 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Reviewed-by:
Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#502852}
-
Anton Urusov authored
This is the initial version of the policy-tool page that is created to make managing policies easier for admins. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia58300dc786a6dabcd14721d134fb52027934739 Reviewed-on: https://chromium-review.googlesource.com/613507Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Anton Urusov <urusant@google.com> Cr-Commit-Position: refs/heads/master@{#502851}
-
Tatiana Gornak authored
BUG=739343 Change-Id: I81eb671ca64b84df871bf071af6817117acbd9a5 Reviewed-on: https://chromium-review.googlesource.com/672544Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#502850}
-
Gauthier Ambard authored
And fix the testMostVisitedNewTab which was the failing test. It is failing because the doodle is showing, taking too much space on the collection view. The "sufficientlyVisible" check is failing because it is checking that the view is > 75% shown on screen, not taking into account its subviews. Bug: 766495 Change-Id: I084f8c8dab9152ce155a73d39561c8c76c6277e9 Reviewed-on: https://chromium-review.googlesource.com/672529 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#502849}
-
sebsg authored
Bug: 748223 Change-Id: I12752f13d311d1e61dbacb66e61abd8672154a99 Reviewed-on: https://chromium-review.googlesource.com/667948Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#502848}
-
EhsanK authored
This CL allows creation of MimeHandlerViewGuest even when element size is 0x0. This is specifically important for Google slides pages where an <embed> of size 0 is used for print previewing the page. Essentially, we need to makes sure for such <embed>'s the guest is created (after attaching) and embed.postMessage works fine. Bug : 763812 Change-Id: I7ad0cd0898aee2e1b5d6b15dd9bfdcb100a8e16b Reviewed-on: https://chromium-review.googlesource.com/667900 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#502847}
-
Alex Clarke authored
This feature was not helpful because it complicated dealing with about:blank and granting additional virtual time. Virtual time should be used like so to avoid race conditions: 1. Navigate to about:blank 2. Set VirtualTimePolicy::PAUSED 3. Navigate to target page 4. Wait for Page.frameStartedLoading has fired 5. Set VirtualTimePolicy::DETERMINISTIC_LOADING with a budget of say 6000ms 6. Wait for budget to expire See VirtualTimeBrowserTest as an example of how to do this. The page is ready to be inspected. If you need to do something like click on a button and wait for the browser to process any navigations tha might result then do so while virtual time is paused due to budget running out and then issue more budget. This patch also tries to deflake VirtialTime test. I found a few bits of state that were not cleaned up between runs, although there's still something strange going on with that test which causes some of the virtual time tests to rerun. Bug: Change-Id: Ie530f9086815ef27c4cc3e65589a831e8fbe6b93 Reviewed-on: https://chromium-review.googlesource.com/671017 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#502846}
-
Peter Kotwicz authored
This CL fixes a few of the WebApkUpdateManager tests which regressed as a result of https://chromium-review.googlesource.com/591917 This CL also replaces comments referencing ManifestUpgradeDetector to reference WebApkUpdateDataFetcher instead. BUG=None Change-Id: Ifc9dfaffd59ef88e083c600f3e20d17b5c5debc0 Reviewed-on: https://chromium-review.googlesource.com/663414Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#502845}
-
Yuly Novikov authored
This reverts commit ef7da402. Reason for revert: Possible cause of crbug.com/766473 Original change's description: > Revert "Disable surfaceless EGL on Android" > > This reverts commit dd49d9c1. > > Reason for revert: works well after > https://chromium-review.googlesource.com/646188 > > Original change's description: > > Disable surfaceless EGL on Android > > > > There are outstanding bugs related to how Android code meant for WebView > > is interacting with surfaceless EGL. These cause crashing on startup > > and incorrect rendering on platforms that support surfaceless EGL. Work > > around the issues by disabling surfaceless EGL on Android to unblock work > > before a more complete solution can be developed. > > > > BUG=382349 > > > > Review URL: https://codereview.chromium.org/330453003 > > > > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276713 0039d316-1c4b-4281-b951-d872f2087c98 > > BUG=382349 > TEST=Start Chromium, run WebGL Aquarium on Pixel C > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Id8b03aa5a91bfe087ce59c3c7a6b63f6e09a4171 > Reviewed-on: https://chromium-review.googlesource.com/669842 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Yuly Novikov <ynovikov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502609} TBR=ynovikov@chromium.org,kbr@chromium.org,oetuaho@nvidia.com Change-Id: Ib83d4c05d3ead960f56287af48156342121ff70e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 382349 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/672723Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#502844}
-
Rob Buis authored
After #501642 some callsites behave differently because they only tested for initial/inherit, not unset. So use IsCSSWideKeyword instead. Bug: 660273 Change-Id: Ibe8842ac21da804c43104fd978983d84c9f65001 Reviewed-on: https://chromium-review.googlesource.com/667865Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#502843}
-
Helen Li authored
vcdiff dependency is used for SDCH. SDCH has been disabled in Chrome in M59. This CL removes vcdiff dependency from src/DEPS. TBR=jochen@chromium.org Bug: 762686 Change-Id: I836e501c09900c4d49bf742a5b430d3e586a3a66 Reviewed-on: https://chromium-review.googlesource.com/671147Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#502842}
-
Charles Vazac authored
Bug: 702760 Change-Id: Ic02ef50fbf2776f63c578397d82bc77e1dd7184f Reviewed-on: https://chromium-review.googlesource.com/665354 Commit-Queue: Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#502841}
-
Francois Doray authored
This method is called when the opacity of an aura::Window's Layer changes. It will be used to recompute aura::Window occlusion states. Bug: 738387 Change-Id: I42e07cd0f4370091515645cfe6cbd7cd633edb87 Reviewed-on: https://chromium-review.googlesource.com/665178 Commit-Queue: Francois Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#502840}
-
Ramya Sharma authored
issue: https://screenshot.googleplex.com/BCNV2sT8deF.png Bug: 695749 Change-Id: I87f6875ad6040b0a1d167bd46de15bdcd61e57f9 Reviewed-on: https://chromium-review.googlesource.com/672463Reviewed-by:
Marti Wong <martiw@chromium.org> Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#502839}
-
Sylvain Defresne authored
In order to roll GN fc561c03..cf557ff0 (r498655:r502818) and pick up the following changes: eab0e88e Add support for partial_info_plist to create_bundle. a5c648fa [GN] Adds const to the comparison operator of the DepsIterator a6c6d28e Fix GN bootstrap 9c37f1fb [GN] Add unit tests for the mapping between PBXObject and it's name. 95ce69ba Fix GN bootstrap for MacOS X 315b910c Fix GN bootstrap 39ca4928 Fix roll_gn.py script. TBR=dpranke@chromium.org Change-Id: I1fd1b1c35bda88277984eb6f4bc73a74b6ab0002 Reviewed-on: https://chromium-review.googlesource.com/671018Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502838}
-
Sylvain Defresne authored
The file build/config/ios/imageset.gni was introduced to avoid breaking the downstream build after the file rename. Remove it as the downstream code has been fixed to use the new path. Bug: 764286 Change-Id: I0dbaccca19f87017ed1a34ee7eeb37d94e1aaad9 Reviewed-on: https://chromium-review.googlesource.com/671384 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#502837}
-
clamy authored
The last committed NavigationEntry is incorrect when we shortcut a RenderFrameHost swap due to a sad tab. It's also wrong for subframes. BUG=764641 TEST=Navigate to a WebUI page from a sad tab (in PlzNavigate) Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I5580699f27389b10ecfd6d3cfe419c244ddf0a5e Reviewed-on: https://chromium-review.googlesource.com/667405 Commit-Queue: Camille Lamy <clamy@chromium.org> Reviewed-by:
Charlie Reis (OOO until 9/25) <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#502836}
-
Ramya Sharma authored
Two issues when new folder was created: 1. if row is behind k/b then it is not visible to user to edit. 2. if the newly created folder is below visible area on screen, cell is not created and hence we cannot shift focus to this newly created folder. Demo: https://drive.google.com/a/chromium.org/file/d/0B5e_gsRJBxElb2ZUSWxqczBMX3M/view?usp=sharing Bug: 695749,766623 Change-Id: Iea25042088942d4ada50f90e392e5921514743cb Reviewed-on: https://chromium-review.googlesource.com/671825 Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by:
Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#502835}
-
Tatiana Gornak authored
This reverts commit bbebe805. Reason for revert: Suspecting in breaking the compilation for ChromeOS build Original change's description: > Migrate Bool(ean)?DBusMethodCallback to DBusMethodCallback<bool>. > > Part of OnceCallback migration in chromeos/dbus. > > BUG=739622 > TEST=Ran trybot. > > Change-Id: Ic932aa7c018297a064889c4f05c8578bca712474 > Reviewed-on: https://chromium-review.googlesource.com/666944 > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Stefan Kuhne <skuhne@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502831} TBR=hashimoto@chromium.org,stevenjb@chromium.org,skuhne@chromium.org,bauerb@chromium.org,hidehiko@chromium.org,waffles@chromium.org,emaxx@chromium.org Change-Id: I4dcf82e6eb3f745582c48c9b035c92b0c72b69ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 739622 Reviewed-on: https://chromium-review.googlesource.com/672505Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#502834}
-
Gauthier Ambard authored
The ContentSuggestions empty sections can be displayed if their section info allow them to. For now they are only displayed if they are started at the opening of the NTP. This CL fixes it by adding them if needed. Bug: 765075 Change-Id: Ieb8dde40d14044bfb674bcd9108b84775d1b4531 Reviewed-on: https://chromium-review.googlesource.com/671021Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#502833}
-
Sylvain Defresne authored
The CL https://chromium-review.googlesource.com/578630 configured all platform to use C11 but did not remove the code enabling C99 on iOS/macOS. This caused iOS/macOS to use an older standard. Bug: 766484 Change-Id: I31090257abe4feb770a0b088cfa657e2b42ca624 Reviewed-on: https://chromium-review.googlesource.com/671349Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502832}
-
Hidehiko Abe authored
Part of OnceCallback migration in chromeos/dbus. BUG=739622 TEST=Ran trybot. Change-Id: Ic932aa7c018297a064889c4f05c8578bca712474 Reviewed-on: https://chromium-review.googlesource.com/666944 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502831}
-
stkhapugin@chromium.org authored
Disables testMostVisitedNewIncognitoTab because it's failing multiple times on bots downstream. Bug: 766495 Change-Id: Ie640c58e32eb87ed7b6ae070e35e111fbe23cd81 Reviewed-on: https://chromium-review.googlesource.com/671011 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#502830}
-
Philip Jägenstedt authored
Reported by Simon Pieters. No-Try: true Change-Id: I466202c42da81f89083cc3479035b2cb1924e8af Reviewed-on: https://chromium-review.googlesource.com/672366Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#502829}
-
Iulia Harasim authored
This CL changes the personalized signin promo's description in Recent Tabs on both iOS and Android. Bug: 766312 Change-Id: I6197e39fdc874e74124ce282085429c8001db131 Reviewed-on: https://chromium-review.googlesource.com/671352Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Iulia Harasim <iuliah@google.com> Cr-Commit-Position: refs/heads/master@{#502828}
-
Kent Tamura authored
|basename| is a base of the name 'V8*Partial'. So it's an interface name, not a file basename. Bug: 760462 Change-Id: Ic04bc604aea37a33d8c78fa4cc505fe3f30b120e Reviewed-on: https://chromium-review.googlesource.com/672029Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502827}
-
Vitalii Iarko authored
The color is encoded as @ColorInt with alpha channel equal to 255. In the JNI bridge the absence of color is encoded as 0, because we would not have a fully transparent color anyway. Bug: 754183 Change-Id: I236a1e4e0659a9e732ad437cdb295fe6056737f4 Reviewed-on: https://chromium-review.googlesource.com/671347 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#502826}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 435a341a. With Chromium commits locally applied on WPT: 2803f82c "Add web platform test for getUserMedia with feature policy applied" Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2048 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: Idffa132b324ab1b94398fd4d6a6f65e1b15f8b07 Reviewed-on: https://chromium-review.googlesource.com/672213 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502825}
-
Manuel Rego Casasnovas authored
As a follow-up of r501249, this patch does a small refactoring adding a new method LayoutGrid::ContentAlignment() that is from LayoutGrid and GridTrackSizingAlgorithm. Change-Id: I4c057ef2ef47decbe76d3dac2140ee8deb0e515f Reviewed-on: https://chromium-review.googlesource.com/663395Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#502824}
-
Xida Chen authored
This is a follow-up for the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/667323 TBR=junov@chromium.org Bug: 725651 Change-Id: I438a4210e28ff85d051de5103f33e2b81197f2e4 Reviewed-on: https://chromium-review.googlesource.com/670924Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#502823}
-
Tatiana Gornak authored
This CL implements following logic: 1. "Generate a strong password..." fallback is shown 2. When user clicks on the fallback NO PASSWORD IS GENERATED. Instead the generation bubble is shown. 3. Only if the user clicks on the generation popup, then the password is generated and pre-saved. In this CL if user clicks out of the password field and then clicks back, the generation popup will appear again. No decision on what should appear was made yet. BUG=739343 Change-Id: Ib01bb2a24f5106b29afd1f0ce1efac2aa830a06e Reviewed-on: https://chromium-review.googlesource.com/594148 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#502822}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d6ef217affb3..08d6322ff7a5 $ git log d6ef217af..08d6322ff --date=short --no-merges --format='%ad %ae %s' 2017-09-19 perezju [Telemetry] Adjust wait after forcing Garbage Collection Created with: roll-dep src/third_party/catapult BUG=690042 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I4db179f81a4b18b210243ba918d4591edec7c042 Reviewed-on: https://chromium-review.googlesource.com/671219 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502821}
-
Stephen Martinis authored
This will be used by the one buildbot step effort for perf builders. This CL shouldn't have any effect when it lands. Bug: 758630 Change-Id: I2e8434a975be2908427e5c6fd0091a5f1490f5bf Reviewed-on: https://chromium-review.googlesource.com/629962 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#502820}
-
David Roger authored
When a reconcile is done, the first account is kept in memory. Then later, if the first account is missing (i.e. the user is not signed in, and the Gaia cookie is lost), the cached first account is reused if possible (i.e. if the token is still there). The main (only) practical use case for this behavior is when the user manually clears the Gaia cookies from the Chrome settings. When this happens, Dice will rebuild the Gaia cookie, and this CL ensures that the default Google account will be the same as before the cookie clear. Bug: 764303 Change-Id: I62f31527a4d5235362ad0d48c0fc6ab7b4d72571 Reviewed-on: https://chromium-review.googlesource.com/666621 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#502819}
-
Sahel Sharify authored
Bug: 684691 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5ebf3fcff043b01f02fdbabdaf171fa13e838392 Reviewed-on: https://chromium-review.googlesource.com/658277 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#502818}
-
Kent Tamura authored
Add "basename" parameter to template("generate_global_constructors"), and generate snake_case IDL files and C++ header files. This is a preparation of the Great Blink mv. At this momnet, we only have lists of global scope interface names in *.gn. After the great mv, it's difficult to produce generated IDL list and C++ header list from the interface names in *.gn. So we need to introduce additional snake_cased interface list. Bug: 578345 Change-Id: Ia7f861e43d9b622926adde0280e4297c71bcc750 Reviewed-on: https://chromium-review.googlesource.com/672225Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502817}
-
John Wu authored
//components/autofill/ios/browser to be shared. //ios/web_view would like to integrate autofill as a feature, and could benefit from sharing as much code as possible with //ios/chrome. Bug: Change-Id: I7126d69a59fe85265a934a1ddcbe915ca21e6f28 Reviewed-on: https://chromium-review.googlesource.com/658205 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#502816}
-
Lisa Suzuki authored
This CL's intention is to adjust to the change of WebIDL's specifications. This CL enables types to be annotated types in Typedef and NonAnyType. In order to check if ASTs are dumped correctly and if the code generator works correctly, I also added pattern match based tests and code generator's tests. Bug: 714866 Change-Id: I3f04365eca44a646a92796028479744d9bd4dce8 Reviewed-on: https://chromium-review.googlesource.com/668353 Commit-Queue: Lisa Suzuki <lisabelle@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#502815}
-
Shubhie Panicker authored
This uses same mechanism as timer suspension, a finch flag will be added next. Bug: 653493 Change-Id: Ie0e90b03c402664114b9a7aeee6818bfb53a0cb6 Reviewed-on: https://chromium-review.googlesource.com/653493 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#502814}
-