- 28 May, 2020 40 commits
-
-
George Steel authored
Uses font-weight as a template for the implementation as the value is also a scalar with keywords. Bug: 924353 Change-Id: If635e279f369f7b1433b98d9cfb7f6423fbcb3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209389Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#772767}
-
Yue Ru Sun authored
which should be used to filter by source type when querying source data from the logs, since the total number of types likely changes over time and will break analysis scripts. This patch also syncs metrics proto and renames ukm::SourceIdType::UKM to ukm::SourceIdType::DEFAULT. Change-Id: I81246e6634f398056727a7ed29f0761f46b3ee02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213092Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#772766}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib488cd6fbf50936efaeec7fe8c55f7bac284bfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772765}
-
Azeem Arshad authored
Scans for cellular networks are disruptive and should be initiated only by explicit user action. This CL does the following: * Document that cellular scans should be explicit. * Remove the periodic scan for all network types in network-select. * Make sure that cellular scans are initiated only when cellular type is explicitly requested. * Prevent network subpage from triggering cellular scans. BUG=b/157403230 Change-Id: I3d70ede85b155346fe294bbfc0a0337c1e8c7408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217708Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#772764}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590666951-97e5506c192bc4f156540656aa3946ef3f3bcc93.profdata to chrome-mac-master-1590681272-1f7442a5117e311b8b673287ed7b2ccca996fb7b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia2793768960d7e126e5c5e961fa4dca3ca892659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220217Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 1026641 Change-Id: I086268457874e00af01eb548db5322ee9cf2402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215916 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Katie D authored
This transforms greyscale and black pixels in the cursor to a custom color, without impacting white, fully transparent, or color-tinted pixels. That allows us to set a custom color for the black parts of cursors without creating new assets. See go/cros-cursor-color for (WIP) design doc. Bug: 1085442 AX-Relnotes: n/a Change-Id: I593e1d908d9a532c3032d8eb91ff25b9b6d9aa89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112964 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#772761}
-
Dominique Fauteux-Chapleau authored
This only parses fields that will affect the behaviour of the analysis and reporting. Other fields like "display_name" or "version" can be parsed once they are needed in a follow-up CL. Bug: 1069049, 1069048 Change-Id: I486c3b8c8c51a676423fab23a3c5977d3ca25d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218763 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#772760}
-
Daniel McArdle authored
Chromium's clang_tidy_tool.py calls one of two clang-provided helper scripts. The default is run-clang-tidy.py. When the --diff option is present, we select clang-tidy-diff.py. These two scripts do not take the exact same arguments, and clang_tidy_tool.py has been attempting to pass an unrecognized argument to clang-tidy-diff.py when called with --diff. This CL drops the unrecognized `--header-filter` argument from invocations of clang-tidy-diff.py. Now we can use --diff again! Also, this CL drops the unused `out_dir` parameter from the internal RunClangTidyDiff() function. Bug: 947106 Change-Id: I9be50064e2ec5da73e056519206f11641cbcec57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218471 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
-
Anastasiia Nikolaienko authored
MirrorReauthenticationRequest stats are send from 2 different places for child users and regular users. Send them in ProcessMirrorHeader for all users. Change-Id: Ic89793a999e8183561cecc64db9bbb67d52a9cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214957Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#772758}
-
Patrick Monette authored
Bug: 1085718 Change-Id: I776c529fd96c1b45d106747a3937d5a487287a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216045Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#772757}
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: I759ca6c31856fbf1e99a70b4e925a7d5093c50cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212978Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#772756}
-
Tao Bai authored
- Send the datalist to Autofill Service - Autofill the datalist. - Also add the test. - This patch doesn't stop notifying Autofill service if the datalist is focused. Bug: 949555 Change-Id: Iedcefc3eba64b22cc2a87bb1442860944271d18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218912 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#772755}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f55afd74b600..f6bc843257ca 2020-05-28 bmeurer@chromium.org [sdk] Properly encapsulate and await `Script` content. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1056632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifdd962dbc8824fc1e96982591648a91c4c9ee8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220207Reviewed-by:
-
Tommy Li authored
We've launched this feature and it seems to have "stuck" the landing. This CL just deletes the feature flag now on ToT. This CL also deletes the Confirm Delete popup flag for Remove Suggestion, because we never liked it or seriously experimented with it. We launched without it. Finally, it also deletes a browsertest that is out of date. We have a more comprehensive unit test in OmniboxPopupModelTest now, and this old test was apparently not working Mac anyways. In general, we want to get rid of these end-to-end browser tests, which are flaky and slow, and replace them with integration tests that span across two to three classes. I don't think we will have to sacrifice coverage, but even a bit of coverage loss seems okay to me, as the end-to-end ones have been flaky for years, and we've never been able to deflake them entirely on all platforms. Bug: 1205 Change-Id: I2a3514a15e6de5dbe942ec1fd2a323867133571c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218719Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772753}
-
Peter Kotwicz authored
This CL: - Moves SplashController.java SplashDelegate.java SplashscreenObserver.java to browserservices/ui/splashscreen because the files are used by both TWAs and webapps. - Moves WebappVerifier.java, AddToHomescreenVerifier.java, WebApkVerifier.java to browserservices/ui/splashscreen/webapps - Moves CurrentPageVerifier.java to browserservices/ui/controller because it is used by both TWAs and webapps. - Moves most files from browserservices/trustedwebactivityui to browserservices/ui BUG=985328 R=peconn TBR=yfriedman (For trivial import changes) Change-Id: Ib3978eb766f43e23d40f7baa4391a25bc7467dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217862 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#772752}
-
Li Lin authored
It was previously gated in context menu. We moved the check to QuickAnswersController now. Bug: b/157602163 Test: manual Change-Id: Ia181ab66bc6fb60c991e59939f037f94b8ec3afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219115Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772751}
-
Michael Ludwig authored
Bug: 1087413 Change-Id: I34af0357f372e156b5d1c1859cdee975cf391b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219675 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#772750}
-
Mitsuru Oshima authored
Instead of using current default (15), use Android's default (8), multiplied by the chrome/android scale difference (0.75) which is 6. Bug: 1083120 Change-Id: Ic12ac596935e82eeb54a6887de6d9c856db971ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217727Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Benoit Lize authored
This reverts commit 25c28325. Reason for revert: Updated the failing test. > Original change's description: > > base/allocator: Respect malloc() alignment guarantees in PartitionAlloc. > > > > Generally speaking, malloc() must return data suitably aligned for > > std::max_align_t. In practice this means 16 bytes on 64 bit > > architectures, whereas PartitionAlloc only provides 8 there. This is > > problematic to use it as a malloc() replacement. > > > > This CL makes PartitionAlloc respect the alignment guarantees on 64 bit > > architectures. > > > > Bug: 787153,998048 > > Change-Id: I860f9d0439d59f8d494306452b8cdbff515c8300 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219498 > > Commit-Queue: Benoit L <lizeb@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Takashi Sakamoto <tasak@google.com> > > Cr-Commit-Position: refs/heads/master@{#772662} > > TBR=tasak@google.com,haraken@chromium.org,lizeb@chromium.org > > Change-Id: Ic3266b40748d22cb25d91ab041db79da42851f4f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 787153, 998048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220085 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772669} # Not skipping CQ checks because this is a reland. Bug: 787153, 998048 Change-Id: I15257083b8e651c2ec0516563e5b8728bc5f158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218280 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#772748}
-
Nidhi Jaju authored
These metrics will allow for better estimation of the size of ServiceWorkerRegistrationInfo by finding the size of each url associated with each service worker registration for an OOM investigation. Bug: 848194 Change-Id: Id5825212ceba7636d0291f1efc36114021a9f2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217670Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#772747}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I231ad5de7ccfb93b5eebf999e10f74868bbd337d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219782Reviewed-by:
-
Nathan Zabriskie authored
Clusterfuzz uncovered a potential issue when the bytes per pixel for the src SkColorType doesn't match the bytes per pixel for the dst color type. This CL checks for the equality of these values and early exits if they differ. This prevents a potential bad address read during SkCanvas:: WritePixels. Bug: 1081040 Change-Id: I7addf74b3066b8539f87d4c8566f554260d3ea13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218757 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#772745}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. Note that file still refers to WebMediaStreamTrack::ContentHintType class enum, which will be moved out of WebMediaStreamTrack on its own CL. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: Iec6e6fba53d3ab32a9b90af48d1378d2a0f731c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218748 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#772744}
-
danakj authored
This test wants to verify devtools inspect works with an iframe in another domain. It was putting the iframe in another site, which causes it to become detached from the local root in site isolation. Instead, put both the main frame and iframe into the example.test domain, with the iframe in a subdomain. This test was originally added for webkit bug 31587 which is found at https://bugs.webkit.org/show_bug.cgi?id=31587. It said: > If you try to inspect elements located inside an IFRAME that was > loaded from a different domain, not satisfying the same origin > policy, Web Inpector in recent WebKit nightly builds cannot show > style information. Works in Safari 4.0.4. R=yangguo@chromium.org Bug: 623268 Change-Id: I842bf835e49ee79e60e423fd36a5d3cedb8a8cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218765 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772743}
-
Yann Dago authored
Bug: 958893 Change-Id: I23c5b75bae61c0d1041a9f08797e3c0cad258e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208358 Auto-Submit: Yann Dago <ydago@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#772742}
-
Tom Sepez authored
Use same logic as guards the (INT_MIN / -1) corner case. Bug: 1086092 Change-Id: Ib1715b55cd3b1e65b869e603b74845c8052cdff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216808Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
Bug: 1087205 Tbr: ortuno@chromium.org Change-Id: Icc5694ca27c7a5e38405cb06eb401ecb086a1f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218377 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#772740}
-
Stephen McGruer authored
We often find that the default number of characters (500) output for a failed command using blinkpy's Executive class isn't sufficient to understand the failure. To make it easier to debug failed imports/exports, always print the full error. Bug: None Change-Id: I743b4908031298beb7fe21ad54d4aab5a186ea83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220065 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#772739}
-
Amin Hassani authored
different parts of Chrome like UI might be interested to track the state change of DLC(s). This CL adds that capability. BUG=chromium:1070700 TEST=DLC unittests. Change-Id: I9e31270d8d2bca97f68af44420e3f9bcbece133c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216856 Commit-Queue: Amin Hassani <ahassani@chromium.org> Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772738}
-
Leonard Grey authored
This reverts commit 69b0dc7d. Reason for revert: Still failing :( https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/103363 https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/60614 Original change's description: > Reland AddLayoutInstabilityTest.OOPIFSubframeWeighting. > > Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2218908 > > The CL was reverted due to failures: > https://chromium-swarm.appspot.com/task?id=4c70451b557f4a10 > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8879124242719394576/+/steps/browser_tests/0/logs/Deterministic_failure:_LayoutInstabilityTest.OOPIFSubframeWeighting__status_CRASH_/0 > > ../../chrome/browser/page_load_metrics/integration_tests/layout_instability_browsertest.cc:152: Failure > Value of: cls_values[i].has_value() > Actual: false > Expected: true > > This looks like one of the scores in the loop isn't getting set correctly. I'm not sure which, > so this CL also fixes the check of scores and is more explicit about which score is being checked. > > Bug: 943668 > Change-Id: Icd0203fa8b6521b83605ab1c1210376c2f7a8356 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219112 > Reviewed-by: Steve Kobes <skobes@chromium.org> > Commit-Queue: Annie Sullivan <sullivan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772696} TBR=sullivan@chromium.org,skobes@chromium.org Change-Id: I5d2b5fc216e5103926e52800a02e2fc42b81700e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220270Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#772737}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ifce14be46d30b422febeffc281ce6ab2549688f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220172Reviewed-by:
-
Shimi Zhang authored
There is another crash caused by StrictMode violation on Samsung devices This particular one was caused by reading the OEM specific clipboard, which we don't have direct control with. Bug: 1082701 Change-Id: Icce51bdecff57cd88dffc504d8b38f66aa92ca35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211360 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#772735}
-
Mohsen Izadi authored
WidgetBaseInputHandler::HandlingState::injected_scroll_params is a unique_ptr of a vector that is initialized on first use and never destroyed. It can simply be a vector to make code easier to read. Bug: None Change-Id: Ie2e965b142ea28d2e9635790cb41e9bfeb3a21e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083858 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#772734}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/787495f0ba2e..aecba11114cf $ git log 787495f0b..aecba1111 --date=short --no-merges --format='%ad %ae %s' 2020-05-27 junyer Refuse to rewrite when MaxSubmatch() is too large. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org CC=mmoroz@chromium.org Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Change-Id: Ie5f8daab7d432ee895e1b60415d3e65bb3747a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218454 Commit-Queue: Paul Wankadia <junyer@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#772733}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fdd70eae3267..0387dfcbf8e0 2020-05-28 simonmacm@google.com Merge "Fix time-in-state thread ordering inside processes." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I460295ba5feee31830cc862861cb613daa5a5797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220168Reviewed-by:
-
Haiyang Pan authored
This reverts commit fcd03993. Reason for revert: Tests fail on quite a few android builders. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=media_unittests&tests=SurfaceTextureTransformTest Original change's description: > Fix SurfaceTexture DecomposeTransformMatrix > > This CL handles adds handling of few more cases: > * Small videos have bad matrix. We get small sizes likely because > decoding errors > * Shrink amount other than 1.0. This is best guess approach as there is > no way knowing what shrink amount was used. > * Empty matrix case (when either of scales is zero). Shouldn't happen > outside of small size case. > > This CL also add fallback to visible_size if coded_size/visible_rect > seem wrong or matrix was broken and adds DumpWithoutCrashing for that > case. > > Bug: 1081695, 1086624, 1076564 > Change-Id: Ife0b70bc85b9249fa2805df1db59733ac8cdbd53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216731 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772493} TBR=backer@chromium.org,vasilyt@chromium.org Change-Id: I1fe1e970dcd4db63c5ec1a7f7e39452a0ca37202 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1081695, 1086624, 1076564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220268Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#772731}
-
James Cook authored
SyncInternalsWebUITest.SyncDisabledByDefaultChromeOS is kind of a change-detector test. It exists because historically Chrome OS had a different 'Disable reasons' value on chrome://sync-internals. SplitSettingsSync makes 'Disable reasons' match all other platforms, but there's no good way to change JS test expectations based on a platform-specific C++ feature flag. Don't assert the value of 'Disable reasons', and leave a TODO to use the cross-platform test when SplitSettingsSync is the default. Bug: 1060289, 1087165 Change-Id: Idaf7f608051dc979033a225425e8eb4057d63ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219021Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#772730}
-
Aya ElAttar authored
1. Changed member value from a public member to a private one. 2. Added a setter & getter for value, so any reference doesn't need to swap to use base::Optional when its type is changed. 3. Added non const iterators for PolicyMap to be able to get a non-const reference to value in schema_map.cc Bug: 1083984 Change-Id: I3e82e619de466963f4a8043876f2b897ec2f6ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216075 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#772729}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0b9eddaa2663..d85a68f5582f 2020-05-28 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-28 shaochuan@chromium.org packages: update target assumption in determine_android_branch 2020-05-28 vapier@chromium.org sysroot_lib: use full path to pkg-config in our wrapper 2020-05-27 dhanyaganesh@chromium.org config: Remove x86 boards from chromeos_config_boards 2020-05-27 dhanyaganesh@chromium.org config: Remove arm_internal boards that we don't need 2020-05-27 navil@google.com chromeos_config: release-basic builder dryrun of ManifestSync. 2020-05-27 saklein@chromium.org cros_logging: Add documentation for log levels. 2020-05-27 saklein@chromium.org Misc scripts: Remove verbose option. 2020-05-27 saklein@chromium.org commandline: Add verbose option. 2020-05-27 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-27 dburger@chromium.org Raise full builders timeouts. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0bf78ad112525e6541ce63c08e49b5de8c6e984e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220170Reviewed-by:
-
