- 26 Nov, 2018 40 commits
-
-
agrieve authored
This reverts commit 27bd2d6f. Reason for revert: Broke this bot: https://logs.chromium.org/logs/chrome/bb/internal.client.clank/arm-builder/18748/+/recipes/steps/compile/0/stdout Original change's description: > Cronet: Simplify Android GN logic for srcjars by not using them > > No need to zip up the generated source just to unzip it again :P > > Bug: 908479 > Change-Id: Iac6982eb4b436a7e33c53b79f239fe2954fa4f11 > Reviewed-on: https://chromium-review.googlesource.com/c/1349871 > Commit-Queue: agrieve <agrieve@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610889} TBR=pauljensen@chromium.org,agrieve@chromium.org Change-Id: I9daab0436aa1ff7605f427ab815adff711c0d59d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908479 Reviewed-on: https://chromium-review.googlesource.com/c/1351575Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610938}
-
Justin Cohen authored
Changes Url to URL and adds an -IsURLNewTabPage helper. Change-Id: If80a6e41d9b2d74ed5449550b49de1cb670bed07 Reviewed-on: https://chromium-review.googlesource.com/c/1350191Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#610937}
-
Jeremy Roman authored
This should allow us to determine which resolvers are not being properly resolved or detached. Bug: 873980 Change-Id: I44ead90aaf8b963b7380ba70c56c73ae2b7ad7d1 Reviewed-on: https://chromium-review.googlesource.com/c/1344822Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610936}
-
Eugene But authored
Additionally fixed extra WebStateObserver::TitleWasSet calls. This makes session restoration behavior similar for both legacy and slim navigation managers. Bug: 877671 Change-Id: I2c0265914ed1a6738335efd031f752db9c0a295f Reviewed-on: https://chromium-review.googlesource.com/c/1347316Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#610935}
-
Max Moroz authored
TBR=inferno@chromium.org,metzman@chromium.org Bug: 539572 Change-Id: I600b9d777607f7b9be9e8e8065d3d2be029e138f Reviewed-on: https://chromium-review.googlesource.com/c/1351280Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610934}
-
Nikunj Bhagat authored
Bug: 904459 Change-Id: I2eee7eb9d0aa8ef432782d43f55e3c3f073a7b1f Reviewed-on: https://chromium-review.googlesource.com/c/1347269Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610933}
-
Ken MacKay authored
Bug: internal b/117862002 Change-Id: Iae3c3ddd762bb8358e8a7b5bef68d5ba12743a67 Reviewed-on: https://chromium-review.googlesource.com/c/1318814Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#610932}
-
Takuto Ikuta authored
This is follow up for https://chromium.googlesource.com/chromium/src/+/7267171a528f001a5d097ea147544acb145f13e9 Bug: 867725 Change-Id: I1b8a59394acaadc4b741e7874592b090992185a5 Reviewed-on: https://chromium-review.googlesource.com/c/1350425Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#610931}
-
Mounir Lamouri authored
This reverts commit 108147df. Reason for revert: FindIt suggests a 74% chance that this is the cause of the following issues: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26833 Original change's description: > Inherit the navigation initiator when navigating instead of the parent/opener > > Spec PR: https://github.com/w3c/webappsec-csp/pull/358 > > Bug: 905301, 894228, 836148 > Change-Id: I43ada2266d42d1cd56dbe3c6dd89d115e878a83a > Reviewed-on: https://chromium-review.googlesource.com/c/1314633 > Commit-Queue: Andy Paicu <andypaicu@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610850} TBR=mkwst@chromium.org,andypaicu@chromium.org Change-Id: If3ccf72cf8a4285926429f2855f32c1b0c606c5b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905301, 894228, 836148 Reviewed-on: https://chromium-review.googlesource.com/c/1351285Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#610930}
-
Mounir Lamouri authored
This reverts commit 20b501c3. Reason for revert: FindIt believe with 74% confidence that it's the cause of these failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9835 Original change's description: > Reland "v8binding: Do not hold a cross origin ScriptState in IDL callback function" > > This is a reland of 756bea38 > > Original change's description: > > v8binding: Do not hold a cross origin ScriptState in IDL callback function > > > > Make IDL callback function not hold a ScriptState of its > > creation context when it's cross origin from the incumbent > > realm. > > > > Not holding a cross origin ScriptState, there is much > > less risk to access a cross origin context. > > > > IDL callback interface will follow the same approach in > > a separate patch. > > > > Bug: 892755, 886588, 904218 > > Change-Id: Ie55b436fcc5f66f4ee053ef08ad98ea68fb3a2d6 > > Reviewed-on: https://chromium-review.googlesource.com/c/1314023 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#609662} > > Bug: 892755, 886588, 904218 > Change-Id: I78ca7050e659cdb533ae09dab792bc699d2b48bf > Reviewed-on: https://chromium-review.googlesource.com/c/1343881 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610820} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: I21faed593e8bdaae31c86a11413b18d31ab38c45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 892755, 886588, 904218 Reviewed-on: https://chromium-review.googlesource.com/c/1351424Reviewed-by:
-
David Black authored
Per discussion w/ PMs, moving forward we'd like to use finch as a kill switch for these rather than to enable them. This will prevent the user from seeing nothing while they wait for their first flag sync. Bug: b:119886923 Change-Id: Ic93d082f7c46eba4814750588fd89fa47328a67e Reviewed-on: https://chromium-review.googlesource.com/c/1347619Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#610928}
-
Xiaohui Chen authored
Bug: b/77916222 Test: locally build and run on eve Change-Id: If98c7ea10e1778626563587f58c0773351e8e485 Reviewed-on: https://chromium-review.googlesource.com/c/1341081Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#610927}
-
ssid authored
Change-Id: Ia75e5ed83f814b6b6af3f4a87a03302a4e7f6dce Reviewed-on: https://chromium-review.googlesource.com/c/1351072Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#610926}
-
Etienne Bergeron authored
This is a cleanup CL. There is no functional changes. R=oysteine@chromium.org Change-Id: I4e8cdd9f401bb554987c8fb10edecc64b65f1bab Reviewed-on: https://chromium-review.googlesource.com/c/1348852 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/89124cf9..344c43de Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0bc32d5f5676f71c62cc391ab9a78f371e187c4b Reviewed-on: https://chromium-review.googlesource.com/c/1351269Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610924}
-
yileili authored
This is a reland of 36f90a0e Original change's description: > Use cast http connection in libassistant. > > Bug: b:118193766 > Test: Manual > > Change-Id: Ia0cd58e42761b35b9f7281344266505074d59936 > Reviewed-on: https://chromium-review.googlesource.com/c/1321956 > Commit-Queue: Yilei Li <yileili@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607318} Bug: b:118193766 Change-Id: Ice6e98bea5c1d97f538d7de98c4c799dc72788ae Reviewed-on: https://chromium-review.googlesource.com/c/1337292Reviewed-by:
-
Peter Kasting authored
These aren't causing failures today, but would with future changes I'm making. * Be consistent about the root window passed to EventGenerator and the coordinate system used for points passed to EventGenerator. * For WindowSelector close button tests, the window bounds have been transformed and potentially converted to containing rects. To make sure mouse events properly hit the close button, click 5 pixels in from the right edge instead of 1. * Fix copy-and-paste errors. Bug: none Change-Id: Ic8d36c32b1c6fe5569c02e86ab1f9c90d65ac78e Reviewed-on: https://chromium-review.googlesource.com/c/1347583Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#610922}
-
Dan Elphick authored
Fixes uses of Object::Set, Get, ToObject and GetPropertyNames in content/renderer/pepper/ppb_var_deprecated_impl.cc. Bug: v8:7283, v8:7286, v8:7279, v8:8238 Change-Id: I54b420f7173b23d241508ad697c0410c8ae45da6 Reviewed-on: https://chromium-review.googlesource.com/c/1349332Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610921}
-
Akihiro Ota authored
Build on PosInSet and SetSize functions in ax_node.cc to handle invalid or erroneous assignment. SetSize should not allow decreasing assignments, while PosInSet should not allow decreasing nor duplicate assignments among nodes in the same container. Change-Id: I07b0e9c493439aca9ef50ecfe3c3f5bbf7a7ce7a Reviewed-on: https://chromium-review.googlesource.com/c/1343374 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#610920}
-
David Jacobo authored
TextClassifier provides methods for text classification via the ARC container, one of these methods is classifyText(), this method expects (among other params) a text to classify which needs to be non-empty. This CL ensures that the provided text string is not empty before passing it to the container, we already had a check in place but is likely that converting the string could have messed with it. Bug: b/119794258 Test: Build. Change-Id: I155295c283e1f774f152483c8f5f009ded70baa3 Reviewed-on: https://chromium-review.googlesource.com/c/1344196 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Min Chen authored
Bug: 907660 Change-Id: Ic0b3916328d92a4989be0a9e3b2553986ab4f830 Reviewed-on: https://chromium-review.googlesource.com/c/1347618Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#610918}
-
Sammie Quon authored
This CL fixes: Consolidates TestShellObserver in window selector controller unittest and TestOverviewObserver in window_selector_unittest. Removed two overlapping tests. Remove a TODO about bouncing a window, since a toast shows anyways. Remove a enum for the header layout which is not needed anymore because the header always fades in at the final location now. Previously there was this enum to differentiate when the header animated with the window, or when there was color on header which had to be slided in. Test: none Bug: none Change-Id: I7578b2809fda56b8f783875eef12f12ae6e57dd1 Reviewed-on: https://chromium-review.googlesource.com/c/1345536Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#610917}
-
Etienne Bergeron authored
see: https://cs.chromium.org/chromium/src/base/metrics/user_metrics.cc?l=33 TRACE_EVENT_INSTANT1("ui", "UserEvent", TRACE_EVENT_SCOPE_GLOBAL, "action", action); R=oysteine@chromium.org Bug: 867931 Change-Id: I27b80317c4fccc1bb27958a5c3d0439fd6d760c6 Reviewed-on: https://chromium-review.googlesource.com/c/1350193Reviewed-by:
-
Tarun Bansal authored
Simplify the browser tests by not checking for when the experiment is disabled. Also, add DCHECKs to the cc file to ensure that the navigation predictor mojo binding object is created only if the field trial is enabled. Change-Id: I24189c75994e73a1f30d1a7aecc6d7bdaf4e8857 Bug: 903945 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1349873Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610915}
-
Ken Buchanan authored
This CL changes browser process asynchronous hit testing so that if the InputTargetClient returns a FrameSinkId for a RenderWidgetHostView that has no children, it stops doing any further asynchronous queries and accepts that as the current target. It does not take into account whether the point being hit test is over any of the descendant views, should any exist. Test: SitePerProcessHitTestBrowserTest.* Bug: 847604 Change-Id: Ic70a26c19a7e06cef86d2b5b0b91227589e14755 Reviewed-on: https://chromium-review.googlesource.com/c/1342771Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610914}
-
Micah Morton authored
This change causes the cros-disks mount operation to be called with the 'nosymfollow' mount option if the FsNosymfollow Chrome flag is enabled. R=stevenjb@chromium.org Bug: 867807 Change-Id: I394a8c536b77146a0f2fe15c5fafda985f9a44a4 Reviewed-on: https://chromium-review.googlesource.com/c/1344933Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Micah Morton <mortonm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610913}
-
Antonio Gomes authored
BUG=907517 Change-Id: I0d0d73d43ad7af5e2b3cf2091bc45fe782334347 Reviewed-on: https://chromium-review.googlesource.com/c/1349591Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#610912}
-
Anastasia Helfinstein authored
Bug: 907179 Change-Id: I1f66d659690027191a5c2d0d21f09abb2f2d82d0 Reviewed-on: https://chromium-review.googlesource.com/c/1347575Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
Weidong Guo authored
Bug: 907196 Change-Id: I760dc43fc5fd31aec1addc020190a568596b3109 Reviewed-on: https://chromium-review.googlesource.com/c/1344649Reviewed-by:
-
danakj authored
When a RenderWidget is frozen, its compositor is stopped. However when the main frame is being navigated, we want to start requesting mojo pipes for the gpu and display compositor immediately so that it can happen in parallel with the navigation loading. Previously, we just always did this when creating a RenderWidget, and left them active when freezing the RenderWidget. After 678f025f however, we don't, and this causes time-to-first-pixels regressions on navigation. So we add a WarmupCompositor() method to RenderWidget, and call this from RenderFrameImpl::CreateFrame() when it makes the provisional frame, and the WebFrameWidget, since we expect to make use of the main frame RenderWidget shortly. Then, if RenderFrameImpl::FrameDetached() occurs, due to the navigation failing, we will AbortWarmupCompositor() to drop the mojo pipes instead of holding onto them indefinitely. This recovers the loading regressions introduced, while also not allocating mojo channels for frozen RenderWidgets indefinitely. In order to do this reasonably, we drop the "callback" from the request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that it always returns something immediately. This way RenderWidget does not need to worry about having a task run to collect the new frame sink, and ordering with tasks from the compositor to collect it. R=piman@chromium.org Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0 Bug: 905191 Reviewed-on: https://chromium-review.googlesource.com/c/1341073 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610909}
-
Toni Barzic authored
The CL changes how SystemNotificationHelper initializes notification display service for (transient) system notification. Previously, the notification display service was created as a profile keyed service for the sign-in or system profile. On Chrome OS, we are trying to reduce usage of sign-in profile beyond sign-in screen (ideally, the profile would be shutdown once a user session starts). Having system notifications attached to the sign-in profile prevents this. Good news is that the profile in NotificationDisplayService is used mainly to map notifications to users/profiles. In this CL, NotificationDisplayService is updated to be able to work with null profile (at least for transient notifications), and uses null profile NotificationDisplayService to handle system notifications. The system notification display service ownership is moved to SystemNotificationHelper (it's created lazily, and shut down during browser process shutdown). In addition, this changes how NotificationPlatformBridgeChromeOs detects profile shutdown - instead of explicitly observing profile desctruction, the bridge is notified of NotificationDisplayService shutdown (which occurs during profile destruction) by a NotificationDisplayService instance. This way the platform bridge can clean up system notifications on null-profile, system notification display service shutdown. BUG=901768 Change-Id: I63969f58683a38a009fd0253418c522d58b68512 Reviewed-on: https://chromium-review.googlesource.com/c/1338759Reviewed-by:
-
Peter Kasting authored
There's no real reason not to run this test on iOS/Android, as they define an AcceleratedWidget type and the test works correctly when they're serialized appropriately. The correct struct traits are obvious, so I don't see any benefit to not defining them. Bug: none Change-Id: I58db88a774abb441bb3af8e7f458040214c5fd93 Reviewed-on: https://chromium-review.googlesource.com/c/1343562Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#610907}
-
Nico Weber authored
Unused after https://chromium-review.googlesource.com/c/chromium/tools/build/+/1347346 Also remove code that's been unused since that change related to .isolated files from compare_build_artifacts.py Bug: 899438,876915 Change-Id: Ie572c2a27924b72a2ffb86165afca37fcbd667d6 Reviewed-on: https://chromium-review.googlesource.com/c/1351378Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610906}
-
Morten Stenshorne authored
If someone has bothered to set a containing block size override, that should be chosen in favor of special-code for orthogonal writing modes, that reads out data from some ancestor layout object. LayoutNG sets an override when entering legacy layout roots, since we shouldn't be allowed to read out data from ancestor objects during layout when using LayoutNG. We also need to take care when the child establishes an orthogonal writing mode, in order to pick the correct dimension. Bug: 869882 Change-Id: I63997ebc10b77fba37527ed7a01ae406854d8f96 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1348055Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610905}
-
jdoerrie authored
This change adds UTM parameters for navigations to the Google Password Manager. The UTM campaign parameter depends on the dialog from where the navigation originated. Bug: 904821 Change-Id: I0f2e55f83b3ba81a49c960583996aa2fe5bd392f Reviewed-on: https://chromium-review.googlesource.com/c/1350973Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#610904}
-
Benjamin Shaya authored
Bug: 112417422 Test: cast_audio_backend_unittests Change-Id: Iaf52c3ca4c09ab8290e1ddb165ead94d7fb59f63 Reviewed-on: https://chromium-review.googlesource.com/c/1347690Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Cr-Commit-Position: refs/heads/master@{#610903}
-
Vlad Tsyrklevich authored
Refactor a trivially copyable (e.g. plain old data) object out of the current GuardedPageAllocator. This 'base state' object encapsulates just the information required by the crash handler. Because its construction/destruction is trivial, a base state object can be overwritten with out-of-process memory and destructed without concerns about undefined behavior or destructing complex objects with pointers from another process. The GuardedPageAllocator encapsulates all of the remaining data and allocation logic that does not to be reached by the crash handler. As such, it's been refactored into client/. Bug: 896019 Change-Id: I418411b914a61c592f8b585d55058aa5a705acfb Reviewed-on: https://chromium-review.googlesource.com/c/1339246 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#610902}
-
Hiroshige Hayashizaki authored
The long virtual test name caused crbug.com/906964 due to path length limit exceeded. Bug: 880027, 906964 Change-Id: I63cf49387adecf2f9e729ee10b26ffd86971cf8d Reviewed-on: https://chromium-review.googlesource.com/c/1344579 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610901}
-
Ian Kilpatrick authored
This removes another 2xLayoutUnits on the NGConstraintSpace. This should have no behaviour change. Bug: 635619 Change-Id: I765139563ffc9b167fefffe16ed3674c1db5dbf9 Reviewed-on: https://chromium-review.googlesource.com/c/1340585 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610900}
-
Anastasia Helfinstein authored
With this change, Dictation stops listening when a new tab is opened, as well as in most cases where focus changes between two text fields on a page. I will follow up on why it does not stop when using my minimal example of two <input type='text'> tags (and nothing else). Bug: 866489 Change-Id: Ib0a60dcb3b5871173bceeab9675491c81e72414d Reviewed-on: https://chromium-review.googlesource.com/c/1347002Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#610899}
-
