- 25 Nov, 2020 1 commit
-
-
Moe Ahmadi authored
Sets the z-index value of dragged MV tiles to that of the realbox input. Fixed: 1122894 Change-Id: I1b3cfd2469c62edfedd0335f0fb4aef483bbf12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556447Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830786}
-
- 24 Nov, 2020 39 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1da4494cc50..377448c7bd4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ezemtsov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144488 Tbr: ezemtsov@google.com Change-Id: I34dfd872d3ff2f6891eea94edb03bf5873a3bc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559007Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830785}
-
Nicholas Hollingum authored
This infrastructure will hopefully form the basis of the state management for the borealis system. The important concepts are: - State is managed by manager objects, which can be in exactly two states (on/off) - State is conceptualized with state objects, that are constructed or destroyed during state transitions, based on what those transitions are defined as. - The state manager owns the instance of the state object, so we force designs that work a bit like an onion/stack in the sense that if state C is a descendant of P then we model this by having P own the *state manager* for C (as opposed to having C own/inherit/extend P itself). Bug: b/172178036 Change-Id: I2b065f71972d11e3212509f2f4c569e598ca9c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526865Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#830784}
-
adoneria authored
Also, adds win7 32-bit testers to test these builds. Bug: 1151458 Change-Id: Iaacac3d1e0ecf4336cf0c9f29cb2be12973ee109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552944 Commit-Queue: Anjali Doneria <adoneria@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#830783}
-
Abigail Klein authored
visible. On Windows, there is a bug where the caption bubble is focused after the tab model changes, even if the caption bubble had previously been deactivated. When the tab model changes, it causes focus to advance to the next focusable view and activate that view's widget. The fix for the caption bubble is to ensure that the caption bubble cannot be activated by the focus manager unless the caption bubble is visible. The stack trace of this behavior is: Browser::OnTabStripModelChanged Browser::OnTabDetached BrowserView::OnTabDetached views::WebView::SetWebContents views::WebView::UpdateCrashedOverlayView views::View::SetFocusBehavior views::View::AdvanceFocusIfNecessary views::FocusManager::AdvanceFocusIfNecessary views::FocusManager::AdvanceFocus views::FocusManager::SetFocusedViewWithReason views::Widget::Activate ...leading to... captions::CaptionBubble::OnWidgetActivationChanged One outstanding question is whether the focus manager should ever activate a widget that is not visible. This will be explored in a follow-up. Bug: 1055150, 1123635 Change-Id: I9b5eaee54a5f78592c320b18282a726f9e0980eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558721 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#830782}
-
Eugene Zemtsov authored
Fails on ios-simulator-full-configs bot TBR=marq@chromium.org BUG=1146303 Change-Id: I1f613b0ae47cd8512cf6f8d442a0bd5dda83fe60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558768 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Eugene Zemtsov <ezemtsov@google.com> Cr-Commit-Position: refs/heads/master@{#830781}
-
Yi Gu authored
The test is also flaky on CrOS: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=DownloadTest.SaveLargeImage TBR=jam@chromium.org Bug: 1141263 Change-Id: I534a8e08e22bf98960041c1e1ffca83e335ccb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559378 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830780}
-
Brandon Maslen authored
Currently the HTTP 2 protocol will limit data frames to 2,852B (2*MSS - frame header). Unfortunately this leads to excessive amounts of data frames during large H2 uploads. On resource constrained clients or servers this leads to a significant drop in throughput. In tests this has been observed to lead to H2 performing up to 136% slower than HTTP 1.1 with large transfers. This change updates the max data frame size to be 16,376B (16KB - frame header). This more closely aligns with HTTP 1.1 that uses 16KB and QUIC that uses a larger chunk size also. The TLS layer will also chunk data at 16KB so this is a good boundary to align to. In tests this led to significant improvements in the above scenario. It's not expected that all H2 uploads will see throughput improvements as an abundance of processing resources could sufficiently keep up with the smaller frames to maintain throughput at the cost of more compute. It does seem that most large uploads would benefit from a lower CPU/Byte cost on the client and server sides due to the increase in frame size. Bug: crbug.com/143193 Change-Id: Ifadbe7ffc075130ee690cd168a1b60b7abdbfcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551284 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#830779}
-
Christoph Schwering authored
The number of times a value is filled into different fields is limited. The exception are state fields because websites sometimes have one state select box for each country and display the relevant select box once the respective country has been selected. This CL simplifies this mechanism and makes it more explicit by encoding the type-dependent limits in TypeValueFormFillingLimit(). As a side effect, the limits apply not just to filled fields but also unfilled fields of the same type. Bug: 1075734, 1084903 Change-Id: Icc5e8e082850ed44d9c7fbbc911d03a95033d81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557977 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#830778}
-
Jae Hoon Kim authored
|OnInstall()| accidentally was using a moved variable when a status of busy is returned from the platform dlcservice. This change fixes the previously incorrect double move of a variable. BUG=chromium:1152219 TEST=./unit_tests Change-Id: I1f526d808ef3cf571dbe61516340dc69c35f32d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558953Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#830777}
-
Yi Gu authored
The test has been flaky on Linux: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=PDFExtensionClipboardTest.CombinedShiftArrowPresses%2F TBR=thestig@chromium.org Bug: 1121446 Change-Id: Ibb0a5bb8f17e0d41a16f105d5ed6d4c3f1236dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558849Reviewed-by:
-
Vincent Boisselle authored
Bug: 1152438 Change-Id: Ifa99673cbb51a13a56a7bb146c304a39e579cfdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557226Reviewed-by:
Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#830775}
-
Chris Harrelson authored
content-visibility:auto elements have different sizing behavior when near the viewport vs not. This sizing behavior is an intentional part of the platform, and should not be considered a layout shift for the the first time the elements' subtrees become unskipped (*). There are two cases of "first time": * The very first paint when a content-visiblity:auto element is in the DOM, and in which the element is found in that frame to be near the viewport. * The first paint *after* a content-visiblity:auto element has been found to be near the viewport, but was was found for at least one frame previously not to be near it. These two cases are handled in somewhat different ways in Blink - the former is a synchronous relayout, whereas the second is async. In both cases, CLS should not be impacted. In the future, we could consider in the future whether layout shifts for subsequent unskips should also not count for CLS. Bug: 1151526 (*) https://drafts.csswg.org/css-contain-2/#skips-its-contents Change-Id: I9421452430dd572ed87bb20b0bd20e9a7e3501a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556211 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830774}
-
Michael Checo authored
- Final strings TBD Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I78e4f4fa8138322d800fe1144ecd594caa141ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552286 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#830773}
-
Gayane Petrosyan authored
In some cases PlainText might return a single space " ". The case found is when a selection starts with an element that is nested within inline-block element. This combination creates extra spaces that is selectable and is not fully collapsed by PlainText. Bug: 1151474 Change-Id: Id855e9847efc5f70cedb3c58d72b33191c4771b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558914 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830772}
-
Zhaoyang Li authored
https://chromium.googlesource.com/external/github.com/google/eDistantObject.git/+log/e8a984232246..91c532d921e1 $ git log e8a984232..91c532d92 --date=short --no-merges --format='%ad %ae %s' 2020-11-23 haowoo Retrieve block signatures directly from block headers. 2020-11-21 mobile-devx-github-bot Add signature to blocks in EDO 2020-11-10 albertbow Fix Swift Array objectAtIndex: failure on eDO since iOS 13.4. 2020-11-02 albertbow Fix eDO TSAN issue caused by __block variable. 2020-10-14 albertbow Enable ASAN and TSAN Travis tests in external CI. 2020-10-14 albertbow Fix eDO ASAN issue captured by Xcode 10. 2020-10-06 albertbow Fix TSAN warning on EDOListenSocket. 2020-10-03 haowoo Remove the unneeded cancel block. Created with: roll-dep src/ios/third_party/edo/src Bug: 1152551 Change-Id: I74d20d4a29ac6a4aeccbb47bcdc10f57d43c2070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558784Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#830771}
-
Xianzhu Wang authored
The bug is caused by integer overflow and DCHECK/CHECK failure when calculating the area of a layout shift region containing rects with geometry values like 2^31-1. The situation happens only during printing when layout shifts should not be reported because in normal cases the viewport clip limits the geometry of the region. Bug: 1151591 Change-Id: I3fd080eab1be31815668486dc555c227ff2cf4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557883 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#830770}
-
Emircan Uysaler authored
This CL addresses hangs we see after a hide/show sequence. Merging primary and overlay fences imposes the one-Image-in-flight limitation of primary plane on overlays. However, overlays might be presenting the same image after hide/show. Therefore, skip merging fences until we can do updates independently, after |supports_commit_overlay_planes| is supported. Bug: 1151042 Change-Id: Icf8a629ce700c63559f036bd2c1c9dab0a58d888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552945Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830769}
-
Tibor Goldschwendt authored
Previously, we requested fake data via a triggering GWS experiment ID. However, that does not work on Chrome OS. After this CL, we request fake data by appending an async fake_data:1 to the data request. + Move AppendToAsyncQueryParam to Google utils so that it can be used by both the logo and the task module service. Bug: 1149880 Change-Id: If449c3d05eeac8bd1124514dfc8539199bfb25a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551329Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830768}
-
chrome://weblayerKen Rockot authored
Simple adaptation of this WebUI to use JS modules in lieu of manually managing dependency imports. Bug: 1004256 Change-Id: Ib9e5477f1a1578772f9a2d657d41aa5c36aee516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556700 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830767}
-
Elly Fong-Jones authored
The original change assigned "N" as the accelerator for this item, but that is already in use by "minimize"; have "Name Window" use "W" instead, which is free in this menu. Bug: 1152079 Change-Id: Ibebe8331c3580a6db76808791056677550d293c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558748 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830766}
-
Andreas Papacharalampous authored
the extension mentioned should be a better alternative than the existing files.association workaround Bug: 1144959 Change-Id: Ie912519b00e5c74af0634fc85a09610ec09175c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515285Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#830765}
-
Mike Jackson authored
In preparation for run on os login support for linux, I'm adding tests to validate the existing functionality of the linux shortcut code. There are minimal product code changes, primarily to help facilitate testing, or to remove dead code that was only previously used by the old test code. Bug: 897302 Change-Id: I8e08632227da675f19082c72d6fa611747d1f15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528877Reviewed-by:
-
Yi Gu authored
The test has been flaky (score > 1400): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests%20(with%20patch)&tests=All%2FCrossOriginOpenerPolicyBrowserTest.CrossOriginIsolatedSiteInstance_MainFrame https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVydQsSBUZsYWtlImpjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BDcm9zc09yaWdpbk9wZW5lclBvbGljeUJyb3dzZXJUZXN0LkNyb3NzT3JpZ2luSXNvbGF0ZWRTaXRlSW5zdGFuY2VfTWFpbkZyYW1lDA TBR=ahemery@chromium.org Bug: 1125998 Change-Id: I991e18b0d74e08db3fe0360c6f43b2a284921be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559006 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
Nicolás Peña Moreno authored
Currently, InsertPerformanceEntry receives a ref PerformanceEntry as parameter, so push_back may be creating a copy of the object. We make sure this does not happen by passing a raw pointer to push_back so it creates a Member out of it to retain ownership and there's no risk of cloning the object. Change-Id: I3315e394a30baa6cb7627f935f4b83e560fe2a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558739Reviewed-by:
-
Yi Gu authored
The test has been flaky (score > 1400): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=ExtensionWebRequestApiTest.RedirectToAppCacheRequest https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEV4dGVuc2lvbldlYlJlcXVlc3RBcGlUZXN0LlJlZGlyZWN0VG9BcHBDYWNoZVJlcXVlc3QM There are other instances on Mac but not as many as on Linux ATM. TBR=cduvall@chromium.org Bug: 1094834 Change-Id: I28ff7697b3cd7cbd8f81ced7f0dd4cfb4d53103f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559005Reviewed-by:
-
Andreea Costinas authored
Add a new policy for Chrome OS that will be used to control whether reusing the Chrome OS login credentials for network authentication is allowed. Only used for managed proxies secured with NTLM authentication. Bug: b/173097096 Test: presubmit tests; verfied chrome://policy with YAPS Change-Id: I0e352fcac0c2aea434670aeaae13f1f2e86b3f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543349 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830760}
-
Nicholas Hollingum authored
We add a BorealisWindowManager handler which will do the bulk of processing for borealis windows. This handler recognizes borealis windows specifically (i.e. not crostini windows) but otherwise emulates the previous behavior (i.e. it pretends the windows are crostini ones). In a future CL we will add special behavior for borealis windows. Bug: b/172979315 Change-Id: Id4ef5fbb1fe95b1d1e2c79c510870cdd2329d6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554275 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Rachel Wong authored
This CL links the flag at chrome://flags to trigger the corresponding Suggest experiment to enable rich entity support in the Launcher. The relevant Suggest config can be found at http://google3/googledata/experiments/gws/studies/suggest/cros_suggest_launch.gcl. Bug: 1130372 Change-Id: I0ed17ac19c2ea988e025a743d148aa73ed8e71a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556880Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#830758}
-
Jeffrey Kardatzke authored
There was a previously unknown iHD requirement before that if we want to keep the protected session attached to the decoding context, then we need to submit the encryption parameters for every slice (even if that slice is not encrypted). BUG=b:153111783 TEST=H264 and VP9 works with seeking in/out of encrypted/clear content Change-Id: I6fff69d4b5ce4a0835f898a068e6a9049ab5e3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555469 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#830757}
-
Aleks Totic authored
Bug: 958381 Change-Id: I5dfd967b14adc19da07ea23bb38fe9f8d987dbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559250 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#830756}
-
Andrew Grieve authored
This reverts commit 30f14e92. Reason for revert: official bot breaking https://bugs.chromium.org/p/chromium/issues/detail?id=1144538#c8 Original change's description: > Reland "Android: Enable use_debug_fission for official builds" > > This reverts commit 86befdda. > > Reason for reland: Bugs fixed in other CLs (see issue) > > Original change's description: > > Revert "Android: Enable use_debug_fission for official builds" > > > > This reverts commit 9d3a4611. > > > > Reason for revert: Official builds failing crbug.com/1144538 > > > > Original change's description: > > > Android: Enable use_debug_fission for official builds > > > > > > Bug: 1122182 > > > Change-Id: I29b579cf7c5e7eb6d2528a6fad28562059698bf8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508342 > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#822625} > > > > TBR=agrieve@chromium.org,benmason@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1122182,1144538 > > Change-Id: I49cb3f0d42027a5e855cf1aa16f8cd1441f46ca9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513206 > > Commit-Queue: Krishna Govind <govind@chromium.org> > > Reviewed-by: Ben Mason <benmason@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#823080} > > Bug: 1122182 > Bug: 1144538 > Change-Id: Id3bcf776146a9bd9e66ec50cd8b9529029479faf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541383 > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ben Mason <benmason@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827946} TBR=agrieve@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1122182 Bug: 1144538 Change-Id: Iccd274ff85e12710206105c713a2f3dbc260f1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558781Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#830755}
-
Dave Tapuska authored
Now that WebFrameWidgetImpl is only subclass of WebFrameWidgetBase, the two classes can be merged into one. BUG=1097816 TBR=dcheng@chromium.org Change-Id: Ibe12b5a865355e37cf0d3500fb521779f40574aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552251 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830754}
-
Vasiliy Telezhnikov authored
This is a reland of db7626d6 Changes from the original: check if vk_context_provider not null. Original change's description: > Use GrShaderCache with Vulkan > > VulkanContextProvider is created before GrShaderCache and so cache > wasn't pass to Skia via GrContextOptions. > > This CL defers init of GrContext in VulkanInProcessContextProvider to > SharedContextState::InitializeGrContext to mitigate this. > > Use of cache itself is under feature flag for metrics comparison and > a kill switch purpose. > > Bug: 1151031 > Change-Id: Idc410b9b557f7ca67164eb80d6a37a27ceb0f6d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551245 > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829651} Bug: 1151031 Change-Id: Ibd4e7d55fdc56c1ea2cc0e82d6cc6c34459165c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554353Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830753}
-
Francois Doray authored
With this CL, the same histograms are recorded when the BackgroundTabLoadingFromPerformanceManager feature is enabled/disabled. Bug: 1059341 Change-Id: I2a099ef73e71b649d5a927659f9fbe3c052e63cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553287 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#830752}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: If3df892370f81f37fb854eb931741817c11b6ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558670Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#830751}
-
Joon Ahn authored
Applies linear gradient on the chart area and adjusts etc paddings and colors. http://screen/BQXtyTNo9TZgeqb Bug: 1125150 Test: browser_tests --gtest_filter=Diagnostics* Change-Id: I993fc3e2fd0dbbdc74bd0e6ba183a9bcfcc5b379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558913Reviewed-by:
-
Chris Sharp authored
BUG: b:173720192, b:173642641, b:174060344 Change-Id: Id941a5178fe483a3fc9933beb96924d68f4586c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555258 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830749}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a629d81faa7a..ae003f552e4e 2020-11-24 heiserya@google.com Telemetry-on-lacros fixes: If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1149629 Tbr: oysteine@google.com Change-Id: Ie2341fb8e08ba6b6655f73d8c97e9b911ad748d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830748}
-
Yi Gu authored
The test has been flaky on all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=accessibility/aom-click-action.html TBR=aboxhall@chromium.org NOTRY=True Bug: 1134459 Change-Id: I795f7a7b21eef84a24d5b56e42240604e863ff8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559375Reviewed-by:
-
