- 02 May, 2018 40 commits
-
-
Xiaohan Wang authored
- Roll src/media/cdm/api/ 163f87884..d12602556 (1 commit) 2018-04-26 xhwang cdm: Mark CDM_10 interface as stable - Update Chromium to use the latest stable CDM_10 interface, e.g. now cdm::ContentDecryptionModule is not defined anymore. - Use an std::array kSupportedCdmVersions to store information about supported and enabled (by default) CDM interface versions. - Simplify IsSupported* functions. - Add static assert to make sure the CDM Host interface for a supported CDM interface is also supported. - Add static assert to make sure experimental CDM interface is never enabled by default. NOPRESUBMIT is specified to workaround the media presubmit on histogram enum UMA style check. See https://crbug.com/772494. NOPRESUBMIT=true Bug: 733821 Test: No functionality change. Change-Id: I236a24106354ea9210e703bae5a13dc4238f93d3 Reviewed-on: https://chromium-review.googlesource.com/1035783 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#555542}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. VideoFrameSubmitter is one such call site. BUG=759031 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia4fde6fdb870c87d1852edd1f4a33a89f7cc9743 Reviewed-on: https://chromium-review.googlesource.com/1034390 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555541}
-
Katie D authored
This is part of a change to allow Select-to-Speak to work in tablet/touch only mode. This change allows the extension to tell the EventHandler that capturing should being, allowing Select-to-Speak to start capturing touch events or mouse events without the 'search' key having been clicked. This change does not cause any behavior changes at this time, because there is no current way to enter the SELECTING state without holding down the search key first. In a follow-up change, this pathway will be activated when a user will click a button in the ash system shelf. That button is not yet hooked up. To see a complete demo, see https://chromium-review.googlesource.com/c/chromium/src/+/1031550. Bug: 753018 Change-Id: I3be60fa338ce32e2a99ce7e21d9d7cab503ac4e0 Reviewed-on: https://chromium-review.googlesource.com/1036534 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555540}
-
Johannes Henkel authored
It's probably an oversight that this is missing; also adding a comment to the header file for next time. Andrey thank you for pointing me at network_param_ipc_traits.h. R=caseq Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I21e278de132e0b3e465c3e27d25201b6878270e3 Reviewed-on: https://chromium-review.googlesource.com/1038808Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#555539}
-
Min Chen authored
crash in mash. Add RunAllPendingInMessageLoop to make it happy in mash. Bug: 838595, 837092 Change-Id: Ib5fbd2857c41fc4de3254b6f31a4bb6809864d76 Reviewed-on: https://chromium-review.googlesource.com/1040533Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#555538}
-
Daniel Cheng authored
This is the first step in a multi step plan to simplify the number of injection points core exposes for testing: 1. Simplify existing DummyPageHolder tests that don't need custom clients. These can be trivially migrated to the new DummyPageHolder and PageTestBase implemented in step 3. 2. Rename DummyPageHolder and PageTestBase to DummyPageHolderDeprecated and PageTestBaseDeprecated. 3. Implement new DummyPageHolder and PageTestBase based on WebViewHelper. 4. Migrate tests that don't need custom clients to the new DummyPageHolder or PageTestBase. 5. Migrate tests that need custom clients by migrating the hooks from ChromeClient / LocalFrameClient to WebViewClient, WebWidgetClient, or WebFrameClient as appropriate. 6. Remove DummyPageholderDeprecated and PageTestBaseDeprecated. Bug: 734748 Change-Id: I37a4b60770b6d76933ff475253f7b15dcf8df26d Reviewed-on: https://chromium-review.googlesource.com/1020814 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555537}
-
Sahel Sharify authored
Bug: 838971 Change-Id: Ic296d7e5792ed38cc636b1f84d7d3d2e1ac229cb Reviewed-on: https://chromium-review.googlesource.com/1037424 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#555536}
-
David Bokan authored
When an iframe loads its first or a new document we might swap out the FrameView. When this happens, the validity of a candidate for implicit promotion will change so we should reevaluate at that time whether any candidates should be promoted. Also disabled implicit root scroller in frameElement-frame test since it causes promotion of the frame which leads to pixel differences in the output. When/if this feature ships we should rebaseline this test. Bug: 838683 Change-Id: I55f3a49af8670897a31e63fd58469f5121b32671 Reviewed-on: https://chromium-review.googlesource.com/1036843Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555535}
-
Kevin Marshall authored
This is a reland of 7891d057 The underlying issue in crbug.com/838703 was fixed and "lint_test_expectations.py" Works On My Box(TM). TBR=scottmg@chromium.org Original change's description: > Fuchsia: Explicitly check that all file dependencies exist. > > Wrap file path references with "EnsureFileExists()" which acts as a > simple identity function, except for invalid paths for which it > raises IOErrors. > > Bug: 837200 > Change-Id: Ie718cd5517415b375ed3bf5d5112d59b32074c04 > Reviewed-on: https://chromium-review.googlesource.com/1037778 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555137} Bug: 837200 Change-Id: I21713adc9e8d9fcaab06957a25255de3ee6e596e Reviewed-on: https://chromium-review.googlesource.com/1038963Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#555534}
-
Karan Bhatia authored
r551018 introduced an override for ReadyToCommitNavigation method on ChromeExtensionWebContentsObserver. However it failed to call its superclass implementation. Fix it. BUG=696822 Change-Id: I882c8af072f942e65072fb06e3b2209d2e983c1c Reviewed-on: https://chromium-review.googlesource.com/1039158Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555533}
-
https://pdfium.googlesource.com/pdfium.git/+log/d3b0f7cc78e6..303f9a3afc4a $ git log d3b0f7cc7..303f9a3af --date=short --no-merges --format='%ad %ae %s' 2018-05-02 dsinclair [xml] Simplify the CFX_XMLParser parse methods 2018-05-02 dsinclair [xml] Rename CFX_XMLParser::ParseTextChar 2018-05-02 hnakashima CFWL_MonthCalendar::GetTodayText() includes "Today" string. 2018-05-02 hnakashima Pass DPI as CFX_Size in XFA_DrawImage. 2018-05-02 dsinclair Cleanup XFA document properly on failed load 2018-05-02 dsinclair Add a CFX_XMLDocument class. 2018-05-02 hnakashima Remove out params from CalculateAccWidthAndHeight. Return CFX_Size. Created with: roll-dep src/third_party/pdfium BUG=chromium:837578 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia4cf7f68b647c08a999794d10f270247e6e803fa Reviewed-on: https://chromium-review.googlesource.com/1040358Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555532}
-
Michael Lippautz authored
Compute estimated marking time in PostSweep were both, marked bytes and marking time, refer to the same garbage collection cycle. Bug: chromium:830196, chromium:757440 Change-Id: I80ea0c028ba7668f05b94b1acbe9b0c38afa801a Reviewed-on: https://chromium-review.googlesource.com/1039566 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555531}
-
Sigurdur Asgeirsson authored
Bug: 755840 Change-Id: I3f27b8a1138690f2b9ed9cd6af442bc1758a5f38 Reviewed-on: https://chromium-review.googlesource.com/1028453Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555530}
-
Danyao Wang authored
This fixes WebPageReloadNavigation and NativeContentReload in navigation_and_load_callbacks_inttest with WKBasedNavigationManager. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I04cf18663fed453c8d4093a67fe988298acd87fc Reviewed-on: https://chromium-review.googlesource.com/1040276Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555529}
-
Max Morin authored
Missed in https://chromium-review.googlesource.com/c/chromium/src/+/1004634. Bug: 803102 Change-Id: I9366f75252bfcf9009491dfbfae481bee40e042c Reviewed-on: https://chromium-review.googlesource.com/1039809Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#555528}
-
Peng Huang authored
Add a flags argument for SwapBuffers, PostSubBufferCHROMIUM, wapBuffersWithBoundsCHROMIUM and CommitOverlayPlanesCHROMIUM. This flags will be used to indicate if the client want to receive presentation feedback and VSync update. Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icd22dbbc493f7982fec9cc5310f404a9ef5d477b Reviewed-on: https://chromium-review.googlesource.com/1033582 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555527}
-
Mark Pilgrim authored
Bug: 773295 Change-Id: I14ef40e378fa6cceb68d31342ef9bf35eb7f7ab3 Reviewed-on: https://chromium-review.googlesource.com/1040085Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#555526}
-
Xiaohui Chen authored
Push native assistant state into voice interation controller so existing UI elements logic could be reused. Bug: b/78193960 Test: locally build Change-Id: I6fbaf74db41263fbdd184bed37e8f29a21578c6f Reviewed-on: https://chromium-review.googlesource.com/1040351Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#555525}
-
Hiroshige Hayashizaki authored
This CL 1. Maps std:x|y URLs to std:x (according to the draft spec [1]), 2. Then maps to std-internal://x/index.js (not spec'ed [2]) in GetInternalURL(), 3. Then retrieves and serves the script contents for std-internal: URLs in GetSourceText() using ui::ResourceBundle() from blink_resources.pak. The source JavaScript files for Layered APIs are placed under third_party/blink/renderer/core/script/resources/layered_api and bundled into blink_resources.pak. This CL introduces std: and std-internal: schemes that are used in Blink side (std: is user-facing while std-internal: is mostly invisible for users) but not outside Blink. [1] Spec: https://github.com/drufball/layered-apis/blob/master/spec.md [2] Implementation design doc: https://docs.google.com/document/d/1V-WaCZQbBcQJRSYSYBb8Y6p0DOdDpiNDSmD41ui_73s/edit Bug: 829084 Change-Id: I61fc0a2f17d937db6e859303ab8a84e4b2b87850 Reviewed-on: https://chromium-review.googlesource.com/1013321 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#555524}
-
Jialiu Lin authored
No SB APIs will be triggered if users are in incognito mode. If enterprise configures the PasswordProtectionWarningTrigger to PASSWORD_REUSE, no Gaia reuse ping sent, and Chrome triggers the OnPolicySpecifiedPasswordReuseDetected() with is_phishing_url set to false. By default, Chrome triggers the OnPolicySpecifiedPasswordReuseDetected() with is_phishing_url set to true, when modal warning is shown. OnPolicySpecifiedPasswordChanged() is triggered when we detect a sync password change. TBR=markusheintz@chromium.org Change-Id: Ia3a9e6f1c70f47d4e1ec8b14feb58d94e85fbd62 Bug: 811467 Reviewed-on: https://chromium-review.googlesource.com/1022111 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#555523}
-
Evan Stade authored
Bug: none Change-Id: I7f3f331b0023077348049edbfb9ce104bee7a293 Reviewed-on: https://chromium-review.googlesource.com/1040306Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#555522}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9ab22385ead..38a08436886e $ git log f9ab22385..38a084368 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 khushalsagar fonts: Reland push font remoting. 2018-05-02 reed check for finite vertices 2018-05-02 angle-skia-autoroll Roll third_party/externals/angle2/ 47155b171..78feddc28 (5 commits) 2018-05-02 reed use SkLeftShift in case the first arg is negative 2018-05-02 reed check for 0x8000 before calling abs 2018-05-01 herb Add the filter rec bypass to make canonical strike descriptors Created with: roll-dep src/third_party/skia BUG=chromium:831354 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I2e0bf369d9581b066ce31b0c003b9c5a14482f9b Reviewed-on: https://chromium-review.googlesource.com/1040529Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555521}
-
edchin authored
This CL enables undo close all tabs in the tab grid by serializing the current window. The undo operation deserializes the saved closed window. Current known issue is that snapshots are erased when WebStates are closed. Another CL will deal with keeping snapshots around long enough for undo operations. Bug: 804567 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I12cf8c11d1e067a7de1b9a6ce44d207810619eb8 Reviewed-on: https://chromium-review.googlesource.com/1036257Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555520}
-
Jared Saul authored
Bug: 839029 Change-Id: I11bb3eb81a3e2ac04bd8f99332756e8529b94f7b Reviewed-on: https://chromium-review.googlesource.com/1040535 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#555519}
-
Dave Schuyler authored
This CL renames references to answer layout to old-style layout to be clearer about what refers to the old style answer layout. Some uses of old-style answer formatting in entities were also cleaned up. Bug: None Change-Id: I6812c7d005cb9c945b8a36e89668d062cda4558a Reviewed-on: https://chromium-review.googlesource.com/1040538Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#555518}
-
Jeremy Roman authored
Change-Id: I43d203b91343e0c8458a1b5c0af7252dddb00a0e Reviewed-on: https://chromium-review.googlesource.com/1038607Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555517}
-
Alexander Timin authored
This patch only plumbs ObserverType to CalculatedThrottlingState, but does not modify logic yet. This patch is extracted from http://crrev.com/c/956224 by ryansturm@ to unblock dedicated worker throttling and load throttling work. R=ryansturm@chromium.org,alexclarke@chromium.org TBR=toyoshim@chromium.org Change-Id: I4b554a48a7f5a247eac7687de93b68ac37dea07e Reviewed-on: https://chromium-review.googlesource.com/1039805Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555516}
-
Mark Pilgrim authored
(split off from https://chromium-review.googlesource.com/c/chromium/src/+/1035543 ) This adds GetSharedURLLoaderFactory(), which returns a SharedURLLoaderFactory owned by the SystemNetworkContextManager and backed by the SystemNetworkContext. Bug: 773295 Change-Id: I5301e9785d913dd27cdc36e7ef4f759290e1ecf5 Reviewed-on: https://chromium-review.googlesource.com/1037943 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555515}
-
Peter Kasting authored
* Removed initial TabStrip* arg, no one was using it. * Changed names from e.g. TabStripAddedTabAt() to OnTabAdded() to shorten and make consistent with other observer OnXXX() names. * Changed TabStripMaxXChanged() to OnTabsMaxXChanged() in keeping with the meaning change in https://chromium-review.googlesource.com/c/chromium/src/+/1038789 . * Changed override order in GlassBrowserFrameView to match base class. BUG=none TEST=none Change-Id: Ibf29362d818d8f63e34c168d428173bca6e2a257 Reviewed-on: https://chromium-review.googlesource.com/1038796 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#555514}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d4cebe797eb..9dea5038cdf1 $ git log 5d4cebe79..9dea5038c --date=short --no-merges --format='%ad %ae %s' 2018-05-01 bmgordon Reland "cbuildbot: Use previous build state for chroot reuse" Created with: roll-dep src/third_party/chromite BUG=chromium:829665 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib2d03b9830dbc167cc5111d0f16a0d6eec7fab1b Reviewed-on: https://chromium-review.googlesource.com/1040113Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555513}
-
Rayan Kanso authored
Design doc: https://docs.google.com/document/d/1zk6WSUb063I_07ct1EP8krOsDKXai1v4nJchvpQeAio/ TBR=avi@chromium.org Bug: 826257 Change-Id: Ib34d8640545beae4b6b0dfa38d634937215ae4ff Reviewed-on: https://chromium-review.googlesource.com/1026730 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#555512}
-
Christopher Grant authored
Having a dedicated mode for prompts should make visibility of other elements simpler when prompts are active. To make this work: - Simplify voice search, content and omnibox's visibility gating logic - Fix voice search metrics reporting - Add vollick@'s sequence object to introduce an alternative to transient elements - Removed illegal visibility bindings (ancestor bound to descendant) and related hacky workarounds. BUG=829880 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ic0f6c7546797b956eda02e50fd9384149a3612c6 Reviewed-on: https://chromium-review.googlesource.com/1031209 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555511}
-
John Abd-El-Malek authored
The test class now works with frame requests when the network service is disabled. Also remove the exception in BrowserTestBase::InitializeNetworkProcess which isn't needed anymore. Bug: 776589 Change-Id: I87d5efedba8f967dc6b5c890cede22d53e60c90c Reviewed-on: https://chromium-review.googlesource.com/1037626Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555510}
-
Ahmed Fakhry authored
BUG=838561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7c4874880c80706327d97cbf86cef54c940abd6b Reviewed-on: https://chromium-review.googlesource.com/1040348Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#555509}
-
Steve Kobes authored
This configuration is no longer tested. Bug: 823365 Change-Id: Ied6ece777017245dad4ec93ef25f691f9110e62b Reviewed-on: https://chromium-review.googlesource.com/1040536Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#555508}
-
Eric Stevenson authored
In diagnose_bloat.py and generate_gradle.py the defaults for max jobs (-j) are too high for machines without a large amount of RAM. This should help non-Googlers. Bug: 799954 Change-Id: I0f1480cb3bf93c17e9a182da821876b0d6f5f12c Reviewed-on: https://chromium-review.googlesource.com/1038440Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#555507}
-
Scott Chen authored
The test broke when some <settings-toggle-button>s in settings Privacy page was moved to a new element. The original CL (1022716) did not break trybots because the problematic tests only run for branded builds. Bug: 838543 Change-Id: Iadc8076f870bdca9831e52e7fa5929052f95c038 Reviewed-on: https://chromium-review.googlesource.com/1037925 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#555506}
-
Sorin Jianu authored
The returned vector must contain a nullptr for an extension id that does not exist. Bug: 837371 Change-Id: I1e81a64c64c6a1d2b0cb9a76a278836c7412eb07 Reviewed-on: https://chromium-review.googlesource.com/1037906 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555505}
-
Ned Nguyen authored
This reverts commit d8a31d45. Reason for revert: suspect breaking blink_heap_unittests BUG:chromium:839114 Original change's description: > [oilpan] Enable incremental marking buildflag > > Includes incremental garbage collection infrastructure in regular > builds. Does not enable incremental marking at runtime! > > This CL may cause throughput regressions and is an attempt > to collect a broad range of potential performance issues. > > Bug: chromium:757440 > Change-Id: Ie7b75f8d96f9230400beed1a3258e45e0ca742ed > Reviewed-on: https://chromium-review.googlesource.com/980753 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555449} TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I1d1cd812dcf24a9a87ad6100658e4c18979f29bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:757440 Reviewed-on: https://chromium-review.googlesource.com/1040688Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#555504}
-
Dmitry Gozman authored
This reverts commit 5419f892. Reason for revert: fails again. See https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Win_Builder__dbg_%2F130922%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout. Original change's description: > Reland "Move manifest.mojom and content::Manifest to blink" > > This is a reland of c07726e1 > > Original change's description: > > Move manifest.mojom and content::Manifest to blink > > > > ... as a part of Onion Soup project. > > > > This also required moving WebDisplayMode from public/platform > > to public/common since it's referenced both in manifest itself > > and, more generally, browser code. > > > > mojom::blink::Manifest is typemapped to blink::Manifest, which uses > > stl types and should be used by blink's embedder, not blink > > implementation. > > > > Bug: 704441 > > Change-Id: I94d07bb028278f17d215f64c14552793d5f916ae > > Reviewed-on: https://chromium-review.googlesource.com/1006188 > > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Mathieu Perreault <mathp@chromium.org> > > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#554953} > > TBR=dgozman > > Bug: 704441 > No-Presubmit: true > Change-Id: Ie4f16da0aa695e6eecef72574f263cbbb4b3254f > Reviewed-on: https://chromium-review.googlesource.com/1036507 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555485} TBR=dgozman@chromium.org,sky@chromium.org,dcheng@chromium.org,jbroman@chromium.org,mathp@chromium.org,dtrainor@chromium.org,reillyg@chromium.org,haraken@chromium.org,mlamouri@chromium.org,mastiz@chromium.org Change-Id: I2b3d28d1eafb06d480701e6bc69033ea3bcca33a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 704441 Reviewed-on: https://chromium-review.googlesource.com/1040685Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555503}
-