- 31 Mar, 2020 40 commits
-
-
Kenichi Ishibashi authored
This CL adds StoreRegistration() and DeleteRegistration() mojo methods which wrap corresponding ServiceWorkerStorage methods. ServiceWorkerStorage's methods return a deleted version and resource ids that can be purged after storing/deleting a registration. This CL doesn't expose these values as mojo return values. Purging resources should be done only when no browser/embedders use them. The storage service will manage purging resources but the mechanism hasn't been implemented yet. Bug: 1055677 Change-Id: I1bcd8bad4172a3c759e89692f8d7948da33219b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126432 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#754853}
-
Anastasiia Nikolaienko authored
Bug: 1054798 Change-Id: I09f616428f0dd123f51505af4afc552619111a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107630 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#754852}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/17111b3e43c3..d7f02588fc51 git log 17111b3e43c3..d7f02588fc51 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 szuend@chromium.org [formatter] Improve formatting for code containing await expressions Created with: gclient setdep -r src/third_party/devtools-frontend/src@d7f02588fc51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1062617 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If3217a3b758fa7fdce9882b4dcd304767cde38d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754851}
-
Anand K. Mistry authored
Bug: 1065271 Change-Id: Ie746af2f801ae4466f7a02dff0755c8a5200d425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125911Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#754850}
-
Ewann authored
This CL adds a coordinator to the privacy table view controller. Before that the controller was also the coordinator. Bug: 1064961 Change-Id: I781924cc24b4c8aae0e957e1e504e95ece8953b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120423 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#754849}
-
Friedrich Horschig authored
The password dropdown keys credentials by username. For two suggestions with the same username (i.e. a locally and a account-stored one), the first one in the list would match the selection of either entry. This CL fixes that issue by checking from which store the selected entry originated from. Therefore, the credential that is second in list can be previewed and filled as expected. (See linked bug for screenshot.) Bug: 1060552 Change-Id: Icb13d4af705fc0cac5609c0a359ac0dc0bbaf8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119526Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#754848}
-
Finnur Thorarinsson authored
Apparently, as seen in the crash report from the field, the ContentResolver can be in a weird state when asking for an AssetFileDescriptor for an image. The content URI looks a bit weird, so hopefully this is a one-off problem, and not something systemic for the whole image collection. Bug: 1063578, 656015 Change-Id: I00a46e26f634a080b4d10110ef4d545804bad1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127787Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#754847}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/54265a4c5ab7..fddb4d33089e Created with: gclient setdep -r src-internal@fddb4d33089e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic318c4abe9a51c90aacee63dbb887c38c1556a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129401Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754846}
-
Nazerke authored
This CL removes unused NonModalAlertCoordinator, NonModalAlertTouchForwarder and NonModalAlertPresentationUpdater. Change-Id: Icb676ce2e1b8a057f30b55336204ab5654d9b6f6 Bug: 1065878, 1029346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128486 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#754845}
-
Hitoshi Yoshida authored
The current IDL compiler generates two sets of files foo/bar.{cc,h} and bindings/{components}/v8/v8_bar.{cc,h} for foo/bar.idl that defines a dictionary, and makes v8_bar.h include bar.h. On the other hand, our new code generator which is enabled behind a flag will generate only v8_bar.{cc,h} and foo/bar.{cc,h} won't be necessary. This CL replaces inclusions of foo/bar.h to v8/v8_bar.h to make them work with both code generators, and has no behavior changes. Bug: 839389 Change-Id: I477e0e9029597cc6a9522463d08d5442a2625bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120223Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#754844}
-
Mathias Carlen authored
This trybot runs linux browser_tests and unit_tests with the enable_autofill_assistant_api build flag set. Bug: b/152289442 Change-Id: Iee527fe0d0f7813830e2d1d4ec7b27cf08835913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124253 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#754843}
-
Roman Sorokin authored
This is a reland of 04e528b0 Original change's description: > cros oobe: s/LoginManagerTest/OobeBaseTest > > Moved DemoSetup* and EnableDebugging* tests to OobeBaseTest > > Bug: 987587 > Change-Id: I1b0860861720d1cbd77be9e2c007c74a7e2f8801 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124608 > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754456} Bug: 987587 Fixed: 1066120 Change-Id: I91439edc93288427822c1d453d1ef66be6eb472f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127806 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#754842}
-
dpapad authored
Also removing calls to CallJavascriptFunctionUnsafe() in the process, replacing with FireWebUIListener(). This is in preparation of migrating to Polymer 3. Bug: 1012533 Change-Id: I01bd5afcac01db2a9827846b165be7d36d16b376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128972 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754841}
-
Andres Calderon Jaramillo authored
Problem: CL:2010243 made it so that the GL image for a video frame is created using the visible size. This is correct because we want to make sure that when we composite, we don't sample padding (which would result in unwelcome green lines). However, the coded size of the video frame sent to the client still contained the non-visible area. This caused PaintCanvasVideoRenderer to sometimes issue GL commands with dimensions exceeding those of the GL image backing the texture. These commands would subsequently fail validation resulting in the associated video frame not being rendered on the canvas. Solution: This CL is a generalization of CL:2056285 which solved the same problem but for the VA-API video decode accelerator. The essence of the solution here is to override ProvidePictureBuffersWithVisibleRect() in VdaVideoDecoder. That way, we end up creating the outgoing video frame with a coded size equal to the visible size solving the problem above. Note that there's one caveat: there is an unusual corner case where an H.264 video includes information about a visible rectangle whose origin is not at (0, 0). Therefore some of the top and left parts of the video should not be displayed. However, Chrome does not currently deal well with this case. This CL does not make that situation better, but this could be addressed in a follow-up CL considering that it's a rare case. I tested across many boards. To see the test cases and screenshots of the results, see [1] (a d08cb982 in the filename represents the base commit before this CL). [1] https://drive.google.com/open?id=1h94xbzNLBrlHBlbmaaasHV1P7HOaPBt1 Bug: 1062002 Test: video in bug gets rendered to canvas in kevin successfully. Change-Id: I6daf9df07c8588d82d5396908d8f91c92ce3984d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122484 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#754840}
-
Dominic Mazzoni authored
Completely mechanical/automated. Doing it in small chunks and landing with TBR to minimize collisions. Bug: 1063155 Change-Id: If4a545312b17b2b2adfc385cc26ddd246a7ccf30 Tbr: aleventhal@chromium.org Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125389 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#754839}
-
Takashi Toyoshima authored
Since the situation is still unclear, let's flip the default mode to keep policies activated. Since the Chrome 82 was cancelled, mitigation removal may happen at Chrome 83 via Finch in the best case, but the plan may be postponed through this flag until Chrome 84. Bug: 1053866 Change-Id: Id4020ff8074622bb6965a3dc61a57d97bbf69ebc TBR: emaxx@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128035Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e7c94f4973bc..e157435c1e77 git log e7c94f4973bc..e157435c1e77 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 cepheus@frii.com Bump revision. Created with: gclient setdep -r src/third_party/glslang/src@e157435c1e77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I26d148ec7e3aacd60f297ccd91e2ced964731d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129393Reviewed-by:
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I58214e0073f255662c6efca3f3f1e47f1c8b94ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124711Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#754836}
-
Hirokazu Honda authored
The client of ImageProcessor feeds ImageProcessor VideoFrame in import mode. The underlying buffer of the fed VideoFrame can have a different stride and size from the expectation of ImageProcessor. The difference is critical in V4L2ImageProcessor. It is necessary to reconfigure the v4l2 image processor driver by VIDIOC_S_FMT with the stride and height of the fed VideoFrame. Bug: 1033799 Test: ip_test --gtest_filter=NV12* on kukui Change-Id: I73050718f6a95a1eaa3d9c7a60eeea1bc791f04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097857 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
This reverts commit aed7a18a. Reason for revert: Disabling for M-83, feature moved to M-84. Original change's description: > Reland "Files app: Enable flag files-ng by default" > > This reverts commit 7545fd48. > > Reason for revert: We want to enable the flag by default on ToT, the revert was intended to disable the flag on M-82, on ToT it should be > enabled. > > Original change's description: > > Revert "Files app: Enable flag files-ng by default" > > > > This reverts commit ea497580. > > > > Reason for revert: Feature moved from M-82 to M-83. > > > > Original change's description: > > > Files app: Enable flag files-ng by default > > > > > > Add files-ng classes and attribute to main.html so files-ng styles are > > > applied during app startup (to avoid a FOUC flash of non-files-ng blue > > > color). > > > > > > Enable file-ng by default in FilesApp and its browser test harness. > > > > > > Bug: 992818 > > > Change-Id: If437271c5604d36b4b0908abb663a84e52b6ae35 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087308 > > > Reviewed-by: Alex Danilo <adanilo@chromium.org> > > > Commit-Queue: Alex Danilo <adanilo@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#747421} > > > > TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org > > > > Bug: 992818 > > Change-Id: I8b1c770e2c43823eff9a2a9aceae650fcb25a3f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103992 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Reviewed-by: Noel Gordon <noel@chromium.org> > > Reviewed-by: Alex Danilo <adanilo@chromium.org> > > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#750448} > > TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 992818 > Change-Id: I94e63a873d4e2970d201a32dca0944a4e8fa520f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116152 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752674} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 992818 Change-Id: I3e6a3a82ded4953ea6c9757c0b94b500cd21563f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128045Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
David Jean authored
Indenting was added by git cl format Bug: 1065322 Change-Id: Id1d13cf3d81eb3391892917ca497da15bd09f538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124712 Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#754833}
-
Hans Wennborg authored
Ran `./tools/clang/scripts/upload_revision.py 4e0d9925d6a3561449bdd8def27fd3f3f1b3fb9f`. Bug: 1065826 Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iab8aaf31aa0c281213e425039f13bab9a9ed06d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125464 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#754832}
-
Wei-Yin Chen (陳威尹) authored
This should be no-op in prod code. Bug: None Change-Id: I8bd24b4c6d20f9ae461d3e4b4c8e860fd71dee2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117531Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754831}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/25a88e75eaed..63a4edd314aa git log 25a88e75eaed..63a4edd314aa --date=short --first-parent --format='%ad %ae %s' 2020-03-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1b2dd6f92a6b..05fa1a99914a (10 commits) 2020-03-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1c29477aa06e..5cf1e9a31c90 (6 commits) Created with: gclient setdep -r src/third_party/skia@63a4edd314aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: Ibcb2fbd01d5bf750fc8d43a7e952e23e96701cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129387Reviewed-by:
-
Fergus Dall authored
Currently we consider this an error condition, but since we are now able to distinguish this from other failure sources we can retry instead. This CL arbitrarily sets the retry frequency to 5 seconds, which is hopefully fast enough to not be annoying. Bug: 1065817 Change-Id: I532efeb2f4f7ef1aea4be248e1396061edb65d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126967 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#754829}
-
Dominic Mazzoni authored
Eventually all COM interfaces should be on AXPlatformNodeWin and we won't need BrowserAccessibilityComWin at all. This change also provides an implementation of setCurrentValue, which was previously unimplemented, including tests. Bug: none Relnotes: N/A Change-Id: I045625ce7abe695c21e93f244f6c92515f612c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119203 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#754828}
-
Hirokazu Honda authored
Bug: 1033799 Test: ip_test on kukui Test: appr.tc on kukui Change-Id: I475f526f8d39535cfe0be696e657b27b82cc135b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102303 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1dcb54c744c7..54265a4c5ab7 Created with: gclient setdep -r src-internal@54265a4c5ab7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1032601,chromium:1043347,chromium:1053811,chromium:1065917 Tbr: jbudorick@google.com Change-Id: I8a39a6b6edb33993b731d18b7dcda20c158caab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128883Reviewed-by:
-
Hirokazu Honda authored
The output buffer of ImageProcessor is created by minigbm. The minigbm's buffer alignment can be different from the encoder's one. It is necessary to execute S_FMT with the buffer allocated by minigbm. Bug: 1033799 Test: appr.tc on kukui Test: vea_test on kukui Change-Id: I45659393c84a1bb629afa895349d9c438251810f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104572 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
This CL is a mechanical cleanup for instrumented tests under org/chromium/chrome/features/start_surface, suggested by Android Studio. Bug: None Change-Id: I3b6f24e4e2b510d3e6d7ba8d6e648c9480cfc418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123643 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#754824}
-
Robert Ogden authored
These browsertests have dependancies which are flaky on Windows and some other platforms, and should have been disabled there like the rest of the tests are. Bug: 1023485 Change-Id: I9e2bcd4bf215cc3a07e242e6f038ed33778d50cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129089 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#754823}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/08c02ced798a..e7c94f4973bc git log 08c02ced798a..e7c94f4973bc --date=short --first-parent --format='%ad %ae %s' 2020-03-31 johnkslang@users.noreply.github.com Merge pull request #2166 from alelenv/rq_lvalue_fix Created with: gclient setdep -r src/third_party/glslang/src@e7c94f4973bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I372a74ab218a39973eb88bb262fe8739721b19b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128882Reviewed-by:
-
Jan Krcal authored
This CL expands the previous CL 2102656 with one more recording suffix. This new suffix will simplify direct comparison between active-multi-profile and latent-multi-profile. Bug: 1060113 Change-Id: Ic9981feef6c3c577302d579df7d083002c00cf56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120421 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#754821}
-
Alex Danilo authored
Hides the <paper-ripple> elements for files-ng. Adds a flat color for menu items that are being activated (e.g. pressed) to provide user feedback when activating a menu item. Bug: 992825, 1002396 Change-Id: I628cf5668ad03e2f959df9ed5d5e821cd6e0624b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128000Reviewed-by:
-
François Degros authored
BUG=chromium:1058685 Change-Id: I049d3560fe2cdb7cd82a1853964489e2f19199db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127446Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#754819}
-
Robert Ogden authored
Limiting the probe to a number of milliseconds is causing this to flake about 5% of the time, and does nothing to help with test timeouts. Removing the test-specific limit. With this change, the test was not flaky at all after 100 interations with --gtest_repeat TBR=tbansal@chromium.org TBR since it's outside normal working hours and I've already been contacted by the flake sherrif once tonight... Bug: 1023485 Change-Id: I20377999a1e3d5076cc861118ee84a514916d4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129239Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#754818}
-
Johann authored
Flakiness on https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux Sample output: [ RUN ] LoadingPredictorBrowserTestWithOptimizationGuide.OptimizationGuidePredictionsNotAppliedForAlreadyCommittedNavigation/1 [22182:22182:0330/211059.950234:15709478620:ERROR:edid_parser.cc(102)] Too short EDID data: manufacturer id [22182:22182:0330/211100.151354:INFO:content_main_runner_impl.cc(974)] Chrome is running in full browser mode. [22182:22462:0330/211100.642123:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [22182:22462:0330/211100.642156:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed. [22182:22462:0330/211100.642407:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [22182:22462:0330/211100.642629:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [22384:22480:0330/211100.706731:WARNING:simple_synchronous_entry.cc(1389)] Could not open platform files for entry. [22182:22182:0330/211100.741071:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -11 ../../base/test/metrics/histogram_tester.cc:201: Failure Expected equality of these values: expected_count Which is: 1 actual_count Which is: 0 Histogram LoadingPredictor.OptimizationHintsReceiveStatus does not have the right number of samples (1) in the expected bucket (2). It has (0). BUG=chromium:1060966 TBR=tbansal@chromium.org Change-Id: Ia2ab0b7bc030b6ee68c440e2bfb540ddb8dce95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128040Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#754817}
-
Jinsuk Kim authored
ChromeActionModeCallback is a WebContents object that handles events for action mode. This CL introduces a new class ChromeActionModeHandler that manages the callbacks in response to the lifecycle of the active Tab's WebContents. It is owned by RootUiCoordinator which hooks up the handler with ToolbarManager. It replaces TabObserver.notify..Changed with the observer list managed by the handler. Bug: 995903 Change-Id: Ib9f3ec4c16f71141d339ff8a807ae2167e6e8d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912100 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
No support for block fragmentation yet. There are no new tests, since the new code will be covered by most (all?) tests in the layout_ng_fragment_traversal virtual testsuite. Because of the way a FragmentData object is shared between all (inline) fragments within a block fragment, we now store the "is first for node" bit on all fragments, not only block fragments. This way we know when to reset FragmentData objects during pre-paint (which should only happen for the first fragment, and for subsequent fragments within the same block fragment, we just expand the visual rectangle). Since we now visit each fragment, rather than treating the LayoutObject as a whole (and therefore build up the visual rectangle fragment by fragment as we visit them), there's no way to detect whether the visual rectangle of the FragmentData changed since previous layout. This is obviously unfortunate. We also need some special code when dealing with an out-of-flow positioned box whose containing block is a non-atomic inline, since this relationship isn't reflected in the fragment tree structure. Out-of-flow positioned boxes also need special treatment if we have only performed NG fragment tree traversal in parts of a subtree (and done LayoutObject traversal in other parts). Apart from that, the changes in pre-paint are rather straight-forward. We use NGFragmentChildIterator to walk the fragment tree, rather than walking the LayoutObject tree. There's some refactoring and cleanup possible, but probably not much until we've completely got rid of legacy layout altogether. FragmentPaintPropertyTreeBuilder won't be needed then. Bug: 1043787 Change-Id: I7e1a4ef107acbfc910fdb0a43b5bd0b3b556e62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111158 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#754815}
-
Maggie Cai authored
This CL removes the original preferred apps files that is no longer neede. BUG=853604 Change-Id: I59598a574d2be298eb60a8a9b14500e3c6aae3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125916 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754814}
-
