- 11 Dec, 2020 40 commits
-
-
Alice Wang authored
This CL moves PersonalizedSigninPromoView to signin.ui target. Bug: 1156619 Change-Id: Ic0c0a1e23c05b88bb36f4daee3eba469c7fcb63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584505 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#836067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd549ceda1d4..d2300e5aba7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sreejakshetty@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: sreejakshetty@google.com Change-Id: I7b9c5f7496be447a7b9e9c23b10380bf11d822c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586054Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836066}
-
David Dorwin authored
Although fuchsia.logger.LogSink is provided when using run-test-component, it still needs to be in the sandbox. Also make indentation consistent. Bug: 1132147 Test: The following no longer appears in the system log when running run_cast_runner_integration_tests with and without --use-run-test-component: `app#sys#fuchsia-pkg://fuchsia.com/cast_runner_integration_tests#meta/cast_runner_integration_tests.cmx` is not allowed to connect to `fuchsia.logger.LogSink` because this service is not present in the component's sandbox. Change-Id: I67d4205156f1a0bc7eb847159ea417ec776a7832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586098 Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#836065}
-
Leo Lai authored
we are obsoleting the unnecessary `TpmIsBeingOwned()`. BUG=b:172775884 BUG=b:172748724 TEST=build ok. Change-Id: Ie1dc4044060caadb24a9470dbb98d51bcfc383e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532157 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#836064}
-
Benoit Lize authored
The provided task runner was always bound to the same thread on which the manager is created. Make this explicit rather than implicit. Bug: 1131857 Change-Id: I1e24d20edf9cd77c2ce904d13e2e66ef559cc183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527045 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836063}
-
Victor Hugo Vianna Silva authored
1) Before this CL, some ModelTypeControllers called IsWebSignout() in their GetPreconditionState() implementation to make sure the data type was stopped upon web sign-out. This is no longer needed following the StopSyncInPausedState launch (crbug.com/906995), so this CL removes such checks. If GetPreconditionState() makes no other checks, the controller also no longer needs to observe the SyncService. Note this isn't true for controllers that check for persistent auth errors, since that concept is more general than web sign-out. For those, only TODOs/includes are removed. 2) The CL also addresses one IsWebSignout() TODO in PersonalDataManager. Contrary to what the TODO implies, just removing the call isn't enough. IsSyncFeatureEnabled() returns true in the sync-paused state, so the check for TransportState::PAUSED must be moved up. 3) Finally, the CL updates the last TODO pointing to crbug.com/906995 to point to a newly filed bug. This concludes the post-launch cleanup for StopSyncInPausedState. Bug: 1140447 Change-Id: I996a8871050f8f18e1509a5560ca0ccfc849f217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505772Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#836062}
-
sandromaggi authored
Before this change, an empty value was causing a failure state only if no other values existed. The empty value was skipped for filling and later on (maybe) failed in the empty-check. If the field was filled by outside forces (e.g. cached by website) the skipped value would not cause a failure state. This behaviour was causing inconsistent results. After this change, an empty value will always cause a failure state immediately and not attempt the filling. Bug: b/175270472 Change-Id: I939e2069e237d960ebf3a826a799e5ab23ecc4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582323Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#836061}
-
Joel Hockey authored
Adds window properties for * kEscHoldToExitFullscreen - if true holding esc for 2s will exit fullscreen. * kEscHoldExitFullscreenToMinimized - if true window is minimized when it exits from fullscreen rather than being restored to normal. AppServiceAppWindowLauncherController sets these properties on: * Borealis to use esc, and minimize on exit * PluginVM to use esc, and restore on exit Bug: 1144780 Change-Id: Ibcbbb811f99b5650df6b16e0de85b2b5129a4a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581626Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#836060}
-
David Grogan authored
Updated TestExpectations in place and organized the flex section a bit. 7 tests weren't moved because I already ported those to check-layout versions in css/css-flexbox and they hadn't been deleted from vendor-imports yet. Removed two tests from css3/flexbox/mozilla because they were in the move. One test is still in that directory because it wasn't in vendor-imports. Change-Id: I15e815ea15e30eee4568c65aa92dd364c17a5e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585929 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#836059}
-
Michael Ershov authored
Some initialization steps may block (and trigger a crashing check). Move it to a worker thread to unload the UI thread and fix the crashing. Waiting for the initialization to finish will be implemented in the next CL. Bug: 1145946 Change-Id: I03ca8aee5e0ab3870670506828b821a7a69bddff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574938Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#836058}
-
Carlos IL authored
Enable AutofillPreventMixedFormsFilling and InsecureFormSubmissionInterstitial in preparation for 100% launch. Bug: 1105210 Change-Id: Id6d4325ee8d0fb27f109b45d3654c56e5d653688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583141 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#836057}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fea01bf21b37..721ef456ee27 2020-12-11 sigurds@chromium.org Refactor ApplicationPanelTreeElement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1157484 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie332f48ad59eace2343ac01578e7960fc939a532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586752Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836056}
-
Aya ElAttar authored
- Removed DlpRulesManager::IsRestrictedAnyOfComponents given that it's no longer needed after replacing kGuestOs with {kCrostini, kPluginVm}. Change-Id: I9730cc7eb1f20d16a6ac8e1e47c16afe62598fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577780 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#836055}
-
Leo Lai authored
we are migrating tpm status calls to TpmManagerClient. BUG=b:172748724 TEST=build ok. Change-Id: I3cee2889e8bb17ac1b39f9dc973d1bf94cbf1558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580974 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#836054}
-
Alice Wang authored
This CL moves SigninView to signin.ui target. Bug: 1157052 Change-Id: I2211e6f6592dccbe4d73edeb8b6e18f173a92c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582324 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#836053}
-
arthursonzogni authored
[Bug] showed there was a mismatch in between Chrome and Firefox about the referrer sent during a navigation, when initiated from a document with an opaque origin. Chrome: No referrer sent for both subresources and main resources. Firefox: No referrer sent for subresources, but a referrer is sent for main resources. This patch is meant to help making web browser to eventually converge. We believe the correct behavior is not to send the referrer: - 3.1.2 of [determine-requests-referrer] - 6.9 of [http-network-or-cache-fetch] [Bug]: https://crbug.com/1109065 [determine-requests-referrer]: https://w3c.github.io/webappsec-referrer-policy/#determine-requests-referrer, [http-network-or-cache-fetch]: https://fetch.spec.whatwg.org/#http-network-or-cache-fetch). Fixed: 1109065 Bug: 1109065 Change-Id: I15c80d52d963fc8e8a1318e4bf89fe72234c5fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584029 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#836052}
-
Eugene But authored
Bug: 688063 Change-Id: I4cef9ed86a096fe6035ef5a11b4eb02b29c047bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585679 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#836051}
-
Colin Blundell authored
This CL moves the implementation of ChromeSubresourceFilterClient::OnAdsViolationTriggered() to ProfileInteractionManager, with the former now just calling through to the latter. In subsequent work we will eliminate the callthrough to the client altogether, thus having this logic be shared with WebLayer. In this CL, however, there is no behavioral change. Bug: 1116095 Change-Id: Ic315394b20e107d3eb0180bbf157a2a8cdb23118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578838 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#836050}
-
arthursonzogni authored
If the first navigation is same-origin and the previous document was the initial empty document, the 'window' object is sometimes reused for the new document. It means the initial empty document and the new documents will both reuse the same LocalDomWindow. Weirdly, sandbox_flags are stored on the LocalDomWindow, instead of the Document. I don't know why. As a result, Chrome apply sandbox twice. It gets the union of sandbox flags defined for the initial empty document and for the new document. Firefox doesn't, see [WPT test]. The patch makes Chrome to converge toward Firefox. Chrome also stop reaching a DCHECK about sandbox flags computed from the browser and the renderer not matching. [WPT test]: https://wpt.fyi/results/html/browsers/sandboxing/sandbox-initial-empty-document-toward-same-origin.html?sha=009fb03561&label=master&max-count=1 Fixed:1156632 Bug:1156632,1041376 Change-Id: Ic8eaa5409ce3affdfee3e75bb12c4dad3cf84ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578902 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#836049}
-
Josiah K authored
Screenshot: https://screenshot.googleplex.com/8NAe4DWRAsTKipU Design: go/switch-access-setup-ux-select-switch AX-Relnotes: In Switch Access, disallow removal of select switch if it's the only one remaining, to prevent users from getting into a bad state. Fixed: 1157268 Change-Id: I69358685f8cf389675875a1558c71591a6e6e921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583150 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836048}
-
Philipp Hancke authored
and reactivate test BUG=webrtc:12194 Change-Id: Ie71da8834182ea458654d7b802dcdccd39fcd482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580532 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#836047}
-
Benoit Lize authored
Freelists must be null-terminated. This is currently not enforced in the code. This commit removes all "reinterpret_cast<>"s for the freelist, and enforces null termination. Bug: 998048 Change-Id: I0593a337ef36693e4ffe08ce8ec04ba679e24183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584764Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#836046}
-
Rakina Zata Amni authored
There are currently some known cases where url_is_unreachable sent by the renderer is different than the one currently calculated in the browser with CalculateURLIsUnreachable(), such as when a data: URL navigation happens in a subframe, or when the browser tries to commit an error page with an empty GURL. This CL makes sure the browser and renderer-calculated values match and adds a DCHECK to ensure this holds for all tests. Bug: 1155414, 1154753 Change-Id: I46750ccfdd3619c0665f71fbfebe1ecb9651d234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574040 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836045}
-
Sreeja Kamishetty authored
This reverts commit 9b07e5e0. Reason for revert: Failing following pdf_unittests on Linux MSan Test builder AccessibilityTest.TestSelectionActionHandling More details: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26576/overview Original change's description: > [a11y] Add scrolling action to PP_PDF_SET_SELECTION > > This CL adds scrolling when PDFiumEngine::HandleAccessibilityAction > is called with PP_PDF_SET_SELECTION and the selection is not > visible since Blink triggers also scrolling with setting selection. > So, this change makes PDF document scroll the page when a selection > is set. > > AX-Relnotes: When SetSelection action is handled on pdf, it also > triggers scrolling if the selection is not in the visible area. > For instance, atk_text_set_caret_offset() on pdf scrolls the page > if the text is not in the view port. > > Bug: 993456 > Change-Id: I8323eff293b3216e2b862f8df3e896380b1c9945 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573975 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: K. Moon <kmoon@chromium.org> > Reviewed-by: Martin Robinson <mrobinson@igalia.com> > Commit-Queue: Julie Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#835994} TBR=dmazzoni@chromium.org,mrobinson@igalia.com,jkim@igalia.com,kmoon@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I524b4c3d27265923e8ef4b2508582f08e38b3582 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586413Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836044}
-
Aya ElAttar authored
- Removed EndpointType::kGuestOs which was used to refer to both; Crostini and PluginVm. - Added more granular endpoint types; kCrostini, and kPluginVm, kBorealis, and kUnknownVm. Bug: 1103217 Change-Id: I23020d8937a47bc649b5bae45ebacc80214165a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577209 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#836043}
-
Saurabh Nijhara authored
This CL adds error code for update download canceled due to DeviceAutoUpdateTimeRestrictions policy to the enum so that it can be reflected in the histogram. This error code is already added in update engine code in the following CL - https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2567121 Bug: chromium:1117450 Change-Id: I69d109553c28a4948d725183293640d8eb044731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584984Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#836042}
-
dpapad authored
- Remove unused Polymer3 migration stuff (auto_imports, namespacee_rewrites) from settings.gni. - Move stuff that appeared in settings.gni but only used in OS Settings to os_settings.gni. - Make Polymer.dom() and Polymer.dom.flush() rewrites more robust (previously depending on the order these rewrites were processed incorrect code "dom.flush()" could be produced) Bug: 1045266 Change-Id: I8ff5a94241be2b346ac4680186d6c1a49b687005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582645Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836041}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607644656-0b01fdecc754de80a3c2ac369c5f084aa20b4340.profdata to chrome-linux-master-1607666365-bbaa45b634e1691b87709d169151bc6605a0f202.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I578d6271dbc1394a0fbe5c5cabd092269a7da824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836040}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607644656-0a2d12ddbaae1d8a16ffb54f7cbbe55ff04a272a.profdata to chrome-mac-master-1607666365-8c1e3ea09225831030a16a3eef7156247263dd6d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I66ee80c5296d76607ed9bf3ef88555a5304ccce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586523Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836039}
-
Sreeja Kamishetty authored
This reverts commit 583f52a3. Reason for revert: Following browser_tests failing on Linux MSAN bot All/SearchPrefetchServiceEnabledBrowserTest.OmniboxNavigateToMatchingEntryStreaming/1 All/SearchPrefetchServiceEnabledBrowserTest.OmniboxNavigateToNonMatchingEntryStreamingCancels/1 More details: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/26573/overview Original change's description: > Search Prefetch Streaming requests can be cancelled after headers > > The goal of this CL is to allow unneeded requests to be cancelled > when they are unlikely to be navigated to. This is achieved through > a few avenues of change: > > -- When the user navigates to something in omnibox, the URL is reported > to Search Prefetch Service to be able to mark it as likely to be served > (using kCanBeServedAndUserClicked when the request is kCanBeServed). > This occurs before the omnibox is closed and all results are wiped. > -- kCanBeServed are wiped when omnibox closes. > -- Streaming requests will no longer pause the mojo channel, so they can > witness the Complete event to be able to make the request as complete. > -- As part of above, we store the response body in memory instead of > just handing off the data pipe. Data pipes have a 500k data limit, which > search requests typically go over. Net won't send the complete event > until all data is in the pipe. Therefore we store the data and create a > pipe to navigation if needed. > -- Full body implementation now reports kComplete where it used to > report kCanBeServed. > > Bug: 1156325 > Change-Id: Ied70a3eafd896801e263f631cb4d80556e762180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583112 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835897} TBR=tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I130213d5d9d72641b12be31192f51461957cd15b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584426Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836038}
-
David Van Cleve authored
Downside of writing comments in strings: Tricium doesn't catch typos! TBR=csharrison@chromium.org Change-Id: I06aa20fb9369f0e6d5ef43e9a3cae3a5b8d27934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586316Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836037}
-
Satoshi Niwa authored
Design doc : go/arc-project-quota BUG=b:171847983 TEST=Check if valid value is returned Change-Id: I808fa4d5da78858a7f7d7266c7caf08fee21e579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546503Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#836036}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4d774788..59248a61 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1436d7dcb42e75cef95cf5e3b72240600a931119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586015Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836035}
-
Marc Treib authored
- Remove getNumberOfSyncedDevices which was unused. - Merge init() into the constructor. - Add a few comments/TODOs where the Java PSS still diverges from the native version. - Add warning comments to some potentially dangerous methods (notably getChosenDataTypes and getPreferredDataTypes). - Mark getPreferredDataTypes as deprecated. Its only usage was an error (see crbug.com/1157046). Bug: 1135552 Change-Id: I8d0d1e8165086ef6af498a2010a887ba25ae7efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582083Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#836034}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/19bfdf4583d4..fea01bf21b37 2020-12-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic1e54ef858ca01fd3b9db23dfd263898f36a5779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836033}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607612331-9abd6632cfb32a4e513da1b46025c0e77c15ae02.profdata to chrome-win64-master-1607644656-7adc1a9108854fa8e662531b0c0fa8127d30765c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2ec17bcc877d146aa1f601679a9e6c4c65857718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836032}
-
Alice Wang authored
This CL moves ConfirmSyncDataStateMachineDelegate to signin.ui target. Bug: 1155132 Change-Id: Icea2dc2f77573d55e6cccfe8e7a73e425871995a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582325Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#836031}
-
Ramin Halavati authored
Extensions will be disabled in the first experiments of ephemeral Guest profiles. WebStore private APIs are updated to treat ephemeral Guest profiles similar to the off the record ones. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: If4b4711d133f8e429b2ced09fdf6747cb0c31491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580805Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#836030}
-
Noel Gordon authored
Add PopulateLoadTimeData helper to setup files app load time data. Add CreateTrustedAppDataSource to add trusted resources and load time data and initialise security policy for the metadata Shared Worker. Bug: 1113981 Change-Id: Ic507af120de1a8c8ff19429bcfe864291a0f2a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586637 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#836029}
-
Hirokazu Honda authored
No existing ChromeOS arm device supports non 8 bit stream decoding. VaapiVideoDecodeAccelerator implementation doesn't support non 8 bit stream decoding. We have relied on underlying implementations (e.g. drivers and firmware) to filter non 8 bit streams. AcceleratedVideoDecoder has a getter function for the bit depth of an input stream. This CL filters out non 8 bit streams in chrome by calling the getter function. Bug: b:174798524 Test: video_decode_accelerator_tests test-25fps.vp9_2 on scarlet and atlas Change-Id: I9071649740cd0ddab889887f09cabf598d38ec09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576298 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836028}
-