- 04 Aug, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596520791-9a2885d858aeb98ad5bcc11e2200637e7a775fe0.profdata to chrome-win64-master-1596542250-4b9669504bdebb7cf76d0d2b9c7cc833bb153daa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I691948ebb390448504aa7f37a6032d6b44a9aec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794612}
-
Richard Knoll authored
Handle click and dismiss actions of onboarding notifications and keep track of the last dismiss timestamp to prevent spamming the user with these notifications. Bug: 1102348 Change-Id: I5aa79deea29f9e3068bcd1890b50d6c85c654ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332634Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794611}
-
Brian Ho authored
When the hardware doesn't support CTM [1], Chrome OS needs to fallback to applying the "night light" color shift with the compositor [2] by setting the OutputSurface's display color matrix. GLRenderer uploads this matrix to the fs to apply the tint [3]. SkiaRenderer currently does not respect OutputSurface's color matrix, so this CL adds color matrix support via a SkColorFilter similar to how we tint non-overlay content for debugging. [1] https://01.org/linuxgraphics/gfx-docs/drm/drm-kms-properties.html [2] https://source.chromium.org/chromium/chromium/src/+/master:ash/system/night_light/night_light_controller_impl.cc;l=219;drc=a6765a0769369b0d469e3df88e046e18104f7547?originalUrl=https:%2F%2Fcs.chromium.org%2F [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/gl_renderer.cc;drc=42c6a1c82a29862f869d1a3a5ca1b3be4e55291f;l=3375?originalUrl=https:%2F%2Fcs.chromium.org%2Fchromium%2Fsrc%2Fcomponents%2Fviz%2Fservice%2Fdisplay%2Fgl_renderer.cc Bug: 1098435 Change-Id: Ia4772f245c80a73bfc431981f8ab8dc341232eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327810Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#794610}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Iec348432a6388c6a0c41e50cd180703cbe7adc83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335493Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#794609}
-
Caroline Rising authored
Approval given in crbug/962604. Bug: 910739 Change-Id: I26db0a3f807228cbb6d708889129ceb403233734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334812Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#794608}
-
Mario Bianucci authored
Today, custom SVG cursors are blurry on high DPI displays because they rasterized and then scaled up as required for the display resolution. This results in the cursor being blurry. This CL fixes that by scaling the size of the cursor up before rasterizing and placing it into a cursor to be used in the browser process. Bug: 325565 Change-Id: I61e37f4ae4355a534d71022974a30d62fccc53cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321534Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#794607}
-
Toni Barzic authored
Remove the traced process ID from PerfettoService's list of active service PIDs if the process goes away while ConnectToTracingService is in progress. The PID is added to active services list before calling ConnectToTracingService, and if it doesn't get removed, BeginTracing requests will keep waiting for acks from a process that's gone. BUG=1110514 TEST=tast run ui.LauncherAnimationPerf* Change-Id: I1c491536e8740e0e8618dbf3109046440c418749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333873 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#794606}
-
Sean McAllister authored
This migrates is_linux (which is also set for chromeos) to explicitly include chromeos as is_linux || is_chromeos in preparation for separating those flags. Bug: 1110266 Change-Id: I019e775b7ecd01c6a1c401c13d9a29abd35ad170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326290Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#794605}
-
Thomas Tellier authored
Bug: 1101326 Change-Id: Ibcb9e16bf903d518a69a2631b289881f0303f6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333191Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#794604}
-
Egor Pasko authored
Still looking at the data on Dev/Canary. Bug: 1045052 Change-Id: Ibf8f3f54bc944883e4f9450ac85535fff5c7d87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335287 Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#794603}
-
Thomas Tellier authored
5-second instead of 3-second timer for password/PIN going back to masked format. 5-second timer will reset upon character being entered to keep the password/PIN visible during revision. Bug: 1101326 Change-Id: I962139aef26bd9fb68e5110d5169d0f486a5bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314176Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#794602}
-
Hiroshige Hayashizaki authored
In order to use ClassicScript in worklet unit tests, this CL changes Script::RunOnWorker() to Script::RunOnWorkerOrWorklet(). This CL removes a DCHECK() in WorkerOrWorkletScriptController to allow kSanitize in non-importScripts() cases. This is to allow ClassicScript::UnspecifiedScript()'s default kSanitize value to be used in worklet unit tests in https://chromium-review.googlesource.com/c/chromium/src/+/2331758 kSanitize doesn't occur here in non-test environment, but allowing kSanitize here and using ClassicScript::UnspecifiedScript()'s default kSanitize value in worklet unit tests makes it easier to track ClassicScript::UnspecifiedScript() with kDoNotSanitize cases as exceptional. Bug: 1111134 Change-Id: Id4c35427391b263b5bdc9568be95266bb8715a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332096 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794601}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a1a497ffe792..2de6d657dde3 2020-08-04 john@johnkgo.com SPV: Standalone; sanity check the client GLSL input semantics option value. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I7d1b7edcabf30579bf30ed88c27367eefba743ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794600}
-
Friedrich Horschig authored
Although every password settings fragment should be launched using PasswordManagerHelper#showPasswordSettings() which requires a referrer, some clients crashed because the bundle seems to be missing regardless. A possible reason is that the fragment wasn't started but just recreated without a bundle. To cover these cases, store the referrer in the savedInstanceState and reuse it on creation. Bug: 1112628 Change-Id: I93805c2d93bae35c5dd0b6647626db87cc7db275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335444Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#794599}
-
David Roger authored
This CL re-organizes the file to avoid duplicated sources and deps sections Change-Id: I6fa29387b6da8c3c2f37412558b2922c2fac5a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335438 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#794598}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a79b9fd7235f..c6116bf6ce82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aaronhk@google.com,sinhak@google.com Change-Id: I04ec65c1b3fafa8f5d0afb166785823897531975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336770Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794597}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596527967-453034edae7748ca30b46c873b3303e5191c764d.profdata to chrome-win32-master-1596542250-9615b306cb5f76d5a757426ea1c30fa3bd674a0e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I611493cff888a73bb559656975643bced09a3cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794596}
-
Boris Sazonov authored
Reason: flaky. Failed builds: https://ci.chromium.org/p/chromium/builders/ci/Nougat%20Phone%20Tester/14902 https://ci.chromium.org/p/chromium/builders/ci/android-10-arm64-rel/7768 TBR=bialpio@chromium.org Bug: 1112773 Change-Id: I51c3a9c3aa5141ae7442e1da79bc590e2d968fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336602Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#794595}
-
Kevin Babbitt authored
Check for cases where a system color keyword is used on an element whose color-scheme differs from its parent. Refactored color-scheme methods on ComputedStyle slightly so that we can observe the computed value for color-scheme without needing to enable the CSSColorSchemeUARendering flag. Verified using http://wpt.live/css/css-color/system-color-compute.html that the UseCounter is recording on live sites. Bug: 1081945 Change-Id: Ifde1fcddd8bb230a9e2a52cfb4a32818d44b567a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330438 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#794594}
-
mark a. foltz authored
Replace with more inclusive terms per Chromium Style Guide. Bug: 1106011 Change-Id: I6b88cb9bfa1e1b7fa004c6e40b2ea6712cd29083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335486Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794593}
-
Piotr Bialecki authored
Bug: 1112333 Change-Id: I6be773adf04a41639865521a2eec02b66bd4989d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335895Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#794592}
-
mark a. foltz authored
Replace with more inclusive terms per Chromium style guide. Bug: 1106011 Change-Id: I42537596567d42959e737aeffba16bce34f0cda7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335387Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794591}
-
Saurabh Nijhara authored
As per product requirement, restrictions such as force sign out, notifications and EOL (End of Life or Auto Update Expiration) Settings banner are not applicable to unmanaged users by default. However, the admin can enable these for unmanaged users by setting the unmanaged_user_restricted flag in the policy MinimumDeviceVersion. This CL is to show the banner on Chrome OS Settings page and management page (chrome://management) for users only if 1) Update is required as per policy 2) Device has reached EOL 3) User is managed or unmanaged_user_restricted is true in policy. This policy is only applicable to ChromeOS. Bug: 1112371 Change-Id: I8e099529b898f1c63ecf7675457f7e1dcf9e80c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335433 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794590}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/965b1ffc561e..504a6f1944fe 2020-08-04 jobay@google.com Let `$` return null when no element is found 2020-08-04 jacktfranklin@chromium.org Bridges: fix complex type finding across imports 2020-08-04 jobay@google.com Use custom query handlers to implement $ and $$ in test/shared/helper.ts 2020-08-04 patrick.brosset@microsoft.com Grid: Handle separate row/col color and dash and highlight on grid-template hover If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5bd9a51c25a1a9e2de84a10b3e953374bb028bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794589}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb3f2812. With Chromium commits locally applied on WPT: dfdc7fe9 "[WPT] Errors caught/reported for importScripts()" a1917485 "Add WPT for CSP frame-ancestors violation reporting with report-uri" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ib34e4b4485db87f845bc48b661139a6a1ddfc5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334585Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794588}
-
Sigurd Schneider authored
This helper function will be used in upcoming CLs in a few places. Bug: chromium:1069378 Change-Id: If5646fa116c1d15c38f7e5ff43d5374cebdeb151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332820Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#794587}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f3bd05074570..46b0d8780f66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib0b3dbe1c1a7c48ab122378fe90106f5e8860dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336507Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794586}
-
Chris Hamilton authored
A variant container for hosting instances of util::TokenType. Allows strong typing when a token can be one of many types. BUG=1096617 Change-Id: Iec386f9760d4b093931ecdc6c477c202ae00bdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327644 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794585}
-
Alexander Cooper authored
Both the Plane and Anchor Manager currently maintain a map and a uint to generate Ids based on the address of their corresponding type. This logic will soon be similiarily expanded for HitTest and potentially AugmentedFaces. To avoid duplicating this logic, it is extracted into a helper class. Change-Id: I51f4475d37fe84ca687b82761d21a07b5b93d948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333674Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#794584}
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 1111134 Change-Id: I71da5c606925ead07c7469569825d000d2bd0da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331178 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#794583}
-
Bruce Dawson authored
The webui_closure_compile instructions refer to closure_compile but the correct gn arg name (as of crrev.com/c/2248564) is enable_js_type_check. Change-Id: I7bd947e0a277fe6e0f4972cd69ac2fc1c0b9b8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335557 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#794582}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/963bc42f8719..93bb4f5a94f3 2020-08-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-04 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-04 uekawa@google.com cros_mark_android_as_stable: print out json metadata. 2020-08-04 lamontjones@chromium.org api: freshen python bindings. 2020-08-04 erikchen@chromium.org Fix a parallel_unittest bug. 2020-08-03 vapier@chromium.org licensing: ban no-source-code license 2020-08-03 engeg@google.com chromeos_config: Sync R86 (ToT) boards criticality If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ibc2de041c387c8a4c71eadde38f9e7d3801f0d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794581}
-
Jongmok Kim authored
Uses explicit deletion instead, removes use of base/macros.h. Bug: 1010217 Change-Id: Id7efbf60060e975843f53dc363763f369195f488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326515 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#794580}
-
Mikel Astiz authored
This includes: 1. Trivial removal of an unused argument |no_db|. 2. Removal of argument |delete_file|, which should be unnecessary because none of the tests seem to rely on it (is only relevant for tests that instantiate HistoryService multiple times). 3. Removal of other keyed services besides HistoryService, which tests don't seem to rely on. MediaEngagementServiceTest is one of the few examples that does advance destroying and recreation of HistoryService, and requires logic like BlockUntilHistoryBackendDestroyed(). Because it's unique to this test and not something other tests should follow, the code gets moved there. The end result is that TestingProfile::CreateHistoryService() is a convenience function to set up a testing factory. It continues to be deprecated and tests should migrate over to using TestingProfile::Builder directly. Change-Id: I8b3d0378df23e383cae42687af31a034fc921fa1 Bug: 1106699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332576 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#794579}
-
Scott Little authored
Before this CL, translate_ui_delegate.cc sorts the list of supported translate languages using insertion sort. This CL changes it to use std::sort. Bug: 1109032 Change-Id: I6687ad1ba6c4da6dbb263446ed86d416ac9637b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333996 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Auto-Submit: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#794578}
-
Joshua Pawlicki authored
CSIP was using an UpdateServiceOutOfProcess in practice. Bug: 1107586 Change-Id: I3915818a8e828fe296cdbd5f3268351f82309a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336954 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794577}
-
Marijn Kruisselbrink authored
And migrate old settings to the new names. Bug: 1110509 Change-Id: I56f12e15e767bc13f0167652fab2be71ba5ac03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324669Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#794576}
-
Kateryna Prokopenko authored
Doc: https://docs.google.com/document/d/1hmC2R-f2_024I3urdEpKm34V5tSWeIk8MuRts7rggso/edit# Bug: chromium:1082628 Change-Id: I5ddc4e3cd9fc509b46442c0e506553527d1dc4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289841 Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#794575}
-
Nektarios Paisios authored
When an object on Mac is focusable but has no value or name, we compute its accessible description from its inner text. Unfortunately, we were adding a space between the concatenation of each piece of text coming from each child object which creates a mismatch between the text offsets returned by AXPosition and text markers vs. the actual text contents. If extra spaces are needed, they should be added by Blink, not by the browser. This patch removes the code that computes the inner text completely since no other screen reader announces focusable items unless they have an accessible name, and it is not proper to add an accessible name if there is none. AX-Relnotes: On Mac and same as on all other platforms, navigating by tab now does not announce the text contained in a large container such as a table row if that container is focusable. R=dmazzoni@chromium.org Change-Id: Iac5f321113595a2372df03bb119ab1c7a6f1bbf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308649 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#794574}
-
Chris Harrelson authored
This fixes the referenced performance regression in which some such videos stopped being composited. Bug: 1108972 Change-Id: Ia77d33c1c50cf25427d825ae3969a120a8cde640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335648Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794573}
-