GitLab

This CL adds an a11y button to allow fullscreening into the display
cutout area in addition the predefined gesture.

Bug: 867955
Change-Id: I7f1b47b11ac40d9d3ede9181c536d433fdeb03ed
Reviewed-on: https://chromium-review.googlesource.com/1171724
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586037}

BUG=b:113066827

Change-Id: Ic0e1d434eadbddf38f0fc6b2a5a6b1f364e947af
Reviewed-on: https://chromium-review.googlesource.com/1188588Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Alex Leung <alexleung@google.com>
Cr-Commit-Position: refs/heads/master@{#586036}

Switch everything to:
* IsUsingWindowService
* IsSingleProcessMash
* IsMultiProcessMash

Hopefully this makes it clearer when ash really is in the browser
process.

Fix one keyboard-related conditional too.

TBR=kbr@chromium.org

Bug: 874468
Test: ash_unittests with SingleProcessMash locally, spot check browser_tests
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0d175240dfff820cbf612fb7e30fec72ba5b81a2
Reviewed-on: https://chromium-review.googlesource.com/1188750
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586035}

This CL adds Chrome OS Discover UI in separate window.

Window need further changes to match the specs, but this
change mostly adds infrastructure.

Bug: 864686

Change-Id: I2834d8f9efb3660050a31768508992acb1f3f262
Reviewed-on: https://chromium-review.googlesource.com/1182880
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586034}

Currently we just sort suggestions by relevance and keep the best of
several duplicates. This can remove allowed_to_be_default_match's.
This change keeps the best default match, if any, and in fact
promotes it to the best relevance of the non-default matches
(if it's better).

Bug: 542780
Change-Id: Ie53f10d421412c390259891290fa15a951a4a2e1
Reviewed-on: https://chromium-review.googlesource.com/1174860
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586033}

ImageFetchTabHelper will be able to get image data by both JavaScript and
image_fetcher::IOSImageDataFetcherWrapper. The image_fetcher ivar of BVC
can be removed once this is completed.

Bug: 163201
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie5bb9279c5fb19498d3cde4c37cdf8944baa9e98
Reviewed-on: https://chromium-review.googlesource.com/1181571Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586032}

This CL bumps the targetSdkVersion to 28 since our app should be fully
supporting Pie features (i.e. cutout adjustments).

Bug: 831670
Change-Id: I7e1507f4c3c56ed802de3af75eafea3b9024d826
Reviewed-on: https://chromium-review.googlesource.com/1188897Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586031}

it has been snapped.

We did defer resetting the transform to identity of the drag window from
overview items until it has been snapped. In order to avoid the weird
transform if trying to snap an arc window.

Previous cl:
https://chromium-review.googlesource.com/c/chromium/src/+/910076

We should do the same thing if we try to snap a window through drag from
the top.
Changes in this cl,
- Do not restore the drag window's transform to identity when end window
   drag if the window should be snapped or drop into overview.

- Restore identity transform after window has been snapped. Calculate a
  starting transform for the to-be-snapped window based on its transformed
  bounds before to be snapped.

- Move the logic of GetTransformedBounds and GetTopInset to overview_util.

Bug: 872538
Change-Id: Icc2f034e0752fba4ba8ec673022e1f9306ca35b2
Reviewed-on: https://chromium-review.googlesource.com/1178385
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586030}

This reverts commit bab2befc.

Reason for revert: test expectations for inspector now include the source code line number. This means that any change to the source requires rebaselining all the tests.

Original change's description:
> Show Deprecation message for Shadow DOM V0.
> 
> This patch marks them deprecate at M73.
> 
> Bug: 671907
> Change-Id: I0ba155ad98ff0add788b9089e65cb0a3ea03b3f5
> Reviewed-on: https://chromium-review.googlesource.com/1180840
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Commit-Queue: Yoichi Osato <yoichio@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585764}

TBR=hayato@chromium.org,tkent@chromium.org,yoichio@chromium.org

Change-Id: I4d6b33052bcdd54f0de25127d4334c35e49bb9e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 671907
Reviewed-on: https://chromium-review.googlesource.com/1189025Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586029}

In the paint code (ClipPathClipper), the reference box used is the one
computed by LocalReferenceBox(), and the coordinate space is adjusted
for that. In the hit-testing code however, the reference box is adjusted
instead, leading to incorrect results when the reference box is
subjected to an additional transform (a 'transform' on a <clipPath>.)

Instead, set up the reference box and coordinate space in the hit-
testing code in the same way as for paint, by translating to the correct
local coordinate space before performing the actual hit-test.

Bug: 876390
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I60acd616964a942893f0e256766aca728d14b494
Reviewed-on: https://chromium-review.googlesource.com/1188302Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#586028}

The Autohide Shelf context menu option lets the user make
the shelf hide when a window is maximized. This option used to
have a check mark signifying that autohide was enabled. With touchable
app context menus, there is no check mark.

To work like a checkmark, we will add a new selection option which
toggles with "Autohide Shelf". It is called "Always Show Shelf".

Bug: 875781
Change-Id: I6ed9f42cd6ac3e67f70110ea69944cc18a7abba7
Reviewed-on: https://chromium-review.googlesource.com/1188888Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586027}

This cl registers the assistant audio decoder service to utility
process.

Bug: b/80315134
Test: manual.
Change-Id: Ic4dda124818cefd66026ca9c0f10ec862c98965f
Reviewed-on: https://chromium-review.googlesource.com/1187657
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586026}

AppCacheResponseInfo and HttpResponseInfoIOBuffer take ownership of the
net::HttpResponseInfo passed to them. Both classes are meant to be
final, and don't need virtual destructors.

The rest of the CL propagates the changes described above.

Change-Id: I8330ce2d6d3f052da165cdbf7896b674935cfa54
Reviewed-on: https://chromium-review.googlesource.com/1188582Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586025}

Use URL validation provided by GURL, and added URL formatting using
FixupURL. This tries to make "smart" adjustments to obviously invalid
input (see url_fixer.h). The fixed URL will default to "https://" if a
scheme was not specified.

Also disabled spellcheck in the URL field and removed "required" from
the Name field. The URL will be set as the title if Name is left empty.

Bug: 874194
Change-Id: I0d40f551f3e79d77aa93ce3dd0f36f736bf987ee
Reviewed-on: https://chromium-review.googlesource.com/1182418
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586024}

Porting the PrivetURLFetcher to the network service and renaming it
PrivetURLLoader. Also cleaned-up some of the tests as part of the port,
disabling the delays in the tested code so the tests don't have to
wait.

Bug: 840390
Change-Id: I0bf21c8f708585c00f75a088f4cc4544e0821f70
Reviewed-on: https://chromium-review.googlesource.com/1162509Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586023}

Add tests for the various click events that take place during
NTP background customization.

Bug: 857256
Change-Id: If6f5e6582cbd1f47a02a19702d69fd6d3024606a
Reviewed-on: https://chromium-review.googlesource.com/1187561
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586022}

https://chromium.googlesource.com/catapult.git/+log/1e44d066259f..72712b0d6078


git log 1e44d066259f..72712b0d6078 --date=short --no-merges --format='%ad %ae %s'
2018-08-24 zmo@chromium.org Add a script to auto generate telemetry_chrome_test_support build target
2018-08-24 benjhayden@chromium.org Remove bot_whitelist.
2018-08-24 simonhatch@chromium.org Pinpoint - Fix flaky migrate tests
2018-08-24 anthonyalridge@google.com Use real metric data for calculating significant changes.
2018-08-24 anthonyalridge@google.com Introduce display region for statistical test results.
2018-08-24 pasko@chromium.org perf_control.py: Remove TODO for a fixed bug


Created with:
  gclient setdep -r src/third_party/catapult@72712b0d6078

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:872521,chromium:868512,chromium:877074,chromium:866423,chromium:866423,chromium:397118
TBR=sullivan@chromium.org

Change-Id: I2a744233b5777b9b640ea4fbaff5c9fba95114e6
Reviewed-on: https://chromium-review.googlesource.com/1188518Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586021}

This CL cleans up a bit said method VaapiVP8Accelerator::SubmitDecode():
- Adds {} where needed (either condition or body > 1 line).
- Removes memset() of a struct, instead using = {}, and moves the
 variable declaration closer to its use, in some cases.
- s/std::min(std::max())/base::ClampToRange()/

No new functionality intended.  This code is only used in ChromeOS.

Bug: 876810
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If2fb903a427dea2424743217e569d09cdadefe22
Reviewed-on: https://chromium-review.googlesource.com/1188615Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586020}

Regular update to current release APKs.

TBR=bajones@chromium.org

Change-Id: Ie1792bfc13c642cea4a99cd6af700356443a35a5
Reviewed-on: https://chromium-review.googlesource.com/1188964Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586019}

This CL temporarily adds an InputEventObserver for TouchMoves on
RenderWidgetHost to try and detect the source of spurious TouchMove
events in the Windows flakes of
SitePerProcessEmulatedTouchBrowserTest.EmulatedTouchShowPressHasTouchID.

Bug: 833380
Change-Id: Ia3d6f75013acbbc9ed1a823c799741e2c64d2253
Reviewed-on: https://chromium-review.googlesource.com/1188876Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586018}

Updates Mac and Linux installers to place manifests in proper per-
platform location. Windows is more complicated due to 32/64-bit registry
considerations, so the installer will be updated in a follow-up commit.

Change-Id: If2f6a4f77e013703c146bba91aaa4362eea12e11
Reviewed-on: https://chromium-review.googlesource.com/1187659
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586017}

It turns out that on OSX, broadcast must be set on a UDP socket before
binding a socket when reusing an address that already has a broadcast
socket bound to it. Otherwise, the bind() call will fail.

Bug: 848078
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I41f2bb6085a9be1dc42c18483a85766d4b3d46ac
Reviewed-on: https://chromium-review.googlesource.com/1188617
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586016}

Devices in Demo Mode are enrolled into the cros-demo-mode.com domain,
which uses enterprise policy to set the list of force-installed apps
and which of those apps are force-pinned to the shelf. This lets us
choose which first and third party apps to feature in the demo.

A few demo apps only work online. When a device in Demo Mode is
offline, we don't want to feature those apps, but they're
unconditionally force-pinned by policy.

This CL updates the shelf's pinned policy pref handling to ignore
certain apps pinned by policy when the device is in Demo Mode and
offline. The user can still pin and unpin those apps themselves.

Bug: 870846
Change-Id: Ie15ea89f77fd5ed6a789614a83c39bb2aee286d2
Reviewed-on: https://chromium-review.googlesource.com/1179318
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586015}

And invoke that instead of invoking a long list of chained commands.

This generates a temporary shell script on the host at test-time,
pushes it over to the VM, then removes it after the test on the host.
(The VM gets auto cleaned-up.)

Bug: 732531, 876587
Change-Id: I7a2e5749d329d6f7a8716724c8c1060d4f8f80d3
Reviewed-on: https://chromium-review.googlesource.com/1149189Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586014}

In order to send PointerLeave events for stylus when the pen is
leaving the proximity of the tablet in PointerEvent web-platform tests,
we add PointerLeave actions to PointerActionSeqence API.

Bug: 583413
Change-Id: I0d04445afc9f9afc5bb02f001240c398fc5eff4e
Reviewed-on: https://chromium-review.googlesource.com/594651Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586013}

Move AudioFocusObserver to the media session service and
convert it to use mojo. At the moment the observers
register themselves with AudioFocusManager but in the
future this will be with the Media Sesssion service.

Also adds an empty MediaSession mojo type so we can pass
it as an arg to AudioFocusObserver.

BUG=875004

Change-Id: I4bd09796018833cb9f9714b2296642bd40be48ff
Reviewed-on: https://chromium-review.googlesource.com/1180484
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586012}

Preivously, the shape of a window was not taken into account when
computing occlusion state. A window with a shape that didn't fully
cover its bounds could wrongly be considered to occlude another
window underneath it.

With this CL, shaped windows can't occlude other windows (similar
to windows that are animated or not axis-aligned).

Bug: 864508
Change-Id: I01ff1afda438982964cdc2d786f37caaa03677be
Reviewed-on: https://chromium-review.googlesource.com/1173318Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586011}

Bug: 113114120
Test: None
Change-Id: Ieaa27aa772b193f2c41a7befe4383e7aa21d9a1a
Reviewed-on: https://chromium-review.googlesource.com/1187404Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Benjamin Shaya <bshaya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586010}

Changes:
Convert search box bounds to widget coordinates without considering
transform so that it is not affected by overview mode transform
animation.

Bug: 877282
Change-Id: I8de8e497a50b336a9be511ee87662b62599b2c87
Reviewed-on: https://chromium-review.googlesource.com/1187888Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586009}

Make sure the caption buttons are updated right away when the theme
changes. The bug occurs in classic Ash; it works properly in Mash.

This patch adds a test which only covers Mash to make it sure it doesn't
regress.

Bug: 877022
Change-Id: Ic4d9824396e196dd368ae896d269f862af883bbd
Reviewed-on: https://chromium-review.googlesource.com/1187406
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586008}

Bug: 805612, 874172, 874168
Change-Id: I21df0bfdcafad1a1f704cd000e6249e61042563d
Reviewed-on: https://chromium-review.googlesource.com/1186823Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586007}

The MimeHandlerViewTests/MimeHandlerViewTest.Fullscreen tests are flaky
on Linux MSan:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests

Example failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11308

TBR=lazyboy@chromium.org

Bug: 877627
Change-Id: Ie7f05125c5abf60454327ea5c5d61326f9137f93
Reviewed-on: https://chromium-review.googlesource.com/1188874Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586006}

The mac bot seems to have fallen offline somehow. Filed https://crbug.com/877224
for that

Bug: 867725
Change-Id: I42e3660b153831e35b32b2f381609784a4013044
Reviewed-on: https://chromium-review.googlesource.com/1188944Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586005}

Bug: 877510
Change-Id: Icf50fe4d6102a0b87ead889e161cafff3c1eb348
Reviewed-on: https://chromium-review.googlesource.com/1188869
Commit-Queue: Ben Mason <benmason@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586004}

During browser fullscreen transition, we have been avoiding doing layout
to prevent jankiness. On Mac, during such fullscreen transition,
CA transaction updates thus full re-paint still happen due to window resize.
This results in transient paint with obsolete layout. For example, if
Chrome is entering content fullscreen mode such as trying to play a video
in fullscreen, BrowserView::IsTabStripVisible() would return false since the
tabstrip should not be shown, but the tab strip is still being painted.

To solve the above problem, and also avoid unnecessary operations, this
CL suppresses CA transaction updates during fullscreen transition. Since
after the fullscreen transition, Chrome will immediately re-layout and
re-paint, the updates during the transition are not needed. This CL also
enables the tests that previously failed due to the state discrepancy
problem.

BUG=875707

Change-Id: I89510fcf55afc47e407d78bdf60a0c5a03ad9e57
Reviewed-on: https://chromium-review.googlesource.com/1188035
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586003}

R=jsbell@chromium.org

Bug: 720919
Change-Id: I192aaba2b58ac7edd9b59212dd48f4fa0cb16379
Reviewed-on: https://chromium-review.googlesource.com/1188850Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586002}

This CL moves the logic of ignoring client resolution of a portrait mode
phone screen into ChromotingSession, so that the Android client can get
this for free.

Bug: 874626
Change-Id: I0bf946c8a2ba5ce52e70b54b06517a3334f5727e
Reviewed-on: https://chromium-review.googlesource.com/1187802
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586001}

This also removes window_manager_constants as it was not used.

BUG=876924
TEST=covered by tests
TBR=msw@chromium.org,tsepez@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ie9cd86ddc5c9a64b3a36b854b515988c52292758
Reviewed-on: https://chromium-review.googlesource.com/1188865
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586000}

Revert "[Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland)."

This reverts commit d88c3ec1.

Reason for revert: PlatformThreadTest.SetCurrentThreadPriorityWithThreadModeBackground is Flaky:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=base_unittests&tests=SetCurrentThreadPriorityWithThreadModeBackground

Original change's description:
> [Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland).
>
> Relanding a CL that was reverted because of a variable that was
> unused in non-DCHECK builds and caused a compile failure.
> Original CL: Reviewed-on: https://chromium-review.googlesource.com/1171482
>
> This CL adds a feature to use THREAD_MODE_BACKGROUND_BEGIN instead of
> THREAD_PRIORITY_LOWEST for ThreadPriority::BACKGROUND threads. This
> lowers the disk and network I/O priority of the thread in addition to
> the CPU scheduling priority. MSDN recommends using this setting for
> threads that perform background work.
> https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-setthreadpriority
>
> TBR=gab@chromium.org
>
> Bug: 872820
> Change-Id: I212fb77bb035088595b4944ce145a74d333c38eb
> Reviewed-on: https://chromium-review.googlesource.com/1185529
> Commit-Queue: François Doray <fdoray@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585272}

TBR=gab@chromium.org,fdoray@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 872820, 877628
Change-Id: I6cf6625fc1f01106e8fff1e206a6a256f3a6160a
Reviewed-on: https://chromium-review.googlesource.com/1188644
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585999}

AppCacheNamespaceVector is std::vector<AppCacheNamespace>.
AppCacheResourceInfoVector is std::vector<AppCacheResourceInfo>. These
aliases don't hold their weight, because the noise saved is outweighed
by the reader having to figure out / remember if they represent special
data types, or just std::vector.

kEnableExecutableHeaders is unused.

Change-Id: I19a32054dd0d08e7026e9aaf8a2b19e0c48d51ed
Reviewed-on: https://chromium-review.googlesource.com/1188383Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585998}