GitLab

Only return the visible page actions from PageActionController.

This is a bit of a yak shave to support having the "action box" show active
extensions on the current page rather than page actions. Previously,
PageActionController was creating widgets for everything then
LocationBarViewGtk was hiding them as necessary. This is assumes too much; we
need to push the visibility logic into the Controller for the future.

BUG=127988


Review URL: https://chromiumcodereview.appspot.com/10388160

TBR=kalman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137632 0039d316-1c4b-4281-b951-d872f2087c98

CID=104015

R=jhawkins@chromium.org
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10399042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137631 0039d316-1c4b-4281-b951-d872f2087c98

This is a bit of a yak shave to support having the "action box" show active
extensions on the current page rather than page actions. Previously,
PageActionController was creating widgets for everything then
LocationBarViewGtk was hiding them as necessary. This is assumes too much; we
need to push the visibility logic into the Controller for the future.

BUG=127988


Review URL: https://chromiumcodereview.appspot.com/10388160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137630 0039d316-1c4b-4281-b951-d872f2087c98

Currently, Ash accelerators are handled at a very early stage, right after a native key event is received by aura::RootWindowHost. This CL change the way of handling Ash accelerators as follows to make it more App friendly:

1. If no window is focused, handle an Ash accelerator immediately in ash/accelerators/accelerator_filter.cc in the same way as before.
2. Otherwise, do not handle it in ash/accelerators/accelerator_filter.cc but let a custom views::FocusManager handle it (see ash/shell.cc). There are 3 types of scenarios here depending on the type of the focused window:
2-a. If the focused window is a browser, and the browser is not for an app, let the custom focus manager pre-handle Ash accelerators before passing it to the browser (see PreHandleKeyboardEvent() in chrome/browser/ui/views/frame/browser_view.cc).
2-b. If the focused window is a browser, and the browser is for an app, let the app handle Ash accelerators first (see chrome/browser/ui/views/frame/browser_view.cc). If the accelerator is not consumed by the app, let the custom focus manager handle it.
2-c. If the focused window is not a browser, let the window handle Ash accelerators first. If the accelerator is not consumed by the window, then let the custom focus manager handle it. This means a WebView without the chrome/browser/ui/ layer can handle Ash accelerators first whenever needed.

Other changes:

chrome/browser/ui/views/frame/browser_view.cc:
Support ET_KEY_RELEASED accelerators in BrowserView::PreHandleKeyboardEvent().

ui/views/focus/focus_manager.cc:
Support ET_KEY_RELEASED accelerators. Also fix code for handing VKEY_MENU so that the Shift+Alt+ET_KEY_RELEASED accelerator for Ash could be handled correctly.

This CL depends on http://codereview.chromium.org/10377158/ (by jochen), https://chromiumcodereview.appspot.com/10388023, http://codereview.chromium.org/10389035/, and https://chromiumcodereview.appspot.com/10332051/, and should not be submitted until the 4 CLs are landed.

BUG=123856
TEST=ran aura_shell_unittests
TEST=manual; launch Chromoting app as a window, connect to a Chromoting server, focus Chrome on the remote machine, press Ctrl-n, confirm a new window is opened on the remote machine.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135791

Review URL: https://chromiumcodereview.appspot.com/10134036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127706
TEST=Start chrome, sign in to sync, start print job spooling and exit while the print job is spooling, should not get a crash.


Review URL: https://chromiumcodereview.appspot.com/10391080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137628 0039d316-1c4b-4281-b951-d872f2087c98

So that we can handle directories in drop event as well as on other platforms.

BUG=58977,99823
TEST=manually tested with LayoutTestsediting/pasteboard/data-transfer-items-drag-drop-entry.html

Review URL: https://chromiumcodereview.appspot.com/10382191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124829
TEST=run aura build with flash and compositor thread, open youtube video, reload many times.


Review URL: https://chromiumcodereview.appspot.com/10382215

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137626 0039d316-1c4b-4281-b951-d872f2087c98

Bug=124566
Test=Manual

Review URL: https://chromiumcodereview.appspot.com/10389109

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137625 0039d316-1c4b-4281-b951-d872f2087c98

This was broken by r136239.

BUG=None
TEST=Tested file inputs work again.


Review URL: https://chromiumcodereview.appspot.com/10332213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137623 0039d316-1c4b-4281-b951-d872f2087c98

Bug=124566
Test=Manual

Review URL: https://chromiumcodereview.appspot.com/10389109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137622 0039d316-1c4b-4281-b951-d872f2087c98

- Use VKEY_CONTROL instead of VKEY_LCONTROL/VKEY_RCONTROL to be consistent with Windows' behavior.

Windows (and ui/base/keycodes/keyboard_code_conversion_x.cc) never sends a VKEY_[LR]CONTROL event when left/right control is pressed. The VKs are used only as a return value of GetKeyboardState() Windows API.

- Add unit tests for Command+NumPad presses.

Add tests that checks if NumPad1 + Command key presses on an Apple keyboard are treated as VKEY_NUMPAD1 with EF_CONTROL_DOWN.

BUG=None
TEST=manual + unit_tests


Review URL: https://chromiumcodereview.appspot.com/10397003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137621 0039d316-1c4b-4281-b951-d872f2087c98

Adds a new histogram that can be called from JS to record stats on the upcoming destination selector.

BUG=128275
TEST=No user visible change.


Review URL: https://chromiumcodereview.appspot.com/10387162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122687
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10310113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126132


Review URL: https://chromiumcodereview.appspot.com/9985012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137616 0039d316-1c4b-4281-b951-d872f2087c98

Streamline methods of PushClient and its Observer subclass.

Remove sync/protocol/service_constants.h and consolidate use of each
constant in one place.  Remove duplicate constant in cloud print code.

BUG=76764
TEST=
TBR=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10398051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125059

TEST=


Review URL: https://chromiumcodereview.appspot.com/10391172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137614 0039d316-1c4b-4281-b951-d872f2087c98

Note: this will appear as a regression to latency tests, but it is actually just a more accurate measurement of the GPU path.


Review URL: https://chromiumcodereview.appspot.com/10378112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137613 0039d316-1c4b-4281-b951-d872f2087c98

Moved gtk-dependent code to files with _gtk suffix that are
excluded when compiling without GTK. Also some minor cleanups in remoting.gyp.

BUG=114211


Review URL: https://chromiumcodereview.appspot.com/10386181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112155
TEST=no


Review URL: https://chromiumcodereview.appspot.com/10398054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137609 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin@chromium.org
R=jhawkins@chromium.org

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10377180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137606 0039d316-1c4b-4281-b951-d872f2087c98

The command-line flag to turn on the HUD is --ash-touch-hud. It can also be
turned on from about:flags

BUG=none
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137549

Review URL: https://chromiumcodereview.appspot.com/10386178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137605 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to set up a PPAPI HostDispatcher in Chrome code, so we can
work on the NaCl IPC proxy outside of src/content.
BUG=116317
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10407009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137604 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10388173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137601 0039d316-1c4b-4281-b951-d872f2087c98

+++ REVERT NOTICE +++
Test still fails.
http://build.chromium.org/p/chromium.pyauto/builders/Win%20XP/builds/16004/steps/pyauto_functional_tests/logs/stdio
+++

TEST=137047 merged, re-enabled password autofill for Incognito window.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10389183

TBR=dyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10399060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=DownloadProtectionServiceTest.CheckClientDownloadZip


Review URL: https://chromiumcodereview.appspot.com/10382113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137599 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10392094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109818
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10332210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137594 0039d316-1c4b-4281-b951-d872f2087c98

Remove all the unnused automation IPCs. These were used by UI tests that have been converted to browser_tests.

BUG=121574
Review URL: https://chromiumcodereview.appspot.com/10388175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137593 0039d316-1c4b-4281-b951-d872f2087c98

Refactored default detection for all versions for better code reuse.  IApplicationAssociationRegistration::QueryCurrentDefault is used on Windows 8.  For now I'm keeping the Vista/Win7 detection as-is since I don't want to break it.  I think the new technique will work there, too, but I don't want to spend time validating this right now.

BUG=113326
TEST=check that chrome can tell whether or not it's the default browser and assorted protocol handler under XP, Vista/Win7, and Win8 at user and system levels.

Review URL: https://chromiumcodereview.appspot.com/10388151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137590 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127996
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10387142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137589 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137588 0039d316-1c4b-4281-b951-d872f2087c98

If "BREAKPAD_DUMP_LOCATION" environment variable is set, use this path instead.  Currently Mac's breakpad uses this to specify alternative path for breakpad dump location.  For Chromebot this allows crashes to be identified with multiple Chrome instances.

Review URL: https://chromiumcodereview.appspot.com/10391175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137587 0039d316-1c4b-4281-b951-d872f2087c98

r1378 | Two overflows when many actions are in one target/one script.
r1379 | msvs: error out on actions w/o inputs
r1380 | ninja: Change the default target from 'build everything' to 'build target "all"'.
r1381 | msvs: fix regression in r1378, environment not set up properly for multiple actions on one input

TBR=grt@chromium.org
BUG=gyp:261

Review URL: https://chromiumcodereview.appspot.com/10391166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137586 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vivianz@chromium.org
BUG=128300
TEST=

Review URL: https://chromiumcodereview.appspot.com/10406023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137585 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125964
TEST=none.


Review URL: https://chromiumcodereview.appspot.com/10383199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122753
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/10386076

TBR=estade@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383228

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137581 0039d316-1c4b-4281-b951-d872f2087c98

The default paths have changed under from Visual Studio 2008 to 2010 and which causes the PDB and MAP files for the syzygyized mini_installer to get generated to the same locations as for the regular mini_installer. This further causes the staging of the Syzygy optimized build to fail because it expects the PDB file to be somewhere else.

Made the paths of the PDB and MAP files explicit.


BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10407006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137580 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky,sadrul
BUG=124724
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10388177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128319
TEST=


Review URL: https://chromiumcodereview.appspot.com/10332192

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137576 0039d316-1c4b-4281-b951-d872f2087c98