- 25 Apr, 2012 33 commits
-
-
mseaborn@chromium.org authored
This is in preparation for changing nacl_process_host.cc to reuse this code instead of having its own copy in DebugContext. This needs to go into chrome/common rather than chrome/nacl so that nacl_process_host.cc can #include it under the checkdeps rules. This changes the code to use PostTask() instead of PostDelayedTask(). BUG=http://code.google.com/p/nativeclient/issues/detail?id=2618 TEST=run_inbrowser_exception_test in nacl_integration Review URL: http://codereview.chromium.org/10211007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133851 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10071033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133847 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133846 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
TBR=mnaganov@chromium.org BUG=None TEST=Tree is green Review URL: http://codereview.chromium.org/10212010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133845 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=binji@chromium.org TEST= BUG= Review URL: http://codereview.chromium.org/10139026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133844 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
This CL does the following: - add a new enable_metro build flag - if the build flag is set then add a new metro icon resource pak to chrome - at run time if Chrome is running in metro mode AND ENABLE_METRO is set then use the metro icon resource pak BUG=114311 TEST= Review URL: http://codereview.chromium.org/10082020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133843 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
I've reordered the resource request URLRequest cancellations so now I can reland r133313 and not have it assert on renderer resource requests. ========== Revert 133313 - I need to move the assertion to a better place. Assert when URLRequests leak for the main URLRequestContexts. I've already enabled the assertions for all the non-main URLRequestContexts: * safe browsing * system * media * extensions I've squashed those leaks, so now it's time to work on the main URLRequestContext for the profile. I know there are defintely existing l BUG=90971 TEST=none ========== TBR=eroman BUG=90971 TEST=none Review URL: http://codereview.chromium.org/10219010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133842 0039d316-1c4b-4281-b951-d872f2087c98
-
khorimoto@chromium.org authored
BUG=117517 TEST= Review URL: http://codereview.chromium.org/10038034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133840 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
This provides an AddExtension() method in FilePath, which will append an extension to the FilePath. This provides clearer, more deliberate functionality than AppendASCII(), and allows us to add extensions without using ReplaceExtension, which will not work on files which already have extension (or appear to, e.g. temp files). BUG=NONE TEST=FilePathTest.AddExtension (added), previous FilePathTests. Review URL: http://codereview.chromium.org/10067002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133839 0039d316-1c4b-4281-b951-d872f2087c98
-
nileshagrawal@chromium.org authored
Command for running with a test filter: ./build/android/run_tests.py -s out/Release/base_unittests_apk/base_unittests-debug.apk -f FileUtilTest.* The _disabled file should be base_unittests-debug_disabled BUG= TEST= Review URL: http://codereview.chromium.org/10214002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133838 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Note that dmprof is not checked by pylint at all since pylint only checks .py files. R=cmp@chromium.org TBR=dmikurube@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10203013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133836 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Add a PRESUBMIT.py to run checkperms.py when it is modified and to run pylint on it. R=thestig@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10134019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133835 0039d316-1c4b-4281-b951-d872f2087c98
-
dyu@chromium.org authored
Possible race condition while running the test on the Mac. TEST=none BUG=124922 Review URL: https://chromiumcodereview.appspot.com/10209014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133834 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
* Define GDataDB interface with methods to Put, Get and Delete. Also define a path-based iterator. * GDataLevelDB implements GDataDB using leveldb. * Add methods SerializeToString and FromProtoString to serialize GDataEntry to strings and vice versa. * GDataDBTests test Put, Get, Delete for files and directories. * Iterator tests in GDataDBTests. * GDataDBFactory class to create GDataLevelDB instance. * Update deps to allow leveldatabase. TODO: * There is no integration with GDataRootDirectory/GDataFileSystem yet. BUG=chromium-os:29232 TEST=unittests pass. Review URL: https://chromiumcodereview.appspot.com/10210012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133833 0039d316-1c4b-4281-b951-d872f2087c98
-
dennisjeffrey@chromium.org authored
BUG=None TEST=Verified with a recent official ChromeOS build that the pyauto pagecyclers successfully run to completion when invoked via run_remote_tests. Review URL: https://chromiumcodereview.appspot.com/10219007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133832 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
- Renames aura::Window::GetScreenBounds() to ::GetBoundsInRootWindow(), which is what it really does. - NativeWidgetAura now gives its NativeWidgetHelperAura a chance to modify those bounds. BUG=none TEST=none Review URL: http://codereview.chromium.org/10210005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133831 0039d316-1c4b-4281-b951-d872f2087c98
-
nileshagrawal@chromium.org authored
Modify test_result.LogFull() to print the summary, and call it when native finish running. BUG= TEST= Review URL: http://codereview.chromium.org/10210001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133830 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10069052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133829 0039d316-1c4b-4281-b951-d872f2087c98
-
alexeypa@chromium.org authored
Review URL: http://codereview.chromium.org/10209010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133827 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
With this CL Chrome is marked as HiDPI aware if the enable_hidpi build flag is set. BUG=114311 TEST=Changed Windows to 2x DPI scale. Ran Chrome. Verified that 2x icons were used. Review URL: http://codereview.chromium.org/10086009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133826 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10065037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133825 0039d316-1c4b-4281-b951-d872f2087c98
-
posciak@chromium.org authored
This fixes a problem with sending log messages from children threads of the GPU process. In GPU process the message goes through GpuProcessLogMessageHandler() and to ChildThread::Send(), but there it would fail on DCHECK(MessageLoop::current() == message_loop()), try to output another log message about it, and since the handler is overriden, it would go back to GpuProcessLogMessageHandler, and back again to ChildThread::Send() and thus recurse until eventually dying silently due to stack overflow. BUG= TEST=manual run of a GPU child thread Review URL: http://codereview.chromium.org/9812022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133824 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
example. BUG=no TEST=no Review URL: http://codereview.chromium.org/10134040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133823 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
R=agl@chromium.org,rsleevi@chromium.org BUG=124434 TEST=none Review URL: https://chromiumcodereview.appspot.com/10216004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133822 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
R=thestig@chromium.org BUG=51770 TEST=none Review URL: https://chromiumcodereview.appspot.com/10212002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133821 0039d316-1c4b-4281-b951-d872f2087c98
-
kevers@chromium.org authored
BUG=123030 TEST=Manual. Review URL: http://codereview.chromium.org/10175010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133820 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
* Define GDataDB interface with methods to Put, Get and Delete. Also define a path-based iterator. * GDataLevelDB implements GDataDB using leveldb. * Add methods SerializeToString and FromProtoString to serialize GDataEntry to strings and vice versa. * GDataDBTests test Put, Get, Delete for files and directories. * Iterator tests in GDataDBTests. * GDataDBFactory class to create GDataLevelDB instance. TODO: * There is no integration with GDataRootDirectory/GDataFileSystem yet. BUG=chromium-os:29232 TEST=unittests pass. Review URL: https://chromiumcodereview.appspot.com/10168025 TBR=achuith@chromium.org Review URL: https://chromiumcodereview.appspot.com/10214008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133819 0039d316-1c4b-4281-b951-d872f2087c98
-
kevers@chromium.org authored
BUG=chromium-os:19569 TEST=Open the settings tab and connect to a WiFi network. Ensure that signal strength and frequency are show in the connection details. BSSID should also be visible for 802.11 networks. Review URL: http://codereview.chromium.org/10174010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133818 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
These are called on UI thread, so no need to deal with MesageLoopProxy::current() etc. BUG=chromium-os:29036,chromium-os:29943 TEST=saving to gdata works as before and no error was emitted with --enable-dcheck with a Release build. Review URL: https://chromiumcodereview.appspot.com/10207022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133817 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
BUG=123939 TEST=launch GPU process by navigating to a page requiring it. open about:tcmalloc. refresh. see GPU process memory information Review URL: http://codereview.chromium.org/10041017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133816 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
* Define GDataDB interface with methods to Put, Get and Delete. Also define a path-based iterator. * GDataLevelDB implements GDataDB using leveldb. * Add methods SerializeToString and FromProtoString to serialize GDataEntry to strings and vice versa. * GDataDBTests test Put, Get, Delete for files and directories. * Iterator tests in GDataDBTests. * GDataDBFactory class to create GDataLevelDB instance. TODO: * There is no integration with GDataRootDirectory/GDataFileSystem yet. BUG=chromium-os:29232 TEST=unittests pass. Review URL: https://chromiumcodereview.appspot.com/10168025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133815 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Replace string copy code and scoped_arrays() with const_casts in MediaDeviceNotificationsLinuxTest. Explain why this is safe. BUG=none TEST=none Review URL: http://codereview.chromium.org/10105037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133814 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133813 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Apr, 2012 7 commits
-
-
hclam@chromium.org authored
TBR=mnaganov@chromium.org BUG=None TEST=Tree is green Review URL: http://codereview.chromium.org/10219001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133812 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
In some functions, we know that we are on UI thread, so we can directly use ui_weak_ptr_. BUG=chromium-os:28503 TEST=none Review URL: https://chromiumcodereview.appspot.com/10169041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133811 0039d316-1c4b-4281-b951-d872f2087c98
-
asharif@chromium.org authored
The "initial-exec" attribute is added to the ThreadCache::threadlocal_heap_ variable under normal compilation. This causes the linker to emit a R_X86_64_TPOFF64 relocation in the _pyautolib.so shared object. This relocation can cause python to error with: cannot allocate memory in static TLS block when it calls dlopen() on _pyautolib.so (when the import statement is interpreted). This only happens when the TLS section is large enough. Building Chrome with -fprofile-generate to add some instrumentation-related data to the TLS is enough to trigger this condition. This CL encloses the function attribute in #if ! defined(PGO_GENERATE). When Chrome is built with -fprofile-generate, we will also pass in -DPGO_GENERATE and -ftls-model=global-dynamic so profile data can be collected without any errors. BUG=none TEST=Rebuilt chromeos-chrome in the chroot with -fprofile-generate -ftls-model=global-dynamic -DPGO_GENERATE && ran pyautoperf autotests. Review URL: http://codereview.chromium.org/10035012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133810 0039d316-1c4b-4281-b951-d872f2087c98
-
jcivelli@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/10216001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133809 0039d316-1c4b-4281-b951-d872f2087c98
-
gcasto@chromium.org authored
enabled. BUG=124112 TEST=Ran unittests Review URL: http://codereview.chromium.org/10168017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133808 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
In favor of less things to have in gdata_file_system.h, which is overly large. BUG=chromium-os:29215 TEST=none Review URL: https://chromiumcodereview.appspot.com/10219006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133807 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
Review URL: http://codereview.chromium.org/10209012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133806 0039d316-1c4b-4281-b951-d872f2087c98
-