- 30 Oct, 2019 40 commits
-
-
Austin Tankiang authored
When there is a forced directory change (e.g. through unplugging a usb), if the gear menu is currently open, the menu items do not update their status with the new directory. This can cause, for example, the 'Format device' item to still be active. This change forces an update on directory change. Modify the formatDialogGearMenu test to test this behaviour too. Bug: 1007566 Change-Id: I8158a2630e6711fb9b8e371faf7f689325043cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859810 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#710702}
-
Fredrik Söderquist authored
'to' animation is sufficiently special that we may as well treat separately altogether. Sink that part of the check out and clean up code using IsAccumulated(). Bug: 1017723, 231517 Change-Id: I27c63a423fa3ac24896bd4cf8f15f5aa101c4499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886813 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#710701}
-
Tom Tan authored
The instruction 'BRK #F000' does trap on Windows ARM64 which is different from other ARM64 platforms. Calling __debugbreak() which will produce the right encoding and always supported by MSVC and clang. Bug: 893460 Change-Id: I54e2d8de6ae7d9ba5929dc8e382e18a99d5aaeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879677Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710700}
-
Martin Robinson authored
This version adds protected memory support to handle calling ATK methods dynamically on the CFI bot. Original change's description: > Reland "Fix emission of AtkValue property change signal" > > This version checks at runtime for atk_value_set_value during testing. > This should allow the change to work on bots running trusty. > > Original commit message: > > > The introduction of text-change signals for the omnibox included a > > regression that prevented the emission of AtkValue property change > > signals. Fix this error and also add an implementation of > > atk_value_set_value. The implementation is used in a test to verify the > > correct behavior. > > > > The fix is that we correct the misuse of a logical operator and now > > always try to emit AtkValue property change events when receiving the > > kValueChanged event in AXPlatformNodeAuraLinux. Bug: 1015387 Bug: 1017177 Bug: 1017548 Change-Id: Iadaea4569944ad0a1be0e1211bbce4ed2c4f6935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879255Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#710699}
-
Nikita Podguzov authored
This CL adds: * chrome.printing API setup including new "printing" permission and printing.idl API description, * One event: OnJobStatusChanged() and its implementation, * Unit tests for this event, * New print job source: EXTENSION. It's not used in print job creation yet but is required for correct implementation of the event. This CL doesn't add any API test since it's impossible yet to create print job via API. API test covering this event will be added together with submitJob() function implementation in follow-up CL. Bug: 996785 Change-Id: I1708631caffdde2395a3d07f2ea7de392d09a63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824948Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#710698}
-
Carlos IL authored
The DefaultInsecureContentSetting policy had a typo (a quotation mark instead of a period at the end of the sentence), an unrelated CL removed the quotation mark, this adds a period. Change-Id: Ia498560a368f8f8def09bf32eb1fab1d64a1b8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887650 Auto-Submit: Carlos IL <carlosil@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#710697}
-
Takashi Sakamoto authored
This reverts commit 9dc83eeb. Reason for revert: causes bot_update failure on Win x64 Builder (dbg). Sample build: https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder%20%28dbg%29/99428 --- error: unable to create file third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/virtual/controls-refresh/fast/forms/controls-new-ui/color-scheme-validation/color/color-suggestion-picker-appearance-with-scrollbar-expected.png: Filename too long --- Original change's description: > [CompositeAfterPaint] Rebaseline tests > > Most of these rebaselines are for the mock scrollbar change which missed > rebaselining for CAP. > > The other rebaselines are for new tests added for > virtual/controls-refresh. > > TBR=schenney@chromium.org > > Change-Id: Ia710bd0bf371eae8367c1ee3739691985f314840 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888572 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710590} TBR=wangxianzhu@chromium.org,schenney@chromium.org Change-Id: Ic072356ff05e5c738f9b830a3ac398d0d8cb4f73 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889710Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#710696}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c3a51a5e47ba..ebdae1144978 git log c3a51a5e47ba..ebdae1144978 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 95a736bd3347..bb35bb4e5379 (18 commits) Created with: gclient setdep -r src/third_party/skia@ebdae1144978 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: I48775ae792e27fcaf0e06fffcae1a5e6b3e85b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710695}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |SelfFragmentsOf()| for improving code health. Change-Id: Ic900ea5921307c92c59a96c9dfae5655a673a60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888624 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710694}
-
Michael Lippautz authored
MatchedPropertiesCache was the single user of custom weakness using HashTraits. Supporting custom weakness in hash tables is responsible for a lot of complications in the tracing protocol. MatchedPropertiesCache was using weakness to hold alive a cached entry as long as all of its matched properties are alive. Once a single matched property dies the entry was removed. This can be modeled using a custom weakness callback that performs the same logic. Cached entry don't have any outgoing edges except for their cached matched properties, so ephemeron semantic is not required. Using a custom weak callback is also faster because the callback is only executed once and not part of the ephemeron fixed point protocol. The cached entry is unlinked using the weak callback and collected on next GC cylce. After this conversion, custom weakness can be removed from hash traits. Weakness should always go through already supported types (e.g. WeakMember). Bug: 1019191 Change-Id: I52b7b24dcba8a3aaca896f86a351da665667fcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886611 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#710693}
-
Alan Cutter authored
This CL makes the contents separator line conditional on whether the browser window is for a PWA or not. This line was accidentally added to PWA windows by: https://chromium-review.googlesource.com/c/chromium/src/+/1845600 Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=418318&signed_aid=qDxxx-0Dy7v7DRzG1X2IKw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=418319&signed_aid=foBwMWJfjX_2Kp905p0F6Q==&inline=1 This issue seems to only affect Chrome OS as other platforms happen to position the separator line behind the web contents area: https://bugs.chromium.org/p/chromium/issues/attachment?aid=418333&signed_aid=Yca--FaV3JB8AIOY8YuyYA==&inline=1 Bug: 1012979 Change-Id: I0190e55862636354c63f6256bd55c2cf642db178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885147 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#710692}
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1788876. The spec validator requires `source_context_schema` to contain all supported source contexts, so this CL adds entries for `iframe-blank`, so that generators/validators successfully run. This CL keeps generated test files unchanged. Bug: 1001422 Change-Id: Ic49379a57503cd716badeb4655d64e2985e8916e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889477Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#710691}
-
Yoshifumi Inoue authored
This patch changes implementation of |LayoutReplaced| to utilie |NGInlineCursor| instead of |NGPaintFragment| for preperation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: I55de0f4c050fdd0883bd79bd4e695ee2a9e6aae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883452 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2cbe458ddd0e..76abb20f3770 git log 2cbe458ddd0e..76abb20f3770 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 gbiv@google.com afdo: allow merging of branch profiles; merge profiles by version Created with: gclient setdep -r src/third_party/chromite@76abb20f3770 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ifc472053cf1b11f035290953478cd9dc82d6af2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889434Reviewed-by:
-
Michael Lippautz authored
- Virtual Visit methods are always called through base class Visitor using Trace methods. There's no need to keep them in the header file. - Drive-by: Move inlined definitions out-of-line to allow skimming the class header more easily. - Only mark definition as inline as this is an implementation detail. Change-Id: I44993d515eb18498105b0e592e282fcd536c82ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884731Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710688}
-
Eric Willigers authored
The code in app_browser_controller.cc is within the web_app namespace, so qualifying names with 'web:app::' is redundant. Change-Id: I8852005ec93db644aa9034115d5f6dcafe2f9ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888238 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#710687}
-
Jason Lin authored
Bug: 951132 Test: Enable ChromeVox and open Crostini Installer from settings Change-Id: I703d77cc91177b048f5de0fafdee783611288f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885144Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#710686}
-
David Munro authored
Flag is currently disabled by default, if toggled on it means that enabling linux will install a Debian Buster container instead of a Debian Stretch one. Doesn't affect the default container you get if you start a new container via vmc container start. Bug: chromium:930901 Test: Enable Linux with flag set, cat /etc/os-release to confirm buster Change-Id: I40dea30b019e13301abf081696584162f6a1a7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883351 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#710685}
-
Darin Fisher authored
This is a precursor to defining ContentSettingsType via mojom. That change will require more work as Clank depends on an Java definition of this type that is auto-generated from content_settings_types.h. Change-Id: Ieec565c6332528e6fc5112ad04c675d9b6137f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885973Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710684}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb5cf40a8b13..a660eacc675c Created with: gclient setdep -r src-internal@a660eacc675c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie9d482705fae13118b66bfecf15f31ca1c12e82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889432Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710683}
-
Jinsuk Kim authored
The only caller of these methods is ChromeActivity class. This CL folds them into the call site. Bug: 995903 Change-Id: If11c291d8c366f173fbcb02e8dba5bb81dc5b29b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884397Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#710682}
-
Anand K. Mistry authored
SmbFs is a FUSE-based filesystem that provides access to SMB file shares. It will have similar capabilities to DriveFs, such as server-side copies, hence the need for a new filesystem type. Bug: 939235 Change-Id: Ibbc21a3211013259a715a9e07760d8050b7bda97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885850Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#710681}
-
Gavin Williams authored
-Creating a new ARIA specific string for the Browse button as the text already displayed next to the button($i18n{selectDriver}) would not make sense spoken out loud. Bug: 987087 Change-Id: I00a3d28672b0ffb85ddc00b49b605975b5e5b182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869478Reviewed-by:Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#710680}
-
Manas Verma authored
Logging the number of times an UpdateAutofillUserPreference call is made to payments with the intention to switch opt-in status. Bug: 949269 Change-Id: I97c4c907079b7d953b4fc0104ca093777a84dbfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867411 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#710679}
-
Yoshifumi Inoue authored
This patch changes |NGCaretPositionTest| to utilize |NGInlineCursor| instead of |NGPaintFragment| and |NGPhysicalTextFragment| for prepration of migrating to |NFragmentItem|. Bug: 982194 Change-Id: I0bba9a20e4ff9150d65632f5c30892c43cf54887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888622 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |InspectorCSSAgent::CollectPlatformFontsForLayoutObject()| to utilize |NGInlineCursor| for preparation of migration to |NGFragmentItem|. Bug: 982194 Change-Id: Id8550ce0d70def5b1eb1f7d442e0e97152cc7fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880360 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Alex Danilo authored
Adds support for showing an error indication marker on the summary panel when a display panel contains a mixture of progress panel items and error panel items. Enables a summary panel that shows an error indicator in the case where there are multiple error panel items hosted by the display panel but there are no progress panel items hosted. Adds unit test to cover these cases and implements a convenience function removeAllPanelItems() to clear out all panel items hosted in a display panel. Bug: 1014771 Tests: browser_tests --gtest_filter=FileManagerJsTest.FilesDisplayPanel Change-Id: I86047d47cb666f069cbe9260504f100d4a63e733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888233 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Shik Chen authored
The i18n process is changed after CCA is migrated as an component app, so update_locales.py is not used now. Bug: 1019581 Test: None Change-Id: Ieefd4ad9ac22df0254e3f3218faca0c0cf3b3b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888237Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#710675}
-
Alexey Baskakov authored
This code is disabled by default behind kDesktopPWAsWithoutExtensions and kDesktopPWAsUSS base features. A browser end-to-end tests will be added later in a follow up CL. An MVP implementation of the bridge+sync needed first. This is a reland of original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1858025 Patchset#1 is the original CL, rebased. The unit test fix: the offending EXPECT check was removed. TEST_F(WebAppIconGeneratorTest, GenerateIcons) { ... EXPECT_EQ(letter_color, icon_info.data.getColor(center_x, center_y)); ... } Will add it back later in a follow up CL. TBR=alancutter@chromium.org, mpearson@chromium.org Bug: 860583, 1019102 Change-Id: I1e3b514de303429ee774121f31d131139bb6a817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888234Reviewed-by:
-
Marina Sakai authored
In the previous CLs, we replaced all the old GetSymbol(), which uses void* as a key, with the new GetSybmol(), which uses an instance of SymbolKey. So, this CL removes the unused old GetSymbol(). Bug: 715418 Change-Id: I465370f55ed07632c6f4d00804733c3c49aaab43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888858Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marina Sakai <marinasakai@google.com> Cr-Commit-Position: refs/heads/master@{#710673}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1ae54bc22fc2..c3a51a5e47ba git log 1ae54bc22fc2..c3a51a5e47ba --date=short --no-merges --format='%ad %ae %s' 2019-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f8f6103eb89f..e1cda3916cee (2 commits) Created with: gclient setdep -r src/third_party/skia@c3a51a5e47ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: I7d87c7f2fddc0bf3e3b81fe5cf73f16ac0585eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889333Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/082b92e5..80c3ae49 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibd28b4f8e9b4f0f7da8f2f27ff37815c3adc87fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889014Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710671}
-
Keith Lee authored
Update files to prevent the following presubmit warning: ** Presubmit Warnings ** Found updated extension api files without updated extern files. Please update the extern files. /usr/local/google/home/keithlee/chromium/src/chrome/common/extensions/api/input_method_private.json *************** To update the externs, run: src/ $ python tools/json_schema_compiler/compiler.py /usr/local/google/home/keithlee/chromium/src/chrome/common/extensions/api/input_method_private.json --root=. --generator=externs > /usr/local/google/home/keithlee/chromium/src/third_party/closure_compiler/externs/input_method_private.js *************** Change-Id: I8ad20550dfe9acc233e4e437740739b7b1b744f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886137Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1e4dbf3f6432..27bd4e420d28 git log 1e4dbf3f6432..27bd4e420d28 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 ukai@google.com Reland "put goma client in depot_tools" Created with: gclient setdep -r src/third_party/depot_tools@27bd4e420d28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:b/77663154 Change-Id: Ife9346d3e73348136114531bc1bc29475a5b0ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889331Reviewed-by:
-
Adam Rice authored
KURL::SetHostAndPort would corrupt IPv6 literals because they contain ":" characters. Make it check for "[]" characters and use the first ":" after an IPv6 address as the start of the port number if one is present. Fixed: 1012416 Change-Id: If07a671b48c8c1b24b16883fb9072a86b0de7ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871449Reviewed-by:
-
Wei Lee authored
chromeosInfoPrivate API We already have the prod key of Chrome Camera App in the whitelist and we also need to add the dev key into it so that the behaviors of prod version and dev version would be identical. Bug: 1019094 Test: None Change-Id: I58921b49c21579db41ebed39bb182443efa84368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886140 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#710667}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6c3f862e2a3..87a7b82520b8 git log c6c3f862e2a3..87a7b82520b8 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 peah@webrtc.org Refactoring of the noise suppressor and adding true multichannel support Created with: gclient setdep -r src/third_party/webrtc@87a7b82520b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/143344262 Change-Id: Ieefc70f1d6fab0e5c8e8698eeb92d57f9f616851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889301Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bc1a479a7027..2cbe458ddd0e git log bc1a479a7027..2cbe458ddd0e --date=short --no-merges --format='%ad %ae %s' 2019-10-30 andrewlamb@chromium.org Include ReplicationConfig in chromite protos. Created with: gclient setdep -r src/third_party/chromite@2cbe458ddd0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I20ab952c6dcb1d78cf034b26a7d660b3489a5dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889302Reviewed-by:
-
Peter Kasting authored
Also replaces bare new with make_unique. Bug: 82078 Change-Id: I2c189d65fab3cee98297f32aa1454ac0f4555453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881942 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Chris Harrelson authored
This was broken due to a subtle bug introduced the original CL (*). The only field on AncestorInfo which was accessed before it was set for a PaintLayer is last_overflow_clip_layer. This was used for invalidation logic regarding sticky-positioned elements. It's necessary for last_overflow_clip_layer to be the last overflow clip layer seen *before* considering the current PaintLayer. Hence it should not be updated in ApplyAncestorInfoToSelfAndAncestorsRecursively for a compositing inputs root that is not the root, for the PaintLayer that is not the CompositingInputsRoot. (*) https://chromium-review.googlesource.com/c/chromium/src/+/1432155 Test: fast/css/containment/compositing-inputs-root-sticky-crash.html Bug: 986008 Change-Id: I79c84c01999ebe483440fdc3cac277a7f5eb226c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857372 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710663}
-
