GitLab

permission_types.h should own the helper method used for generating a
vector of all PermissionTypes. This is done dynamically to reduce
the burden of updating this list. It is stored in a static container
so that it can be lazily generated as needed. Additionally, use of
dynamic memory guarantees uncomplicated destruction while static
storage does not consider this a "leak".

Bug: 986605
Change-Id: I7bcaafe9cf94d31a3ae796c97f754da643e3c572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716946Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681298}

This CL creates a new virtual suite that runs web tests with the audio
service running on a sandboxed utility process.
It also adds expectations for audio-related tests already in expectations
files.

Bug: 976696
Change-Id: Ia25ff740fb4735db0d3ae4ea9d08787e6818da5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715811
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681297}

Early conversion to double resulted in DocumentTimeline returning a
different value than the requestAnimationFrame timestamp. By preserving
the full precision time delta we can use the exact same conversion as
the requestAnimationFrame timestamp.

Bug: 986974
Change-Id: I508330a168bf6523b1ec3912efb24159b876f6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719853
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681296}

This reverts commit 69b9b238.

Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1719859 depends on this cl.

Original change's description:
> Implement GetCurrentFramebufferDamage().
> 
> GLOutputSurfaceBufferQueue::GetCurrentFramebufferDamage() didn't get
> implemented in https://crrev.com/c/1685909. This caused some interesting
> graphics glitches with OOP-D enabled.
> 
> Bug: none
> Change-Id: Idb0d8e43c36e5f925f4c475a2010660b10c48f97
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702147
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#677458}

TBR=dcastagna@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: none
Change-Id: I56334ee6d3d261dfd5b84d8fa5b8e337770b3792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720909Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681295}

In this CL I've conditionally disabled new DCHECKs added
in crrev.com/c/1593403. Although the outline updates
should be safe, we should still fix this properly
and enable these DCHECKS universally.

Bug: 987836
Change-Id: I04d4e79652c2556ca058cb959b859c03a9415d10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719772Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681294}

Fixing a variable typo and adding
SigninPromoViewMediatorTest::AddDefaultIdentity().
Related to: crrev.com/c/1718370

Change-Id: I4532e824b5ab540a7d42eaaaeb271e52e16200cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717303
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681293}

On iOS 13, fallback colors aren't used anymore.
Changes iOS 12 selected text color to the new one.

Bug: 987174
Change-Id: Iab24298207babfdd306516a23dd9c51b8fc9c46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719354
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681292}

This CL triggers the unmasking dialog when a user in the Manual
Fallback dialog selects a masked server card, and uses the results to
populate the field in the form.

Change-Id: I350cde87eb412ab709c4eca589e62ed3429ef920
Bug: 969194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686674
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#681291}

Build with GCC and libstdc++ is failing in files using tab_sharing_ui.h
as it has a ScopedObserver of a TabStripModel without including it
in advance.

Bug: 819294
Change-Id: I4b12073484f65ad2bb873119daa748245296d282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713526Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#681290}

MDC font was defaulting to system font of size 14, this is kept the
same. But for some reason the font they returned couldn't be recreated
with a semibold trait. So it was switched to a normal system font of
the same size.

Fix a bug when a tab was instantiated without being selected. This
was caused by creating the views after they were being styled.

An early return to the |selected| setter was added to simplify that
method.

Bug: 987169, 976817
Change-Id: I10c97a5a8a6f155f0aac21a7f2bf5ab16ded56a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718949
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681289}

Allowing testers to setup responses with a byte array body
instead of a String body is important because it reflects
the true range of values that can be returned in the body of
a response.

Bug: 669707
Change-Id: I96f385bde0aa592caf60eee763bd26d0ccd2eba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715173
Commit-Queue: Benjamin Kirchman <kirchman@google.com>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681288}

... from modules/mediastream/video_track_adapter_settings.h

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ifd92202da1df04bbd49ceec13865e7c38f546c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715884
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681287}

https://android.googlesource.com/platform/external/perfetto.git/+log/b3891c1e6e90..d7e4835d4345


git log b3891c1e6e90..d7e4835d4345 --date=short --no-merges --format='%ad %ae %s'
2019-07-26 treehugger-gerrit@google.com Merge "traced_probes: ftrace page header parsing: turn "overwrite_count" into a bool that it effectively is"


Created with:
  gclient setdep -r src/third_party/perfetto@d7e4835d4345

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I4112e8fa24296d8d993eccdce24d80382917abc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720731Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681286}

Replaces the "$1" in the About page EOL string with the device type.

Bug: 987877
Change-Id: I79be75919f623961abb5e3f8aeab114b9c8afecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719932
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681285}

Neither wallpaper nor account image can be changed in guest mode,
so hide the entire "Personalization" section.

However, ensure the "Appearance" section is still visible in browser
settings, since font size can still be changed.

Screenshots:
- OS settings - http://screen/U7f46skHwXw
- Browser settings - http://screen/kAEEMMpYML7

Bug: 972152
Change-Id: I95196b506a155d98fb8315ab302e9dc5f847e1a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719468Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681284}

Change GN output directory to start with out/, since the other way is
not recommended, leading to confused presubmit in some cases.

Bug: None
Change-Id: I645d9e2bd8f41dc2836492f6d1d58a8aaeab7e4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718969Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Auto-Submit: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681283}

Also clean up some of the platform conditions.

Bug: 987970
Change-Id: Ie15353400163599dc97bc15c2658650c8d1c0ca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720636
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681282}

This CL adds 'EffectiveAppearance' field, which
stores a value same as 'Appearance' at this moment, and makes
'Appearance()' and 'HasAppearance()' private.

'EffectiveAppearance' is set in LayoutTheme::AdjustStyle().
Rendering code in Blink should refer to 'EffectiveAppearance'
instead of 'Appearance'.

This CL also reduces the size of the Appearance field from
6 bits to 5 bits. crrev.com/641985 reduced the number of
ControlPart items from 42 to 25.

The plan is that 'Appearance' field stores computed-value of
-webkit-appearance, and 'EffectiveAppearance' will store
used-value.

This CL has no behavior changes.

Bug: 965432, 981720
Change-Id: Ifee508c1c8d9fd7f721f0fcc1c4c5c0a52d244c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687573Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681281}

The following methods had no callers and are beng removed
by this CL:

- GetConstraintMinAsDouble()
- GetConstraintMaxAsDouble()
- GetConstraintValueAsString()

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I010896801978cce6b03dd6020ef9556708124d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715408
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681280}

Implements a pref that represents the onboarding experience state.
It is updated every time a new PasswordStore instance is built.
The number of saved credentials is used as a condition for showing the onboarding,
as well as the current state itself.

Bug: 983445
Change-Id: I5ddf0869843bc71f84db4cb04c3b95fcd530bb65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708074
Commit-Queue: Andrei Chulkov <achulkov@google.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681279}

https://webrtc.googlesource.com/src.git/+log/d7ab56d4c20c..378cae2543f5


git log d7ab56d4c20c..378cae2543f5 --date=short --no-merges --format='%ad %ae %s'
2019-07-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b6340b51..94041439 (681123:681228)


Created with:
  gclient setdep -r src/third_party/webrtc@378cae2543f5

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Id38822f1945937705d2b887e6ea435be2a87665d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720729Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681278}

I'm working on a more reliable method to upload files for another project,
and was looking into using that in the DownloadFeedbackService as well.
I expect these metrics to be important if that pans out, so extend the
lifetime of these metrics by a little bit.

Bug: 969929
Change-Id: I1d26b502ad76cf4aa753344a19b0bd2e96c83a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719653
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681277}

This method (from media_stream_constraints_util.cc|h) is used only
within media_stream_constraints_util_audio.cc.
This CL moves it to the anonymous namespace in this file.

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Idde550276ce75c12e8e2ddc203b1d889ae1588b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715665
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681276}

The class has not references left in content/, and can move
moved out of the Blink exposed API as long as forward refenrences
are used in processed_local_audio_source.h.

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I6d9d9370aa8c0ea3aa6b23923919896de12d9d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715664
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681275}

This is a follow up of [1].

[1] https://crrev.com/c/1710237

BUG=704136,923394
R=guidou@chromium.org

Change-Id: I34829b50b263f47cd8d4b6fc9b41df60b57ede0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715164
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681274}

This removes the global defines

    FULL_SAFE_BROWSING
    SAFE_BROWSING_CSD
    SAFE_BROWSING_DB_LOCAL
    SAFE_BROWSING_DB_REMOTE

and moves them to the buildflag system instead. They live in the
new (generated) buildflag header components/safe_browsing/buildflags.h
which is generated by //components/safe_browsing:buildflags.

No behavior change.

Bug: 961767
Change-Id: Ifdc78c21ef4c2e2ab8fc9f48461734a559794333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719289Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681273}

This CL makes sure that the Kerberos system daemon is not started
unnecessarily if there are no Kerberos accounts.

BUG=chromium:963824
TEST=Log into Chromebook with enabled KerberosEnabled policy, but no
     existing accounts (neither through KerberosAccounts policy nor
     added manually). Open ssh console (e.g. CTRL + ALT + -->), verify
     that 'ps -A | grep kerberos' does not show a Kerberos process.

Change-Id: I6b8b4cfd1f50a6b9abc97b8b72fa322fdb83cfc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720770Reviewed-by: A Olsen <olsen@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681272}

This CL is large because it moves various files in
content/renderer/media/{stream,webrtc} to blink.
These files are being moved in one step here because it'd not
be easy to do it incrementally, as of other prior steps.

The following files got moved:

  - content/renderer/media/stream/audio_service_audio_processor_proxy.h
  - content/renderer/media/stream/media_stream_audio_processor.h =>
    third_party/blink/public/platform/modules/mediastream/

  - content/renderer/media/stream/media_stream_constraints_util_audio.h
  - content/renderer/media/stream/processed_local_audio_source.h =>
    third_party/blink/public/web/modules/mediastream/

  - content/renderer/media/webrtc_audio_device_impl.h
  - content/renderer/media/webrtc_audio_device_not_impl.h =>
    third_party/blink/public/web/modules/webrtc/

  - content/renderer/media/stream/media_stream_constraints_util_audio.cc
  - content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
  - content/renderer/media/stream/processed_local_audio_source.cc =>
    third_party/blink/renderer/modules/mediastream/

  - content/renderer/media/webrtc_audio_device_impl.cc
  - content/renderer/media/webrtc_audio_device_not_impl.cc =>
    third_party/blink/renderer/modules/webrtc/

  - content/renderer/media/stream/aec_dump_agent_impl.cc
  - content/renderer/media/stream/aec_dump_agent_impl.h =>
    third_party/blink/renderer/platform/mediastream/

  - content/renderer/media/stream/audio_service_audio_processor_proxy.cc
  - content/renderer/media/stream/media_stream_audio_processor.cc =>
    third_party/blink/renderer/platform/exported/mediastream/

Remarks:

1) Most of the changes in this CL are straightforward, eg namespace or path inclusion
  adaptation, add/replacing "bridge" blink::Platform methods, etc. However, one change
  might deserve some reasoning.

  aec_dump_agent_impl.cc|h: The class AecDumpAgentImpl inherits from mojom::AecDumpAgent.
  However, in order to do this, we would need to include aec_dump.mojom.h, which is not
  allowed for Blink API headers - instead aec_dump.mojom-shared.h is enforced.

  To avoid including aec_dump.mojom.h from a (temporary) blink API headers, the CL factors
  out the "Delegate" inner class out of AecDumpAgentImpl into its own header, and make it
  part of the blink API (aec_dump_agent_impl_delegate.h).
  aec_dump_agent_impl.cc|h got moved to blink/renderer/platform, and include
  aec_dump.mojom-blink.h without problems.

2) The following tests got blink::TestingPlatform derived classes
  added locally, in order to implement the needed factories:

  - content/renderer/media/webrtc/rtc_peer_connection_handler_unittest.cc
  - content/renderer/media/stream/processed_local_audio_source_unittest.cc
  - third_party/blink/renderer/modules/mediastrea/media_stream_constraints_util_audio_test.cc

  By the time the first two files above get moved to Blink, the files should
  share the same derived blink::TestingPlatform implementation, factored out into a helper.
  TODO added.

3) Data types and APIs that are not allowed in Blink, eg base::Bind{Once,Repeating}.
  std::vector and std::string were forcibly allowed at this stage, and will be remove
  in a follow up.
  TODO added.

4) Most of the APIs added as public blink APIs here will eventually get moved again to
  blink/renderer/platform or blink/renderer/modules. It is just a matter of its existing
  clients in //content get Onion souped.
  TODOs added.

BUG=704136

Change-Id: I7799c94a441c49ade6f19518879b1ee0e5d37882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710237
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681271}

Using wpt-import in Chromium 8d139660.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"
f050694a "Restrict Shape Detection API to Secure Contexts"
14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-writing-modes

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id455468aad80c389018c4d62aa90aff902db6723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719113Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681270}

This reverts commit 6df45451.

Reason for revert: Reverting the revert might "fix" the test now that the failures are expected after a new wpt roll:
https://crrev.com/219a669145c403c99e3d7f441abbaad0e5d23a90/third_party/blink/web_tests/platform/win7/virtual/scalefactor200withoutzoom/external/wpt/largest-contentful-paint/observe-after-untrusted-scroll-expected.txt

Original change's description:
> Revert "[LargestContentfulPaint] Set startTime"
> 
> This reverts commit 58051e42.
> 
> Reason for revert: Most suspicious CL for failing paint-related test
> failures as mentioned in the linked bug.
> 
> Bug: 987915
> 
> Original change's description:
> > [LargestContentfulPaint] Set startTime
> > 
> > Currently startTime is 0, which is a problem because getEntries()
> > methods all sort by startTime. To help with this problem, we set the
> > startTime to renderTime, if available, or to loadTime, if renderTime is
> > nt available.
> > 
> > Bug: 965505
> > Change-Id: Ie70b69269f7ce4be0fdc94f33a44a84e062d3ba5
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719379
> > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#681147}
> 
> TBR=npm@chromium.org,yoavweiss@chromium.org
> 
> Change-Id: Ie810b8a3ac88369ab73a66670865f462f590e1ec
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 965505
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719351
> Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681224}

TBR=npm@chromium.org,fhorschig@chromium.org,yoavweiss@chromium.org

Change-Id: I02478f0c560c64268593c3a9df158b4e505f4667
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 987915, 965505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720811Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681269}

It can happen that the fallback cursor mode DCHECK
can trip during tests. With this CL, we simply
early out if we attempt to toggle when the feature
is not enabled.

TBR=bokan

Bug: 987353
Change-Id: I6ebbcfa56e36c03f6d23b4d07cd1412821800605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720150Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681268}

While this does rename some symbols and APIs, it
does not change externally-exposed values (e.g. preferences
or policies), which may require coordination with Enterprise
to avoid breaking anyone.

Adopt more inclusive language in //net, by deprecating the
terms whitelist and blacklist into more descriptive terms,
such as allowlist and blocklist.

TBR=torne@chromium.org, dgozman@chromium.org, bnc@chromium.org

Bug: 987648, 981129
Change-Id: Id558d29e0049af7e110dbb0528ac9d511e4620ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718348Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681267}

This CL renames mojo to mojom and *_struct_traits.* to
*_mojom_traits.* in //ui/gfx/geometry.

*_struct_traits.* => *_mojom_traits.*
ui/gfx/geometry/mojo => ui/gfx/geometry/mojom

Bug: 806965
Change-Id: I288f4019f88815ac92fc2f038676e7459ea01bd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717541
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681266}

From now on every policy needs an owner that is either a list of emails.
Preferably two or more or a OWNERS file reference.

BUG=976215
TEST=Presumbit checks pass.

Change-Id: I8af34ae50f79f0854714ab161844b87dab6010dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713516
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681265}

Adds documentation about the Chrome OS Active Directory integration
as well as the SAML flow during Chrome OS sign-in.

TBR=rsorokin@chromium.org, antrim@chromium.org

BUG=None
TEST=None

Change-Id: I54ba5ff0eac4de0aa687949b7567824a98089edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615025
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681264}

Change-Id: If6d6c9d897243e89124dad942d655b690f5b840d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720243
Auto-Submit: Max Morin <maxmorin@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681263}

When a Window Agent is created it will create a unique token. This token
will be shared with workers and worklets that will be in the same agent
cluster. ie. The Agent Cluster is represented as the Agents having the
same UnguessableToken.

BUG=798572

Change-Id: Iccc50113865a2bddd983ce4044852646cbbc658d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718790Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681262}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/180f6291f9c9..424fc331f3be


Created with:
  gclient setdep -r src-internal@424fc331f3be

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None
Change-Id: I9ef024b1374d6d27fe1abfc24af12559934ea10f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720304Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681261}

In some cases we want Skia to believe that we have GL Version different
from what is returned by glGetString(GL_VERSION). This CL removes
inconsistencies (which lead to failure to allocate GrContext) between
version stored in GLVersionInfo and version strings we pass to Skia.
One such case was when the "disable_es3_gl_context_for_testing" flag
is being used (see crrev.com/c/1419340 for details about flag).

Bug: 984110

Change-Id: Ie15680237a63e58e8e0fdbddf11698a5fd4adf36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716063
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681260}

Updates the copy for the sync help text if there are no devices to
choose from.

Bug: 987596
Change-Id: I96b0224d7a29fe2598e44c16ee512a91bd848b23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719012Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681259}