GitLab

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/582169b..65c5e7b

BUG=563852

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2339603004
Cr-Commit-Position: refs/heads/master@{#418693}

Add some performance metrics for the MD and non-MD extensions pages so
we can begin gathering data. To start, use the signals for
DocumentLoadedInFrame() for the main frame and
DocumentOnLoadCompletedInMainFrame().

BUG=529395

Review-Url: https://codereview.chromium.org/2341553002
Cr-Commit-Position: refs/heads/master@{#418692}

This implements:

- allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Review-Url: https://codereview.chromium.org/2259903002
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Commit-Position: refs/heads/master@{#418691}

Also make sure that we remember the color space even if the compositor has not
been created yet.

BUG=622133

Review-Url: https://codereview.chromium.org/2307083003
Cr-Commit-Position: refs/heads/master@{#418690}

Instead of only listing the number of nearby Physical Web URLs, also include
the page title of the top URL. The title will be truncated if it is too long
to fit in the omnibox popup.

BUG=630769

Review-Url: https://codereview.chromium.org/2319033006
Cr-Commit-Position: refs/heads/master@{#418689}

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2339583002
Cr-Commit-Position: refs/heads/master@{#418688}

*PERF SHERRIF: this CL intentionally regressions dummy_benchmark.stable_benchmark_1 for bisect FYI.
We are doing this to refresh the revision ranges used by bisect FYI jobs.

BUG=646628
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2337323002
Cr-Commit-Position: refs/heads/master@{#418687}

Revert of Moving CRD Windows targets to subdirectories. (patchset #4 id:770001 of https://codereview.chromium.org/2308813002/ )

Reason for revert:
https://build.chromium.org/p/chromium/builders/Win/builds/47116/
FAILED: obj/remoting/host/win/remoting_core/chromoting_lib.res
C:/b/depot_tools/python276_bin/python.exe ...
../../remoting/host/win/chromoting_lib.rc(5) : error RC2135 : file not found: remoting/host/chromoting_lib.tlb

Original issue's description:
> Moving CRD Windows targets to subdirectories.
>
> This is the windows host focused GN rewrite for Remoting Host. This
> work attempts to simplify the build for Remoting so it can be more
> easily understood and maintained. This is done by pushing more of the target config checking deeper into the platform specific targets and
> producing build files that are more in-line with best-practice GN style.
>
> Committed: https://crrev.com/ac59f3fd88f185f04e1cd177fcc2d05a425308e6
> Cr-Commit-Position: refs/heads/master@{#418668}

TBR=zijiehe@chromium.org,joedow@chromium.org,brettw@chromium.org,nicholss@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2339163004
Cr-Commit-Position: refs/heads/master@{#418686}

Do not collapse top/bottom margins if there is a padding or border between
first/last in-flow child and its parent.
W3C spec: https://www.w3.org/TR/CSS2/box.html#collapsing-margins

BUG=635619

Review-Url: https://codereview.chromium.org/2346473003
Cr-Commit-Position: refs/heads/master@{#418685}

CodeMirror.refresh is expensive, and calling it when CodeMirror is hidden breaks the gutters.

BUG=none

Review-Url: https://codereview.chromium.org/2342643002
Cr-Commit-Position: refs/heads/master@{#418684}

With a comment that if you're doing something beyond add/remove of
files you should get an owner.

BUG=none
TEST=none
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2338403002
Cr-Commit-Position: refs/heads/master@{#418683}

sessions timeout with open streams.

Review-Url: https://codereview.chromium.org/2322423002
Cr-Commit-Position: refs/heads/master@{#418682}

Update defaultConsoleRowHeight to account for the 1px border, and grow a visible
item instead of an offscreen one when testing setStickToBottom.

See bug for detailed analysis.

BUG=624534

Review-Url: https://codereview.chromium.org/2317343006
Cr-Commit-Position: refs/heads/master@{#418681}

BUG=646977

Review-Url: https://codereview.chromium.org/2343683002
Cr-Commit-Position: refs/heads/master@{#418680}

We use a sync channel on other platforms to facilitate synchronous
shared buffer creation from within a sandbox. We need to do this
on Windows too.

This implements that, and adds a test for sandboxed shared buffer
creation.

BUG=594883

Review-Url: https://codereview.chromium.org/2264543003
Cr-Commit-Position: refs/heads/master@{#418679}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/798d1e3c..06fda3c9

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2338393002
Cr-Commit-Position: refs/heads/master@{#418678}

This CL fixes crash when multiply JS requests to show Login screen are
generated.

BUG=645625
TEST=none

Review-Url: https://codereview.chromium.org/2334223007
Cr-Commit-Position: refs/heads/master@{#418677}

This takes the implementation from the notification center
(used for downloads) and moves it into views::. The color
is updated as per sgabriel's orders to Blue 500, a default
height of 5 is applied (shared in app list and notification
center) but lesser heights are also permitted. If the height
is small enough, we don't round the corners, which is exactly
what we'll want for the cros detail views.

The base views::ProgressBar class was not used on its own anywhere,
and it had a lot of code that wasn't used either. All the progress
bar classes are consolidated into a single class and unused code
is culled.

BUG=626846

Review-Url: https://codereview.chromium.org/2329633003
Cr-Commit-Position: refs/heads/master@{#418676}

Includes Mac build fixes and Win alignment warnings fix.

TBR=thakis@chromium.org
BUG=630728

Review-Url: https://codereview.chromium.org/2341863002
Cr-Commit-Position: refs/heads/master@{#418675}

BUG=646443

Review-Url: https://codereview.chromium.org/2340063003
Cr-Commit-Position: refs/heads/master@{#418674}

Signin Error Dialog:

Part of the desktop user menu revamp project is to migrate signin error
surfacing from user menu's tutorial card to a tab modal dialog, and thus
completing the flow of signin modal -> sync confirmation modal dialog or
signin error modal dialog.

Particularly, this CL adds the code for appropriately constructing and
handling the dialog.

DO NOT LAND until after the first CL lands
(https://codereview.chromium.org/2274013002/).

Design doc:
https://docs.google.com/document/d/17yHrKd_EU6WoIAgljnZmNCSJLRlbM3O2Pxr7aPEnqik/edit?ts=57445a70#heading=h.9vm5owqqt3w1

BUG=630523
BUG=615893

Review-Url: https://codereview.chromium.org/2315393002
Cr-Commit-Position: refs/heads/master@{#418673}

This resolves "ninja explain" failures after:
https://chromium.googlesource.com/chromium/src/+/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643

e.g.
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/297782
ninja explain: restat of output gen/extensions/extensions_renderer_resources_stamp.d.stamp older than most recent input /b/c/b/linux/src/out/Release/gen/mojo/common/common_custom_types.mojom.js (0 vs 1473884135)

BUG=629375
TBR=btolsch@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2338993003
Cr-Commit-Position: refs/heads/master@{#418672}

BUG=634443

Review-Url: https://codereview.chromium.org/2341803002
Cr-Commit-Position: refs/heads/master@{#418671}

Also refactor/limit some functions to make it more obvious how they are
used (and how they are not). For example, previously you could ask for
a VPN or ethernet image for use on the tray, but this never actually
happened. We don't want to add tray icons for these types (particularly
now that they're a different size from the menu icons).

BUG=606817

Review-Url: https://codereview.chromium.org/2338103002
Cr-Commit-Position: refs/heads/master@{#418670}

RTCVideoDecoder::ResetInternal() forgot to lock it, which caused TSan
errors in the unittest.

Review-Url: https://codereview.chromium.org/2339043002
Cr-Commit-Position: refs/heads/master@{#418669}

This is the windows host focused GN rewrite for Remoting Host. This
work attempts to simplify the build for Remoting so it can be more
easily understood and maintained. This is done by pushing more of the target config checking deeper into the platform specific targets and
producing build files that are more in-line with best-practice GN style.

Review-Url: https://codereview.chromium.org/2308813002
Cr-Commit-Position: refs/heads/master@{#418668}

MostVisitedSitesBridge can handle conversion between int and the enum
for the sake of Java. Using the enum itself is better for iOS, and
generally as an interface.

Review-Url: https://codereview.chromium.org/2332353006
Cr-Commit-Position: refs/heads/master@{#418667}

Move SwapPromise tracking to SwapPromiseManager and SurfaceSequnce
creation to SurfaceSequenceGenerator.

BUG=625283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2323423002
Cr-Commit-Position: refs/heads/master@{#418666}

BUG=643239
TEST=manual(UI),autotest(extension API),browsertest(policy)

Review-Url: https://codereview.chromium.org/2306673002
Cr-Commit-Position: refs/heads/master@{#418665}

* Replace sparse histogram recording ALPN/NPN usage and whether there was
  overlap or fallback in case of NPN with a new histogram with much fewer
  values.  This was made possible by NPN being disabled.
* New histogram is recorded with all TLS handshakes, telling us what
  percentage of total TLS connections use HTTP/2.  (The old histogram was only
  recorded when either NPN or ALPN was used, depriving us of this piece of
  information.)
* Remove fixed values from enum NextProto; remove commented out historical
  values.  Note that git cl format puts the new enum on a single line.

BUG=526713

Review-Url: https://codereview.chromium.org/2243453002
Cr-Commit-Position: refs/heads/master@{#418664}

As is, the 'chrome' target depends on libsecret, which
explicitly depends on glib.
In case of use_ozone=true builds, though, use_glib is
set to false.

CL fixes it by not building libsecret dependant files
when use_ozone is true.

Review-Url: https://codereview.chromium.org/2341773004
Cr-Commit-Position: refs/heads/master@{#418663}

This patch ensures we don't process tiles for solid color analysis
many times. This wasn't as much of an issue before we separated raster
and decode images, since we'd only process a tile once. Now, we can
visit tiles more than once.

This shows pretty significant gains on perftests.
Before:
*RESULT prepare_tiles: 2_100= 2236.82763671875 runs/s
*RESULT prepare_tiles: 2_500= 8168.21533203125 runs/s
*RESULT prepare_tiles: 2_1000= 10103.5654296875 runs/s
*RESULT prepare_tiles: 10_100= 8856.08984375 runs/s
*RESULT prepare_tiles: 10_500= 8581.669921875 runs/s
*RESULT prepare_tiles: 10_1000= 8932.677734375 runs/s
*RESULT prepare_tiles: 50_100= 3708.318359375 runs/s
*RESULT prepare_tiles: 50_500= 3758.5810546875 runs/s
*RESULT prepare_tiles: 50_1000= 3686.30078125 runs/s

After:
*RESULT prepare_tiles: 2_100= 9835.1611328125 runs/s
*RESULT prepare_tiles: 2_500= 20325.25390625 runs/s
*RESULT prepare_tiles: 2_1000= 21301.900390625 runs/s
*RESULT prepare_tiles: 10_100= 16529.826171875 runs/s
*RESULT prepare_tiles: 10_500= 16585.15625 runs/s
*RESULT prepare_tiles: 10_1000= 16813.125 runs/s
*RESULT prepare_tiles: 50_100= 4764.2998046875 runs/s
*RESULT prepare_tiles: 50_500= 4804.51220703125 runs/s
*RESULT prepare_tiles: 50_1000= 4789.98486328125 runs/s

However, I'll also be changing the tests to actually reset this state
when I change the perftests to test specific scenarios.

R=enne
BUG=645569
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2334003007
Cr-Commit-Position: refs/heads/master@{#418662}

TBR=achuith@chromium.org
BUG=646965

Review-Url: https://codereview.chromium.org/2341833003
Cr-Commit-Position: refs/heads/master@{#418661}

Component builds are, by definition, not optimized for maximum
performance. So incremental linking - which trades a little bit of
performance for much faster build times - is appropriate in release
component builds, as well as in debug builds.

This change enables incremental linking in release component builds.
This also requires turning off /OPT:ICF and /PROFILE in component
builds because they are incompatible with /incremental, but they are
performance related flags so they are also not important for component
builds.

blink_core.dll cannot be incrementally linked in debug x64 component
builds, but it *can* be incrementally linked in release x64 component
builds (and debug/release x86 component builds), and this change
enables incremental linking of blink_core.dll in all supported
configurations.

This drops the chrome rebuild time after touching
third_party\WebKit\Source\core\html\AutoplayExperimentHelper.cpp from
~260 seconds to 9 seconds. The chrome rebuild time after touching
base\win\registry.cc drops from ~200 seconds to less than 2 seconds,
with 21 of 24 link steps skipped entirely.

This also fixes some /INCREMENTAL /OPT:ICF mismatch warnings.

BUG=608801,621236

Review-Url: https://codereview.chromium.org/2331373006
Cr-Commit-Position: refs/heads/master@{#418660}

There is a crash which happens when AutoplayUmaHelper receives unload
event from window, but m_element is already garbage collected. This CL
fixes this crash by making Element as a Member of AutoplayerUmaHelper.

BUG=646890
R=avayvod@chromium.org,mlamouri@chromium.org

Review-Url: https://codereview.chromium.org/2341783002
Cr-Commit-Position: refs/heads/master@{#418659}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6a1c97a..582169b

BUG=634525

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2335113002
Cr-Commit-Position: refs/heads/master@{#418658}

The change is desirable because:

- Ref-counting doesn't result in memory safety here, because
  ExternalMemoryAllocator wraps a raw pointer to short-lived
  memory.  Ref-counting cannot extend the lifetime of the
  memory this pointer points to.

- No consumers of SkBitmap::Allocator currently use ref-counting.
  If SkBitmap::Allocator was designed today, it probably wouldn't
  use SkRefCnt as a base class.

- Blink-to-Chromium style conversion will rename |ref| to |Ref| in WTF,
  but won't do it outside of Blink/WTF (e.g. in Skia), so RefPtr should
  only be used with Blink/WTF types going forward (i.e. Skia types
  should be wrapped in smart pointers provided by Skia).

More discussion is in an older code review:
https://codereview.chromium.org/1880993003/#msg10

BUG=641014

Review-Url: https://codereview.chromium.org/2326473005
Cr-Commit-Position: refs/heads/master@{#418657}

BUG=513459

Review-Url: https://codereview.chromium.org/2340603002
Cr-Commit-Position: refs/heads/master@{#418656}

BUG=619037

Review-Url: https://codereview.chromium.org/2341773003
Cr-Commit-Position: refs/heads/master@{#418655}

This removes all .gyp files not called "compiled_resources" in the main Chromium repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2332843004
Cr-Commit-Position: refs/heads/master@{#418654}