GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271958 0039d316-1c4b-4281-b951-d872f2087c98

TEST=manual: Force a reset (manually edit a protected pref).
Expect to see reset UI in chrome://settings,
dismiss it, restart Chrome, expect no reset UI.
BUG=374360

Review URL: https://codereview.chromium.org/294123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271957 0039d316-1c4b-4281-b951-d872f2087c98

Broke gclient runhooks on Linux ChromiumOS Builder on Blink waterfall.
Bugs 119020 and 236611 will be updated with details.

> Roll FFmpeg for M37.
> 
> Syncs to head as of bebce653e5601ceafa004db0eb6b2c7d4d16f0c0.  The
> roll requires us to stop using some deprecated features:
> - Replaces av_get_frame_defaults() with av_frame_unref() per docs.
> - Switches FFmpegVideoDecoder to use ref-counted frames.
> - Removes error concealment settings and disables error resilience
> for all platforms except ChromeOS (since it's required for mpeg4).
> 
> Avoiding these also allows us to disable some deprecated features
> wholesale via #defines.
> 
> BUG=119020,236611
> TEST=all tests (and regression tests) pass under asan
> NOTRY=true
> R=jrummell@chromium.org, wolenetz@chromium.org
> 
> Review URL: https://codereview.chromium.org/286953005

TBR=dalecurtis@google.com

Review URL: https://codereview.chromium.org/296483012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271956 0039d316-1c4b-4281-b951-d872f2087c98

Changes from the first submit:
- Submit a binary image file separately by dcommit in advance

Original description:
On Android, permission infobar appears for Web MIDI permission,
but correct icon is not used. This change add a proper icon.

BUG=339767

Review URL: https://codereview.chromium.org/292743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271955 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375853
TEST=This is test. Ran tests manually.

Review URL: https://codereview.chromium.org/288263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271954 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271953 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271952 0039d316-1c4b-4281-b951-d872f2087c98

These are disabled currently in the Android ARM GYP build. This patch disables it for all ARM builds since the warning appears when cross-compiling to ARM on Linux without Android (this isn't something people normally compile, so probably nobody noticed).

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/299663014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271951 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174386:174434&mode=html
TBR=
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/294153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271950 0039d316-1c4b-4281-b951-d872f2087c98

Most code uses PLOG with the same effect.

TBR=bradchen
NOTRY=true

Review URL: https://codereview.chromium.org/281223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374942

Review URL: https://codereview.chromium.org/295803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:399

All of the code reviews for this patch were written against https://codereview.chromium.org/251933005/ . I used the wrong email address to create said patch, so I have created this one with the correct email address.

Review URL: https://codereview.chromium.org/288193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271947 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271946 0039d316-1c4b-4281-b951-d872f2087c98

Syncs to head as of bebce653e5601ceafa004db0eb6b2c7d4d16f0c0.  The
roll requires us to stop using some deprecated features:
- Replaces av_get_frame_defaults() with av_frame_unref() per docs.
- Switches FFmpegVideoDecoder to use ref-counted frames.
- Removes error concealment settings and disables error resilience
for all platforms except ChromeOS (since it's required for mpeg4).

Avoiding these also allows us to disable some deprecated features
wholesale via #defines.

BUG=119020,236611
TEST=all tests (and regression tests) pass under asan
NOTRY=true
R=jrummell@chromium.org, wolenetz@chromium.org

Review URL: https://codereview.chromium.org/286953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271945 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375910
R=zea@chromium.org

Review URL: https://codereview.chromium.org/296933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271944 0039d316-1c4b-4281-b951-d872f2087c98

Remove chrome_official_builder's dependency on pdf. I don't see why it's needed, since the chrome target depends on pdf.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/293083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271943 0039d316-1c4b-4281-b951-d872f2087c98

--fatal-warnings don't seem to be supported. This also adds support for mach_logging files which were added recently.

BUG=
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/295023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271942 0039d316-1c4b-4281-b951-d872f2087c98

Adds a protobuf target and a template for defining protos. This handles doing host builds of protoc when cross-compiling.

The command buffer sevice wants more optimization on Android, so this patch generalizes the solution. Normally Android, like Windows, optimizes for size. This now adds support on Android for speed optimization just like Windows does. Mac & Linux always optimize for speed.

Removes the declare_args call around the gcc_version. This was parameterized to be different if is_android was set, which isn't valid because build parameters can't vary across toolchains. Since this value is derived from the environment, I just removed the declare_args call.

BUG=
R=piman@chromium.org

Review URL: https://codereview.chromium.org/289953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271941 0039d316-1c4b-4281-b951-d872f2087c98

This appears to be a vestigal part of some StreamAsFile() operation that no
longer exists. It's not necessary to cache this file info in the plugin, as we
only ever return it once.

I've split this off from a bigger StreamAsFile() refactoring to make the diff
smaller, to help debug Windows failures on that patch.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/297763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271940 0039d316-1c4b-4281-b951-d872f2087c98

This is not perfect, as some function names are still to long. But it improves
most of them.

I've also added the ability to specify the chromesite template to use from
within the .rst file.

BUG=374811
TEST=locally ran the server
R=kalman@chromium.org, sbc@chromium.org

Review URL: https://codereview.chromium.org/299753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271937 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/298563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271936 0039d316-1c4b-4281-b951-d872f2087c98

Fixes dependency ordering to get libjingle style overrides working for webrtc. See http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux/builds/5887/steps/compile/logs/stdio. Tested it locally.

BUG=N/A
R=hellner@chromium.org

Review URL: https://codereview.chromium.org/293983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271935 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271934 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=62&start=14827

R=reed@google.com
TBR=reed@google.com, robertphillips@google.com, zea@chromium.org

Review URL: https://codereview.chromium.org/294903008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271933 0039d316-1c4b-4281-b951-d872f2087c98

Fails flakily on Android.

BUG=375838
R=johnme@chromium.org

Review URL: https://codereview.chromium.org/296933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271929 0039d316-1c4b-4281-b951-d872f2087c98

Per discussion, allows kInfiniteDuration() for the front DiscardPadding
value.  When there's no decoder delay, this ensures accuracy when
discarding.  If decoder delay is present, the code falls back to using
the duration as an estimation.

BUG=371633
TEST=new unittests
NOTRY=true
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/293053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271928 0039d316-1c4b-4281-b951-d872f2087c98

Changes in preparation for upcoming preroll_buffer() method.

BUG=none
TEST=none
NOTRY=true
R=wolenetz@chromium.org

Review URL: https://codereview.chromium.org/294043007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271927 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Unload all apps / extensions when deleting a profile. (https://codereview.chromium.org/266343002/)

Reason for revert:
Caused crash in official builds when deleting profiles while the chrome:chrome-signin tab is open

BUG=374683
TBR=kalman, sky

Original issue's description:
> Unload all apps / extensions immediately when deleting a profile.
>
> Previously apps could remain running with references to profiles that had been deleted by users, but before the browser shut down and profiles were fully removed. Problems included E.g. opening a link in an app would open a tab in the deleted profile.
>
> Relanding patch: ShutdownStartupCycle failed in build [49353], this patch was speculatively reverted in r269383 [49355], but ShutdownStartupCycle failed again in [49362] after the revert had landed.
>
> [49353] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49353
> [49355] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49355
> [49362] http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/49362
>
> BUG=368684
> TEST=Manual testing as described on http://crbug.com/368684#c1
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269343
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270890

Review URL: https://codereview.chromium.org/289283013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271926 0039d316-1c4b-4281-b951-d872f2087c98

Crashes on various platforms. See bug.

TBR=haitaol@chromium.org
BUG=375856

Review URL: https://codereview.chromium.org/295093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271925 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271924 0039d316-1c4b-4281-b951-d872f2087c98

Caused canvas test failures on all platforms.

BUG=375851

> Skia roll 14765:14816
> 
> https://code.google.com/p/skia/source/list?num=50&start=14816
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/284413006

TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/294183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271923 0039d316-1c4b-4281-b951-d872f2087c98

Times out on Android Tests Dbg flakily. See bug for details.

BUG=375840
TBR=haitaol@chromium.org

Review URL: https://codereview.chromium.org/299833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271922 0039d316-1c4b-4281-b951-d872f2087c98

https://src.chromium.org/viewvc/chrome?view=rev&revision=271919 fixes the
compiler crash, http://src.chromium.org/viewvc/chrome?view=rev&revision=271780
fixes the bug in landmines that didn't allow the initial land/revert to
go smoothly.

Should be A-OK this time.

> Revert 271721 "VS2013 Update 2"
> 
> static_library build ICEing on some builders on mini_installer.
> 
> > VS2013 Update 2
> > 
> > As discussed in the linked bug, the toolchain2013.py script in
> > depot_tools is no longer workable (because the update for Update 2 is
> > supplied as a .msp that must be applied against a system-installed
> > VS2013).
> > 
> > As such, the Express hash here is not updated.
> > 
> > The hash zip referenced here was built as follows:
> > - Install VS2013 Update 2 on a clean VM
> > - Copy DIA SDK\, VC\
> > - Copy DLLs from VC\redist to sys32\ and sys64\
> > - Copy win8sdk unchanged from previous .zip.
> > - Delete various unused arm\ subdirectories
> > - Delete the IDE-only Snippets, etc. subdirectories in VC\
> > - Patch VC\include\xtree to disable warning 4702 per request in
> >   http://crbug.com/346399 .
> > 
> > A followup change will be to write a script that does these steps
> > semi-automatically, hopefully for Express too, though there is the
> > added complication of the WDK/ATL/MFC hacking required there. In
> > particular, this script will not be useful for a dev to actually run
> > as part of runhooks, but will be a bit useful for deployment/
> > documentation of the above process.
> > 
> > In the interim there are no extremely-pressing reasons for Express
> > users to update to Update2 that I'm aware of, so they get non-Update2
> > for now.
> > 
> > R=iannucci@chromium.org
> > BUG=372451,346399,371847,339215,350639
> > 
> > Review URL: https://codereview.chromium.org/284663003
> 
> TBR=scottmg@chromium.org
> 
> Review URL: https://codereview.chromium.org/297753002

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/295093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271921 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375808,245025,373542
TBR=rsleevi

Review URL: https://codereview.chromium.org/299623007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271920 0039d316-1c4b-4281-b951-d872f2087c98

The previous code is causing:

FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\mini_installer\mini_installer.mini_installer.obj.rsp /c ..\..\chrome\installer\mini_installer\mini_installer.cc /Foobj\chrome\installer\mini_installer\mini_installer.mini_installer.obj /Fdobj\chrome\installer\mini_installer.cc.pdb
c:\b\build\slave\win-latest-rel\build\src\chrome\installer\mini_installer\mini_installer.cc(857) : fatalerror C1001: An internal error has occurred in the compiler.
(compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 228)
 To work around this problem, try simplifying or changing the program near the locations listed above.
Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information
INTERNAL COMPILER ERROR in 'C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe'
    Please choose the Technical Support command on the Visual C++
    Help menu, or open the Technical Support help file for more information

after Update 2. The CRT's implementation looks like the simple char
loop, so simplify here too.

In practice, I think this will only rarely get used, as the compiler
is allowed to "know" what memset does and replace it with an optimized
version.

There's an upstream bug filed here: https://connect.microsoft.com/VisualStudio/feedback/details/878340/ice-on-memset-implementation-at-o2

R=grt@chromium.org
BUG=372451

Review URL: https://codereview.chromium.org/294943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271919 0039d316-1c4b-4281-b951-d872f2087c98

This is part of an effort to get rid of use of DescWrapper/NaClDesc for nexe
module loading. This is anticipation of moving nexe loading away from SRPC to
Chrome IPC.

Note that this tightens up some permissions for converting file descriptors;
I'm not sure why some were originally opened with _O_RDWR.

BUG=333950
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/291973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271918 0039d316-1c4b-4281-b951-d872f2087c98

The Decode function should not require the plugin to
maintain its buffer when it completes asynchronously.

BUG=281689
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/291083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271917 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/284313010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271916 0039d316-1c4b-4281-b951-d872f2087c98

Add regression tests to ensure that IPC::Listener::OnBadMessageReceived is always called for all cases, i.e.
1) using IPC::Channel directly
2) using IPC::ChannelProxy and the IPC is dispatched on the IO thread
2) using IPC::ChannelProxy and the IPC is dispatched on the listener thread

R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/282303014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271915 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271914 0039d316-1c4b-4281-b951-d872f2087c98