- 17 Mar, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ae2152e9..26596343 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1de4176011186a71522726bcf05ae8f6dfafdf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105839Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750930}
-
Hwanseung Lee authored
This reverts commit 4143ca0e. Reason for revert: complication error at chrome internal Original change's description: > Clean up the AndroidSetupSearchEngine feature flag > > The AndroidSetupSearchEngine feature is enabled by default > and the config has no effect anymore. > Therefore, remove the config and every reference to > AndroidSetupSearchEngine. > > Bug: 1057939 > Change-Id: I5e395d7ed031d93b64d4ae9d012f72351b0dec22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102032 > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> > Cr-Commit-Position: refs/heads/master@{#750834} TBR=sky@chromium.org,hs1217.lee@samsung.com,fhorschig@chromium.org Change-Id: I564011f94406cd750d9156b348fc04208e4530cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1057939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107336Reviewed-by:
Hwanseung Lee <hs1217.lee@samsung.com> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#750929}
-
Hiroshige Hayashizaki authored
Manual changes: - mixed-content/generic/test-case.sub.js: to accept an array of scenarios. - TestExpectations: to reflect test renames. All other changes are mechanical, by commands: find gen -type f | perl -npe '$_=~s@/[^/]*\.([^/\.]*(\.html[^/]*|-expected\.txt)$)@.$1@g;' | sort -u > new_files git rm -r gen time python ../common/security-features/tools/generate.py --spec . run_web_tests.py --no-retry-failures --reset-results .... git add `cat new_files` git commit Bug: 906850 Change-Id: If0b32bdc7796e7df2b9de80e7a33cf3413a69959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103589 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#750928}
-
Hiroshige Hayashizaki authored
Manual changes: - referrer-policy/generic/test-case.sub.js - referrer-policy/4K-1/generic/test-case.sub.js - referrer-policy/4K/generic/test-case.sub.js - referrer-policy/4K+1/generic/test-case.sub.js to accept an array of scenarios. All other changes are mechanical, by commands: find gen -type f | perl -npe '$_=~s@/[^/]*\.([^/\.]*(\.html[^/]*|-expected\.txt)$)@.$1@g;' | sort -u > new_files git rm -r gen time python ../common/security-features/tools/generate.py --spec . run_web_tests.py --no-retry-failures --reset-results .... git add `cat new_files` git commit Bug: 906850 Change-Id: I66bcf412557016d985f5bf8ee461cd46f1b46485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102931 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Manual changes: - upgrade-insecure-requests/generic/test-case.sub.js: to accept an array of scenarios. - TestExpectations: to reflect test renames. All other changes are mechanical, by commands: find gen -type f | perl -npe '$_=~s@/[^/]*\.([^/\.]*(\.html[^/]*|-expected\.txt)$)@.$1@g;' | sort -u > new_files git rm -r gen time python ../common/security-features/tools/generate.py --spec . run_web_tests.py --no-retry-failures --reset-results .... git add `cat new_files` git commit Bug: 906850 Change-Id: I0dde51e0520a803635493fae549befd1f6f72a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102932 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#750926}
-
Andrey Zaytsev authored
This is part of the Friendly Settings Privacy settings redesign. The network prediction toggle is being moved to the new cookies page. See http://slides/1utofQR2FyZlTOOsUgYGi0SyPeVA3DxCDjHmaAuu0EIo#slide=id.g64328a826f_0_1 for more context. Implementation review: http://slides/13mIMXvISMXz_I_rRuDeN_qe4RsW49LYhudbSj23owVw#slide=id.p Bug: 1032584, 1061479 Change-Id: I7d418242100ec6c3562fa3841caf1ec0e613bcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105313 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#750925}
-
Andreas Haas authored
This CL removed a use of the deprecated ArrayBuffer class. In the |OutgoingStream| class, ArrayBuffer was used to own a byte array and its length. This Cl replaces ArrayBuffer with a small inner class that does exactly that, it stores a byte array and its length. The constructor uses the wtf::Vector allocator to allocate the byte array. R=ricea@chromium.org CC=haraken@chromium.org Bug: chromium:1008840 Change-Id: I21286265eeaabe359ea7709b8d05042c854b7c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102585Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#750924}
-
Maksim Ivanov authored
The OWNERS file can only include Committers. Bug: none Change-Id: I7507cba5c56e6d5ada2eb5ef4bef62736035d7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106077Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#750923}
-
Antonio Gomes authored
This is the first step to unify media_devices.typemap and media_devices_for_blink.typemap. Basically, the former will be used as-is from Blink when the work done. Note that, the approach could have been backwards, ie use blink.mojom.MediaDeviceTypes throughout the code and remove blink::MediaDeviceTypes, however that would result in a way bigger CL (see [1] for reference), since today blink::MediaDeviceTypes enum item are used mainly for indexing vectors, and blink::mojom::MediaDeviceTypes class enum items can be implicitly converted to int, for similar purposes. [1] https://crrev.com/c/2106015 Since 'blink::mojom::MediaDeviceTypes type' parameter is actually unused in blink::MediaDevices::OnDevicesChange(), it is possible to consider removing the parameter and the blink.mojom.MediaDeviceTypes definition altogether from media_devices.mojom. BUG=704136 R=guidou@chromium.org Change-Id: Id3d42c3bbde30a7dd02b92439b867764e4211073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105794Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#750922}
-
Kei Nakashima authored
Implemented |NewLinkedHashSet::InsertBefore| and added test for it. Change-Id: I653902201706e107403308e594356b6bb899db91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106702 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#750921}
-
Rushan Suleymanov authored
Make entity tracker's lifetime same as initial sync done. The tracker won't exist if we still have no data from the server. In this patch also authentication_account_id is not set explicitly for metadata coming from ModelReadyToSync. The behavior for this field becomes similar to cache_guid. If authentication_account_id differs from activation request then the metadata will be reset. Generally it should not affect anything. In the next patch unittests will be added. Bug: 947044 Change-Id: I34a75006d1f31888f8ca485a94538b6dd98923c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038733 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750920}
-
Maksim Ivanov authored
Having the component specified in the OWNERS file allows to route the bug directly to the responsible team during bug triage process. Bug: none Change-Id: I0c9d019ec7e653375f297a27b4578440ed9d631a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106573Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#750919}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: Ibc2a0eaefdfe20ea1484a464024c184b15306548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105219 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#750918}
-
Maria Petrisor authored
The LoginShelfButtons (Shut down, Browse as Guest and Add Person) are not updated on a locale change issued through a policy change. Both the text language and the alignment of the buttons (in case of RTL) are not updated. LoginShelfView does have an OnLocaleChanged function and adds an observer that are meant to update the buttons, but the function is not triggered when the locale policy changes. This CL adds a function, NotifyLocaleChange, which is called after the language switch (OnLanguageSwitchedCallback) handled in login_display_host_webui.cc. NotifyLocaleChange uses LocaleUpdateController to notify all OnLocaleChanged observers. Both the text and the alignment issues are resolved after adding the proposed changes. Browser tests are also added for checking the Shut down button text, alignment, and the text of an UnifiedSystemTray element. Bug: 1051945, 1054417 Change-Id: Ida6ea782622dacdf118666c64bb908929b4cdb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081820 Commit-Queue: Maria Petrisor <mpetrisor@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jit Yao Yap <jityao@google.com> Cr-Commit-Position: refs/heads/master@{#750917}
-
Sylvain Defresne authored
WebStateList is not re-entrant (already asserted by locked_) so there is no point nesting batched operations. Add a bool to ensure this is not the case. Add a method to check whether a batched operation is in progress (could be used internally to also omit sending notification during a batched operation). Bug: 1014526 Change-Id: I6b6dc3278312895a32898d898245f538f9a5264d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089675 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#750916}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8bc88340292b..ba9e1b8b75f3 git log 8bc88340292b..ba9e1b8b75f3 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 kthelgason@webrtc.org Fix issue with decoding in certain cases. Created with: gclient setdep -r src/third_party/webrtc@ba9e1b8b75f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2247c7d799550d9eeccd56565a6df16a37a7e902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107314Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750915}
-
Camillo Bruni authored
The newly introduced will make the return type of ModuleRecord::Evaluation explicit. Currently an empty v8::Local return value corresponds to a successful evaluation and any returned value is treated as an exception. This is different when top-level await is enabled. In this case ModuleRecord::Evaluation always returns a Promise on success. Thus simply checking for an empty or non-empty v8::Local is no longer sufficient and we need a dedicated flag to detect Exceptions. Bug: 1022182, v8:9344 Change-Id: Ida7684bff79d68624548c99aee6e7b6f2e334afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105315 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#750914}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/281b5c16d2cc..23283eb96876 git log 281b5c16d2cc..23283eb96876 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 liviurau@chromium.org Doc update Created with: gclient setdep -r src/third_party/devtools-frontend/src@23283eb96876 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieb9345412e4df7398443d531be7202d1e1cc8a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107313Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL merges subtests that only differ in subresource request's origin/redirection into a single file. In `/common/security-features/tools/spec.src.json`, `origin` and `redirection` fields are removed from `test_file_path_pattern`, so that scenarios that only differ in subresource request's origin/redirection result in the same file name. __eq__() is added to some classes, as this CL adds some assert()s that indirectly requires the __eq__()s. Diffs in generated files: - An array of scenarios is written, instead of single scenario. - `<title>`, `<link rel>` to spec URLs, and `<meta name="description">` are removed, because this CL merges multiple files with different titles etc. into one file. - `<meta name="timeout" content="long">` is added, as a single test now can run up to 8 subtests. (In my local runs, the max exec time for a single generated test file was about 2.8 seconds). - <link rel="author"> is removed, as the git history log is more representative. Subsequent CLs will actually re-generate files: - https://chromium-review.googlesource.com/c/chromium/src/+/2103589 - https://chromium-review.googlesource.com/c/chromium/src/+/2102931 - https://chromium-review.googlesource.com/c/chromium/src/+/2102932 which will reduce the number of generated tests from 8548 to 1380. Bug: 906850 Change-Id: I2c3e847dcbfd89311d0e36da5b91c20f9a3f3a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893828 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Rainhard Findling authored
Bug: 1061546 Change-Id: I80085f5bf7630a7937f83b467517e8d06fbc396a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106181Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7a8f79762c4a..25ede1ced679 git log 7a8f79762c4a..25ede1ced679 --date=short --first-parent --format='%ad %ae %s' 2020-03-16 jmadill@chromium.org Roll external/spirv-headers/ 30ef660ce..a17e17e36 (1 commit) (#3230) Also rolling transitive DEPS: src/third_party/spirv-headers/src 30ef660ce2e6..a17e17e36da4 Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@25ede1ced679 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I4f757aa41e0554eb18bde014f1029e902cf7bfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107255Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a8acd7799b44..273f9c7c26d7 git log a8acd7799b44..273f9c7c26d7 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 3a50a43df988..440fc9959f06 (1 commits) 2020-03-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 9b620aa0c12d..4b2483ee88ab (1 commits) 2020-03-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src be663d752e45..6cd8cbdaab99 (7 commits) 2020-03-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src f1d9f12a19de..64c36933d4f2 (2 commits) Created with: gclient setdep -r src/third_party/angle@273f9c7c26d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I8cef478b73d2f55c23a1a6738b9899986e713dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107257Reviewed-by:
-
Takuto Ikuta authored
This is to fix https://luci-milo-dev.appspot.com/p/chromium/builders/ci/linux-rel-swarming-staging/1795 Bug: b/144318226 Change-Id: I5a28290b1791d8140932ae224faee8973ce59149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106706 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#750908}
-
Tarun Bansal authored
No longer needed with the data reduction proxy (DRP) being disabled. The pref that stored network properties is now being deleted via chrome/browser/prefs/browser_prefs.cc Change-Id: Ide5f22c3460f84d272df1524f1f17429e38e1018 Bug: 1048736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104095Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This CL changes the parameter of SetMainScriptHttpResponseInfo(). Before this CL it took net::HttpResponseInfo. After this CL it takes std::unique_ptr<MainScriptResponse>. This change is a preparation for removing URLResponseHead <-> HttpResponseInfo conversion in service worker codebase. This CL also renames the method. Bug: 1060076 Change-Id: I0d0b24b7d5d5e6f15d6d017565e82b5fc11c3107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106705 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Saurabh Nijhara authored
In case of multipofile mode, when account picker is invoked a blank white screen appears. Though it is not entirely clear why it happens, but removing 'full-screen-dialog' attribute from the oobe-dialogs in checking_downloading_update polymer element apparently fixes it. This leads to another problem of the update_screen not shown in full screen mode. For that we need to call onBeforeShow() of the polymer element explicitly so that the oobe_dialog_host_behavior in the checking_downlaoding_update can be used to set full screen mode for all the oobe dialogs. Bug: 1061330 Change-Id: Ic51082b0694f4bed0f357ec7616ab2fbc108fcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105316Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Shik Chen authored
This CL creates a dedicated folder to store external libraries, so it's easier to track and update the dependencies in the future, as we are going to add other libraries. Bug: 1058325 Test: Open CCA and check there is no error in console. Change-Id: I98117d55a46323df827e78e692342b81bb94361c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105668 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#750904}
-
Fredrik Söderqvist authored
This function is now reasonably simple and small so we can fold it into its only user (the ScopedSVGPaintState destructor). This makes ScopedSVGPaintState::filter_ useless, so remove that field. Bug: 109224 Change-Id: I24a90c300744802e0ab2d1b2e0b1d33fbc977797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105218 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750903}
-
Jan Wilken Dörrie authored
TBR=vasilii Bug: 1047726 Change-Id: Idfa373c13c4a6304f11c2240175d1bd98e2002c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106062Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#750902}
-
Marc Treib authored
In case of test failure, Sync's FakeServer outputs a log of all requests, which can be helpful in debugging. However in other cases, the output can be annoying - lots of text to scroll over to get to the actual failed expectation message. So this CL adds a commandline switch --disable-fake-server-failure-output to disable the verbose output, for use in local testing/debugging. Bug: none Change-Id: Iaf07e79681eac1e961f0a530b6cac45548cf8742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104051 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aedd57803884..281b5c16d2cc git log aedd57803884..281b5c16d2cc --date=short --first-parent --format='%ad %ae %s' 2020-03-17 szuend@chromium.org Make LiveLocation creation and updates asynchronous Created with: gclient setdep -r src/third_party/devtools-frontend/src@281b5c16d2cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib6bf847e52dba18dd0e9e386953cae298208b0ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107109Reviewed-by:
-
Hitoshi Yoshida authored
Drops support of Dictionary and SerializedScriptValue in Web IDL. All of their use cases were already removed, and keeping support of them is a risk to re-introduce them. Bug: 839389, 1047081 Change-Id: I76d641d9df46755423c18276c7e940d355ecf300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100167Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4b2483ee88ab..02d73f58b81e git log 4b2483ee88ab..02d73f58b81e --date=short --first-parent --format='%ad %ae %s' 2020-03-17 johnkslang@users.noreply.github.com Merge pull request #2129 from jeffbolznv/memoryBarrierAtomicCounter Created with: gclient setdep -r src/third_party/glslang/src@02d73f58b81e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I1e442de5e2a357beaf1f7fedf3b56b75cddf973d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107111Reviewed-by:
-
Rakina Zata Amni authored
Currently the decision to create new BrowsingInstances are made in two functions: ShouldSwapBrowsingInstancesForNavigation and DetermineSiteInstanceForURL, possibly causing confusion when only looking at one of the functions, and other issues like not being able to know whether it is a "forces swap" (requiring different processes) or a "proactive swap" (may not require different processes). This CL fixes that by moving all the BI swaps to ShouldSwapBrowsingInstancesForNavigation. Bug: 977562 Change-Id: Id5fb8785399584199ac0711811e9ec8b6d6efe03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081728 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750897}
-
Ahmed Mehfooz authored
Bug: 1056451 Change-Id: I667692eb3dd172921fec09cf93f66e33cd0a7024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099475Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750896}
-
Kunihiko Sakamoto authored
This reverts commit a471ff9b. Reason for revert: DumpAccessibilityEventsTest.AccessibilityEventsMenuListCollapse* are still flaking on Win7 bots. https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/100813 https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/65070 Original change's description: > Reland "Ensure UI Automation GetFocus reaches focused node in web content" > > This is a reland of 756820dd > > The original CL was reverted due to test failures on Win7. > > On both Win10 and Win7, UI Automation was generating an initial focus > event when the test listener first connects. On Win10, this initial > focus event comes from a window managed by the operating system > (ClassName=ApplicationManager_ImmersiveShellWindow). Since that element > is outside the scope of the test app, the test listener throws it out. > On Win7, the initial focus event comes from an element in our web > content, so the test listener logs it. > > My suspicion is that the difference in behavior is due to mitigations > for focus stealing introduced between Win7 and Win10. Regardless, the > fix is to generate separate expectation files for Win7. > > Original change's description: > > Ensure UI Automation GetFocus reaches focused node in web content > > > > AXPlatformNodeDelegate::GetFocus() returns the node within the called > > node's subtree that currently has focus. When an element in web content > > has focus, and a delegate in Views is asked for focus, that delegate can > > only reach as far as the web content root. Calling GetFocus() again on > > the web content root ensures that the platform API returns the currently > > focused node. > > > > Bug: 928811 > > Change-Id: Ice47eed0a8ea4281beb48624942ac2428fb1950f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099162 > > Reviewed-by: Ian Prest <iapres@microsoft.com> > > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > > Cr-Commit-Position: refs/heads/master@{#749386} > > Bug: 928811 > Change-Id: I32e59febfb6dbb7b5386c155c252c880a0f2ebc5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101930 > Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#750781} TBR=kbabbitt@microsoft.com,iapres@microsoft.com Change-Id: I064dad632ef4379f6132e4d1a2f17bd558e8293e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105691Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#750895}
-
Ahmed Mehfooz authored
This cl ensures that short notification timeouts are not enabled if at boot the user has enabled Chrome Vox, magnifier, autoclicks or select to speak. Bug: 1059017 Change-Id: I033ea01ee30330a3238bd13f5c94fd21c028734a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105763 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#750894}
-
Hiroki Sato authored
Previous CL (http://crrev/c/2024635) wired ARC window title to its root node. However, this made ChromeVox announce window title twice. One is from the window title and the other is from a name of the root node. This CL partially reverts the previous change and makes default fallback focus to the window itself. This change also makes only the root window of each ARC task be modal instead of assigning to every root node. Android framework sends only actionable windows to AccessibilityService. Bug: b:150342403 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open any ARC app and title is not announced twice. Change-Id: Ie6527af9b01c03a175517dcfe7d88ca29b4b034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099671 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#750893}
-
Fredrik Söderqvist authored
This makes it possible to discern "no valid filter" from "contents does not need recording". In turn this makes it possible to skip the corresponding FinishEffect() call when there's no valid filter. This allows simplifying FinishEffect() and drop the Abort() method on SVGFilterRecordingContext. The call to SVGFilterRecordingContext::BeginContent() is sunk out of PrepareEffect() and likewise the clearing of the invalidation mask is hoisted. Bug: 109224 Change-Id: I440a0d85f93ec0bd0d043a4f3545d793364b9f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105374Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c701b5aaf3e3..58bd5d914210 Created with: gclient setdep -r src-internal@58bd5d914210 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052382 Tbr: jbudorick@google.com Change-Id: I5ed549b27088659b53a9681015706adce27a1f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107103Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750891}
-
