- 03 Aug, 2018 40 commits
-
-
Gauthier Ambard authored
This CL adds a way for the user to select an option in the ConsentBump personalization screen. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia4da17b939a6ada46e8a8e6418a1c11e846014ed Reviewed-on: https://chromium-review.googlesource.com/1160842 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580479}
-
Ned Nguyen authored
The extra v8 benchmarks we want to schedule on android-go-perf builder are: v8.browsing_mobile speedometer speedometer2 Steps that I did to generate this reshard: 1) Update the android-go-perf's story timing data by running: ./tools/perf/core/retrieve_story_timing.py -c 'android-go-perf' --output-file=tools/perf/core/shard_maps/timing_data/android_go_timing.json 2) Copy the story runtime of v8.browsing_mobile, speedometer, speedometer2 to android_go_timing.json 3) Generate the benchmark shardings with: ./tools/perf/generate_perf_sharding --timing-data tools/perf/core/shard_maps/timing_data/android_go_timing.json --num-shards=19 --output-file tools/perf/core/shard_maps/android_go_shard_map.json --benchmarks=memory.top_10_mobile,system_health.memory_mobile,system_health.common_mobile,power.typical_10_mobile,start_with_url.cold.startup_pages,start_with_url.warm.startup_pages,system_health.webview_startup,v8.browsing_mobile,speedometer,speedometer2 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I8a0696dc8b73092f4289b4abca60a40d92458e98 BUG: chromium:863767 Change-Id: I8a0696dc8b73092f4289b4abca60a40d92458e98 Reviewed-on: https://chromium-review.googlesource.com/1160766 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580478}
-
Gauthier Ambard authored
This CL adds the options displayed by the ConsentBump personalization screen. For now it is not possible to interact with those options. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I069f1b2c242e8a56ad15f3c45ffd85d863c0db67 Reviewed-on: https://chromium-review.googlesource.com/1160649 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580477}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f357c021..9adf7905 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If9b1743ffe295daf7be8450420b1a876f70f480e Reviewed-on: https://chromium-review.googlesource.com/1161620Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580476}
-
Scott Wu authored
Metrics recording is not enabled for ios web view. In order to make it optional in current password manager logic, refactor is needed like changing GetMetricsRecorder to return a pointer as well as adding nullptr checking logic. Bug: 868817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8a5b7c9a835e72992a04cb15758a4e2ee86d748c Reviewed-on: https://chromium-review.googlesource.com/1154848 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580475}
-
Peter E Conn authored
Split CustomTabActivity's PageLoadMetrics.Observers according to their purpose. Also create the TabObserverRegistrar class that deals with attaching these observers to Tabs as they enter and exit the TabModel. Bug: none Change-Id: Ic434ead9c5167eb876f91af33b54dfd3d50493cd Reviewed-on: https://chromium-review.googlesource.com/1154968Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#580474}
-
Takuto Ikuta authored
This is for more than 30 mins compile steps like below builds. 3482s https://ci.chromium.org/b/8939283904169846144 2889s https://ci.chromium.org/b/8939330795897045184 2670s https://ci.chromium.org/b/8939259288541607584 Bug: 804251 Change-Id: I052b8f2cae46fe4987f88316b67f81c17243fdb3 Reviewed-on: https://chromium-review.googlesource.com/1161705Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#580473}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e16a2e80be66..d38bbdff043d git log e16a2e80be66..d38bbdff043d --date=short --no-merges --format='%ad %ae %s' 2018-08-03 sadrul@chromium.org rendering: Fix filtering events. Created with: gclient setdep -r src/third_party/catapult@d38bbdff043d The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:868650 TBR=sullivan@chromium.org Change-Id: I7264905b5a4821446dcdf3f49b95132105460608 Reviewed-on: https://chromium-review.googlesource.com/1161147Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580472}
-
Giovanni Ortuño Urquidi authored
Introduces a BookmarkAppInstaller class whose job is to create a Bookmark App with certain characteristics e.g. name, start url, launch container, etc. The BookmarkAppInstaller class uses CrxInstaller to actually create and install the BookmarkApp. Currently the installer only takes a WebApplicationInfo but in the future it'll support more options, for example, if the app will be synced, what container will the app launch in, etc. Marks BookmarkAppInstallerTest as a friend in CrxInstaller so that we can create a fake CrxInstaller that fails to install the app. Bug: 864904 Change-Id: I105d1e93160f2527ee6cb5c4951fab885a893392 Reviewed-on: https://chromium-review.googlesource.com/1152642 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#580471}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/d4de71b02044..64cb8d9d67fb git log d4de71b02044..64cb8d9d67fb --date=short --no-merges --format='%ad %ae %s' 2018-08-03 hinoka@google.com Don't runhooks in annotated run Created with: gclient setdep -r src/native_client@64cb8d9d67fb The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: I29df247c49c65412c57c42308c9c7d1290a9025c Reviewed-on: https://chromium-review.googlesource.com/1161148Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580470}
-
Alexey Baskakov authored
Bug: 860581 Change-Id: Id8a879d680bf220d46930543a43b92b1d74d6bcf Reviewed-on: https://chromium-review.googlesource.com/1159550 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#580469}
-
Kunihiko Sakamoto authored
Mark virtual/paint-touchaction-rects/fast/events/touch/touch-latched-scroll-node-removed.html as flaky Tbr: xidachen@chromium.org Bug: 870595 Change-Id: Ie37dab1122f12a1b6b608ba7ac9976d7d9e56cdb Reviewed-on: https://chromium-review.googlesource.com/1161714Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580468}
-
Kunihiko Sakamoto authored
This reverts commit db560919. Reason for revert: This made ExtensionWebRequestApiTest.WebRequestTestOSDD flaky. crbug.com/870588 Original change's description: > Fixes ExtensionWebRequestApiTest.WebRequestBlocking with network service > > Getting this test working required a few fixes: > - Modifying a header rather than Set-Cookie for some tests, which > required switching to XMLHttpRequest (crbug.com/827582) > - Handling redirect from http:// -> chrome-extension://, and bypassing > security checks if this is from web request > - Plumbing through whether the request is async or not > > This is not handling subresource redirects because subresource > redirects to schemes other than http/https/data are not supported > yet with network service (crbug.com/868545). > > Also adds a bunch of tests for redirects. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Iabca6e5890b0d5edd066fd8945b19bdbb5d52670 > Reviewed-on: https://chromium-review.googlesource.com/1145956 > Reviewed-by: Nick Carter <nick@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580365} TBR=nick@chromium.org,jam@chromium.org,reillyg@chromium.org,karandeepb@chromium.org,cduvall@chromium.org Change-Id: Ib831aea7b5afeb6b0e06c79a1d80520d61e02dbf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721414,870588 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1161821Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580467}
-
Ross McIlroy authored
With scheduled script streaming and background compilation it is now worthwhile to stream smaller scripts. Enable support for streaming these smaller scripts when the ScheduledScriptStreaming trial is enabled to investigate performance impact. BUG=chromium:865098 Change-Id: Ia7691dbe9f8dd970aafda2715a34edc3ef16616b Reviewed-on: https://chromium-review.googlesource.com/1160653Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580466}
-
Kunihiko Sakamoto authored
This reverts commit 553ec6da. Reason for revert: The new tests are failing on Win10 Tests x64 and Win7 Tests (1) https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/26185 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20(1)/82347 Original change's description: > [Sync::USS] Bookmark sync conflict resolution > > This patch addresses the problem of conflict in bookmarks upon > receiving a remote update for a node that has local changes. > > The general polic that is implemented is that server wins except in > case of deletion. > > Bug: 516866 > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1 > Reviewed-on: https://chromium-review.googlesource.com/1157006 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580436} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: I148386f4fe2391f5c895288924aefa2f4f88d00b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 516866 Reviewed-on: https://chromium-review.googlesource.com/1161683Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580465}
-
Kyoko Muto authored
BUG= 867331 Change-Id: I886542193ed17743d8e10c11ae9c2c5036c8187b Reviewed-on: https://chromium-review.googlesource.com/1159937 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580464}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7917065. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22261 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler jsbell@chromium.org: external/wpt/encoding external/wpt/resources msramek@chromium.org, mkwst@chromium.org: external/wpt/clear-site-data TBR=foolip No-Export: true Change-Id: Ic5e40a323daad97a8358872fe0dd1f70438b4d20 Reviewed-on: https://chromium-review.googlesource.com/1161617 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580463}
-
Marc Treib authored
Followup to https://crrev.com/c/1148392, which introduced IsSyncFeatureEnabled and made IsSyncActive depend on it. Bug: 856179 Change-Id: Icfc6e35550285ec7688b0de0cdce9c161d2049cc Reviewed-on: https://chromium-review.googlesource.com/1160850 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580462}
-
Darren Shen authored
VirtualKeyboardAppWindowTest.DisableOverscrollForImeWindow tests that we don't reduce the viewport size of IME related windows (like the floating candidate window when you gesture type). However, the test uses ShowKeyboard(true), which shows the locked keyboard. When the locked keyboard appears, we don't overscroll. Rather, we reduce the size of the work area, shrinking the actual size of the window. The test still passes because shrinking the work area also shrinks the viewport size. This patch changes the test to use ShowKeyboard(false), which triggers overscrolling. This matches the original intent of the test more closely. TBR=yhanada@chromium.org Bug: 849995 Change-Id: Ifdbea75c5b84081fc67cd29e3af21f1984b4a4eb Reviewed-on: https://chromium-review.googlesource.com/1160064Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#580461}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d146987b6945..ee09b25fcad3 git log d146987b6945..ee09b25fcad3 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 vapier@chromium.org toolchain: fix default selection in toolchain.conf processing 2018-08-03 dgarrett@google.com workspace: Use a reference repo if available. 2018-08-03 tikuta@chromium.org cros_chrome_sdk: Invoke gomacc inside compiler wrapper 2018-08-03 dgarrett@google.com run_tests: Move new tests into chroot. Created with: gclient setdep -r src/third_party/chromite@ee09b25fcad3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I33d5604f2d2b82439546ffb89f5bd9b246f68a06 Reviewed-on: https://chromium-review.googlesource.com/1161347Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580460}
-
Mark Cogan authored
This CL fixes the size distortion of the incognito NTP in the new tab animation. The foreground animation view was assuming that the content view it animated had the same bounds as itself; this isn't correct for the incognito NTP, which is shorter to accommodate the toolbar. This CL instead repositions the content view correctly without resizing it. It also makes the animation view shorter (by StatusBarHeight()) to make this calculation cleaner. Bug: 868292 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id49a3de2f3f62c246356da082f74285014a7b37a Reviewed-on: https://chromium-review.googlesource.com/1160843Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#580459}
-
Abhishek Bhardwaj authored
Add an |is_tethered| field to the WiFi struct embedded in NetworkConfiguration. This field will tell the instance whether a WiFi configuration is tethered. BUG=b:62926617 TEST=Verify the is_tethered field is true when Chrome OS is connected to a mobile hotspot and false otherwise. Change-Id: I5dfc9f019be585fab435000f39a10661d2d35894 Reviewed-on: https://chromium-review.googlesource.com/569099 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#580458}
-
Jennifer Apacible authored
A previous change made controls always appear when the mouse is moving on all OS except Windows. This change gates handling the ET_MOUSE_MOVED event to Windows OS. Bug: 870120 Change-Id: I556c354643a920c34b973066369e26f38130705f Reviewed-on: https://chromium-review.googlesource.com/1161300 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#580457}
-
Kunihiko Sakamoto authored
This reverts commit 381beab3. Reason for revert: Suspected of breaking browser_tests on Mac. crbug.com/870579 Original change's description: > chrome: Call SetUpBundleOverrides from ChromeMain. > > It looks like we always need to call SetUpBundleOverrides no matter > what the process type is, so we can just call it from ChromeMain. This > will save us from needing to call this function from browser-specific > code in a later change. > > While here, also remove a dead declaration. > > Bug: 855193 > Change-Id: I449d92ef9c7d80d066d4cfefb3015014bd407cc1 > Reviewed-on: https://chromium-review.googlesource.com/1159335 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580285} TBR=avi@chromium.org,pcc@chromium.org,rsesek@chromium.org,mark@chromium.org Change-Id: I32f905ff8f82306a85fbc9798652b8c99aa46009 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855193,870579 Reviewed-on: https://chromium-review.googlesource.com/1161722Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580456}
-
Chris Palmer authored
johnme@ suggests a better way to handle it; let's do that. Bug: 786211 Change-Id: I446c70117451d2ef49ce13f5884ebb858d9ee392 Reviewed-on: https://chromium-review.googlesource.com/1161400 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#580455}
-
Oystein Eftevaag authored
This adds support for both global metadata, and metadata events. As part of this, the Perfetto support expands in a couple of ways: * Implement Flush(), so a Consumer can make sure the metadata events are written once, before tracing shuts down. * Support multiple data sources; global metadata is a separate data source as it's not actually tied to tracing. Bug: 840499 Change-Id: Ib4a76f692f333ffea89f7cf8200d0da3eeefaa23 Reviewed-on: https://chromium-review.googlesource.com/1129959 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#580454}
-
Max Moroz authored
Bug: 870331 Change-Id: Icbf8bc191e4078bd3ee8fb7fe15e51caae59e372 Reviewed-on: https://chromium-review.googlesource.com/1160861Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580453}
-
Bill Orr authored
Third party code will be blocked in the browser process. We'll need to host VR input outside the browser process. To support that, we need some IPC mechanism to get gamepad data over to the browser process where the device/gamepad service is hosted. For now, we'll host OpenVR gamepad data in the same place we host the OculusRenderLoop. This is not the final shipping location, but adding an IPC mechanism moves us closer to the final architecture. BUG=795510, 860821 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib63489c36e3e08723d9e4f92327fb97aa77597a9 Reviewed-on: https://chromium-review.googlesource.com/1147742 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#580452}
-
Kunihiko Sakamoto authored
This reverts commit 94d8037b. Reason for revert: USS/TwoClientBookmarksSyncTestIncludingUssTests.CreateSyncedBookmarks/1 failed on linux-chromeos-rel and Win 7 Tests x64 (1) https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11463 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29/41473 Original change's description: > [Sync:USS] Enable more two client bookmarks integration tests > > This CL enables more integration tests for bookmarks to run > against USS archiecture. > > > Bug: 516866 > Change-Id: Icece27bdf1b2070ca72d667b1a70e623c45c315f > Reviewed-on: https://chromium-review.googlesource.com/1158691 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580434} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: I34b63c1bc4202e2605527ff4844116fcc389e883 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 516866 Reviewed-on: https://chromium-review.googlesource.com/1161721Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580451}
-
Renee Wright authored
Bug: 864897 Change-Id: Iede53b65ec37b5778f9ec52f5a03293b2a0ee604 Reviewed-on: https://chromium-review.googlesource.com/1154738 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#580450}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f6db395a..f357c021 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia2b55e25d0196c1663ffb5823be8915ad3b3622f Reviewed-on: https://chromium-review.googlesource.com/1161602Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580449}
-
Mitsuru Oshima authored
Use ZERO tween applies the target values at the end of the animation when animation is not necessary. I'll consolidate two SetTransform in a separate CL. BUG=none TEST=covered by unittests. Change-Id: I29291b4d43330552cdc3f92ee91bd9faf23f921b Reviewed-on: https://chromium-review.googlesource.com/1158844 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580448}
-
Mohamed Amir Yosef authored
This CL enables the two client bookmark integration test MC_DeleteBookmark to run against USS archticture. Bug: 516866 Change-Id: I5d60f5b7473ba2b24ebbf501d2e6ae689f7aa0d8 Reviewed-on: https://chromium-review.googlesource.com/1158697 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580447}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/95340100f95f..2958a8faf500 git log 95340100f95f..2958a8faf500 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 tsepez@chromium.org Use more helper macros/methods in JBig2_Image.cpp. 2018-08-02 thestig@chromium.org Fix some nits in SkiaState. 2018-08-02 thestig@chromium.org Skia Path: Fix text/xform size mismatch when calling drawTextRSXform(). Created with: gclient setdep -r src/third_party/pdfium@2958a8faf500 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:751423 TBR=dsinclair@chromium.org Change-Id: I57dc7b1e7ab52e06e0b3ad22952be79cd6d6561b Reviewed-on: https://chromium-review.googlesource.com/1161345Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580446}
-
Han Leon authored
Currently we have a [Native] mojom struct content.mojom.PushEventPayload with a typemapping to the native struct content::PushEventPayload, we use them to pass payload data when calling the Mojo call content.mojom.ServiceWorker.DispatchPushEvent(). However, as content::PushEventPayload contains only 2 members: a string containing real data and a bool indicating data's validity, and it has no expectations to be expanded for now, so, we can just use a base::Optional<string> to replace it, and correspondingly in mojom we just needs a 'string? payload' for our content.mojom.ServiceWorker.DispatchPushEvent(). This CL removes content::PushEventPayload by doing the above replacement. BUG=789854 Change-Id: I8df737165b3004db820e3b758c1bfa8bdb7b5690 Reviewed-on: https://chromium-review.googlesource.com/1149705Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#580445}
-
BUG=762641 TBR=alemate@google.com Change-Id: I7e17a0c0a86fdd5de588a64ffb745435e6e39fd5 Reviewed-on: https://chromium-review.googlesource.com/1161608 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580444}
-
mrefaat authored
The current behavior is that apps can launch without user gestures. This is a source of abusive experience for users. Bug: 850760, 804054 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If47224bf27018a4b9d5a1cdbc39891849de05eb4 Reviewed-on: https://chromium-review.googlesource.com/1152692 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#580443}
-
Kunihiko Sakamoto authored
This reverts commit be2632ac. Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg) crbug.com/870208 Original change's description: > Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors" > > This reverts commit 67ca5a07. > > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change. > > Original change's description: > > Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors" > > > > This reverts commit 20f64257. > > > > Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg) > > > > Original change's description: > > > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors > > > > > > This change implements obtainining Remote Gatt Descriptors for WinRT by > > > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore, > > > appropriate tests are enabled. > > > > > > Bug: 821766 > > > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676 > > > Reviewed-on: https://chromium-review.googlesource.com/1156392 > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#579830} > > > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > > > Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 821766, 870208 > > Reviewed-on: https://chromium-review.googlesource.com/1159943 > > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580106} > > TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org > > Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 821766, 870208 > Reviewed-on: https://chromium-review.googlesource.com/1160901 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580200} TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org Change-Id: I9bd3f94b1be3b58b7975e1e57dff09cd7a9c2910 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766, 870208 Reviewed-on: https://chromium-review.googlesource.com/1161682Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580442}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0da902e4fde4..ca942e227a7a Created with: gclient setdep -r src-internal@ca942e227a7a The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:865968 TBR=mmoss@chromium.org Change-Id: I8143efdc6693c31454ebde0f0a6ba4760de23581 Reviewed-on: https://chromium-review.googlesource.com/1161023Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580441}
-
Kunihiko Sakamoto authored
This reverts commit ffac89b5. Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg) crbug.com/870208 Original change's description: > Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors" > > This reverts commit d01b7c9e. > > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change. > > Original change's description: > > Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors" > > > > This reverts commit f61df6f9. > > > > Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change. > > > > Sample builds: > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242 > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240 > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236 > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235 > > > > failures: > > BluetoothTestWinrtOnly.GattServices_ObserversCalls/0 > > BluetoothTestWinrt.GetPrimaryServices/1 > > BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1 > > BluetoothTestWinrt.GetPrimaryServicesByUUID/1 > > BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0 > > BluetoothTestWinrt.GetGattServices_and_GetGattService/1 > > BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1 > > BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0 > > > > Original change's description: > > > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors > > > > > > This change implements reading and writing of Remote Gatt Descriptors > > > for WinRT. Furthermore, it enables corresponding tests. > > > > > > Bug: 821766 > > > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe > > > Reviewed-on: https://chromium-review.googlesource.com/1156703 > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#579838} > > > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > > > Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 821766 > > Reviewed-on: https://chromium-review.googlesource.com/1159961 > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580062} > > TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 821766 > Reviewed-on: https://chromium-review.googlesource.com/1160902 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580201} TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org Change-Id: I0b4eac30dd4f35b8fb275bed74d69f7b7b1b0f38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766,870208 Reviewed-on: https://chromium-review.googlesource.com/1161681 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580440}
-