- 15 Sep, 2016 40 commits
-
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/7bffcd267301..262052c9261a $ git log 7bffcd267..262052c92 --date=short --no-merges --format='%ad %ae %s' 2016-09-15 reed test/fix/tweak writePicture/readPicture CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=djsollen@google.com Review-Url: https://codereview.chromium.org/2335343009 Cr-Commit-Position: refs/heads/master@{#419028}
-
samuong authored
BUG=chromedriver:1508 TBR=stgao@chromium.org Review-Url: https://codereview.chromium.org/2349463002 Cr-Commit-Position: refs/heads/master@{#419027}
-
gab authored
Grew tired of the post+wait pattern in many tests to flush a base::Thread. Was going to need it again in https://codereview.chromium.org/2333023003/ and decided to add an API for everyone's sake instead :-). Off the top of my head, will also be useful in https://codereview.chromium.org/2299523003/ BUG=646443 Review-Url: https://codereview.chromium.org/2337253003 Cr-Commit-Position: refs/heads/master@{#419026}
-
scottmg authored
Filter out StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched. https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/21323 BUG=504347 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2349503002 Cr-Commit-Position: refs/heads/master@{#419025}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/eb686c79229ef3cf3b39e6a0807f4c98e3e93cf9 Add BuildBucket manifest scheduling support. (dnj@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=chromium:627996 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2348693002 Cr-Commit-Position: refs/heads/master@{#419024}
-
lazyboy authored
There are 3 types of tasks in ExecuteCodeFunction that require FILE thread: a) Reading the file content (for non-component extension files) b) Retrieving the file GURL of the script file from base::FilePath c) content l10n (if the script is CSS) This CL does all of these in on UI->FILE hop and doesn't require additional FILE thread hop. Previously, the most common case, i.e. chrome.tabs.executeScript() with {file:...}, would require UI->FILE->UI->FILE->UI. With this CL this become UI->FILE->UI. This CL accomplishes this with adding an optional callback to FileReader, to specify additional tasks to be run on FILE thread. So the thread hop changes are: Component extension's executeScript() with file:... url would stay same. *All* other means of executing script file:... url, e.g. chrome.tabs.executeScript(,{file:..}) would require two (UI->FILE->UI) less thread hops, whee! BUG=622464 Test=None, internal only change. Review-Url: https://codereview.chromium.org/2301713002 Cr-Commit-Position: refs/heads/master@{#419023}
-
chenwilliam authored
Splits build_applications.py into build_debug_applications.py and build_release_applications.py I simplified devtools BUILD.gn by symlinking/copying all of the source code files & folders vs. previously images, acorn, etc files were copied specifically. Addresses refactoring suggestion from release mode CL comment: https://crrev.com/2262743002/ BUG=none Review-Url: https://codereview.chromium.org/2336943002 Cr-Commit-Position: refs/heads/master@{#419022}
-
gmanikpure authored
BUG=chromedriver:1503 Review-Url: https://codereview.chromium.org/2344573004 Cr-Commit-Position: refs/heads/master@{#419021}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/48c952ad..e9b7e550 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2341193002 Cr-Commit-Position: refs/heads/master@{#419020}
-
alexmos authored
Before this CL, it was possible for a web iframe with an unblessed extension frame to exploit the renderer, create a blob: or filesystem: URL in the extension frame context, then create a new top-level window and navigate it to that URL, which could end up putting the new window into a privileged extension process running attacker's code. BUG=645028 Review-Url: https://codereview.chromium.org/2345473003 Cr-Commit-Position: refs/heads/master@{#419019}
-
jbroman authored
Mark virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-correctness.html as flaky on Linux debug. BUG=647470 TBR=ymalik@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2344033002 Cr-Commit-Position: refs/heads/master@{#419018}
-
hanxi authored
The crash is caused by not including the AIDL files from which the WebApkServiceImpl is inherited in the webapk1.dex. In the build.gn, I move the dependency of webapk_service_aidl from "deps" to "srcjar_deps", since the .java files in the latter will be included in webapk1.dex. BUG=645215 Review-Url: https://codereview.chromium.org/2340853002 Cr-Commit-Position: refs/heads/master@{#419017}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/d2845f7e87aa167cf7df78003b5768f948803d07 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/18ca30ca804679ee624a52e73017d234a8c0008f Teach bot_update to remove partially deleted git repos. (vadimsh@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=647046 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2346993002 Cr-Commit-Position: refs/heads/master@{#419016}
-
muyuanli authored
This CL deprecates setWallpaper call in intent_helper.mojom. It also removes set_wallpaper_delegate.h since it's no longer needed. This is going to be committed only after ag/1432663/ enters canary. Test=Manually test setting wallpaper with OGQ Backgrounds app in Arc++. Bug=642465 Review-Url: https://codereview.chromium.org/2332063004 Cr-Commit-Position: refs/heads/master@{#419015}
-
vakh authored
V4LocalDatabaseManager now tracks the same lists for updates as well as full hashes. SafeBrowsingDatabaseManager tracks only API requests. Also, since hash_tables.h is deprecated, moved all code from base::hash_set to std::unordered_set using sed: $ sed -i 's/base::hash_set/std::unordered_set/g' * BUG=543161, 576864 Review-Url: https://codereview.chromium.org/2345573002 Cr-Commit-Position: refs/heads/master@{#419014}
-
qyearsley authored
In this CL: - Move tokenize_line class method to TestExpectationLine, as suggested by FIXME. - Make tokenize_line non-protected, since it's used in another class, and would be useful in other modules, e.g. update_w3c_test_expectations. - Move class attributes that tokenize_line depends on. - Other changes suggested by linter (e.g. shorten long variable name). This is a preliminary refactoring CL which is intended to make it easier to re-use tokenize_line in update_w3c_test_expectations.py, in order to make it easier to fix http://crbug.com/647395. BUG=647395 Review-Url: https://codereview.chromium.org/2341173002 Cr-Commit-Position: refs/heads/master@{#419013}
-
https://codereview.chromium.org/2307653002/jyasskin authored
Review-Url: https://codereview.chromium.org/2344813004 Cr-Commit-Position: refs/heads/master@{#419012}
-
thakis authored
Revert of Adding target to build SwiftShader (patchset #4 id:60001 of https://codereview.chromium.org/2330173002/ ) Reason for revert: This seems to not build in our sysroot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/5244/steps/compile/logs/stdio Original issue's description: > Adding target to build SwiftShader > > Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. > > BUG=630728 > > Committed: https://crrev.com/72ce608cb69854a0029f019e67ddf1509c274f0a > Cr-Commit-Position: refs/heads/master@{#418934} TBR=sugoi@google.com,sugoi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630728 Review-Url: https://codereview.chromium.org/2349473003 Cr-Commit-Position: refs/heads/master@{#419011}
-
sky authored
As part of this I realized SetLockedToRoot and SetDescendantsStayInSameRootWindow meant the same thing, so I nuked the later. In order to test this I need multiple display support, which isn't quite working yet (in particular shutdown is currently problematic). BUG=615552 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2344783002 Cr-Commit-Position: refs/heads/master@{#419010}
-
jyasskin authored
TBR=bruening@chromium.org BUG=647420 Review-Url: https://codereview.chromium.org/2348453003 Cr-Commit-Position: refs/heads/master@{#419009}
-
lunalu authored
BUG=509735 Review-Url: https://codereview.chromium.org/2310683003 Cr-Commit-Position: refs/heads/master@{#419008}
-
yzshen authored
These new tests measure performance of dispatching incoming messages on the same thread. Currently on Linux: RouterDispatchCost 3.93483e+06 times/second MultiplexRouterDispatchCost 3.39754e+06 times/second BUG=594244 Review-Url: https://codereview.chromium.org/2340363002 Cr-Commit-Position: refs/heads/master@{#419007}
-
davidben authored
Some functions (the ones that do I/O) use this crazy three-level error system (rv, SSL_get_error, and the error queue). Others are more straightforward and simply use the error queue. Using SSL_get_error here could result in state from other operations getting in the way of things. Since these don't actually do I/O and really can only fail on internal error, just map to ERR_FAILED rather than try to have so many MapOpenSSLError variants. Also treat SSL_export_key_material's return value as a boolean. In BoringSSL, the calling convention is simpler and documented as such. BUG=none Review-Url: https://codereview.chromium.org/2342123002 Cr-Commit-Position: refs/heads/master@{#419006}
-
erg authored
This implements a new mus IPC protocol to allow inter-process drag and drop in mus. It handles the entire lifecycle of a drag between two mus Windows, possibly in different processes. This patch does not implement changing the mouse cursor or showing a drag representation, which is queued work. This patch is mus side only; it does not implement the views sided of this protocol, which is next. (With it, you can drag text from the chrome omnibox to the quick launcher and vice versa. You can drag text from the quick launcher to the content area. Etc.) BUG=614037 Review-Url: https://codereview.chromium.org/2266603002 Cr-Commit-Position: refs/heads/master@{#419005}
-
rdevlin.cronin authored
Add logic to open options pages that open in tabs (embedded options pages still to come). Add a test for the same. BUG=529395 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2329443004 Cr-Commit-Position: refs/heads/master@{#419004}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/8f53f54a9cca..0a17fafd723e $ git log 8f53f54a9..0a17fafd7 --date=short --no-merges --format='%ad %ae %s' 2016-09-15 tonikitoo Use either /RECT or /QuadPoints for annotation coordinates, depending on /AP 2016-09-15 npm Use ToUnicode mapping even when unicode is 0. 2016-09-15 npm Deleted unused defintions and methods from PWL_FontMap 2016-09-15 dsinclair Cleanup CFX_SystemHandler. 2016-09-15 dsinclair Use safe math when rendering line segments in AGG. 2016-09-15 dsinclair Replace FX_UINT with unsigned int BUG=647026 TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2342113002 Cr-Commit-Position: refs/heads/master@{#419003}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/615af784ab6e..7bffcd267301 $ git log 615af784a..7bffcd267 --date=short --no-merges --format='%ad %ae %s' 2016-09-15 bsalomon Fix key computation for GrPaths 2016-09-15 mtklein GN: port Valgrind bots. 2016-09-15 bsalomon Add GrContextOptions flag to disable distance field path renderer. 2016-09-15 robertphillips Fix color bug in SkRRectsGaussianEdgeShader CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=djsollen@google.com Review-Url: https://codereview.chromium.org/2348623002 Cr-Commit-Position: refs/heads/master@{#419002}
-
watk authored
Previously it was possible for GVD to be processing a Flush() but not have no outstanding bitstream buffers in the VDA when it received a NotifyError(). For example, when decoding single frame videos. In that case it went into the error state but never propagated the error. Now, if an error is received while in the flushing state, the error is propagated by calling the decode cb corresponding to the EOS buffer. BUG=647081 TEST=manually verified that AVDA decode errors now propagate to WMPI Review-Url: https://codereview.chromium.org/2344703003 Cr-Commit-Position: refs/heads/master@{#419001}
-
gayane authored
Fixing the flaky unittest by correcting the wrong measurement units. This CL also enables the test for mac bots. BUG=645538, 646758 Review-Url: https://codereview.chromium.org/2344673002 Cr-Commit-Position: refs/heads/master@{#419000}
-
alokp authored
BUG=571155 Review-Url: https://codereview.chromium.org/2340423002 Cr-Commit-Position: refs/heads/master@{#418999}
-
junov authored
The lack of gpu context recovery was causing some layout tests to be flaky. After running the test virtual/gpu/fast/canvas/canvas-lost-gpu-context.html all subsequent gpu tests run in the same instance of content_shell would fail. BUG=646973 Review-Url: https://codereview.chromium.org/2335223004 Cr-Commit-Position: refs/heads/master@{#418998}
-
benzh authored
The behavior of MediaStreamAudioTrack::Configure() has changed: Configure() used to be able to complete before any audio sample is received because the AudioParameter can be obtained from a WebRtcLocalAudioTrack according to https://codereview.chromium.org/857093002 After the media stream refactoring http://crbug.com/577874 Configure() remains pending until the first audio frame is received. For always-on hotword detection with a DSP audio source, no audio sample is sent until the DSP detects a potential hotword trigger. This patch removes MS_CONFIGURED timeout so that the plugin can keep waiting for a hotword instead of reporting a timeout error. BUG=616203 TEST=Verified always-on hotwording on Samus and Chell Signed-off-by:
Ben Zhang <benzh@chromium.org> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2306803003 Cr-Commit-Position: refs/heads/master@{#418997}
-
geofflang authored
This test doesn't run fast enough to always finish within the hard-coded 45 second time limit. R=kbr@chromium.org TBR=piman@chromium.org BUG=646442 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2346883002 Cr-Commit-Position: refs/heads/master@{#418996}
-
cwallez authored
https://chromium.googlesource.com/angle/angle.git/+log/09cfac6..415f29e BUG= TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2347683002 Cr-Commit-Position: refs/heads/master@{#418995}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/194bd0247efb60371dbcae87731f13dce4fa7934 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/adcd4b78d5f35da535ccf82a221afb9fa389f631 presubmit_support: Remove a noisy logging.debug() (thakis@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=none Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2346883004 Cr-Commit-Position: refs/heads/master@{#418994}
-
alokp authored
BUG=571155 Review-Url: https://codereview.chromium.org/2348603002 Cr-Commit-Position: refs/heads/master@{#418993}
-
miu authored
Revert of Enable whitelisting for targets other than libchrome. (patchset #8 id:40002 of https://codereview.chromium.org/2336033002/ ) Reason for revert: Broke ninja on Linux x64: ninja: Entering directory `out/Release' [1/1] Regenerating ninja files FAILED: build.ninja /mnt/ssd/miu/chromium/src/buildtools/linux64/gn --root=/mnt/ssd/miu/chromium/src -q gen //out/Release/ ERROR at //chrome/BUILD.gn:1358:5: Undefined identifier. public_deps += [ ":default_apps" ] ^---------- See //BUILD.gn:211:7: which caused the file to be included. "//chrome", ^--------- ninja: error: rebuilding 'build.ninja': subcommand failed Original issue's description: > Refactor chrome resource targets into chrome_paks.gni > > This will allow monochrome to easily define its own set of the same > targets with a different resource whitelist > > BUG=641032 > > Committed: https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e > Cr-Commit-Position: refs/heads/master@{#418966} TBR=brettw@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641032 Review-Url: https://codereview.chromium.org/2348643002 Cr-Commit-Position: refs/heads/master@{#418992}
-
jennyz authored
BUG=646037 Review-Url: https://codereview.chromium.org/2343973002 Cr-Commit-Position: refs/heads/master@{#418991}
-
arthursonzogni authored
Opening a link in a new tab/window was broken with PlzNavigate. This CL solves the majority of broken tests. There is still 3 browser_tests that doesn't work properly yet, but it seems to me this is unrelated to click modifiers (ctrl/shift/meta+click). Timeout: ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin Flaky fail: ClickModifierTest.WindowOpenControlShiftClickTest ClickModifierTest.WindowOpenBasicClickTest BUG=644116 R=clamy@chromium.org Review-Url: https://codereview.chromium.org/2323153003 Cr-Commit-Position: refs/heads/master@{#418990}
-
Pawel Hajdan, Jr authored
We need to configure code to use built-in data from system library, not a separate file shipped with Chrome. BUG=551343 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/2339173005 . Cr-Commit-Position: refs/heads/master@{#418989}
-