- 13 Jan, 2021 40 commits
-
-
Sigurd Schneider authored
DevTools front-end CL: https://crrev.com/c/2622195 Bug: chromium:1069378 Change-Id: I51a66ebe85e2036a0939364e0c1e4cb9d525429a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622114 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#842946}
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2584978 Disable tests CLs: https://crrev.com/c/2584848 https://crrev.com/c/2592797 Bug: 1152082 Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k Change-Id: I200074600b3e82404bc42694defa6a407ded6e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587035 Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#842945}
-
Richard Knoll authored
These metrics are no longer useful for us and have expired in M87: - Sharing.DeviceInfoAvailable - Sharing.DeviceLastUpdatedAge.* - Sharing.DeviceLastUpdatedAgeWithResult.* - Sharing.MajorVersionComparison.* - Sharing.SharedClipboardRetries.* Bug: 1125773, 1125771, 1125770 Change-Id: I34261e33f5789b1d3b864bf8a960ce3b1f7bd346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621815Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842944}
-
Maxim Kolosovskiy authored
This reverts commit 8aca3b4d. Reason for revert: I suspect the CL caused WindowOpenApiTest.PopupBlockingExtension failure https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/22177/overview [ RUN ] WindowOpenApiTest.PopupBlockingExtension 2021-01-13T05:48:40.927570Z INFO browser_tests[28993:28993]: [content_main_runner_impl.cc(1055)] Chrome is running in full browser mode. 2021-01-13T05:48:41.111260Z WARNING browser_tests[28993:28993]: [audio_manager_linux.cc(69)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized. 2021-01-13T05:48:41.147293Z ERROR browser_tests[28993:28993]: [cras_audio_handler.cc(1627)] Failed to retrieve WBS mic deprioritized flag 2021-01-13T05:48:41.148942Z WARNING browser_tests[28993:29172]: [statistics_provider.cc(321)] Finished loading statistics. 2021-01-13T05:48:41.786294Z WARNING browser_tests[28993:28993]: [user_policy_manager_builder_chromeos.cc(123)] No policy loaded for known non-enterprise user 2021-01-13T05:48:42.161192Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:42.192143Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:42.205962Z ERROR browser_tests[28993:28993]: [proximity_auth_profile_pref_manager.cc(192)] Failed to find local state prefs for current user. 2021-01-13T05:48:42.726389Z WARNING browser_tests[28993:28993]: [merge_session_throttling_utils.cc(143)] Loading content for a profile without session restore? 2021-01-13T05:48:43.054799Z WARNING browser_tests[28993:28993]: [wallpaper_controller_client.cc(377)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. 2021-01-13T05:48:43.218141Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:43.726830Z WARNING browser_tests[29202:29284]: [http_cache_transaction.cc(1192)] Unable to open or create cache entry 2021-01-13T05:48:44.322210Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:44.376219Z ERROR browser_tests[28993:28993]: [plugin_vm_manager_impl.cc(141)] New session has dispatcher unexpected already running. Perhaps Chrome crashed? 2021-01-13T05:48:44.859368Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(495)] One-time key permissions migration started for token: 0. 2021-01-13T05:48:44.863796Z INFO browser_tests[28993:28993]: [android_sms_pairing_state_tracker_impl.cc(72)] No Pairing cookie found 2021-01-13T05:48:45.010359Z ERROR browser_tests[28993:29140]: [object_proxy.cc(621)] Failed to call method: org.chromium.U2F.IsUvpaa: object_path= /org/chromium/U2F: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.U2F was not provided by any .service files 2021-01-13T05:48:45.018258Z ERROR browser_tests[28993:29172]: [als_reader.cc(47)] Missing num of als 2021-01-13T05:48:45.681453Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.682492Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.685002Z INFO browser_tests[28993:28993]: [key_permissions_manager_impl.cc(520)] One-time key permissions migration succeeded for token: 0. 2021-01-13T05:48:45.768048Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:45.769933Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:46.230042Z WARNING browser_tests[28993:28993]: [browser_util.cc(167)] Lacros-chrome is not supported 2021-01-13T05:48:50.078030Z ERROR browser_tests[28993:29172]: [object_proxy.cc(621)] Failed to call method: org.chromium.debugd.GetPerfOutputFd: object_path= /org/chromium/debugd: org.freedesktop.DBus.Error.ServiceUnknown: The name org.chromium.debugd was not provided by any .service files 2021-01-13T05:49:10.763123Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico 2021-01-13T05:49:10.833186Z WARNING browser_tests[28993:29410]: [embedded_test_server.cc(668)] Request not handled. Returning 404: /favicon.ico ../../chrome/browser/extensions/window_open_apitest.cc:91: Failure Expected equality of these values: num_browsers Which is: 4 chrome::GetBrowserCount(browser->profile()) Which is: 2 Google Test trace: ../../chrome/browser/extensions/window_open_apitest.cc:76: WaitForTabsPopupsApps tabs:5, popups:2, app_popups:1 Stack trace: #0 0x56363e71a458 extensions::WaitForTabsPopupsApps() #1 0x56363e71c5aa extensions::WindowOpenApiTest_PopupBlockingExtension_Test::RunTestOnMainThread() #2 0x563646f1d248 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #3 0x563646f207ca base::internal::FunctorTraits<>::Invoke<>() #4 0x563646f20741 base::internal::InvokeHelper<>::MakeItSo<>() #5 0x563646f206e7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #6 0x563646f2068c base::internal::Invoker<>::RunOnce() #7 0x56363c76ba61 _ZNO4base12OnceCallbackIFvvEE3RunEv #8 0x563645c03021 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #9 0x563645c01fc2 ChromeBrowserMainParts::PreMainMessageLoopRun() #10 0x563640599fc6 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #11 0x7fb5dc82e9e5 content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x7fb5dc8383ca base::internal::FunctorTraits<>::Invoke<>() #13 0x7fb5dc8382e1 base::internal::InvokeHelper<>::MakeItSo<>() #14 0x7fb5dc838267 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #15 0x7fb5dc83820c base::internal::Invoker<>::RunOnce() #16 0x7fb5dcc03581 _ZNO4base12OnceCallbackIFivEE3RunEv #17 0x7fb5dda03df6 content::StartupTaskRunner::RunAllTasksNow() #18 0x7fb5dc82d3ad content::BrowserMainLoop::CreateStartupTasks() #19 0x7fb5dc83bfd3 content::BrowserMainRunnerImpl::Initialize() #20 0x7fb5dc82a804 content::BrowserMain() #21 0x7fb5de9aae56 content::RunBrowserProcessMain() #22 0x7fb5de9ac3c9 content::ContentMainRunnerImpl::RunBrowser() #23 0x7fb5de9abd27 content::ContentMainRunnerImpl::Run() #24 0x7fb5de9a9106 content::RunContentProcess() #25 0x7fb5de9a9a3d content::ContentMain() #26 0x563646f1cb13 content::BrowserTestBase::SetUp() #27 0x563645acb283 InProcessBrowserTest::SetUp() #28 0x563645ab3802 extensions::ExtensionBrowserTest::SetUp() #29 0x56364163b48b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x56364162ee67 testing::internal::HandleExceptionsInMethodIfSupported<>() Original change's description: > Support multiple receivers for Cros APIs. > > With this CL, most of Cros API starts to support multiple receivers. > AshChromeService and LacrosChromeService are exceptions. > > Bug: 1148448 > Test: Build and run Lacros on a DUT. > Change-Id: I1d1a0be111108ae15657d81ea747750a760bd2f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624323 > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842869} TBR=jamescook@chromium.org,hidehiko@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id097eab1934d9a2afca29f249a007de57ef18d90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626229Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842943}
-
Colin Blundell authored
This CL continues with the abstraction of dependencies on signin and sync from //components/safe_browsing's access token fetching flow in order to enable reuse by WebLayer. The concrete step taken here is to abstract the dependencies on //components/safe_browsing/core/browser/sync from RealTimeUrlLookupService, passing these dependencies in via the constructor. There are no behavioral changes in this CL: - //chrome and //ios/chrome's factories glue the relevant parameters from //components/safe_browsing/core/browser/sync - //weblayer's factory passes in values for the parameters such that access token fetching for URL lookups continues to be disabled in WebLayer Followup work will bring up support for access token fetching in WebLayer. Bug: 1080748 Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#842942}
-
Gauthier Ambard authored
This CL makes sure that the constraints of the fakebox are correctly updated when there is only one toolbar. In particular, those constraints were broken when rotating from portrait to landscape. Fixed: 1161448 Change-Id: I80dbfc524010915e381a4129208471b9e142b351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623013 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#842941}
-
arthursonzogni authored
Instead of trying to forward fix, dumbly revert the cause of crashes. Hopefully, just in time before M89 branch cut. This revert will fix: - https://crbug.com/1153966 - https://crbug.com/1153961 This revert part of: https://chromium-review.googlesource.com/c/chromium/src/+/2548022 ``` Retire ScopedObserver in /chrome/browser/ui/views. ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=bsep@chromium.org Bug: 1145565 ``` There was an existing bug. Unexpectedly, HungPagesTableModel:: InitForWebContents() can be called twice. See https://crbug.com/1165917. For some reasons, this didn't resulted in any crashes... ...until the reverted patch cames in. The old base::ScopedObserver was supporting multiple observations. The new one: base::ScopedObservation doesn't. As a result, if base::ScopedObservation::Observe is called twice, then RemoveObserver will be called only once instead of two, causing the issue. Bug: 1153966,1153961 Change-Id: Iecc8e8e0e9fa387795ce55b4414d1d871cc4c9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625867Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842940}
-
Aya ElAttar authored
Changed DragDropController to: - Cancel drop if not allowed by policy rules. - Show CursorType::NoDrop while dragging if the policy rules disallow the data from being dropped. Bug: 1139886 Change-Id: I8a12f1f4af2fa0f21d4d562d393d9f64cec39f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595382Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842939}
-
Reid Kleckner authored
Disable TwoClientSendTabToSelfSyncTestWithSendTabToSelfWhenSignedIn.SignedInClientCanReceive in component builds This test times out in optimized (is_debug=false) component builds. It passes in is_debug=true component builds. I can't explain that behavior, but disable it in all component configs to be on the safe side. R=victorvianna@google.com Bug: 1166032 Change-Id: Ie39ffcfe06531c5a2039b22c8c3fbcd306fbe510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626761 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#842938}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08b9eb7a896f..4ecb2f5fc58f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I38468bfcfa572f453226e5ee270ba2da7a86a2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627128Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842937}
-
Lingqi Chi authored
https://chromium-review.googlesource.com/c/chromium/src/+/2583677 only set the prerendering state for main-frame navigation. This CL shares parents' prerendering states with their children, so that sub-frames can also know the correct prerendering state. Bug: 1142658 Change-Id: I70552d4dc6380f91536e062ad2ea3ec8d0719b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603660Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#842936}
-
Song Fangzhen authored
This CL builds on https://chromium-review.googlesource.com/c/chromium/src/+/2606873 We update the MockNetworkContext and MockHostResolver to make them behave the same as in network when resolving hostnames. And the tests should all pass whithout special machines' failures. Bug: 1141241 Change-Id: Iffeec31910faafe7e42dd42d15ee4ce63ec9a33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624316 Commit-Queue: Ke He <kehe@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#842935}
-
Yoshifumi Inoue authored
This patch changes |CachedTextInputInfo::GetPlainTextRange()| to return empty |PlainTextRange| when passed range is outside of cached text to avoid crash when selection moved during IME text composition. This case is happend with following scenario: 1. Start IME text composition 2. Move selection to another content editable 3. |InputMethodController::TextInputInfo()| in |FrameSelection::SetSelection()|. 4. |InputMethodController::WillChangeFocus()| is called to clear IME text composition from |FocusController|. Bug: 1157910, 1161562 Change-Id: I38ed328558a572388d9e715dd6f6cae481b868e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626624 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#842934}
-
Hayato Ito authored
It looks generate-test-wbns.sh fails with two errors: 1. nested/resource.js is missing 2. cors/resource.json is wrong. It should be cors/resource.cors.json BUG=1082020 Change-Id: I18a87f59784d6c36e050a64567c1ba671af0468a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627209Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842933}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610495996-ac73e18e1b2efb1cd1bfbf2a2aaf90e9e3476b5a.profdata to chrome-linux-master-1610517435-75fc59b03a49bc3203d88e1f39423cb5de4c8383.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib11113d54ddcdc8bcf3a36c13ce683e3af1f0092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627035Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842932}
-
Peter E Conn authored
This is a temporary class that will allow us to move things around more easily without breaking downstream. Change-Id: Ifc36c7d582ed9d2dea512a000bcb9d85fcbdd6ab Bug: 1164866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623290Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842931}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - naming_controller.js In //ui/file_manager/file_manager/foreground/js/ui/: - search_box.js - autocomplete_list.js Bug: 1133186 Change-Id: Ie31eb3bb909b274636bd28400fc6b6add9c94d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626699 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#842930}
-
Mihai Sardarescu authored
The method OnUnconsentedPrimaryAccount() is obsolete now (as all observers were converted to use OnPrimaryAccountChanged()) so this CL removes it. Bug: 1158855 Change-Id: Ice0ffc2b2f19597602837371ee05a71d27ee697f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624668 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842929}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610495996-38f3d5c57ab4be3d52eaefe38d45ce16ec0addd8.profdata to chrome-mac-master-1610517435-0b7576a8f42d1cf58a978eb4b1fa934cc5ba313f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I91347340172b8185305362e099f59ec0b9107eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627129Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1e60bce4..d98dd8de Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d7c951d033bea3733bb10c5d27290d35985319c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627047Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842927}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 201f15f1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ia76bdc513efc319864f71758787b415e82617a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626251Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842926}
-
Owen Min authored
Disable benchmarks.blink_perf_unittest.BlinkPerfTest.testExtraChromeCategories on Linux and CrOS due to flaky. Bug: 1163628 Change-Id: I3b7093890b12e4e63eb2bdee5bf816d03f948015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626168 Auto-Submit: Owen Min <zmin@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#842925}
-
Alice Wang authored
This CL moves account picker bottom sheet MVC to signin.ui target. Bug: 1149857 Change-Id: Ifc32d7d39b69bb052ad3b4bddbe576d4cbe5a059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613972 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#842924}
-
Alice Wang authored
This CL adjusts the if branch in AccountManagementFragment after removing sign-out allowed pref value. Bug: 1162231 Change-Id: I463913e92c45de052c0272a478282fb3c2ad1932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624647Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842923}
-
Aga Wronska authored
The correct component name is FamilyExperiences. Bug: 1165368 Change-Id: Ie206eb950cae0243baa5a655d8c12dff506a4066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625369 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#842922}
-
Luciano Pacheco authored
Add JS modules for //ui/file_manager/file_manager/foreground/js/ui/ : - location_line.js - banners.js - providers_menu.js Bug: 1133186 Change-Id: I6200138fbf3507a38cb08d8ace292c62526e4ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627208 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#842921}
-
Luciano Pacheco authored
Add JS modules for //ui/file_manager/file_manager/foreground/js/u/ : - breadcrumb.js - breadcrumb_unittest.js - gear_menu.js - import_crostini_image_dialog.js - install_linux_package_dialog.js - install_linux_package_dialog_unittest.m.js Bug: 1133186 Change-Id: I4dddd38ede167983f2f45a97f4205dddfb9e5373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626849 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610495996-7189a1d14c9908600535ebce9352fe55a59722e6.profdata to chrome-win64-master-1610505994-ce0c95957b1d27284e834682f26210d976ec22d1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iba2277867181ab35c0d0d717e70c991b989ec491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627027Reviewed-by:
-
Luciano Pacheco authored
Add JS modules for //ui/file_manager/file_manager/foreground/js/ : - task_history.js - quick_view_model.js - metadata_update_controller.js - last_modified_controller.js Add JS modules for //ui/file_manager/file_manager/foreground/js/ui/ : - actions_submenu.js - actions_submenu_unittest.m.js Remove tearDown() from actions_submmenu_unittest because now the setUp() always replace the whole DOM content, so the DOM reset in tearDown() isn't necessary anymore. Bug: 1133186 Change-Id: I8ca80a94dd2be9e5f354bcc54b6883b8df3cedd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626678 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2881d6b22d1e..44ba8e1708ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib65ede43af21321eb33d7a95b032c1f72eda5c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626460Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a69b4bb071c..be2a8614c5d6 2021-01-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b9b9a8a5 to 8aca3b4d (503 revisions) 2021-01-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5b8dec52b68f to 2ed9671a0ddd (8 revisions) 2021-01-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 9ff83f6c957f to 424fd828893e (13 revisions) 2021-01-12 mtklein@google.com Revert "sketch Half in skvm" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Test: Test: Test: Aztec Ruins MECTest: Test: Fortnite on ANGLE Change-Id: Icfd629e6053b4280fc21eed25d4def3c80f5428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625845Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3889691dd695..178c01be65a4 2021-01-13 dberris@chromium.org chromeperf: Anomaly configs in subscriptions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: eseckler@google.com Change-Id: I6fe53482f865121820fa4cab5b144194e813a213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627028Reviewed-by:
-
Maksim Sisov authored
.. number_formatting.cc It was required to initialize ICU with InitializeICUForTesting to fix that as WaylandBufferManagerHost may call base::FormatNumber in certain conditions that requires ICU initialized. Also, remove call expectation for zwp_linux_dmabuf_v1.CreateParams as it's not guaranteed that it will be called (if parameters are invalid, zwp_linux_dmabuf_v1 is never called). Last but not least, always check if the terminate gpu callback is fired. If it is fired, set a callback again and continue running current fuzz test case to verify that WaylandBufferManagerHost doesn't crash even after it has already fired one terminate gpu callback that a potential client just ignored. Bug: 1164654 Change-Id: Ia3f0c248a1e9587a63d9d4cc230defc39357e8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624210Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#842914}
-
Junji Watanabe authored
CAS is already available on production, and developers should be able to use it instead of Isolate server. Bug: 1163817 Change-Id: I1ea0333725eb8c6337507605781e9c3e29b4f5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626816 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#842913}
-
Wolfgang Beyer authored
Introduced in https://crrev.com/c/2574985 Bug: 1072335 Change-Id: I57a42b17dafa55c4f7b4c12bae32f72d7be12321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623945Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842912}
-
Vidhan authored
Currently, FieldFiller static_casts AutofillDataModel to either AutofillProfile or CreditCard. These casts are not guarded and may prevent autofilling. This is prevented by introducing absl::variant<const AutofillProfile*, const CreditCard*> and removing the static_casts. Bug: 1147883 Change-Id: I4768c8f60429ede281e4a804512e519af34dc111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560746Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#842911}
-
Ramin Halavati authored
"Signin.Intercept.Guest.Availability" metric is added to record if Guest option is available at signin intercept or not and why. Bug: 1157764 Change-Id: I00dc3bb07b6b6cec758c206b1046a0c2e767d7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620621Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76d89fa22033..08b9eb7a896f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yukishiino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yukishiino@google.com Change-Id: I9daf3dfd7eb0c419a63096bf3549f5525f5f21d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625844Reviewed-by:
-
Alex Moshchuk authored
Looks like one line of a comment near the end of this function was accidentally deleted in https://chromium-review.googlesource.com/c/chromium/src/+/2230632. This CL restores it. Change-Id: I081e0a184f2468e5e6e60a63446a9fa5cca2a0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626907 Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842908}
-
Sara Kato authored
Bug: crbug/1159562 Test: build Change-Id: Icc582dd5ffe43c94e9d06bf98d4ac470af01ea27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617401Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842907}
-
