GitLab

This CL changes some old content Polymer slotting with the newer keyword
slot. These are the simple, unnamed cases in MD settings. The cases that
use slot names will be done separately.

Bug: 739532
Change-Id: I7a4bd4c186f1e4e576bb19569bdd45a9264a1ff0
Reviewed-on: https://chromium-review.googlesource.com/564062Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486945}

Previously, we omitted these clips, as an inadvertent side-effect
of avoiding clipping to the dirty rect.

Bug: 734116
Change-Id: I6dcd92b80b8158f36689d5b48d92a0bdf43bb016
Reviewed-on: https://chromium-review.googlesource.com/567520
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486944}

The blocking pool has been deprecated in favor of TaskScheduler.

Bug: 667892
Change-Id: Iabaa23abc14ade5b5c0e4ed9bee6b8f574d7b689
Reviewed-on: https://chromium-review.googlesource.com/571306Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486943}

Up until now, each in-product help feature has recorded their own
histogram for how often they are triggered. However, this makes it
hard to inspect the overall data for how often in-product help is
triggered in general.

This CL therefore adds a new histogram that is triggered regardless of
which feature invoked it: InProductHelp.ShouldTriggerHelpUI. That name
is also the base name for the suffix-based feature specific histograms.

In addition, tests are added to ensure these histograms behave as
expected.

BUG=733799

Change-Id: I9c99494dc64f9c20fc2e811d7596ff0d7a7f72c2
Reviewed-on: https://chromium-review.googlesource.com/569259
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486942}

This CL moves PrimaryBeginFrameSource to components/viz/service/frame_sinks
and updates all the appropriate includes, forward declarations, and
namespaces.

Bug: 722935
Change-Id: I8f7021a1cc1b262c1ebc18ee5ff1287eb91772ef
Reviewed-on: https://chromium-review.googlesource.com/571268
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486941}

Bug: 741969
Change-Id: Id80b178aee043babd25a533e21fc25118a446d77
Reviewed-on: https://chromium-review.googlesource.com/572424Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486940}

We have collected adequate data from
Cookie.CookieLineCookieValueValidity. Remove it.

BUG=638117

Change-Id: Iab9d2b095cebda9a4b1cf0fdb572aa6ee30a457d
Reviewed-on: https://chromium-review.googlesource.com/571884Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486939}

BUG=725605,740044,741047

Change-Id: Ibeee3338455826284044df7695681af319547bad
Reviewed-on: https://chromium-review.googlesource.com/572380Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486938}

The reasons to require are being a LayoutBox, and either having
overflow clip or needing a resizer.

Bug: 467721
Change-Id: If79f1855dfaed6dc60ebd86a2d7e02ebbc1c382d
Reviewed-on: https://chromium-review.googlesource.com/568904
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486937}

Reason for TBR: sheriffing, making the tree green

TBR: suzyh
Bug: 743009
Change-Id: I3cceb99b3fa73bec5b4940f3f3f39ab737130a67
Reviewed-on: https://chromium-review.googlesource.com/572334Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486936}

BUG=667892
R=gab@chromium.org

Change-Id: If4c7bdd1a8109a38cf0dc1081234e025e267f217
Reviewed-on: https://chromium-review.googlesource.com/570732Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486935}

There will be one shared block cache for all users of
LevelDB::Init, and a separate one for All IndexedDB
instances. The default is 8MB, but it's 512KB for
low-memory Android devices.

Previously, each instance would get its own block cache, and use
the default LevelDB settings for such a cache, which is 8MB (*)

(*) https://cs.chromium.org/chromium/src/third_party/leveldatabase/src/include/leveldb/options.h?gsn=Options&l=96

Bug: 711518
Change-Id: I6a64467815489ae7695b8db9b9074170d9e56d94
Reviewed-on: https://chromium-review.googlesource.com/567583
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486934}

On Mac it can happen that certain cameras stop working system-wide after Chrome 
has been running for a while (potentially days) and the computer has gone 
through sleep/wakeup cycles.

This could potentially be related to DeviceMonitorMac interacting with 
VDCAssistant either at a bad time or in a bad way. To be able to test this 
theory, this CL adds a feature switch that allows disabling the use of 
DeviceMonitorMac.

Bug: 699446
Test: Run chromium on Mac with --disable-features=DeviceMonitorMac
Change-Id: Id2a06c75bca7ec8e2db37b4b9647fe508edb0327
Reviewed-on: https://chromium-review.googlesource.com/558199Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486933}

Refine the pin keyboard UI in the lockscreen which includes 
1. Update the style/icon of the pin button
2. Tweak the spacing between user view, password view and pin keyboard.
3. Add ripple to pin button. 

Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCHm5Lyh8lQ6SZ3vjzwd3Uo8wMSJbxAVNpw


Bug: 719015
Change-Id: I83a2ea93848498f9bb4023cfb677aa176b3b4174
Reviewed-on: https://chromium-review.googlesource.com/562239Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486932}

Re-land of https://codereview.chromium.org/2978723002 with a fix
for UBSan.

Bug: 701919
Change-Id: I75f798dab00c966d8a1ecdebc519a0251f914700
Reviewed-on: https://chromium-review.googlesource.com/572186Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486931}

This effectively reverts https://codereview.chromium.org/2556803003/
as we're now using a different approach since
https://chromium-review.googlesource.com/569119
The original fix did not work anyway, see
https://bugs.chromium.org/p/chromium/issues/detail?id=490148#c17 for details.

Bug: 490148, 553246
Change-Id: Id8c395eeaf3ed1c9e8404f11705ab147869a4ff1
Reviewed-on: https://chromium-review.googlesource.com/570197Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486930}

Integrates the GCC subtract-carry intrinsics for intel, etc, and the
saturated instructions on arm.

Bug: 672489
Change-Id: I5db9d94224ab9c87fb025e0150879558a64f238f
Reviewed-on: https://chromium-review.googlesource.com/571404
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486929}

BUG=490942
R=skobes@chromium.org

Change-Id: I290bed7089f16e19523cabbe66ea57f607c25135
Reviewed-on: https://chromium-review.googlesource.com/526369Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486928}

The sign-in promo view in the tab switcher should use ACCESS_POINT_TAB_SWITCHER
access point (instead of ACCESS_POINT_RECENT_TABS. Also adding histograms
for the tab switcher (instead of using the one for recent tabs).

Bug introduced with crrev.com/2885943002
Histograms added with crrev.com/2871753002

Bug: 742331
Change-Id: I9ac3864ba692081115df7f368417a82673bf1b62
Reviewed-on: https://chromium-review.googlesource.com/570958Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486927}

Some Chromebooks have a dedicated "Hamburger" key which is supposed
to invoke quick settings when pressed.

We already have a definition of "AL Control Panel" key in HID
specification, and we had DomCode::LAUNCH_CONTROL_PANEL and
DomKey::SETTINGS definitions, but now we want to use it in accelerators
and so we need to allocate a VKEY for it.

We define a new VKEY_SETTINGS with keycode 0x9A, which is next unmapped
keycode on Windows. This new VKEY is POSIX-specific.

For the DOM code we are using the next available code as well: 0x0B0F

BUG=b:63576567

Change-Id: I3e9b3d8b721334114e282fff000d54a031fdc9ae
Reviewed-on: https://chromium-review.googlesource.com/571160Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dmitry Torokhov <dtor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486926}

The connection is force closed when a transaction is aborted
mid-execution. The "While" tests failed to catch this, so
added another EXPECT_CALL for ForcedClose().

Bug: 742503
Change-Id: Id56a5cced876bc8a4d02c60a29e20471085a29ac
Reviewed-on: https://chromium-review.googlesource.com/571197
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486925}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a47a2b11..86730555

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ib20ac3dd51ea14d324d126479ccb391c5cc92c40
Reviewed-on: https://chromium-review.googlesource.com/572280Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486924}

BUG=internal b/22512618
TEST=Unit tests passed on cast targets

Change-Id: Ia19432ec97343a95777b3580b5d99e0f594ba3ae
Reviewed-on: https://chromium-review.googlesource.com/569678Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486923}

Since the real dependency is for Download Manager to suggest the
installation of Google Drive if Google Drive is not already installed,
it will make the implementation much simpler to directly query
existence of Google Drive app than to go through Google App Launcher.

Bug: 741948
Change-Id: Id121fed82ccf578c4d1373089df0e3045a7fe2c8
Reviewed-on: https://chromium-review.googlesource.com/568635Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486922}

changes:
app_list_folder_view ctor/dtor sets/resets |folder_delegate_| in
apps_grid_view. We could use it to determine whether to layout suggested
apps and indicators or not.

TEST: tested that suggested apps/indicators doesn't show in folder view
Bug: 743180
Change-Id: I22cdbd573dca877af726f25f53531fac1c4f40c2
Reviewed-on: https://chromium-review.googlesource.com/572364Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486921}

Bug: 719015
Change-Id: I464db646324b3ff9da3ecb203b36f82b8edc81ae
Reviewed-on: https://chromium-review.googlesource.com/563977Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486920}

Currently, connections are kept open indefinitely, which
can block future loads from a server if there are 6 or more
<video> tags on the same page.  This should fix that in most
cases.

BUG=716748

Review-Url: https://codereview.chromium.org/2979893002
Cr-Commit-Position: refs/heads/master@{#486919}

https://skia.googlesource.com/skia.git/+log/8abb9f453798..f2c901474c24

$ git log 8abb9f453..f2c901474 --date=short --no-merges --format='%ad %ae %s'
2017-07-13 brianosman Add GN arg to allow Flutter-specific API guards
2017-07-14 liyuqian Simplify Sk4i's Min/Max

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=ethannicholas@chromium.org

Change-Id: Icac0cbdcd4edbbcec072aba1debaf550a3bd1517
Reviewed-on: https://chromium-review.googlesource.com/572058Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486918}

My change in #486768 flipped this builder from ChomeOS/X11 to
ChromeOS/Ozone, but it looks like that config may not successfully
build 'All' correctly. This change reverts the config for that
particular builder (so that we keep building X11 for now), but
we need to fix the build so that it is using Ozone instead.

TBR=kbr@chromium.org, jmadill@chromium.org, kylechar@chromium.org, fhenigman@chromium.org
NOTRY=true
BUG=671355, 743257

Change-Id: Ic4739ef28a35fa556c662ba19221530217f0556f
Reviewed-on: https://chromium-review.googlesource.com/572384
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486917}

This reverts commit 191d1148.

Reason for revert: NaCl broke on the Linux x64 builder

Original change's description:
> Replace Saturated*() calls with Clamp*() templates
> 
> This replaces the calls but leaves the saturated_arithmetic headers
> where they are. Those will be moved in the next CL.
> 
> Bug: 672489
> Change-Id: If901e49240b2e8d1f85155b9b395d9bb584300cf
> Reviewed-on: https://chromium-review.googlesource.com/571317
> Commit-Queue: Justin Schuh <jschuh@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486905}

TBR=danakj@chromium.org,jschuh@chromium.org,eae@chromium.org

Change-Id: I6515c4ffa226fe39027c91f77d42051f2638686e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 672489
Reviewed-on: https://chromium-review.googlesource.com/572307Reviewed-by: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486916}

Bug: chromedriver:1878
Change-Id: I134077a3583feffb5e2f9b15293c435d07a20e0e
Reviewed-on: https://chromium-review.googlesource.com/572333Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486915}

Log the scores when the Media Engagement service is started to
see the distribution of scores across users.

BUG=740106

Change-Id: I539e0c0542caf3d0c094d76c3eb4798ae7a5e300
Reviewed-on: https://chromium-review.googlesource.com/566958Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486914}

Bug: 734132

Changes this patch:
- Added a raw pointer factory for NewTabPromo

Change-Id: I670b4d8a3e1c56ad345780c05d6e2f6e922da10c
Reviewed-on: https://chromium-review.googlesource.com/546943
Commit-Queue: Christopher Benson <chrisbenson@google.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486913}

TBR: scheib@chromium.org
Change-Id: Id7dfb8b7163c3c87ed71c0257187850ad97c6c3c
Reviewed-on: https://chromium-review.googlesource.com/572236Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486912}

This adds TileDrawQuad as possible overlay candidate by
setting up the candidate overlay with right properties from
the draw quad. Also adds debug color borders for them.

BUG=735933

Change-Id: I5646c66e304aafb470e76eaf31a990b7e3ddc155
Reviewed-on: https://chromium-review.googlesource.com/571784Reviewed-by: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Cr-Commit-Position: refs/heads/master@{#486911}

The tether confirmation dialog now uses blue network icons specifically,
and includes more UI stylizations.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice0c1ee283ea09918a5ca4ada044598ac4f4a15a

BUG=740686

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice0c1ee283ea09918a5ca4ada044598ac4f4a15a
Reviewed-on: https://chromium-review.googlesource.com/555592
Commit-Queue: Regan Hsu <hsuregan@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486910}

Reason for revert:
sky@ and ducbui@ found a simpler and more correct fix in
https://chromium-review.googlesource.com/c/569578/, so this is no longer needed.

The browsertest NewPageInNewForegroundTab, as well as prerender logic in the
MetricsWebContentsObserver constructor, are not reverted, as the browsertest
is expected to continue to pass, and the prerender logic is still needed
even with ducbui's fix.

Original issue's description:
> Provide WebContents::CreateParams to tab helpers.
>
> With browser-side navigation enabled, navigations in new foreground tabs are
> considered to have started in the background. This is a change in behavior.
> This causes page load metrics to incorrectly consider these page loads to have
> started in the background, which skews all of Chrome's page load metrics
> (PageLoad.* in UMA).
>
> clamy explains:
> """
> the background/foreground issue seems to be due to the ordering of calls in
> chrome/browser/ui/browser_navigator.cc when we create a new tab.
> What happens is:
> - we first create a WebContents and ask it to navigate
> (https://cs.chromium.org/chromium/src/chrome/browser/ui/browser_navigator.cc?type=cs&l=557).
> This result in the creation of a NavigationHandle, so we fire DidStartNavigation.
> In the current architecture, we fire DidStartNavigation after receiving
>  DidStartProvisionalLoad.
> - then we insert the WebContents in the tab strip
> (https://cs.chromium.org/chromium/src/chrome/browser/ui/browser_navigator.cc?type=cs&l=589).
> This fires WebContentsImpl::WasShown.
> """
>
> This patch implements Nasko's proposed fix to expose the WebContents
> CreateParams to interested WebContentsObservers, page load metrics's
> MetricsWebContentsObserver being the first consumer.
>
> We don't have the CreateParams in all places where a WebContents is passed to
> TabHelpers, so we wrap the CreateParams in a base::Optional<> and provide
> CreateParams in cases where they are available.
>
> BUG=725347
>
> Review-Url: https://codereview.chromium.org/2894973002
> Cr-Commit-Position: refs/heads/master@{#474895}
> Committed: https://chromium.googlesource.com/chromium/src/+/42b72063edb66bfd015bd9dea116c3e3e937d3eb


Bug: 725347
Change-Id: I10871fb8a711e9a71b1b8ad2541b6bce017d27be
Reviewed-on: https://chromium-review.googlesource.com/571285Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486909}

Multiple tests in AndroidSyncSettingsTest calls
AndroidSyncSettings#updateAccount (get Account on UiThread) without
providing a callback and waiting for the callback, while tearDown
process reset the Account to be null, therefore, situation tends to
happen when teardown runs before the ui thread runnable, and cause
null exception.

Bug: 640116
Change-Id: I43da6070f0193265efe965fdb0530f4caee4ace2
Reviewed-on: https://chromium-review.googlesource.com/567766Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486908}

transactions reading from the network and writing to the cache enabling each of
those transactions to drive reading the response body from the network. This
ensures that a slow consumer does not starve other consumers of the same resource.

This CL implements the Writers class in isolation and does not create an
instance or integrates it with HttpCache/HttpCache::Transaction. In a follow up CL
which will be dependent on parallel validation CL
(https://codereview.chromium.org/2721933002/), a Writer object will replace entry-
>writer. In case of transaction types that do not support shared writing like
partial transactions, Writers will only contain one transaction at a time and will
have is_exclusive set to true.

The flow of Read() call will be:
URLRequestHttpJob -> HttpCache::Transaction::Read() -> HttpCache::Writers::Read()
-> HttpNetworkTransaction::Read()
HttpCache::Writers will invoke HC::T's callback after writing the read buffer to
the cache successfully or on network read failure/ cache write failure.
So, in essence, HttpCache::Writers::Read() abstracts away the DoNetworkRead* and
DoCacheWriteData* functions of HC::T

HttpCache::Transaction that has invoked Read() is the |active_transaction_| and
may be killed at any time by it's consumer.

When a transaction completes writing to the cache, either failure or success, it
invokes HttpCache::DoneWritingToEntry as it does now which will invoke the
required functionality in Writers.
But If |active_transaction_| does not exist, Writers object invokes
HttpCache::DoneWritingToEntry itself.

BUG=472740

Review-Url: https://codereview.chromium.org/2886483002
Cr-Commit-Position: refs/heads/master@{#486907}

This expands the base sampling profiler API to make the client callback to be able
to return new sampling params if another profiling collection should be started.

Additionally, converts sampling profiler reporting to use a base::Feature rather
than a field trial directly and adds a base::Feature param that specifies whether
this new functionality should be used to do periodic sampling (at 1s intervals). This
new functionality is not on by default, but can be enabled via a field trial.

The new periodic samples will be added to UMA logs as they're received and
will have PERIODIC_COLLECTION trigger specified in the proto.

Adds a test for the new base profiler functionality.

Also, updates profile_duration for non-periodic profiles to include the
sampling_period, as that was previously not accounted for.

Also fixes some existing lint warnings.

BUG=735182

Review-Url: https://codereview.chromium.org/2927593002
Cr-Commit-Position: refs/heads/master@{#486906}