GitLab

BUG=386356

Review URL: https://codereview.chromium.org/408253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285635 0039d316-1c4b-4281-b951-d872f2087c98

Original Patch: https://codereview.chromium.org/399143004
Reverted In: https://codereview.chromium.org/416903002/
This was reverted because the test was flaky on Vista. Resubmit with a fix.

------------------------

Open the WrenchMenu on mouseover when dragging a browser action

Enable dragging from the main container to the overflow container by opening the
wrench menu when hovering over the button while dragging a browser action. This
also requires keeping the menu open while the drag is happening.

Note: this doesn't fix drag calculations for the overflow menu.
In an effort to keep these patches small, that will come later.

BUG=393038

Review URL: https://codereview.chromium.org/413323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285634 0039d316-1c4b-4281-b951-d872f2087c98

R=atwilson@chromium.org
BUG=354458

Review URL: https://codereview.chromium.org/413563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285633 0039d316-1c4b-4281-b951-d872f2087c98

This is the first part of the "Validate incoming JS Message Headers" CL - https://codereview.chromium.org/406993002/

It's just the test message file parser and its sanity check.

TBR=jochen@chromium.org

BUG=395801

Review URL: https://codereview.chromium.org/411553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285632 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285631 0039d316-1c4b-4281-b951-d872f2087c98

R=jiayl@chromium.org
TBR=sergeyu@chromium.org
BUG=N/A

Review URL: https://codereview.chromium.org/416993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285630 0039d316-1c4b-4281-b951-d872f2087c98

07d49ef  Fix Clang warning with preloaded D3DCompiler string.
a09403c  Fix masked ClearBuffer.

BUG=82385
TBR=jmadill@chromium.org

Review URL: https://codereview.chromium.org/417223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285629 0039d316-1c4b-4281-b951-d872f2087c98

Some i18n strings are referenced by the user pod template but never
actually shown on desktop. These need to be set to dummy values (e.g.
blank) to avoid warnings. This CL fixes warnings for four recently
added i18n strings.

BUG=397175
TEST=Manual: Warnings no longer seen in log output

Review URL: https://codereview.chromium.org/418133007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285628 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285627 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/75770afff8cdcd77ddb594a68de71f2b6f5cd393..f7be19401b4e718fab8bdb3b70fb54076bbb4259

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/417113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285626 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285623 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Seems to have broken browser_tests:
DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch (run #4):
[ RUN      ] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch
HTTP server started on http://127.0.0.1:52329...
sending server_data: {"host": "127.0.0.1", "port": 52329} (36 bytes)
../../chrome/browser/devtools/devtools_sanity_browsertest.cc:104: Failure
Value of: result
  Actual: "[FAILED] TypeError: Cannot read property 'sourcesView' of undefined"
Expected: "[OK]"

Original issue's description:
> Blink roll 178929:178934
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178934&mode=html
> TBR=haraken@chromium.org,jchaffraix@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285602

TBR=haraken@chromium.org,jchaffraix@chromium.org,blink-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/414223006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338
TEST=None
R=jamesr@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/417973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285619 0039d316-1c4b-4281-b951-d872f2087c98

Rect-based targeting in views has been on by default
for ChromeOS and Win since M33. Enable it on Linux
too but keep the flag --disable-views-rect-based-targeting
for the time being so that the feature may be toggled
on and off.

BUG=391852
TEST=none

Review URL: https://codereview.chromium.org/374993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285618 0039d316-1c4b-4281-b951-d872f2087c98

This addresses some discoverability concerns. LMK if you think it's sufficient.

Review URL: https://codereview.chromium.org/418543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285617 0039d316-1c4b-4281-b951-d872f2087c98

Currently both smoothness and thread_times initialize their metrics after page
load. This leads to a gap between the page load and the page actions starting.
This patch moves the initialization before the page load, thus eliminating the
gap. It is safe to do so because smoothness and thread_times require a page load
before each run (even when repeating the same page).

Note to perf sheriffs:
This patch is likely to cause performance numbers to worsen, because the browser is often more busy immediately after page load. If you get alerts related to this CL, feel free to ignore them. If there is a reference build for the bot, the number for the reference build should also change accordingly.

BUG=392895

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285297

Review URL: https://codereview.chromium.org/392613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397465

> Disable exceptions on Windows in all builds (take 3)
> 
> They were previously enabled in shared_library builds for historical reasons.
> 
> This change is relevant for Clang, which currently doesn't support exceptions
> on Windows.
> 
> Previous attemps failed due to:
> - chrome_elf_unittests on x64 (crbug.com/396244)
>   Fixed in Chromium r285377.
> 
> - blink_platform_unittests:DateTimeFormatTest.CommonPattern et al.
>   Fixed in Blink r176189
> 
> BUG=82385
> TBR=thakis
> 
> Review URL: https://codereview.chromium.org/420593002

TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/418393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285614 0039d316-1c4b-4281-b951-d872f2087c98

Files re-encoded with the updated bitstream:
$ ffmpeg -i blackwhite.png -pix_fmt yuv444p blackwhite.y4m
$ vpxenc --codec=vp9 --profile=1 --experimental-bitstream -o
blackwhite_yuv444p.webm blackwhite.y4m
$ ffmpeg -i bear-1280x720.mp4 -vf crop=960:720:0:160,scale=320:240
-pix_fmt yuv444p bear-320x240-P444.y4m
$ vpxenc --codec=vp9 --profile=1 --experimental-bitstream -o
bear-320x240-P444.webm bear-320x240-P444.y4m

BUG=392309
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/396543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285613 0039d316-1c4b-4281-b951-d872f2087c98

This consists of:
1) Deletion of WillMeasurePage/DidMeasurePage and
page_specific_results_for_current_page (which does not
make sense since a results can be added any time between
StartTest/StopTest.
2) Moving trace_tag and current_page property to PageTestResults;
current_page is filled at StartTest and reset at StopTest.

The class itself will be deleted separately after all
of its subclasses are deleted or switched to OutputFormatter
(as per thread on telemetry@chromium.org).

BUG=383635

Review URL: https://codereview.chromium.org/403093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285612 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285611 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397333

commit 794bf6e0cea9eca3406a821330be5dde0d014c47
Author: Adam Langley <agl@chromium.org>
Date:   Thu Jul 24 17:16:16 2014 -0700

    Fix OAEP with non-SHA hash functions.

    Due to merging our patched 1.0.1 code with the 1.0.2 code, some parts of
    upstream's 25f93585a70fb05bb9f911884ab95e560f662a5d didn't make it into
    the code.

    https://code.google.com/p/chromium/issues/detail?id=397333

commit 77a942b7fedb58ae1afee042255b4b9267abebca
Author: David Benjamin <davidben@chromium.org>
Date:   Tue Jul 15 01:22:50 2014 -0400

    Don't use the RSA key exchange with a signing-only key.

    This removes the last case where the server generates an RSA key for the
    ServerKeyExchange. Remove the code for this. Client support to accept them
    still remains.

    Leave the APIs for now, but they don't do anything anymore.

commit cd9969434c2b2c347f1fb12623ee240ae01ac942
Author: David Benjamin <davidben@chromium.org>
Date:   Sun Jul 20 16:23:51 2014 -0400

    Pass parameters to tls1_process_sigalgs as a CBS.

    Slightly cleaner; it means we can use CBS_stow.

commit 060d9d2c563b3fbe00eff93e5033591504516e6c
Author: David Benjamin <davidben@chromium.org>
Date:   Tue Jul 15 00:54:26 2014 -0400

    Remove support code for export cipher suites.

    Now the only case where temporary RSA keys are used on the server end is
    non-signing keys.

commit 5ffeb7c22f367ba0094c3ef886ff6ec13ed63ded
Author: David Benjamin <davidben@chromium.org>
Date:   Tue Jul 15 00:34:01 2014 -0400

    Remove two more quirks.

    SSL_OP_NETSCAPE_REUSE_CIPHER_CHANGE_BUG and
    SSL_OP_NETSCAPE_DEMO_CIPHER_CHANGE_BUG. Neither of them have code that's even
    enabled.

commit b9cc33a4d6d935f71c3e70af9718e716b00712e8
Author: David Benjamin <davidben@chromium.org>
Date:   Tue Jul 15 00:09:48 2014 -0400

    Remove SSL_OP_EPHEMERAL_RSA quirk.

    Also fix a place where fixes for the condition for sending ServerKeyExchange in
    s3_srvr.c were never propogated to d1_srvr.c. Tidy up that logic to use
    ssl_cipher_requires_server_key_exchange and simplify the PSK check.

commit ff175b4a46c86cf4fba6200abfe799a778786ada
Author: David Benjamin <davidben@chromium.org>
Date:   Mon Jul 14 23:43:37 2014 -0400

    unifdef OPENSSL_NO_PSK.

    Get those out of the way.

commit 019c3cc64a6f8d76dcee044c6d0d9133424ac1cd
Author: David Benjamin <davidben@chromium.org>
Date:   Mon Jul 14 23:13:22 2014 -0400

    Remove last remnants of GOST support.

    This removes support code for a "stream_mac" mode only used by GOST. Also get
    rid of this

       /* I should fix this up TLS TLS TLS TLS TLS XXXXXXXX */

    comment next to it. It's not actually related to GOST (dates to OpenSSL initial
    commit), but isn't especially helpful at this point.

commit 0e498f14d21b679d3d9b03eaa5551faecdb4bc18
Author: David Benjamin <davidben@chromium.org>
Date:   Sun Jul 20 13:36:15 2014 -0400

    Remove some remnants of SSLv2 support.

    Some ssl23 functions that can be folded into ssl3, declarations and macros that
    don't exist anymore.

commit 39482a13aca033b72118807fadd152207e0fad8a
Author: David Benjamin <davidben@chromium.org>
Date:   Sun Jul 20 13:30:15 2014 -0400

    Remove get_cipher_by_char and put_cipher_by_char.

    Without SSLv2, all cipher suite values are 2 bytes. Represent them as a
    uint16_t and make all functions pass those around rather than pointers.

    This removes SSL_CIPHER_find as it's unused.

commit 0eb17906ab03bd3f8d2e83bc08abf94caf0ff489
Author: David Benjamin <davidben@chromium.org>
Date:   Sun Jul 20 12:01:32 2014 -0400

    Remove support for sending V2ClientHello.

    Accepting them as a server is still necessary, but this code is unreachable.
    Without SSLv2 support, none of the cipher suites are SSLv2, so
    ssl23_no_ssl2_ciphers always returns true and we send a V3ClientHello.

commit d23f412a8afd20e1d5e3459d775d4eab0e3158c8
Author: David Benjamin <davidben@chromium.org>
Date:   Wed Jul 23 15:09:48 2014 -0400

    Improve test coverage around NewSessionTicket message.

    Test both when the peer doesn't support session tickets and when the server
    promises a NewSessionTicket message but doesn't deliver.

commit 072334d943ef81d45f75d97cd722b46f1293f773
Author: David Benjamin <davidben@chromium.org>
Date:   Sun Jul 13 16:24:27 2014 -0400

    Consistently use uint16_t for curve IDs.

    Don't retain curve IDs in serialized form; serialization only happens when
    writing and reading from the wire. The internal representation is a uint16_t
    which matches the range of the value and avoids all the checks for the first
    byte being 0.

    This also fixes a bug in tls1_check_ec_tmp_key's suite B logic; the || should
    have been &&, though now it's gone.

    This doesn't relieve some of the other assumptions about curve IDs:
    tls1_set_curves still assumes that all curve IDs are under 32, and
    tls1_ec_curve_id2nid still assumes 0 is not a valid curve ID. Add a
    compile-time assert and a comment to document this. We're up to 28 now, so this
    may well need to be revised sooner or later.

    Remove SSL_get_shared_curve as it's new and unused API, using it in a loop is
    O(N^3), and lets us simplify a function.

commit f3ec83dee05cfadf540dd66f44b4b99ae4f19b93
Author: David Benjamin <davidben@chromium.org>
Date:   Mon Jul 21 22:42:34 2014 -0400

    Add EarlyChangeCipherSpec tests.

    Adapted from patch in https://www.imperialviolet.org/2014/06/05/earlyccs.html.

commit 1d5c83e063b4a432a6a14ea15a1a1484c8280006
Author: David Benjamin <davidben@chromium.org>
Date:   Tue Jul 22 19:20:02 2014 -0400

    Add test coverage for session resumption with tickets.

    The shim is now passed two file descriptors. In a session resumption test, the
    second is used in an abbreviated handshake immediately after the first.

commit 6444287806d801b9a45baf1f6f02a0e3a16e144c
Author: David Benjamin <davidben@chromium.org>
Date:   Mon Jul 21 17:43:45 2014 -0400

    Do not allow a Finished message when NewSessionTicket is expected.

    Per spec, the server sends it iff it sends the extension in ServerHello. There
    is no need to probe for whether Finished is or isn't sent. NSS is strict about
    this (wait_new_session_ticket never transitions to wait_change_cipher without a
    NewSessionTicket message), so this is safe.

    Reset tlsext_ticket_expected in ssl_scan_serverhello_tlsext to ensure state
    from the initial handshake doesn't confuse renegotiation.  This is another one
    of those per-handshake states that should be systematically reset on each
    handshake. For now, reset it properly at least.

commit 407886f589cf2dbaed82db0a44173036c3bc3317
Author: David Benjamin <davidben@chromium.org>
Date:   Mon Jul 21 22:23:50 2014 -0400

    Remove ssl3_check_finished.

    ssl3_get_new_session_ticket is sensible and fills in a session_id for stateless
    sessions, so the resumption will already be detected at this point. Remove the
    codepath in ssl3_client_hello which allows for resuming sessions with empty
    session_ids. The rest of the code doesn't allow it either.

    This removes another codepath where we potentially probe a Finished message
    early.

commit 9eaeef81fa2d4fd6246dc02b6203fa936a5eaf67
Author: David Benjamin <davidben@chromium.org>
Date:   Mon Jul 21 22:22:02 2014 -0400

    Set s->hit when using tls_session_secret_cb.

    tls_session_secret_cb is used for EAP-FAST which computes the master secret
    externally and enters the abbreviated handshake. It appears to only have been
    working because ssl3_check_finished would drive it into the appropriate state
    afterwards. That, in turn, only has been working because EAP-FAST misuses the
    session ticket extension for some other field, so ssl3_check_finished isn't a
    no-op.

    Instead, set s->hit so it follows the abbreviated state machine directly.

    If we ever build wpa_supplicant with BoringSSL, this will require some testing.
    (And, if not, this API should be removed.)

commit 6553b379e2dbda9d03f6892f45fa97e4d8a37f04
Author: David Benjamin <davidben@chromium.org>
Date:   Tue Jul 22 14:11:30 2014 -0400

    Don't accidentally read Finished in ssl3_get_cert_verify.

    This removes one place where we set CCS_OK. ssl3_get_cert_verify already knows
    whether or not to expect a CertificateVerify message, so there is no need to
    look ahead and potentially read ChangeCipherSpec early.

commit b61b4de6dfd52cc4d0c90d32696ea37a769f3ba6
Author: David Benjamin <davidben@chromium.org>
Date:   Tue Jul 22 19:05:46 2014 -0400

    Fix runner.go session ticket support.

    Some test code to insert a bogus session ticket was retained. Also,
    decryptTicket mutated its input, in turn, mutating the ClientHello,
    breaking the Finished hash.

    The latter fix should probably be merged upstream.

commit 42be6456cac38fd7608b5f3781b7fda41569c488
Author: David Benjamin <davidben@chromium.org>
Date:   Mon Jul 21 14:50:23 2014 -0400

    Add SkipChangeCipherSpec-Server-NPN test.

    Finished isn't always the first post-CCS message.

Review URL: https://codereview.chromium.org/419653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285610 0039d316-1c4b-4281-b951-d872f2087c98

The boolean parameter is not necessary as we can just use null to indicate
readback failure.

android= https://chrome-internal-review.googlesource.com/#/c/169047/
BUG=

Review URL: https://codereview.chromium.org/390933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285609 0039d316-1c4b-4281-b951-d872f2087c98

This page toggles the drawer as part of its navigate steps. It then waits until
the navigation drawer is active before continuing. The navigation drawer is
active, however, as soon as it starts moving, so it doesn't mean that the drawer
is in its final position.
This CL adds an additional check to make sure that the drawer is actually fully
out before continuing.

BUG=

Review URL: https://codereview.chromium.org/418133008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389317

Review URL: https://codereview.chromium.org/401363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285607 0039d316-1c4b-4281-b951-d872f2087c98

Because initial sync may take as long as 10 minutes to occur for new
accounts, do not defer creation of the OEM folder, instead re-position
it when sync data arrives.

BUG=chrome-os-partner:29764
R=jennyz@chromium.org

Review URL: https://codereview.chromium.org/413033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285606 0039d316-1c4b-4281-b951-d872f2087c98

As described in its class comment, a ui::KeyEvent can be either of two
distinct kinds. When constructing a ui::KeyEvent from a native event,
the distinction is made by a new IsCharFromNative() call, in the same
way that other ui::Event properties are determined, instead of having the
caller inspect the native event itself. Removing the redundant |is_char|
parameter from constructors also prevent accidental synthetic `mixed'
events that consuming code does not handle.

Incidentally, while KeyEvent constructor calls are being touched, use
EF_NONE instead of 0 to make that argument's purpose clear.

BUG=380349
TEST=unit_tests,ash_unittests,events_unittests,ui_unittests,interactive_ui_tests

Review URL: https://codereview.chromium.org/404203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285605 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285604 0039d316-1c4b-4281-b951-d872f2087c98

bootstrap.py:
+ no_bootstrap => no_rebuild

NOTRY=true
R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/412053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285603 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178934&mode=html
TBR=haraken@chromium.org,jchaffraix@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285602 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/416203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379912

Review URL: https://codereview.chromium.org/422493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285600 0039d316-1c4b-4281-b951-d872f2087c98

This implements WebServiceWorkerRegistration based on the latest spec
and resolves a register promise with it instead of a ServiceWorker object.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-registration-obj 

[1] Blink: https://codereview.chromium.org/413123002/
[2] Chromium: This patch.
[3] Blink: Remove the macro and fix a bunch of layout tests.


BUG=396400
TEST=compile (tests will be added by subsequent patches)

Review URL: https://codereview.chromium.org/415963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285599 0039d316-1c4b-4281-b951-d872f2087c98

Adding base::StatisticsRecorder::Initialize() to run_all_unittests to mirror another change we had made to the content test suite in https://codereview.chromium.org/330473003/

BUG=387751
TEST=Suggestions*,Blacklist*

Review URL: https://codereview.chromium.org/410673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285598 0039d316-1c4b-4281-b951-d872f2087c98

Currently this was just an action directly into extensions_unittests.

But we want to share the same pak file between extensions_unittests and app_shell.

So in order to do this we create a new target called "extensions_pak" and make
 extensions_unittests depend on it.

After this lands, app_shell will be refactored to use extensions.pak too.

BUG=397250
TEST=extensions_unittests
R=jamescook@chromium.org
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/413293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285597 0039d316-1c4b-4281-b951-d872f2087c98

Support 'mlogin' screen type for multi-profile login to onFocus event to IME extensions. This is the follow up change per comment in https://codereview.chromium.org/418273002/

BUG=395621
TEST=None

Review URL: https://codereview.chromium.org/417183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285594 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285593 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178924:178929&mode=html
TBR=haraken@chromium.org,jchaffraix@chromium.org
BUG=

Review URL: https://codereview.chromium.org/419813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285592 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/418333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285591 0039d316-1c4b-4281-b951-d872f2087c98

This was something that was missed as part of this review:
https://codereview.chromium.org/352173005/

BUG=
TBR=mad
NOTRY=true

Review URL: https://codereview.chromium.org/420713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285590 0039d316-1c4b-4281-b951-d872f2087c98

Partially reverts crrev.com/284112 by moving the verifier test from unit_tests target back to browser_tests, because of trust information leaking between test cases.

BUG=396497

Review URL: https://codereview.chromium.org/419213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285589 0039d316-1c4b-4281-b951-d872f2087c98