GitLab

https://crrev.com/c/1504480 marked the wrong (non-virtual) one.

TBR=flackr

Bug: 938780
Change-Id: Ia0e0aed2b53ac8c8e775793667a39ea5db97c6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509096Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638757}

The key code which is created by KeyEvent rewriting is stored
in AcceleratorHistory when the key button is pressed. However,
there is no code responsible for removing it when the key button
is released. Instead only the key code before KeyEvent rewriting
is erased. As result, the accelerators relying on the state of
AcceleratorHistory often have unexpected behavior when KeyEvent
rewriting is triggered (The comment under this issue gives detailed
explanation).

In this CL, EventRewriterChromeOS stores the pressed keys. Based on
it, EventRewriterChromeOS computes the rewritten event and the rewritten
status. In addition, the test on edge cases is added.

Bug: 913209
Test: unit_tests
Change-Id: Ie22fe2ba8a2bd296628032723acc721db2616a77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477959Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638756}

Bug: 929866
Change-Id: I9d00bbc56040fbeb1973cda37e28af1507842043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509359Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638755}

Creates a script that can be used to generate Java files to
expose native strings to Java, giving us a single source of
truth for these constants.

Bug: 937280
Change-Id: I1f0804bdfff8101dfd149612acd44360ae0dc2c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495747
Commit-Queue: Ian Vollick <vollick@chromium.org>
Auto-Submit: Ian Vollick <vollick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638754}

https://dawn.googlesource.com/dawn.git/+log/aa9d6ad09d0d..b6a80b321e8f


git log aa9d6ad09d0d..b6a80b321e8f --date=short --no-merges --format='%ad %ae %s'
2019-03-07 natlee@microsoft.com Destroy backend implementation for Buffers


Created with:
  gclient setdep -r src/third_party/dawn@b6a80b321e8f

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I1f4ecec1abd2e57d8aae5f707da4eed55c8355d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509257Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638753}

This reverts commit c7021cb3.

Reason for revert: webkit_layout_test failures were due to flaky tests. The flaky tests have been marked in TestExpectations.

Original change's description:
> Revert "AudioService: Fixes for loopback underruns/timing issues."
> 
> This reverts commit 4f9a19f1.
> 
> Reason for revert: Suspected in causing webkit_layout_test failures
> https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/9784
> * media/video-played-collapse.html
> * virtual/video-surface-layer/media/video-played-collapse.html
> 
> Original change's description:
> > AudioService: Fixes for loopback underruns/timing issues.
> > 
> > Fixes a "choppy audio" issue on platforms with certain audio timing
> > parameters/scenarios. Investigation on crbug.com/934770 led to the
> > realization that three related problems needed to be addressed:
> > 
> > 1. Fix the "gap" detection in audio::SnooperNode to check in BOTH
> > directions, not just one direction; and on both the input and output
> > flows. This accounts for the case where a device-switch in
> > audio::OutputController results in a sudden drastic shift in the delay
> > timestamps.
> > 
> > 2. Add automatically-increasing capture delay logic to
> > audio::LoopbackStream to ensure the reads from all nodes' delay buffer
> > will never result in underrun.
> > 
> > 3. Increased the accuracy of media::FakeAudioWorker/OutputStream by: a)
> > addressing a subtle source of error in task scheduling delay math due to
> > integer truncation; b) exposing timestamps to worker callbacks that
> > allow FakeAudioOutputStream to provide a |delay| and |delay_timestamp|
> > that behaves just like a real AudioOutputStream. This "lessens the blow"
> > of a device-switch to SnooperNode.
> > 
> > Bug: 934770
> > Change-Id: Ia75f18b2be3ad905f27d6ad882df9632764bb81c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504981
> > Commit-Queue: Yuri Wiitala <miu@chromium.org>
> > Reviewed-by: Max Morin <maxmorin@chromium.org>
> > Reviewed-by: Oskar Sundbom <ossu@chromium.org>
> > Reviewed-by: Weiyong Yao <braveyao@chromium.org>
> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#638427}
> 
> TBR=dalecurtis@chromium.org,miu@chromium.org,braveyao@chromium.org,maxmorin@chromium.org,ossu@chromium.org
> 
> Change-Id: I845f547c60481ebde0ae24d1a83d59f2f750f7e3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 934770
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509365
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638708}

TBR=dalecurtis@chromium.org,miu@chromium.org,robliao@chromium.org,braveyao@chromium.org,maxmorin@chromium.org,ossu@chromium.org

Change-Id: If7d8fcd080f057491ec785173ebbf849d1f3bbdd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 934770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509634Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638752}

This test caused a recent good change to be reverted because the
flakiness tilted more towards "constant failure" on Mac 10.13 (see
https://chromium-review.googlesource.com/c/chromium/src/+/1509365).

According to the Flake Portal (and running the test on a clean checkout
on my local Linux and Mac machines), the test indeed is flaky.

TBR=chcunningham@chromium.org

Bug: 931533
Change-Id: I368b171a69ce423e47810c77ab0346bc8286c7cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509633Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638751}

In the finch confi for the quota expansion experiment, I had to modify
the min version to 73, as the FLT bug is approved for beta on M73. As
a result, I had to update the experiment group names in the finch GCL
since I revised the target of the experiment. This change ensures that
the field trial testing config has the right experiment group name.


Change-Id: I181f92bb85884c15457a331b5a6af6ca354a0df7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509109
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638750}

R=dpapad@chromium.org
BUG=926658

Change-Id: I9b64c2a2250f73f2e5ab2d8906c259ceb714503d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506884
Commit-Queue: Dan Beam (slow; perfing) <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638749}

An upcoming Skia CL (see below) needs Viz to know a bit more about Skia's GrContext.

https://skia-review.googlesource.com/c/skia/+/198240 (Add GrRecordingContext variants of SkImage makeSubset, makeColorSpace and makeColorTypeAndColorSpace)

Change-Id: I5562adc1659e770a99d3abb0e4d045a44edfc782
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509052Reviewed-by: weiliangc <weiliangc@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#638748}

ProduceCacheInternal()'s |unbount_script| argument can be
empty for module scripts and this is causing crash.

Bug: 938269, 841466
Change-Id: I2e51702fa243c9e1486511ddbe7e845c2b5b4a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507112
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638747}

Everything using Rect in mojom files will indirectly need
to include //ui/gfx/geometry/mojo/geometry_struct_traits.h"
and for that to be allowed in gn, its build target
(//ui/gfx/geometry/mojo:struct_traits) needs to be a public
dependency.

This fixes about 200 dependency errors as reported by a gn
that can check dependencies in generated files (gn:57).

Bug: 938893
Change-Id: Ifbe6d0c6a0bc26e158badf751322509e66093252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508467Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#638746}

https://android.googlesource.com/platform/external/perfetto.git/+log/3cfa438106ff..eb113c10cb35


git log 3cfa438106ff..eb113c10cb35 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 fmayer@google.com Merge "Bump libunwindstack version."
2019-03-07 fmayer@google.com Merge "Allow to skip function names."


Created with:
  gclient setdep -r src/third_party/perfetto@eb113c10cb35

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Iea2a0f2d3762c0b0a81ad1b70252758dfd1823e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509258Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638745}

Fix how pointer event locations are calculated in Perform Actions
command, in particular, fixing how relative pointer moves are handled.
This fixes all failures in WPT test perform_actions/pointer.py.

Bug: chromedriver:1897
Change-Id: If0bd79399e9376fe885ef9c26f20d775a4c7d6c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507313Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638744}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb039b04e175..0086bb261de5


Created with:
  gclient setdep -r src-internal@0086bb261de5

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org

Change-Id: Ica4011dfcd15cc4e095a7470f24d64d2a1fa456f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508562Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638743}

We had three nearly identical stores, that only differ meaningfully in the
histograms/tracing they report. Added a base class to combine duplicate
code.

Note that the only difference was that OfflinePageMetadataStore allowed
multiple Execute() calls before initialization, whereas the other stores
did not. The new SqlStoreBase does allow for this.

Additionally, moved some code out of the header file where possible to
reduce binary size. Because there's so many Execute() calls in the code,
this reduces binary size by about 9KB.

Histogram OfflinePages.SQLStorage.CreateDirectoryResult was removed because
it wasn't being used.

TBR=cmumford@google.com

Change-Id: I434655bb7deaa5b9ac7b403c6fc0d65af4b26b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460110
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638742}

No change to production logic, only tests.

The #setAcceptCookie() API should not expose already-set cookies via the
"Cookie" header or via document.cookie. Current test coverage only
checks WebView does not honor the Set-Cookie header or assignments to
document.cookie. So, this adds a test to handle this case.

This test does not work (yet) for the network service path, so this adds
the test to the filter.

This also removes an accidentally duplicated line in another test (which
I observed while writing this one).

R=tobiasjs@chromium.org

Bug: 936317
Test: run_webview_instrumentation_test_apk \
Test: -f=CookieManagerTest.testAcceptCookie_falseDoNotSendCookies
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: Ic0ed4b73d6f7fd2275438b63fc2c01a4d76d9c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507282Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638741}

Added new uma stats to replace old stats:
Event.DownEventCount.PerInputFormFactorDestinationCombination2

Bug: 926040
Test: Updated & added new test in PointerMetricsRecorder unittest.
Change-Id: Ic2410100428c61bde1c780afd3ee6e04db376063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1443459
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638740}

Bug: 919132
Change-Id: I4db14c49af64028e4c72b493a7988f46d2369c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509312Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638739}

This reverts commit bfa0a0c5.

Reason for revert: Out of an abundance of caution as suspected actual culprit behind https://chromium-review.googlesource.com/c/chromium/src/+/1509333

Original change's description:
> Cleanup Lookalike interstitial browser tests.
> 
> This is a cleanup CL to add a few missing, and simplify existing,
> interstitial tests. It also includes a few unaddressed nits from earlier
> CLs.
> 
> Bug: 927924
> Change-Id: Iaa177d8dfc69d127b6ba2af5c8f508d5e5d8db83
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497756
> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638286}

TBR=msw@chromium.org,meacer@chromium.org,jdeblasio@chromium.org

Change-Id: Ie0b186fd3b3455c13eb1077cb134411416136da2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 927924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509463Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638738}

TBR=rockot@chromium.org

Bug: 939289
Change-Id: I86ad8878e2dcd97589425038fdf0ed2871252ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509492Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638737}

https://chromium.googlesource.com/catapult.git/+log/699655f07b93..eefd8e8457a3


git log 699655f07b93..eefd8e8457a3 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 benjhayden@chromium.org Add report-controls for spa
2019-03-07 benjhayden@chromium.org Fix empty BatchIterator for spa.
2019-03-07 benjhayden@chromium.org Add a drawer to chromeperf-app
2019-03-07 benjhayden@chromium.org Add chart-timeseries for spa
2019-03-07 mattcary@chromium.org Devil: enable parsing a manifest from an android bundle.
2019-03-07 simonhatch@chromium.org Dashboard - Change Pinpoint stats to 7 days


Created with:
  gclient setdep -r src/third_party/catapult@eefd8e8457a3

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:918193,chromium:918193,chromium:918193,chromium:918193,chromium:931269,chromium:924564
TBR=sullivan@chromium.org

Change-Id: I97f6cef6717206bc26633301c1211187c02a0d29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509101Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638736}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/db5c5ade84ad..b139178fb593


git log db5c5ade84ad..b139178fb593 --date=short --no-merges --format='%ad %ae %s'
2019-03-07 vadimsh@chromium.org [lucicfg] Bump lucicfg version 1.3.2 -> 1.5.3.
2019-03-07 ehmaldonado@chromium.org Revert "Avoid unnecessary invocations of "git fetch""


Created with:
  gclient setdep -r src/third_party/depot_tools@b139178fb593

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:938627
TBR=agable@chromium.org

Change-Id: I7f31f68119321b0b5b9966fb81cde4b98261cc7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509100Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638735}

Bug: 923563
Change-Id: I9b1b3b84f35a312deac8ad8b0b286d64c3b6b2a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474674
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638734}

This aligns the chromium.clang waterfall swarming configuration with the
configuration used for chromium.win.

Use the 'win10' mixin as a shorter spelling for:
'swarming': { 'dimension_sets': { 'os': 'Windows-10-1503' } } }
... and use that on the CrWinASan bots, which are also all x64 bots.

R=hans@chromium.org, thakis@chromium.org
NOTRY=true

Bug: 939003
Change-Id: I52d33f47b37c0973336695269a499ca9ad2373c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505894
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638733}

AverageLag are calculated from latency_info.scroll_update_delta.
It was set from GestureScrollUpdate event's delta_y; however, scroll
prediction is done after scroll_update_delta set, which means the
AverageLag did not count in the prediction result.

This CL adds setting the scroll_update_delta from GSU, so it will
count in the prediction change as well.

Bug: 836352
Change-Id: I979e0da617dbfdfa6735aee33958cb9dac9b8331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509102Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638732}

In the Styles sidebar pane, user agent style sections:
- Properties within an inherited section that do not contribute to
  the cascade (not inheritable) are hidden.
- Non-matching selector pieces are hidden.

The goal is to reduce visual noise in the UI without affecting style
debugging.

Screenshot: https://imgur.com/a/2s5wIn8

Bug: 929536
Change-Id: Icaea2edcbb8560273469605f263449edd51bade2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500775Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638731}

Bug: 910390
Change-Id: I87d9aa4751c6abb53a549ceabb57a55a5236efff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508924
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638730}

Bug: 931359
Change-Id: Id017e32692583f81fb30709bf7d26bb6bd2d731a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506560Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638729}

Change-Id: I54d188e1ddcc80aa9563934be7ac89470e00cadc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506449
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638728}

TBR=rockot@chromium.org

Bug: 939037
Change-Id: I8124bcbbd54d5b4b3bebfa35d5bbca55443260d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509362Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638727}

TBR=piman@chromium.org

Bug: 938765
Change-Id: Ic1c54b3a489fc056f43d7d2f353e418645a9d33c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508923Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638726}

Change-Id: Ic5b6943efaace6033d6adb9b665676f20990eb4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509135
Commit-Queue: Jared Saul <jsaul@google.com>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Auto-Submit: Jared Saul <jsaul@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638725}

Chrome Extensions can generate internal redirects in
webRequest::onBeforeRequest event handler.
See Life cycle of requests below.
https://developer.chrome.com/extensions/webRequest

Without OOR-CORS, WebRequestProxyingURLLoaderFactory generates virtual
response for Blink, and Blink-CORS handles the redirects. Simply said,
it rewrites the Origin header to be 'null' for cross-origin redirects.

Detailed steps are:
 1. A certain request is made by Blink.
 2. webRequest::onBeforeRequest intercepts the request, and generates
    an internal redirect response with status 307.
 3. Blink receives the generated response and Blink-CORS handles
    cross-origin redirects if it is needed, e.g. using Origin: null

But, if OOR-CORS is enabled, Blink does nothing. Detailed steps are:
 1. and 2. is ditto
 3. Blink receives the generated response and Blink-CORS is disabled
    and does nothing. Just new request for the redirect is made.
 4. The request is handled in NetworkService, with OOR-CORS. It sets
    Origin header for such cross-origin request, but the value is
    based on the request initiator's origin.

So the proxy needs to craft its ResourceRequest so that the OOR-CORS
can set a proper Origin header, null for such internal redirect cases.

My approach in this patch set is:
 1. Set null origin to the ResourceRequest.request_initiator to pretend
    the retained origin flag is set.
    See https://fetch.spec.whatwg.org/#concept-request-tainted-origin
 2. But WebRequestInfo is initialized with copied ResourceRequest that
    has the original request_initiator.

2. is needed for webRequest events. See API document below.
https://developer.chrome.com/extensions/webRequest#event-onBeforeRequest
That says the initiator does not change through redirects.

Following tests in ExtensionWebRequestApiTest.WebRequestBlocking failed
if OOR-CORS is enabled without this patch.
- crossOriginAnonymousRedirect()
- crossOriginCredentialedRedirect()
- syncXhrsFromOurselfAreInvisible()

And this patch fixes them to pass.

Bug: 909633
Change-Id: I755db213256605c72015ab21c845e649bc35e319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503273
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638724}

Using wpt-import in Chromium d926e1bf.
With Chromium commits locally applied on WPT:
68d5240e "[ChromeDriver] Set key modifiers with mouse actions"
682affef "Implemented setPlaybackRate for scroll-linked Worklet Animations."
2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html"
fc735f1b "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I06207a2c52a93d333c3c9c3be0553342aca12259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508919Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#638723}

MachineLevelUserCloudPolicyPolicyFetchTest.Test is flaky
on all platforms.

TBR=zmin@chromium.org

Bug: 939261
Change-Id: I2e1a6403ffc1b56f753320eceaa26e5fdec0b5fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509332Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638722}

Root cause for the flakiness:
  1.Due to crbug.com/937382, composited worklet animation current time is not identical to the
    current time passed to the animator instance in the worklet scope (which is passed through to
    local time in this test).
  2.Not waiting enough for the compositing thread to update the styles.
The fix:
  1.Changed the test to compare against reference worklet animation's effect local time that has
    default playback rate.
  2.Explicitly wait for the style updates before comparing to the expected results.

Bug: 915352
Change-Id: I35cb3f89048568bc830aff8a6473f6d2aef5aaeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497789
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638721}

Texture sharing between OpenGL and Metal on Mac has to be done through
IOSurfaces so we add a SharedImageBackingFactory for this OS-specific
mechanism.

SharedImageBackingFactory starts with supports for producing GLTexture
SharedImage representations as well as legacy mailboxes. Support for
other representations will be added in later commits.

BUG=chromium:938895

Change-Id: I4aa5faf026c273b3a02820ed08c3a502e6769678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505511
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638720}

This CL adds metrics to track the following:
- errors resulting from invalid relying party domain
- number of allowed credentials in options during credential requests
- number of excluded credentials in options during credential creation

Bug: 803825
Change-Id: Ib37476ef329251831a14209000b904a8e353efb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504297
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638719}

Bug: None
Change-Id: I9bd5def390e5fbe18d19b42d23540797a7a99d81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509353
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638718}