GitLab

to match the behaviour expected by calling code.

The original change was reverted by https://chromiumcodereview.appspot.com/10384209.

BUG=124091,127933

Review URL: https://chromiumcodereview.appspot.com/10391169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137547 0039d316-1c4b-4281-b951-d872f2087c98

-This is for metro mode
-The image is a placeholder, image to be provided later

BUG=127489
TEST=see the bug for details.
Review URL: https://chromiumcodereview.appspot.com/10388156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137544 0039d316-1c4b-4281-b951-d872f2087c98

Reverting r133134 - Make sure that base::MessagePumpForUI from different modules are isolated from each other and add protection from shatter attacks by placing |this| pointer to the used data associated with the message-only window (instead of blindly trusting the value of WPARAM).

We suspect that r133134 might be causing issues like 124091, so it needs to be reworked.

BUG=124091,127933

TBR=alexeypa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10384209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127931
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10398060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137541 0039d316-1c4b-4281-b951-d872f2087c98

Disable off-store extension installs by default. Also get rid of ExtensionService::IsDownloadFromGallery.

BUG=55584

Review URL: https://chromiumcodereview.appspot.com/10356052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10389179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137539 0039d316-1c4b-4281-b951-d872f2087c98

-Changed list of files being checked for NaCl sdk installer.
-Changed Download and unziping of nacl_sdk folder on all the platforms(Used Zipfile module).
-Changed installation of NaCl SDK.
-Removed Hello world examples from test case.
-Added new examples like Input Events, Dynamic Library(Magic * ball), Load progress, Multi-threaded input events, Web socket
Code Cleanup:
-Removed unused methods and pre-defined global variables.
-Removed pre-release gallery test.test(method-testNaClSDK) of new installation process of NaCl sdk.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10310047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137538 0039d316-1c4b-4281-b951-d872f2087c98

DispatcherLinux may not always receive all events (e.g. when a menu is running a
nested message-loop). So install it a message-pump observer, so that all X
events go through the DL.

Also, turn off the check for X-event consistency on release builds.

BUG=128183
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10377161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137537 0039d316-1c4b-4281-b951-d872f2087c98

Search results will be shown under virtual path gdata/.search/<query>.
Content search will be triggered whenever we try to enumerate directory with
the mentioned file path format.
Entries returned by search results will have file names formatted as
<resource_id>.<real_file_name>, so we have to strip resource_id part before
displaying name or selecting target path for copy/move operations.

When user enters some input x in search box(on gdata only),
 file manager will change directory to /gdata/.search/x in
which search results will be displayed

TEST = manual
BUG=chromium-os:27539

Review URL: https://chromiumcodereview.appspot.com/10342010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137536 0039d316-1c4b-4281-b951-d872f2087c98

There were two issues:

1. RTL wrapping was simply not happening if your UI language locale was not RTL. Which made FORCE_RTL_DIRECTIONALITY not work.
2. RTL wrapping was not being applied in the SizeStringInt() path, which resulted in an inconsistency between the needed width for SizeStringInt() and DrawStringInt(), causing a problem with the label code resulting in truncation.

This CL fixes both issues.

BUG=128073, 105550
TEST=See testcases attached to bug.

Review URL: https://chromiumcodereview.appspot.com/10384168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137535 0039d316-1c4b-4281-b951-d872f2087c98

There might be several provisional loads in different render view hosts going on, so the observers need to know where the signals came from

BUG=109792
TEST=none, just added the parameter everywhere


Review URL: https://chromiumcodereview.appspot.com/10392072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137534 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10332209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137531 0039d316-1c4b-4281-b951-d872f2087c98

Prevent title-only panel from fully minimizing when attention is cleared if mouse is in the panel or the panel is being dragged.

Added dragging tests related to minimized panels. Most of the changes are test related.

BUG=127584
TEST=new tests added


Review URL: https://chromiumcodereview.appspot.com/10384192

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137530 0039d316-1c4b-4281-b951-d872f2087c98

- Rename text_to_display_when_empty -> placehodler_text;
- Draw placeholder text when there is no user text;

BUG=none.
TEST=none.

Review URL: https://chromiumcodereview.appspot.com/10310131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10382204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137528 0039d316-1c4b-4281-b951-d872f2087c98

Step2.
- Move ui/gfx/gfx_resources.grd to ui/base/native_theme/native_theme_resources.grd
-Updated gyp/DEPS/py files to use new target.
-Removed old files.

I had to keep the gfx_resources.pak as DumpRendererTree depends on it. I'll update DumpRendererTree first and then remove copy of gfx_resources.pak.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10377155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137527 0039d316-1c4b-4281-b951-d872f2087c98

This disables window manager borders, and supports dragging of the
skyline, as well as resizing from the corners.

This patch also moves our ::Atom caching out of RootWindowHostLinux and into its own Singleton.

BUG=125106
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10381063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137525 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127299
TEST=
1. go to chrome://bookmarks/
2. be sure, the cursor focus is in the search box
3. take a look at the search box
4. It should be the same as the search box in chrome://downloads/ when focused


Review URL: https://chromiumcodereview.appspot.com/10383200

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137522 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a PyAuto test for the DeviceGuestModeEnabled policy which
enables/disables guest login on Chrome OS devices.
As a prerequisite, the browser automation framework is fixed so that it
does not wait for the login screen to be shown when the account picker
is enabled instead.

BUG=128343
TEST=New PyAuto ChromeosDevicePolicy.testGuestModeEnabled


Review URL: https://chromiumcodereview.appspot.com/10382197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137521 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes ImageSkia more like SkBitmap. The goal is to make swapping from SkBitmap to ImageSkia easier.

Notable changes:
- ImageSkia can be cheaply copied
- Added extractSubset, will remove after SkBitmaps have been converted to ImageSkia
- Modified API to look more like SkBitmap

Review URL: https://chromiumcodereview.appspot.com/10245003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137520 0039d316-1c4b-4281-b951-d872f2087c98

Found via Eclipse.

BUG=none
TEST=none
R=groby


Review URL: https://chromiumcodereview.appspot.com/10391167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137519 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137518 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10377177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137515 0039d316-1c4b-4281-b951-d872f2087c98

It needs this for Password Manager. It could be that we could just construct the Password Manager for this type, but this is the simplest fix.

http://crbug.com/127110
TEST=See bug, configure proxy with auth required and open GAIA frame at sign in screen.

Review URL: https://chromiumcodereview.appspot.com/10388166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137512 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org
TBR=tim@chromium.org, davemoore@chromium.org, scottbyer@chromium.org, keybuk@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10391158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137511 0039d316-1c4b-4281-b951-d872f2087c98

SelectAll when activating the omni box via touch. Regular (short) touch should now work the same way as mouse left click and a long press the same as right click.

BUG=127293
TEST=Activate the omni box via touch.  All the text in the omni box should be selected.


Review URL: https://chromiumcodereview.appspot.com/10332197

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137510 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124269
TEST=None yet, except that tests pass; will be used for further testing.

Review URL: https://chromiumcodereview.appspot.com/10391170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10389161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137502 0039d316-1c4b-4281-b951-d872f2087c98

In addition to the at-launch reauthorization, this adds an at-update
reauthorization step. It only runs for users not on a system Keystone ticket,
because the updater runs as root when on a system ticket, and root can't read
individual user's Keychains. The at-update reauthorization is intended to
handle the reauthorization for users who rarely restart Chrome and might miss
out on the at-launch step during the window where Chrome is signed by the old
certificate but has the new reauthorization code in place. The at-update
reauthorization step can remain in place even after the certificate switch
occurs by shipping an old reauthorization stub binary signed with the old
certificate.

BUG=108238
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10377173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137501 0039d316-1c4b-4281-b951-d872f2087c98

Revert 136042 - Make sure only the main browser process and service proceses are allowed to create the profile directory.

This patch lets Chrome start with profile located on a network share on
Windows Vista and newer.

BUG=120388
TEST=Start Chrome with --user-data-dir pointing to a network share location and try to navigate to a web page. This should not lead to a hang of the renderer.


Review URL: https://chromiumcodereview.appspot.com/10332056

TBR=pastarmovj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=85132
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10083060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137498 0039d316-1c4b-4281-b951-d872f2087c98

removed the unnecessary files that I didn't remove in last CL.

TBR=cpu@chromium.org
BUG=10381138
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10389149

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137497 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10386171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137496 0039d316-1c4b-4281-b951-d872f2087c98

There were two subtle changes in how we stored the file system metadata
in a proto file, and each change broke compatibility in a subtle way.
We should discard the proto file if old formats are detected.

Note that the protobuf definitions in gdata.proto were kept compatible.
The problem was in how we stored data in the protobuf, and the changes were
subtle.

BUG=128133
TEST=confirmed that the google drive loaded with the stale GCache directory from josh

Review URL: https://chromiumcodereview.appspot.com/10384204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137492 0039d316-1c4b-4281-b951-d872f2087c98

We do this by keeping a list of pre-sync deleted GUIDs, which is populated whenever a TemplateURL entry is removed from the DB during startup merging. We then use this list to ignore the appropriate entries from Sync, and to inform Sync that they should be deleted.

BUG=128210
TEST=unit_test TemplateURLServiceSyncTest.PreSyncDeletes


Review URL: https://chromiumcodereview.appspot.com/10384188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137490 0039d316-1c4b-4281-b951-d872f2087c98

It was broken by https://chromiumcodereview.appspot.com/10384140.

SOLINK_MODULE(target) out/Release/remoting_host_prefpane.prefPane/Contents/MacOS/remoting_host_prefpane
Undefined symbols:
  "_modp_b64_decode", referenced from:
      -[Me2MePreferencePane onApply:] in me2me_preference_pane.o
ld: symbol(s) not found

This doesn't happen in the components build because the prefpane still
depends on base via

 tools/gyp-explain.py     remoting_host_prefpane modp_b64
These paths lead from remoting/remoting.gyp:remoting_host_prefpane#target to third_party/modp_b64/modp_b64.gyp:modp_b64#target:
remoting/remoting.gyp:remoting_host_prefpane#target -> remoting/remoting.gyp:remoting_base#target -> base/base.gyp:base#target -> third_party/modp_b64/modp_b64.gyp:modp_b64#target

BUG=none
TEST=none
TBR=lambroslambrou

Review URL: https://chromiumcodereview.appspot.com/10389178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137489 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=gbillock

Review URL: https://chromiumcodereview.appspot.com/10387155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137488 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109630

Review URL: https://chromiumcodereview.appspot.com/10284008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137487 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114644
R=asargent@chromium.org
TEST=Docs should no longer show up as a default app for new profiles

Review URL: https://chromiumcodereview.appspot.com/10332206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137486 0039d316-1c4b-4281-b951-d872f2087c98

Two fixes are added. 1) We stay in the loop only if we will call
DoPayloadRead or DoPayloadWrite in the next iteration. 2) Don't call
BufferRecv again if BufferRecv has reported EOF before.

Each fix alone prevents the infinite loop.  The second fix is less risky.
If necessary, we can go with just the second fix.

R=rsleevi@chromium.org
BUG=127822
TEST=SSLServerSocketTest.WriteAfterPeerClose in net_unittests

Review URL: https://chromiumcodereview.appspot.com/10382186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137485 0039d316-1c4b-4281-b951-d872f2087c98