GitLab

https://chromium.googlesource.com/angle/angle.git/+log/bb3adfa42822..137271ffc54d

2021-01-21 sunnyps@chromium.org Support specifying array slice for D3D11 texture EGLImage

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1116101
Tbr: cnorthrop@google.com
Test: Test: D3DTextureTest.TextureArrayImage*
Change-Id: I0b58eedaa197b16860b4797180bbbcaf37665ebd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640836Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845516}

2 tests in this test suite seem inconsistent:

test#2 asserts that

tbody.height=10px > tr.height=1px > td.height=1px
implies td.offsetHeight = 1px

test#4 asserts that

tbody.height=10px > tr > td.height=1px
implies td.offsetHeight = 10px

Edge 17 is the only browser that agrees with #2 and #4
FF agrees with #2, but not #4
Chrome agrees with #4, but not #2
Safari agrees with #4, but not #2

To me, #2 and #4 seem to be in conflict.
Either tbody height propagates to rows, or it does not.

The problem is that #2 is overconstrained.

My suggestion is that tbody height always propagates to tr.

Bug: 958381
Change-Id: I28bfd108c67968d31d0372b536c316c997d2d958
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586097Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845515}

This CL makes it easier/clearer to split up PasswordProtectionRequest
in a future CL.

GetDomFeatures should be wrapped in a SAFE_BROWSING_AVAILABLE buildflag
since it's declaration is wrapped in that buildflag.

Bug: 1147967
Change-Id: I4a06732c97ba49ad1212816bd073b6e526b29ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638242
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845514}

Roll Chrome Win32 PGO profile from chrome-win32-master-1611165592-7dc454a3a93e8067ea7c07bb6e94372701a24ad7.profdata to chrome-win32-master-1611187144-091cd0ce23c5cf7321279c1e02f3c90b64671b48.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I131fe5d80d5dc0054beae1d16fe01512c6b4b753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641186Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845513}

This CL refactors the title preview feature in the sharesheet
by moving it into a dedicated SharesheetContentPreviews class.

Bug: 1167935
Change-Id: I2671c0e53e04779e8fe8bdf3d37d30f91161d3a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636734Reviewed-by: Melissa Zhang <melzhang@chromium.org>
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Commit-Queue: Angela Gyi <angelagyi@google.com>
Cr-Commit-Position: refs/heads/master@{#845512}

This reverts commit 487e7412.

Reason for revert:
https://ci.chromium.org/p/chrome/builders/ci/Win%207%20Nvidia%20GPU%20Perf/17285

Original change's description:
> Reland "trigger_scripts: support go client in chromeos_device_trigger"
>
> This reverts commit 78d95924.
>
> Reason for revert:
> This fixes previous failure and has a test
>
> Original change's description:
> > Revert "trigger_scripts: support go client in chromeos_device_trigger"
> >
> > This reverts commit 3fd9ba25.
> >
> > Reason for revert:
> > https://ci.chromium.org/p/chrome/builders/ci/android-go_webview-perf/23071
> >
> > Original change's description:
> > > trigger_scripts: support go client in chromeos_device_trigger
> > >
> > > This scripts needs json conversion similar to
> > > https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62
> > > when using go client.
> > >
> > > This is fix for breakage like
> > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159
> > >
> > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
> > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> > > Bug: 1127205
> > > Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275
> > > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#844979}
> >
> > TBR=tikuta@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com
> >
> > Change-Id: I96bf20546c714a40a53c44afb57bab5924da5d7e
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1127205
> > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
> > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638954
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#844987}
>
> # Not skipping CQ checks because this is a reland.
>
> Bug: 1127205
> Change-Id: I6b408eed0dbf16608b6ee7084ec093ff4ab51233
> Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639441
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#845499}

TBR=kbr@chromium.org,tikuta@chromium.org,bsheedy@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com

Change-Id: I94525d422ea33245c3142696752cbf64f02e841a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1127205
Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639349Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845511}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=benmason@chromium.org

Change-Id: I00634d73fef108a4c73b2b8caaf3c66ec2459ee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641479Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845510}

This CL also updates hermes dbus constant references
that were pulled in with this uprev.

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/adce67ac57ed..1ee85a708f6a

$ git log adce67ac5..1ee85a708 --date=short --no-merges --format='%ad %ae %s'
2021-01-20 pholla system_api: Fix hermes's dbus constants
2021-01-13 kimjae minios: Daemonize minios
2020-11-05 damiendejean shill: add always-on VPN configuration to Profile.
2020-11-11 kevinptt runtime_probe: use ProbeConfigLoader to load probe configs
2020-12-22 yich system_api: moving bootlockbox-protos to shared lib
2020-12-22 yich system_api: build tpm_manager goprotos

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 1093185
Change-Id: I247131016f8019892ac9645b440473d202046ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641195
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845509}

Except ChromeOS and Android.

Change-Id: I54acfaa74f5df5799c1709a2004d34fb9a27e60d
Bug: 1095763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617229
Commit-Queue: Jerome Jiang <jianj@google.com>
Reviewed-by: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#845508}

This CL replaces blink::mojom::ResourceType with
network::mojom::RequestDestination in
//components/safe_browsing since blink::mojom::ResourceType
is deprecated[1].

This change
  - Renames CanCheckResourceType() to CanCheckRequestDestination()
    in SafeBrowsingDatabaseManager.
  - Replaces |resource_type_| with |request_destination_| in
    SafeBrowsingUrlCheckerImpl.
  - Updates CreateCheckerAndCheck() in mojom:: SafeBrowsing to get
    network.mojom.RequestDestination instead of
    blink.mojom.ResourceType.
  - Replaces |resource_type| with |request_destination| in
    security_interstitials::UnsafeResource.
  - Introduces GetResourceTypeFromRequestDestination() for UMA logging
    in order to keep reporting with ResourceType.

[1] https://crbug.com/960143

Bug: 1059639
Change-Id: I5e35999a3a71c77dc2ab8df0c7ff71d62ec6319c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589575Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#845507}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13ea7423612a..af0dca3dc983

2021-01-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I8c29e390bb70d0edefdfa0657860df4d3dc1b776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641190Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845506}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3195d3ea0758..aeaf8b9be0c2

2021-01-21 vidorteg@microsoft.com Making localizationV2Checks work with typescript

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I3c02f8b1823b98a367d64388c4b5fa7de5a1a77c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641530Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845505}

https://crrev.com/c/2313044 split the GL shared image backing and
factory into separate source files, but the contents of the .cc files
got mixed up - the factory contained the backing sources and vice-versa.
This didn't cause any issues during build because the backing and
factory are always in the same translation unit.

This CL only swaps the contents of the two files and git detects it as a
file rename change so it should have no effect, modulo spelling mistakes
caught by Tricium.

Bug: 1092155
Change-Id: I792b9a7500efc0138354c8cee903cd908e15d523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641058
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845504}

Bug: 1159562
Change-Id: I701ebd786a6dcdb8a105fbb288eb74962b53b5c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638086
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845503}

Currently, on realloc expansion, GetSize() bytes are copied. This is the
maximum size that an allocation can be stretched to within a slot, not
the actual size available to the application at the moment. These are
equivalent for small buckets, but not for single-slot slot spans where
extras can be glued immediately after the allocation.

The added test would fail without this fix.

Change-Id: Ic83e79c11e0a5b3b70f5c90a0bd1f157cbeae703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636101Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Bartek Nowierski <bartekn@chromium.org>
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845502}

https://skia.googlesource.com/skia.git/+log/dd069a9188cc..08f5311ae142

2021-01-21 adlai@google.com Detemplatize render task clustering
2021-01-20 brianosman@google.com Remove "death" functions from particle system
2021-01-20 csmartdalton@google.com Reland "Disable the MSAA atlas mode for CCPR"
2021-01-20 bsalomon@google.com GrQuadUtils: Handle degenerate persp quads where edges intersect outside quad
2021-01-20 reed@google.com Enable new virtuals in flutter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1167277
Tbr: scroggo@google.com
Change-Id: I6d4c48612388b777e423c24828c945bdc0efb2b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641254Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845501}

Bug: 1093185
Change-Id: Id98b43b42586d3a858c3b40b86871a0664936451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641086Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#845500}

This reverts commit 78d95924.

Reason for revert:
This fixes previous failure and has a test

Original change's description:
> Revert "trigger_scripts: support go client in chromeos_device_trigger"
>
> This reverts commit 3fd9ba25.
>
> Reason for revert:
> https://ci.chromium.org/p/chrome/builders/ci/android-go_webview-perf/23071
>
> Original change's description:
> > trigger_scripts: support go client in chromeos_device_trigger
> >
> > This scripts needs json conversion similar to
> > https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62
> > when using go client.
> >
> > This is fix for breakage like
> > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159
> >
> > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
> > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> > Bug: 1127205
> > Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#844979}
>
> TBR=tikuta@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com
>
> Change-Id: I96bf20546c714a40a53c44afb57bab5924da5d7e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1127205
> Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
> Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638954
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#844987}

# Not skipping CQ checks because this is a reland.

Bug: 1127205
Change-Id: I6b408eed0dbf16608b6ee7084ec093ff4ab51233
Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639441
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845499}

A follow-up to https://crrev.com/c/2617167.

Note that the test fails in the current implementation.
See the https://crbug.com/1168449 for details.
The test is now marked as Timeout.

Bug: 1149816, 1168449

Change-Id: I2552f64ea12ac5030c9740f30a94edef2760986c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639337Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845498}

https://android.googlesource.com/platform/external/perfetto.git/+log/a3c06205b28b..477bd92472cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I2ed90df686df83d6c6ce167e08e2efcc24dd168c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641338Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845497}

This change is a mechanical change replacing is_chromeos with
is_chromeos_ash.

This is in preparation to switching lacros from target_os="linux" to
target_os="chromeos".

More detail on http://go/lacros-macros.

Bug: 1052397
Change-Id: I1324b2733d438d2fe62eaa54363b364ad0257862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628631Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Yuta Hijikata <ythjkt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845496}

This CL factors out the duplication for file sharing and USB sharing to
Crostini and Plugin VM into a new GuestOsBrowserProxy. To make this
work, the new proxy requires the VM name for all operations now, and the
USB devices changed observer event no longer determines which devices
are shared with the specific VM but instead returns which VM devices are
shared with (if any).

The duplication between the html and js pages will be dealt with in
later CLs.

Bug: 1167980

Change-Id: Ieeebb01318c25b299773c216da86112e049e1b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635387
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845495}

As above. This patch implements the core content alignment logic. E.g.
determining the offset at which the tracks should start, and the space
between them (gutter-size - this include the grid-gap if any).

Creates a new struct "TrackAlignmentGeometry" which contains these
two values. Effectively the process is now:
GridGap -> TrackAlignmentGeometry -> SetOffsets.

The most significant difference is that TrackAlignmentGeometry includes
the grid-gap, and the BorderScrollPadding start offset.

Bug: 1045599
Change-Id: Idb4d550f0d8b2aca306945a46d41b5a30a20bca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622586
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845494}

Roll Chrome Linux PGO profile from chrome-linux-master-1611165592-f4f825a470f7704c21486baf150746af41ae52eb.profdata to chrome-linux-master-1611187144-41a088ce50b040cc139b89be9e9a13dad4a09053.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I4eba22a7de49019b128ce8aa8def4768c34a383b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641529Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845493}

This CL makes it easier/clearer to split up PasswordProtectionRequest
in a future CL.

Android-only code that depends on WebContents is extracted to a
standalone method - SetReferringAppInfo.
The content derived class implementation of
PasswordProtectionRequest will have access to WebContents and the
method will be moved there in a future CL.

Bug: 1147967
Change-Id: Ic38c933cb8d633bbef77c7b36460aa140bc55a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637403
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845492}

pass browser_tests --gtest_filter=ApplicationLaunchBrowserTest*,
pass browser_tests --gtest_filter=All/SystemWebAppManagerNonResizeableWindowTest*,

Bug: b/175974902, b/176472645
Test: Tested that SWA is not resizeable,
Change-Id: I9a69d16ce6b7b85ed5b14ed340bf99fe75793308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620923
Commit-Queue: Paulz Chen <paulzchen@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Nishi <dhnishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845491}

Makes the logo Finch-configurable. Flag is enabled by default.

Bug: 1168361
Change-Id: Ie9fbeebb5f88fcf6ca2d6a418759f65e61d3231e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639153
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845490}

This CL fixes errors where cros_is_vm and is_tast are undefined in an
ebuild environment.

Bug: 1168623, 1158590
Change-Id: I75ee6a9ed0b558787092bd6194a41515b1b0b50e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639309
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#845489}

RenderViewHost::GetSiteInstance() is being removed from the codebase so
this change replaces the calls in the NaCL code with equivalent calls on
the RenderFrameHost. This should not introduce any behavior changes
since the SiteInstances for these two objects are always the same.

Bug: 1166021
Change-Id: I0bf0c875e0734c986298f1578604a87a994fe020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631986Reviewed-by: Mark Seaborn <mseaborn@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845488}

This flag is used to convey whether external PCI devices are
allowed. It is disabled by default.

Bug: b:176763484
Change-Id: I51b596b3508816d7a43867e986ed9536524bc18c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638525
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845487}

Roll Chrome Mac PGO profile from chrome-mac-master-1611165592-ce7a0617ff859a9176e865c0be149d7728639a62.profdata to chrome-mac-master-1611187144-39ea136b6ebfd3c490dd8e8da57ed07347596a8e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Ia1fec695aa30a9ad0e09cccc6303507dd113bc4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641526Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845486}

Bug: 1141780
Change-Id: Ia382cbd802155af3a2fa75da7040e12a6cffd97a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639716Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Ye Kuang <yekuang@google.com>
Cr-Commit-Position: refs/heads/master@{#845485}

Omnibox is an element of the toolbar. The toolbar knows about elements,
has references to them for instantiation/use. But each element doesn't
need to know the toolbar, which is also desirable for
the modularization's sake. This CL removes omnibox's references to
toolbar.

- Moves toolbar.NewTabPageDelegate to omnibox/
- Moves/duplicates some constants

Bug: 1127732
Change-Id: I91488977f74cc8a97d23a4924ae2ed5644f9eb70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636822
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845484}

Modify FullRestoreReadHandler to get the window information from the
restore data read from the full restore file.

BUG=1146900

Change-Id: Idf18d6ba486011f63e0893ff7c9bb8078b9c9e48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639425
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845483}

When rolling default set of apps pinned to shelf, chrome_launcher_prefs
would check whether it's safe to do so using
IsSafeToApplyDefaultPinLayout(). One of conditions was verifying that
the app list sync has already started (to avoid getting default pinned
apps getting later overridden by an update from app list sync). This
does not work if sync is disabled for the profile, as in that case sync
would never start, so default apps roll would be delayed indefinitely.
For example, this may happen when logging in using a fake user (by
bypassing full login flow in test environments, or on linux-chromeos).

This updates the logic in IsSafeToApplyDefaultPinLayout() to allow
rolling default pinned apps if sync is disabled. This matches the logic
that's already in place for OS settings with split settings feature
enabled.

TEST=Run linux-chromeos with a fresh user data dir, and with no
--login-manager flag. Verify that both Chrome and Files app are pinned
to the shelf by default (both with SplitSettingsSync feature
enabled and disabled).

BUG=1166063,1154486

Change-Id: I8293b7a26447e5b5299b447984ce63417ead7653
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640308Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845482}

The tests were unstable before, now we only check resources
at the test fixture tear down, not upon every storage reset
(some uploads may still be ongoing at that time).

Bug: b:159361496
Change-Id: Iec90ca2c994a019abfc66cfb70dee77b2ce627f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641087
Commit-Queue: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#845481}

OutOfProcessInstance::OnGeometryChanged() recalculates the available
area and background parts upon geometry changes, then notifies the pdf
engine and updates accessibility information for the viewport.

Since PdfViewWebPlugin needs to share the functionality of recalculating
areas and notifying the pdf engine, this CL wraps the shared code into
RecalculateAreas() and migrate it into PdfViewPluginBase.

This change also allows mutable_available_area() to be removed since
`available_area_` now can be accessed directly in PdfViewPluginBase.

Bug: 1140629
Change-Id: Ie0196908fa4f2b948298beb5194757134ec4ba19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626036Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845480}

TEST=http/tests/inspector-protocol/page/page-captureScreenshot-clip.js
TEST=headless_browsertests

Bug: 1164610
Change-Id: I58c2c27d6793cd59605c42600060801e67127743
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636883Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845479}

This is a reland of a4df03d0

This addresses the revert by removing neon from the TFLite build
for chromeos.


Original change's description:
> [TFLite] Enable tflite in build for android and desktop.
>
> Bug: 1165517
> Binary-Size: Expected increase due to inclusion of TFLite in binary.
> Change-Id: I1c4c7b26f257c152d9477855ad32a77c0d30b85f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616241
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> Commit-Queue: Michael Crouse <mcrouse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#845026}

Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome
Bug: 1165517
Binary-Size: Expected increase due to inclusion of TFLite in binary.
TBR: Andrew Grieve <agrieve@chromium.org>
TBR: Tarun Bansal <tbansal@chromium.org>
Change-Id: I4b6b21b4a23a0c6978bfbb57150e9bf81300059f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639648
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845478}

The previous logic for what intrinsic size to give to a video element
was based on outdated spec text, this CL updates it to prevent the
poster image from resizing between starting playback and the first video
frame being rendered.

Bug: 1154296
Change-Id: I41a91f6672d8ccf4e3069afe581fac39f1a58820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617870
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845477}