- 27 Feb, 2020 40 commits
-
-
Sam Maier authored
Added keeps required to keep Mockito happy - revert happened here: https://crbug.com/1056619. This is a reland of 2d6ff560 Original change's description: > Roll R8 2.0.2 -> 2.1.8 > > I checked to ensure crbug.com/1050440 was fixed. > https://issuetracker.google.com/149831282 > > Bug: 1040534 > Change-Id: I3894f4316f2dde2527a35ad6e919ee8cdc86c2b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075039 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744708} Bug: 1040534 Change-Id: Ia991b83ef942d6655f9e1ba561ab1b407025ccae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078591 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#745189}
-
Robert Sesek authored
This was originally attempted in a8a9ff46, but PartitionAlloc unconditionally supplied MAP_JIT to mmap() if it was allocating pages for V8, even though V8 was running in --jitless mode. Because MAP_JIT can only be used from a process that has the allow-jit entitlement, this resulted in the process crashing due to a code signing validation error. Instead of unconditionally supplying MAP_JIT, PartitionAlloc now will only do so if the process has the allow-jit entitlement. Test: Configured a Proxy PAC file, did local signing of Chromium, verified that the proxy resolver utility process does not crash. Bug: 961592, 1052853 Change-Id: Icd1c2db42c208272f36c7d4c0fc1c1c3c6a3520f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078792Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#745188}
-
Domenic Denicola authored
This is the first step at implementing the new fetching semantics from the updated origin policy specification. It also deletes some parts that are no longer in the spec and would have needed updating anyway. In particular, this removes: * The distinction between default origin policies and versioned origin policies, and along with it, the "latest version map". This removes, for now, the application of origin policies to pages without an Origin-Policy header; that will be added back as part of the caching work in crbug.com/1042040. * Redirect-handling logic for default policies. Redirects are now always an error. * Parsing of the response header from the server. We currently just check for its presence, and will do parsing according to the new spec as part of crbug.com/1042036. * Sending Sec-Origin-Policy: 0 on the request. We may add this back later, but it is still under discussion: https://github.com/WICG/origin-policy/issues/51 * A good amount of C++ "unit tests" that were rather integration test-ey, and would have had to be rewritten anyway. Instead they are replaced with web platform test integration tests. * A thorough web platform test of the origin policy installation/deletion cycle, which would have had to be rewritten, and then rewritten again once we tackle crbug.com/1042049. We'll want to refer to it in version history once those foundations are stable. * Reporting, for now. We need to first spec this and then add it back. See https://github.com/WICG/origin-policy/issues/62. Additionally, although we removed all parsing of the response header, we changed the code to look for the presence of Origin-Policy instead of Sec-Origin-Policy per the latest spec. Apart from removals, this CL's biggest changes are to the web platform tests. This implements the plan discussed at https://github.com/web-platform-tests/wpt/issues/20773 and https://github.com/web-platform-tests/rfcs/pull/44 which allows us to serve different origin policies per subdomain. The test origin policies also now contain "id" members, but those are not used or tested for now; that will occur in https://crbug.com/1042036. Bug: 1042034 Change-Id: I4674fe2cfbc1f3e174c76415d86a487e750cdb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020488 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#745187}
-
Devlin Cronin authored
Add an interactive ui test for clicking twice on an action in the toolbar, verifying the second click closes the popup. This provides parity with the test coverage in the old ui (where this was exercised in ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose). Bug: 984654 Change-Id: I6ad9cb8fe3a67fcdab4b905796dc6aa91f458622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022977 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#745186}
-
Chris Hall authored
R=aboxhall, dmazzoni Change-Id: Ibbd5f6b9e8ad6ec954265b9c7eeb5b798055530b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066486 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#745185}
-
Toni Barzic authored
The test was asserting that an animation is still in progress just after running loop. If test is slow enough, it's possible that the animation completes before RunUntilIdle does its job. Downgrade ASSET_TRUE(is_animating()) StopAnimating() to if (is_animating()) StopAnimating() Whether the app list is animating or not at this point is not really focus of this test - the main point was to make sure that the test verifies the state after the animation completes. BUG=1056302 Change-Id: Ib0e0b912c5cc316df667a62c8c13e494c3a45df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078845Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745184}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/65dd8440ec78..9db20bb3437e git log 65dd8440ec78..9db20bb3437e --date=short --first-parent --format='%ad %ae %s' 2020-02-27 crouleau@chromium.org [Devil] Set up logging level based on --verbose. Created with: gclient setdep -r src/third_party/catapult@9db20bb3437e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:383566 Tbr: oysteine@google.com Change-Id: I14566ad2e3a2da3104b9c78b478b2a66b2d55ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079038Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745183}
-
Misha Efimov authored
Bug: 1010286 Change-Id: I66aa3617ee5e16c751a47d7f36f91925d89107d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835160Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#745182}
-
Deepanjan Roy authored
There was a circular dependency that broke run_tbmv3_metric.py: core.tbmv3.trace_processor imported core.results_processor.perfetto_binary_roller, which meant we had to import core.results_processor.__init__, which imported core.results_processor.command_line, which imported core.tbmv3.trace_processor. perfetto_binary_roller is quite independent of any other results processor code, so there is no reason to make users of it import results_processor.__init__.py which pulls in all the results_processor. Change-Id: I4990edbce41b8e06867c30bab1bb7d27f3c5b57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076418Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745181}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Mac. (The [2] CL enabled it earlier for Windows, Linux, and ChromeOS.) In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/2063530 [2] http://crrev.com/c/1967608 Bug: 1053725 Change-Id: Ibb1f8bc0baabc9cbe5326208cda1d12014e0d433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071583 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#745180}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4b8c86e94ba..2f0b41d4e7f8 git log a4b8c86e94ba..2f0b41d4e7f8 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 lalitm@google.com tp: split systrace trace parser into pieces 2020-02-27 lalitm@google.com tp: print stats before entering HTTP mode Created with: gclient setdep -r src/third_party/perfetto@2f0b41d4e7f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:150213213 Tbr: perfetto-bugs@google.com Change-Id: I7cadab7dcc6e17e0a06a55e17f7ce1330b6458ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079034Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745179}
-
Ken Buchanan authored
There have been occasional instances of marshals responding to security emails and removing the list outright, rather than bcc'ing. This makes it hard to distinguish between emails that have had responses and those that have not. Change-Id: I55feedc97450149a5dac69b6dd79c29eb5b44d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079331Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745178}
-
Darwin Huang authored
Bug: 1052575, 1056154 Change-Id: Ic54bb72742ee3e8b8b94f63e5468319e289a8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076539 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745177}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f4467316..bfa4dadb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e9722345ce60aff3e10b9383631754d07b0ce78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078552Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745176}
-
Rohit Rao authored
The pref values are transferred over eDO as JSON representations of base::Value and deserialized back into the appropriate types in the test process. BUG=None Change-Id: Ibcdd487160791d4d163bd3123d2244933406436c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075480 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#745175}
-
Geoff Lang authored
These objects are not used when the passthrough command decoder is in use. This saves several GPU memory allocations in TextureManager for default and black textures. Saves ~2 MB per context. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2028291 TBR=sandersd@chromium.org BUG=1046613 BUG=1030835 Change-Id: Iae138dd860023d3b16e958fed290ad78188b31bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072358 Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#745174}
-
Michael Lippautz authored
This sets up a directory for a C++ garbage collection library. The library will use the core of Oilpan (currently sitting in third_party/blink/renderer/heap) without depending on WTF or Blink internals. Design doc: http://bit.ly/oilpan-library-proposal "Would you tell me, please, which way I ought to go from here?" "That depends a good deal on where you want to get to," said the Cat. "I don't much care where--" said Alice. "Then it doesn't matter which way you go," said the Cat. "--so long as I get SOMEWHERE," Alice added as an explanation. "Oh, you're sure to do that," said the Cat, "if you only walk long enough." -- Lewis Carroll Bug: 1056170 Change-Id: I231f596783d742800b53730af6dcb84b11ffe389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077992 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745173}
-
Joshua Pawlicki authored
This allows extensions to serve from locations that require HTTP auth. Bug: 1031500 Fixed: 1031500 Change-Id: Ied62b0f685f43bbac450147f16518db293fbaea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071044 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#745172}
-
Toni Barzic authored
When the user successfully performs home to overview gesture, record the even in contextual nudges prefs for home to overview gesture. The goal is to stop showing the contextual nudge for the gesture if it's reasonable to assume the user already knows how to use it. BUG=1008963 Change-Id: Ie031320e6c8033fcee9aea26a1c5b01685d3c2f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076265Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745171}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb3f302bdf69..11efa18eca9f git log fb3f302bdf69..11efa18eca9f --date=short --first-parent --format='%ad %ae %s' 2020-02-27 mtklein@google.com impl load32 2020-02-27 brianosman@google.com Revert "Add most important intrinsics to the interpreter" 2020-02-27 mtklein@google.com initialize fEE = nullptr 2020-02-27 borenet@google.com [recipes] Move app_name into flavor.setup() 2020-02-27 westont@google.com Revert "Update Go Deps" 2020-02-27 mtklein@google.com convert to phi nodes Created with: gclient setdep -r src/third_party/skia@11efa18eca9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: Id7257d7a182704017a0b7174a865e256d2a08c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078609Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745170}
-
Nico Weber authored
We had a bunch of workarounds to get link.exe not use /incremental for very large binaries. Since we no longer use link.exe, remove those workarounds, and since this removes all reference to a bunch of configs, remove the configs as well. Inline all that remains into default_incremental_linking. (There's more that can be simplified here, but one thing at a time.) Bug: 1053958 Change-Id: I4cb123ef1a45fdbcd16d09211e55715095744a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079088 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745169}
-
Ben Joyce authored
Bug: 1005891,1054152 Change-Id: I28da67e1d4d1b92a4953a8ae72f9565055cc2afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064823Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#745168}
-
Kurt Horimoto authored
The OverlayPresenter passed as an argument for the OverlayPresentationContext API was not used by the implementation. This CL decouples the presentation context interface from OverlayPresenter. Bug: none Change-Id: Iefa20303f6b38d22240fb9f29f0c3ec6675cb55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069257 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#745167}
-
Greg Kerr authored
This adds the scheduler-configuration-default flag to the flags that are allow listed in guest mode. BUG=b:147685035 Change-Id: Ic2ef8d84ea71857953a3e223e8a0be140f50c035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079252 Auto-Submit: Greg Kerr <kerrnel@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#745166}
-
Kyle Milka authored
If STTS is not available (sync not enabled or no target devices available) display a prompt to educated users to sign in. Bug: 1009124 Change-Id: I357763f51fafcfded316fb8ecfb954470ea527e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067798 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#745165}
-
Akihiro Ota authored
This change is composed of the following menu panel improvements: 1. Change menu title "Search menu" to "Search" 2. Change the hint text of the search bar to "Search the menus" 3. Change instances of "ChromeVox" and "Cvox" to "Search" 4. Use ", then " instead of " > " for layered commands. 5. Change menu title "Forms" to "Form controls" Bug: 1049396 Change-Id: Ic622ec6949af2d7b2a1f3c6b5d73dc6048b89847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032007 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#745164}
-
Domenic Denicola authored
filter() results are not subscriptable in Python 3, so we need to use next() to retrieve the first element instead. Bug: 1056747, 941669 Change-Id: I003eda9a8044d18bf7a2aae82086693aa0386c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079191Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745163}
-
Martin Kreichgauer authored
The existing WebAuthentication.CableV1Event metric recorded information about the caBLEv1 authenticator discovery process up until the point before Chrome starts scanning for BLE advertisements. Most of the current issues with caBLE however occur in between starting the BLE scan and having a fully connected authenticator (e.g. during advertisement registration, establishing a GATT connection or reading FIDO Characteristics). This change replaces the existing metric with one that's recorded at the FidoCableDiscovery (WebAuthentication.CableV1DiscoveryEvent) which allows us to record more fine-grained events. The events recorded by the new metric are an almost-superset of the old metric's events. The only exception is the "Success (7)" event. However, we should still be able to count the number of successful caBLE v1 assertions from the WebAuthentication.GetAssertionResponseTransport metric. Bug: 1055029 Change-Id: I784e0ca94f2b0b1d97bef3efa9af19c8e9ea133a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069022 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#745162}
-
kylechar authored
This is a reland of 985a1f41. Also fix an issue where SoftwareOutputDeviceWinProxy was crashing if we draw the root RenderPass but never call SwapBuffers() as the |swap_ack_callback_| wasn't set. Original change's description: > Don't disable draw during resize > > https://crrev.com/c/2011130 changed Display::DisableSwapUntilResize() to > also block draw instead of just swap. This had the side of effect of > blocking draw when the browser window is minimized, which means we stop > casting tab/window contents. Switch DisableSwapUntilResize() back to > just block swap instead of draw+swap. > > Bug: 1054239, b/149923568 > Change-Id: I66a10dc1e801c56783107ce4412ab557f70da9f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068642 > Commit-Queue: kylechar <kylechar@chromium.org> > Reviewed-by: Saman Sami <samans@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744018} Bug: 1054239, b/149923568 Change-Id: I4f96bcb9547f4c4b24c020ffff728e4fa08d0ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078840Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#745161}
-
Daniel Rubery authored
Real time URL lookups may be running multiple token fetches at once, and needs to manage these requests in parallel. This CL moves that functionality into the SafeBrowsingTokenFetcher. Bug: 1051679, 1041912 Change-Id: I6a667ac86422e5c31c14107d45bf495cc0de4e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072911Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#745160}
-
Ted Meyer authored
We've decided after much deliberation that MediaError wasnt a very good name for a return type that could also denote success, so we've changed it to |Status| instead. Bug: 1043289 Change-Id: I1265f6aa6dc501298fa80b8df027205c70d64e2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068307Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745159}
-
Ana Salazar authored
Overview mode blurs the background, so we don't need the hotseat to blur the background a second time. Bug: 1022157 Change-Id: I7c1ee1f609db32163c629205c4bada0785b2b582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076085 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#745158}
-
John Lee authored
As requested by UX. Change-Id: I95847f267f74b199789f16ba1b5e2bc80e304747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076529 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#745157}
-
Xing Liu authored
This reverts commit bfb35d53. Reason for revert: Triggers a bug in the old code. see crbug/1056107. Original change's description: > Download notification: Simplify foreground notification events. > > Currently we use DownloadForegroundServiceObservers to broadcast > download foreground service events. It uses reflection to cache the > class name and then persist to android shared preference. > > DownloadNotificationServiceObserver implements > DownloadForegroundServiceObservers.Observer, and then call methods of > the singleton object of DownloadNotificationService. > > Also, onForegroundServiceRestarted() is not getting called, which make > the following calls dead code. > > This is extremely weird, we can just call the one line singleton > method. > > Bug: 922929 > Change-Id: I28ff5552fd7fc0fd5a111cd4971d6bf4514bb45f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063853 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743368} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922929 Change-Id: I467b19ba958a380a08e464339e735d5e30e376c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076977Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745156}
-
Xinghui Lu authored
If RTLookupResponse is empty, it can be either the URL is safe or there is an error during the network request. We should fall back to hash based check if an error happens. Bug: 1050859 Change-Id: Ib499ac35bf0ca4e01c211361975958e2cc88f52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068893 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#745155}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I921c72bddfe6c716bad2756a524670efbb991958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745154}
-
Sophie Chang authored
This is a reland of 04f3c8a3 TBR=tbansal@chromium.org for chrome/browser/predictors/... (he also said it was ok over chat) Original change's description: > Reland "Reland "Add support for loading predictor to use hints from optimization guide"" > > This is a reland of 9a31f5ab > > Original change's description: > > Reland "Add support for loading predictor to use hints from optimization guide" > > > > This is a reland of eed7024d > > TBR=tbansal@chromium.org for chrome/browser/predictors/... > > > > Original change's description: > > > Add support for loading predictor to use hints from optimization guide > > > > > > Will add metrics in a subsequent CL. This shouldn't affect any current > > > metrics since the support is all behind a feature flag. > > > > > > Bug: 1050101 > > > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#743767} > > > > Bug: 1050101 > > Change-Id: I796d2bbd322fee835bfc42f3f3bc903b65554291 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068313 > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#744088} > > Bug: 1050101 > Change-Id: I3450fa6cab159b22d0659532ea8f2524bf4944fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071380 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744839} Bug: 1050101 Change-Id: I3a2f925fc8d1d69ef25584848002cc158f2028a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078836Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#745153}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/eed48b86ed9c..c93595b4b916 git log eed48b86ed9c..c93595b4b916 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 perkj@webrtc.org Allow REMB messages to be sent immediately in RtcpTransceiver Created with: gclient setdep -r src/third_party/webrtc@c93595b4b916 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I674e68120b0fc63fa1296edb055d9a1130255b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745152}
-
Yue Li authored
Portrait and smaller screen treatment for 2 columns layout: https://spec.googleplex.com/crosux-spec/feature-specs/oobe-templates.html#oobe-templates-2-columns Also fix an error that the lottie animation is not found in the timeout method. Bug: 1033273, 1033268 Test: Manual Test Change-Id: I8cbe121b0514a8ff41bab6affecf00a576aad72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076665Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#745151}
-
Jerome Jiang authored
BUG=chromium:1055917 Change-Id: I7105ed49b94960bec3e267ffcee7aa4d74efff4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072364Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#745150}
-