- 16 Dec, 2016 29 commits
-
-
rtoy authored
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/of6S04dUf54/ScZJdp37BAAJ Per the discussion on the bug and on the intent we're just going to remove the prefixed items without any further deprecation warnings. BUG=665887 Review-Url: https://codereview.chromium.org/2557523002 Cr-Commit-Position: refs/heads/master@{#438987}
-
xlai authored
This CL aims to make html canvas to match to CSS style restriction regardless whether it is transferred to OffscreenCanvas or not. In a usual compositor commit, when a css style is imposed on the html canvas to change its width and height, its layer will reset a different bounds. However, in the case when html canvas has transferred control to offscreen, it is using a SurfaceLayer, which directly use surface_size_ without incorporating layer bounds to append SurfaceDrawQuad. This CL changes SurfaceLayerImpl to take into account the special case when layer bounds is different from surface_size by doing a transformation on the Quad, especially when the aspect ratio is different. The CL respects existing non-canvas cases on high-dpi devices and settings when enable-use-zoom-for-dsf is on or off. Also, it is also possible that the compositor commit due to style change happens before the Surface Layer for html canvas is created. To prevent flakiness, we force a compositor commit at the time when Surface Layer is created and registered to GraphicsLayers. TBR=khushalsagar@chromium.org, twellington@chromium.org, pfeldman@chromium.org BUG=655335, 652931 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2495373003 Cr-Commit-Position: refs/heads/master@{#438986}
-
yhanada authored
This error is produced if get_pointer_stylus method is called with a pointer object that is already associated with a pointer stylus object. BUG=673666 Review-Url: https://codereview.chromium.org/2575693002 Cr-Commit-Position: refs/heads/master@{#438985}
-
nhiroki authored
This was raised in https://codereview.chromium.org/2582483002/#msg9 getInstance() would be more common name for a function to get a singleton instance and less confusing for code readers. BUG=n/a Review-Url: https://codereview.chromium.org/2579823002 Cr-Commit-Position: refs/heads/master@{#438984}
-
yusukes authored
BUG=672829 TEST=try Review-Url: https://codereview.chromium.org/2583523002 Cr-Commit-Position: refs/heads/master@{#438983}
-
yuweih authored
This CL allows caller of the me2me NMH to override the path to save the host config, so that we can have separate host config file when testing NMH against test gaia environment. BUG=674685 Review-Url: https://codereview.chromium.org/2581043002 Cr-Commit-Position: refs/heads/master@{#438982}
-
reillyg authored
This blocklist allows access to particular models of USB device via the WebUSB API to be blocked via either a binary push or Finch experiment. Manual testing of this is difficult. I added a real device to the blocklist and verified that it was not returned by navigator.usb.getDevices() and was not listed in the chooser. BUG=674353 Review-Url: https://codereview.chromium.org/2581543002 Cr-Commit-Position: refs/heads/master@{#438981}
-
xjz authored
Peoriodically (every 1s) check whether video/viewport intersection is changed when video is rendered remotely. BUG=643964 Review-Url: https://codereview.chromium.org/2556333002 Cr-Commit-Position: refs/heads/master@{#438980}
-
chongz authored
This is the sub-patch (1/3) of supporting |EditCommandSource| in |CompositeEditCommand| (https://crrev.com/2574793002). This CL: 1. Renamed |EditorCommandSource| => |EditCommandSource| 2. Changed type |enum| => |enum class| 3. Moved from "Editor.h" => "CompositeEditCommand.h" This CL shouldn't have any behavior change. BUG=673789 Review-Url: https://codereview.chromium.org/2578753002 Cr-Commit-Position: refs/heads/master@{#438979}
-
tbansal authored
Add thread checkers to request options class. Force the generation of the chrome-proxy header, and use it later when generating the MockWrite for the sockets in tests. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester BUG=634061 Review-Url: https://codereview.chromium.org/2571993002 Cr-Commit-Position: refs/heads/master@{#438978}
-
marius.mlynski authored
FrameView::dispose() doesn't guarantee that the owner's widget is cleared and this could be problematic when it's overwritten in LocalFrame::createView() a short time later. BUG=673170 Review-Url: https://codereview.chromium.org/2563313002 Cr-Commit-Position: refs/heads/master@{#438977}
-
vmpstr authored
This patch adds a few more items into traced value for picture layer impls, in order to help diagnose issues. R=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2578193003 Cr-Commit-Position: refs/heads/master@{#438976}
-
einbinder authored
This patch adds a query parameter "panel" which sets the default panel when devtools loads. BUG=673472 TBR=sky Review-Url: https://codereview.chromium.org/2566573002 Cr-Commit-Position: refs/heads/master@{#438975}
-
jeffcarp authored
Mark tests with pre-existing lines above as possible duplicates. Will follow up on each of those. BUG=674313 Review-Url: https://codereview.chromium.org/2575293002 Cr-Commit-Position: refs/heads/master@{#438974}
-
yzshen authored
It also makes binding to a raw handle easier. BUG=579646 Review-Url: https://codereview.chromium.org/2578333002 Cr-Commit-Position: refs/heads/master@{#438973}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2579693003 Cr-Commit-Position: refs/heads/master@{#438972}
-
wkorman authored
BUG=666986 Review-Url: https://codereview.chromium.org/2570723002 Cr-Commit-Position: refs/heads/master@{#438971}
-
rjkroege authored
BUG=674742 TBR=paulmeyer@chromium.org Review-Url: https://codereview.chromium.org/2578353002 Cr-Commit-Position: refs/heads/master@{#438970}
-
charliea authored
This is in response to problems with loading.mobile on Android One/3G, where almost all stories were timing out. BUG=673461 Review-Url: https://codereview.chromium.org/2577243002 Cr-Commit-Position: refs/heads/master@{#438969}
-
elawrence authored
When a Safe Browsing warning is showing, the Developer Tools Security panel should show custom text in the summary area. BUG=654600 Review-Url: https://codereview.chromium.org/2542533004 Cr-Commit-Position: refs/heads/master@{#438968}
-
sigbjornf authored
Blink objects that implement (Active)ScriptWrappable have the ability to keep their corresponding v8 wrapper object alive across GCs by overriding and implementing ScriptWrappable::hasPendingActivity(). Once an ExecutionContext has become detached, we no longer want to retain wrappers belonging to it, as that will lead to memory leaks. With full bi-directional tracing of references across the v8 and Blink heaps, it is possible to make the lifetime of objects "more accurate", but not keeping a wrapper alive once in a detached setting, has proven to work out well in practice. Consequently, a ScriptWrappable in a detached ExecutionContext should not be retained, even if hasPendingActivity() return |true|. That is, we should simply ignore hasPendingActivity()'s result, freeing the implementations of it from having to take care of this 'detached' detail. This behavior is already provided by the 'standard' Blink wrapper visitors that v8 invokes during GC, but not with wrapper tracing, which is what this CL brings. It does so by extending ActiveScriptWrappable with a predicate for checking if the object's ExecutionContext has signalled destruction. (The natural(?) way to express that is to parameterize ActiveScriptWrappable<> over the class that implements the interface. This makes for a CL with a larger footprint.) R=haraken, mlippautz BUG=468240 Review-Url: https://codereview.chromium.org/2577053002 Cr-Commit-Position: refs/heads/master@{#438967}
-
gab authored
BUG=622400 Review-Url: https://codereview.chromium.org/2574403002 Cr-Commit-Position: refs/heads/master@{#438966}
-
twellington authored
If the last tab is moved to the other window and the device has a home page, the original activity closes, which leads to a weird, confusing animation. There's not a strong use case for having two windows open with only one tab. BUG=674684 Review-Url: https://codereview.chromium.org/2575343003 Cr-Commit-Position: refs/heads/master@{#438965}
-
twellington authored
BUG= Review-Url: https://codereview.chromium.org/2577193002 Cr-Commit-Position: refs/heads/master@{#438964}
-
bnc authored
Remove support for reading persisted settings with old values "npn-h2" and "npn-spdy/3.1". This CL is a follow-up of https://codereview.chromium.org/2129973002/diff/1/net/http/http_server_properties.cc and https://codereview.chromium.org/2353333005/diff/1/net/http/http_server_properties.cc Review-Url: https://codereview.chromium.org/2579543003 Cr-Commit-Position: refs/heads/master@{#438963}
-
alexclarke authored
because that would break the throttling logic which needs to know when the next delayed task is due to be run. BUG=671669 Review-Url: https://codereview.chromium.org/2572893002 Cr-Commit-Position: refs/heads/master@{#438962}
-
avi authored
The text was weirdly vague, trying to be cross-platform but not succeeding, there were odd conditions that could cause leaks, and there was about twice the complexity built in than it actually ended up using. BUG=555865 Review-Url: https://codereview.chromium.org/2440273002 Cr-Commit-Position: refs/heads/master@{#438961}
-
nick authored
handler as an argument, rather than passing them as data members. Eliminate the render_frame_message_source_, render_view_message_source_ data members. Eliminate the HasValidFrameSource() helper method. Eliminate the combo version of OnMessageReceived that took both an RFH or an RVH, and instead do the dispatch in the delegate OnMessageRecieved methods. Use the _WITH_PARAM dispatch macro to plumb the RenderFrameHostImpl into the dispatch methods. Fix some bugs that became apparent after this refactoring: OnEndColorChooser: insist on rfh/rph match (via a ::Matches helper) OnSetSelectedColorInColorChooser: insist on rfh/rph match OnOpenDateTimeDialog: use |source| rather than GetRenderViewHost. OnEnumerateDirectory: Use the right process for permissions check OnRequestPpapiBrokerPermission: rename |routing_id| to reflect that it's not a frame or view route ID. SendPpapiBrokerPermissionResult: rename this from On... to Send..., since it's not a dispatcher. Parameterize by the RPH id, so that we send the response to the right process. BUG=304341 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2563233002 Cr-Commit-Position: refs/heads/master@{#438960}
-
waltercacau authored
BUG=674367 Review-Url: https://codereview.chromium.org/2576293002 Cr-Commit-Position: refs/heads/master@{#438959}
-
- 15 Dec, 2016 11 commits
-
-
mlamouri authored
This is recording how often the metadata are already available/needed and the result of the lock attempt. BUG=670455 R=asvitkine@chromium.org, zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2581603003 Cr-Commit-Position: refs/heads/master@{#438958}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/98f5b96b79b3..eb5390d22252 $ git log 98f5b96b7..eb5390d22 --date=short --no-merges --format='%ad %ae %s' 2016-12-15 jessimb Fixes table formatting and changes unknown units labeling. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2584653003 Cr-Commit-Position: refs/heads/master@{#438957}
-
alph authored
Make two presets: Basic and Advanced Make two buttons: Record and Record Page Load BUG=570441 Review-Url: https://codereview.chromium.org/2576303002 Cr-Commit-Position: refs/heads/master@{#438956}
-
rockot authored
When wrapping an invalid SharedMemoryHandle, we should always just return a null ScopedSharedBufferHandle. Currently we return a non-null ScopedSharedBufferHandle which wraps an invalid platform handle. This will always fail to serialize and is generally bad. Also fixes DiscardableSharedMemoryManager mojom to allow a null shared buffer handle in the response to AllocateLockedDiscardableSharedMemory. The existing client implementation already handles the null case, so no additional code changes are required BUG=674406 Review-Url: https://codereview.chromium.org/2583583002 Cr-Commit-Position: refs/heads/master@{#438955}
-
krasin authored
PngWriteStructDestroyer accesses info_ptr, so info_ptr must have a wider lifetime scope. Otherwise, the behavior of the problem is undefined. The issue is found by AddressSanitizer with use-after-scope check enabled. BUG=649897 Review-Url: https://codereview.chromium.org/2576823002 Cr-Commit-Position: refs/heads/master@{#438954}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/344ec42f60fd..d85dd53e288e $ git log 344ec42f6..d85dd53e2 --date=short --no-merges --format='%ad %ae %s' 2016-12-15 brianosman Shrink the SkImageGenerator API 2016-12-14 stani Exclude complexclip4 GM tests from tile_rt config 2016-12-15 reed speedup dynamicwstream 2016-12-13 mtklein Port SkResourceCache to SkTHashTable 2016-12-15 reed remove unused dynamicwstream.snapshotAsData() 2016-12-15 kjlubick Update Pixel Cs -> NFM26H BUG=429375 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2584513005 Cr-Commit-Position: refs/heads/master@{#438953}
-
thomasanderson authored
This CL updates linux-sysroot-md to reflect the new steps required to build and upload the sysroots after https://crrev.com/4c8b67057de3ee3f6c4105a0dceebc0228d9832e. R=dpranke@chromium.org,sbc@chromium.org Review-Url: https://codereview.chromium.org/2579833004 Cr-Commit-Position: refs/heads/master@{#438952}
-
nparker authored
Also add a test. BUG=673827 Review-Url: https://codereview.chromium.org/2577963004 Cr-Commit-Position: refs/heads/master@{#438951}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/458e104e..2c88e4c9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2582633002 Cr-Commit-Position: refs/heads/master@{#438950}
-
rjkroege authored
animations/3d/transform-origin-vs-functions.html is failing on windows 7 BUG=674715 TBR=ajuma@chromium.org Review-Url: https://codereview.chromium.org/2578283002 Cr-Commit-Position: refs/heads/master@{#438949}
-
amaralp authored
Removed parameter that is always set to true. Review-Url: https://codereview.chromium.org/2578093003 Cr-Commit-Position: refs/heads/master@{#438948}
-