GitLab

Changes the parameter default_zoom_factor to appear as defaultZoomFactor
to javascript.

BUG=477559

Review URL: https://codereview.chromium.org/1093603002

Cr-Commit-Position: refs/heads/master@{#325477}

BUG=465418

Review URL: https://codereview.chromium.org/1057613006

Cr-Commit-Position: refs/heads/master@{#325476}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f7aaadb..bdb0bf5

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1089993002

Cr-Commit-Position: refs/heads/master@{#325475}

This fixes the compilation failures associated with _ChromeEnableBits caused by https://codereview.chromium.org/1038453002/.

BUG=477476
TBR=inferno@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1096493004

Cr-Commit-Position: refs/heads/master@{#325474}

It does not seem necessary to have this variable, just to create another
down below called 'buf'.

BUG=None
TEST=base_unittests --gtest_filter=MD5*
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1087333004

Cr-Commit-Position: refs/heads/master@{#325473}

that return the MockRenderProcessHost.

Preamble to a fix for bug 474231, where I'll add a new method to
MockRenderProcessHost.

BUG=474231

Review URL: https://codereview.chromium.org/1051343005

Cr-Commit-Position: refs/heads/master@{#325472}

Previously all dependencies would stop propagating for link purposes when a shared library or executable boundary is reached.

This patch makes public shared library dependencies propagate through shared libraries. Since the ability to use header files is propagated through these boundaries, so do the link dependencies. See the comment in target.cc for more details.

BUG=475091

Review URL: https://codereview.chromium.org/1083663007

Cr-Commit-Position: refs/heads/master@{#325471}

This is a minor refactoring change.  See linked bug for related work.

In order to make db_ private we needed to:
  - Add accessors for common operations (IsOpen, etc.)
  - Make TestDirectoryBackingStore a friend so it can db_.release().

BUG=475557

Review URL: https://codereview.chromium.org/1082423002

Cr-Commit-Position: refs/heads/master@{#325470}

This changes the renderer side of Chromium to only denote persistent
notification ids as int64_ts rather than as strings.

This CL is part of a three-sided patch:
  [1] https://codereview.chromium.org/1078783002/
  [2] This CL.
  [3] https://codereview.chromium.org/1072873002/

BUG=

Review URL: https://codereview.chromium.org/1071203002

Cr-Commit-Position: refs/heads/master@{#325469}

This CL removes the "override" keyword from all Blink API implementations.
We don't use the keyword for the Blink API since it's in a different
repository, and it makes changes to the API much harder.

Additionally, clean up some minor camelCase -> under_score variables.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1090953002

Cr-Commit-Position: refs/heads/master@{#325468}

BUG=476187

Review URL: https://codereview.chromium.org/1092463003

Cr-Commit-Position: refs/heads/master@{#325467}

These tests are for RemoteMediaVideoInfo and MediaUrlResolver. Many more
unit tests are needed, but these are a start. While these tests do not
replace the downstream instrumentation tests, a complete set of Cast unit
tests may reduce the need for them, and allow us to use those simply as
integration tests.

This CL also fixes one bug in MediaUrlResolver and removes getting the
already known browser user agent.

BUG=472067

Review URL: https://codereview.chromium.org/1079153002

Cr-Commit-Position: refs/heads/master@{#325466}

BUG=467287
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1082503002

Cr-Commit-Position: refs/heads/master@{#325465}

The new URLRequestContext disables alternate protocols
to ensure that the Data Reduction Proxy secure proxy check
request goes out over vanilla HTTP so that it can be
intercepted by middleboxes.

Also, secure proxy check is now done on IO thread.

BUG=437080

Committed: https://crrev.com/652eabf1141c00594aa6e9ed81beb980aec89198
Cr-Commit-Position: refs/heads/master@{#325302}

Review URL: https://codereview.chromium.org/981633002

Cr-Commit-Position: refs/heads/master@{#325464}

Change ScopedSuspendBookmarkUndo to take the BookmarkUndoService
instead of the Profile in its constructor and change client code
accordingly.

Add a GetProfileIfExists() method to BookmarkUndoServiceFactory
to avoid service creation when suspending the undo/redo mechanism
as if the service is initialized at BookmarkModel creation time.

BUG=477679

Review URL: https://codereview.chromium.org/1059523005

Cr-Commit-Position: refs/heads/master@{#325463}

BUG=410824

Review URL: https://codereview.chromium.org/1086393002

Cr-Commit-Position: refs/heads/master@{#325462}

BUG=473071

Review URL: https://codereview.chromium.org/1090783002

Cr-Commit-Position: refs/heads/master@{#325461}

The effects functionality has been migrated to NaCl - the code to
manually register a Pepper plugin for Effects is no longer needed.

BUG=392002
TEST=trybots, unit_tests

Review URL: https://codereview.chromium.org/1085393003

Cr-Commit-Position: refs/heads/master@{#325460}

Although the network stack is single-threaded, it *should* be legal to spin up
a parallel instance of everything on another thread. Until
https://crbug.com/458365 is resolved, the session cache is one of the few
global mutable objects in the network stack, apart from test code. Thus it
needs to be locked.

BUG=476713

Review URL: https://codereview.chromium.org/1079943006

Cr-Commit-Position: refs/heads/master@{#325459}

BUG=472073

Review URL: https://codereview.chromium.org/1089643002

Cr-Commit-Position: refs/heads/master@{#325458}

BUG=

Review URL: https://codereview.chromium.org/1079613003

Cr-Commit-Position: refs/heads/master@{#325457}

BUG=

Review URL: https://codereview.chromium.org/1086213004

Cr-Commit-Position: refs/heads/master@{#325456}

BUG=

Review URL: https://codereview.chromium.org/1051253006

Cr-Commit-Position: refs/heads/master@{#325455}

BUG=477148
TEST=Load webview browser sample (https://chrome.google.com/webstore/detail/browser-sample/edggnmnajhcbhlnpjnogkjpghaikidaa), use the browser sample app to navigate to a website that embeds a plugin (flash or pdf). Verify that the browser doesn't crash.

Review URL: https://codereview.chromium.org/1088323002

Cr-Commit-Position: refs/heads/master@{#325454}

Add original author of the code and original reviewer as OWNERS and
sdefresne@ for componentization work of //chrome/browser/undo.

BUG=476919
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1088513005

Cr-Commit-Position: refs/heads/master@{#325453}

Required in order to reland CL 1056763002. The only difference in the test output is that on the Mac the textual contents of the contenteditable are also present in the AXValue property on the AXGroup representing the contenteditable. I prefer to reland the contenteditable CL in order to investigate this more easily on my Mac.
BUG=347859
R=dmazzoni

Review URL: https://codereview.chromium.org/1080533004

Cr-Commit-Position: refs/heads/master@{#325452}

In the process of investigation of empty username occurences in the password manager, we suspect re-authentication forms to be a frequent cause. This metric will show us in how many cases this is not the cause.

We interpret occurences of an empty and nonempty username pair on the same signon realm as a presence of both a first-time authentication and re-authentication form.

We report the number of password forms with an empty username in the login database, for which there isn't another password form with a nonempty username on the same signon realm.

Out of several possible approaches:
a) SELECT ... WHERE NOT EXISTS
b) SELECT DISTINCT ... FROM ... JOIN ... ON a.signon_realm=b.signon_realm
c) SELECT DISTINCT ... FROM ... WHERE ... AND a.signon_realm=b.signon_realm
d) SELECT, put into std::set<>, SELECT, iterate and search the set

we implemented a), as manual testing on 1000 random samples seemed to be the fastest.

BUG=456728

Review URL: https://codereview.chromium.org/1087233002

Cr-Commit-Position: refs/heads/master@{#325451}

Now that all blink threads have schedulers it makes sense to get
hold the corresponding WebScheduler via WebThread.  This patch
is the chromium side of doing that.

Patch 2: https://codereview.chromium.org/1087203002
Patch 3: https://codereview.chromium.org/1084173002

BUG=463143

Review URL: https://codereview.chromium.org/1088053003

Cr-Commit-Position: refs/heads/master@{#325450}

Fix KeychainItemForForm so that it understands not to specify a path when looking for Keychain items corresponding to Android credentials.

While other code in PasswordStoreMac omitted the path before storing the Keychain item, KeychainItemForForm derived an erroneous path for an Android credential as well, and insisted to retrieve only Keychain items having that path -- yielding no matches. This has led to deleting and updating existing passwords not working.

BUG=476851

Review URL: https://codereview.chromium.org/1089233002

Cr-Commit-Position: refs/heads/master@{#325449}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0b71278..f7aaadb

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1094643002

Cr-Commit-Position: refs/heads/master@{#325448}

BUG=477697
NOTRY=true
NOTREECHECKS=true
TBR=calamity@chromium.org

Review URL: https://codereview.chromium.org/1096473002

Cr-Commit-Position: refs/heads/master@{#325447}

R=derekjchow@chromium.org,byungchul@chromium.org,lcwu@chromium.org
BUG=476713

Review URL: https://codereview.chromium.org/1058143004

Cr-Commit-Position: refs/heads/master@{#325446}

This group was only intended to be ran on early channels to show that we are tracking the right stats and ensure that the latest background mode experiment isn't bringing back the regressions that mode had previously brought (see issue 381820 and issue 398103).

The analysis is complete and support for it in the client is no longer required (already ramped down server-side).

(this is essentially a partial revert of https://codereview.chromium.org/926663002)

BUG=459600

Review URL: https://codereview.chromium.org/1089873002

Cr-Commit-Position: refs/heads/master@{#325445}

BUG=477696
NOTRY=true
NOTREECHECKS=true
TBR=kaznacheev@chromium.org

Review URL: https://codereview.chromium.org/1084403003

Cr-Commit-Position: refs/heads/master@{#325444}

BUG=477691
NOTRY=true
NOTREECHECKS=true
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/1059963005

Cr-Commit-Position: refs/heads/master@{#325443}

A "custom_clang_lib_path" argument is added to specify a custom path of
blink_gc_plugin for distributed builds such as distcc.

R=hans@chromium.org

Review URL: https://codereview.chromium.org/1052033006

Cr-Commit-Position: refs/heads/master@{#325442}

An intricate entangling of libsigchain, sigaction() chaining and
user-space SIGSEGV handling by binary translator cause persistent
crashes when a SIGSEGV handler is installed by a x86 library on
a hybrid application which uses both Arm and x86 libraries.
Backing out the crash handler as a temporary workaround.
More context in the related bug.

BUG=477444

Review URL: https://codereview.chromium.org/1059543003

Cr-Commit-Position: refs/heads/master@{#325441}

When profiles are deleted, new profiles are created in the directory
Profile X. These directories are stored in last active profile. In metro
mode, on initialization rather than last active profile, default profile
corresponding to the directory Default is used resulting in problems
on profile deletion. This CL makes ProfileManager::GetActiveUserProfile
return last active profile instead of default profile for windows build
to solve the problem.

BUG=450192

Review URL: https://codereview.chromium.org/1051843002

Cr-Commit-Position: refs/heads/master@{#325440}

original CL:  https://codereview.chromium.org/1088793002/

BUG=267773

Review URL: https://codereview.chromium.org/1083403002

Cr-Commit-Position: refs/heads/master@{#325439}

An intricate entangling of libsigchain, sigaction() chaining and
user-space SIGSEGV handling by binary translator cause persistent
crashes when a SIGSEGV handler is installed by a x86 library on
a hybrid application which uses both Arm and x86 libraries.
Backing out the crash handler as a temporary workaround.
More context in the related bug.

BUG=477444

Review URL: https://codereview.chromium.org/1089303002

Cr-Commit-Position: refs/heads/master@{#325438}