GitLab

Bug: 507665
Change-Id: If67ff3f6596cc9ca99cd99b0dc2b69ee442161c2
Reviewed-on: https://chromium-review.googlesource.com/571438Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487173}

The swap-promise used to compute the GPU swap timestamp for FMP was not queued
until SetFirstMeaninfulPaint is called, but this method is called with a
timestamp that was computed before the network quiet timer fired and FMP was
decided. The implications are that (1) when the swap promise is fulfilled, it's
because of some other paint, and (2) there might not be any subsequent paints,
and so we don't get a swap timestamp for FMP.

This CL fixes the problem by having the FMP detector queue the swap-promise in
when the FMP candidate is selected, which is on the Paint path. PaintTiming
reports the swap time to the FMP detector when the swap-promise is fulfilled.
The FMP detector now reports both the swap and non-swap FMP timestamps to
PaintTiming when the FMP is finally chosen.

Bug: 741961
Change-Id: I0fa9d396f6b46c90acea9f1a46e6d7cbbf5d7ef7
Reviewed-on: https://chromium-review.googlesource.com/570488Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#487172}

All cros kernel from v3.8 to v4.4 supports native GMB on Intel, and it boosts
performance on all generation Intel SoCs. [1]

[1] https://software.intel.com/en-us/articles/native-one-copy-texture-uploads-for-chrome-os-on-intel-architecture-enabled-by-default

TEST=tested by jenny.q.cao@intel.com on APL(reef, R61-9731.0.0), BYT(Squawks, R61-9741.0.0) and KBL(Soraka, R61-9743.0.0)
1. launch "http://browsertests.herokuapp.com/perf/background_color_animation.html" in browser for 10 minutes.
2. run smoothness.top_25_smooth with --enable-native-gpu-memory-buffers --enable-zero-copy --disable-gpu-rasterization
No visual glitch during the test, and no errors print in dmesg during test.

BUG=chromium:475633

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3359ca9af02f98cac4cf5ce25c25019224dfb4bb
Reviewed-on: https://chromium-review.googlesource.com/551365
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Cr-Commit-Position: refs/heads/master@{#487171}

In change https://codereview.chromium.org/2941623003, base/win/windows_version.h
was included in remoting/host/host_attributes.cc for all platforms. This issue
breaks gn analyze. Refer to the bug for more details.

Bug: 661774
Change-Id: I940bf9a87870fad76d14f6f7bea2c439cde081dc
Reviewed-on: https://chromium-review.googlesource.com/573560Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487170}

https://pdfium.googlesource.com/pdfium.git/+log/185312303814..ffbc0d9a08f8

$ git log 185312303..ffbc0d9a0 --date=short --no-merges --format='%ad %ae %s'
2017-07-17 tsepez More tightly validate format strings in util.cpp.
2017-07-17 dsinclair Move CPWL_Utils Draw methods to CFX_RenderDevice
2017-07-13 dsinclair Add CFX_FloatRect::GetDeflated

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ie1401bedf8ee19a22407886b7b514287b036d11f
Reviewed-on: https://chromium-review.googlesource.com/574754
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487169}

Currently, the passwords settings EG tests enable the "viewing passwords"
feature through NSDefaults (=experimental flags). Since recently, controlling
through a base::Feature is also possible.

This CL gets rid of the NSDefaults code, which needs to reset the state
manually with a simpler ScopedFeatureList, which limits the boilerplate.

Bug: 744058
Change-Id: I594fb4bbd3f90dd81a1f0f35c7f1ccb70aee965c
Reviewed-on: https://chromium-review.googlesource.com/573023Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487168}

ResourcePrefetchPredictor doesn't use LoadingStatsCollector since the CL
https://crrev.com/2937623007 was landed.

Bug: 715525
Change-Id: Ic16227b20fe2f3dfbd2b28e662a28f9339cc816e
Reviewed-on: https://chromium-review.googlesource.com/574606Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487167}

TBR=zmo@chromium.org
NOTRY=true

BUG=angleproject:2103

Change-Id: I72b1be3b79c1ac784bf343a23095ad4bdbc1e7f8
Reviewed-on: https://chromium-review.googlesource.com/575011Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487166}

TBR=pfeldman@chromium.org

Bug: chromium:743085
Change-Id: I66dee48fbf5f0dfc8ae1dadcfcba3deb374af4e6
Reviewed-on: https://chromium-review.googlesource.com/574637Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487165}

The cursor config controls the scale (additional factor influencing
how fast the cursor moves) and rotation of the cursor in ozone. Ash
was applying this, but in mus/mash we need the window-server to apply
it. This patch makes mus automatically apply the scale.

BUG=701068
TEST=covered by test

Change-Id: Ibb4fb3d4584bc23bd17e9f1b527857e27f0b6564
Reviewed-on: https://chromium-review.googlesource.com/572326Reviewed-by: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487164}

https://chromium.googlesource.com/angle/angle.git/+log/c5af8ba..4cff8d6

BUG=

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: I6d79c2fab74d84d4fc66d14ab2ccfb4df4a193b7
Reviewed-on: https://chromium-review.googlesource.com/574633Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487163}

Two build bot json files have been edited so that they run with the appropriate 
command line flags. Given that these build bot changes are related to adding to this
test this is all being packaged as one CL.

From original CL description:
"The added HTML file and JS file have been downloaded from here:

https://rsolomakhin.github.io/pr/multi/

And thus do not need to be thoroughly reviewed. The only changes made to these
files are as follows
1) In the html file an "id" attribute is added to the "buy" button, the 2016
copyright is changed to 2017, and the stylesheet and favicon links are removed.
2) In the js file "requestPayerEmail," "requestPayerPhone," and "requestPayerName"
is added to options on line 106, the JSLint directives are removed from the top of
the file, and the long line on line 137 was changed into two lines."

TBR=@lpromero@google.com -- Reviewed already in last past. Only addition here is the
build bot changes.

Change-Id: Ia20efa783eb763ae97f7e0df2f80e710823d7482
Reviewed-on: https://chromium-review.googlesource.com/570879
Commit-Queue: Randall Raymond <rayraymond@google.com>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487162}

Expands on the shared initialization to include base::AtExitManager,
net::NetworkChangeNotifier, and base::MessageLoopForUI.

With this change Cronet and ChromeWebView can successfully be used when
built together in the framework created by
//ios/web_view:cronet_web_view_combined.

Bug: 738510
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Iead4ba5d4f2376b09edf3f5c87a13829229b83b4
Reviewed-on: https://chromium-review.googlesource.com/558268
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487161}

Add the way for the DownloadService Model to attempt a hard recovery.
This will be used along with other component CLs to allow the
DownloadService to attempt to reset itself.

The recovery method for the Model happens via the following steps:
1. Clears the Model of all Entries.
2. Has the Store destroy itself.
3. The Store attempts to re-initialize.
4. Return the result back to the Model::Client.

BUG=736222

Change-Id: I4e0a256d0b241ef627d457d9c2276691d61da8ce
Reviewed-on: https://chromium-review.googlesource.com/568712
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487160}

Currently, GLFenceEGL's ClientWait always uses EGL_FOREVER_KHR. This change
adds a way to specify a timeout so that a thread can yield to do other work
while waiting.

This is being used in the critical path for WebVR rendering, and even a 1ms
delay noticeably cuts into the 16ms frame time budget. The workaround was to
repeatedly poll checking for completion, but that needs a very aggressive
timeout to avoid unnecessary delay. Using a timeout is more efficient.

Bug: 726026
Change-Id: I4c4292f31cf472e538cfdf18a835d48226d6ac58
Reviewed-on: https://chromium-review.googlesource.com/572663Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487159}

https://skia.googlesource.com/skia.git/+log/263cef7b5f4b..aa352de50c9d

$ git log 263cef7b5..aa352de50 --date=short --no-merges --format='%ad %ae %s'
2017-07-17 egdaniel Update visibility checks in Vulkan to support geom shaders

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: Iefee0ed2e7a4517717bd94ae1ae2772b4cd6c020
Reviewed-on: https://chromium-review.googlesource.com/574752Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487158}

This is a lifecycle violation, because clientHeight might invalidate
style.

Bug: 742704
Change-Id: Ifbe1d8df924e88074b5741dcd48f1d2171a6a04e
Reviewed-on: https://chromium-review.googlesource.com/572213Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487157}

This is a reland of 65143c3c
Original change's description:
> Protect |workers_| under the |idle_workers_stack_lock_|
> 
> The SchedulerWorkerPoolImpl in TaskScheduler will be changed to have a
> dynamic number of SchedulerWorkers, so |workers_| can be read and 
> written to from multiple threads. The |idle_workers_stack_lock_|
> will additionally cover |workers_| and be renamed to |lock_|.
> 
> Bug: 738104
> Change-Id: I23a49e18253a4a9a375be790be5a6735cb844323
> Reviewed-on: https://chromium-review.googlesource.com/556341
> Commit-Queue: Jeffrey He <jeffreyhe@google.com>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486074}

Bug: 738104
Change-Id: Ib4eb5533577abaf190715961483da7550cc01ece
Reviewed-on: https://chromium-review.googlesource.com/574634
Commit-Queue: Jeffrey He <jeffreyhe@google.com>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487156}

Rather than removing the command decoder's reference to the current
surface before ContextGroup destruction, do so afterwards.  Group
destruction might need the surface.

Bug: 718117
Change-Id: I39edc795a427c89f9a31fbd9d9d5ad58f9de0000
Reviewed-on: https://chromium-review.googlesource.com/574636Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487155}

changes:
SuggestionsContainerView is moved from StartPageView nested class in
go/croscl/548972 to support being added to STATE_APPS state. We should
enable DoUpdate() method for STATE_APPS state.

Bug: 742426
TEST: test that bug is fixed
Change-Id: I5eeabcb52f77ad6ddf34fa1ea75a7f9fc1f162d3
Reviewed-on: https://chromium-review.googlesource.com/571020Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487154}

V8 has the ability to use guard regions and signal handlers to do WebAssembly
bounds checks on x86_64 Linux. This requires any in-process signal handlers to
let V8 try to handle the signal first. This CL adds support for this to the
stack dump signal handler.

Bug: chromium:722585, v8:5277
Change-Id: Iccb72b66118c743f78b3ddbaf7887728b213ddb2
Reviewed-on: https://chromium-review.googlesource.com/541956Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Eric Holk <eholk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487153}

when decoding invalid UTF strings in chromedriver.

Web platform tests use ECMAScript strings which
aren't necessarily utf-16 characters.
This change will help us deal with that case.

More info: 
https://bugs.chromium.org/p/chromium/issues/detail?id=723592

To reproduce the error message from above, run:

./wptrun chrome url/url-constructor.html

on web platform tests.

Bug: 723592
Change-Id: Icf4b7de968ace81abba9f3020b9c123ab0791318
Reviewed-on: https://chromium-review.googlesource.com/565461
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487152}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/cf8d9b4ce3fa..38bdf22bfe68

$ git log cf8d9b4ce..38bdf22bf --date=short --no-merges --format='%ad %ae %s'
2017-07-13 wl [truetype] Improve code comment.
2017-07-13 wl [base] Fix memory leak.
2017-07-12 wl [base] Integer overflow.
2017-07-12 wl Document how to scale manually.
2017-07-12 wl CHANGES: Add information on global metrics rounding.
2017-07-12 wl * src/truetype/ttpload.c (tt_face_get_location): Off-by-one typo.
2017-07-11 htl10 Changelog: typo, chromium issue id is 2276 instead of 2278
2017-07-07 wl [cff] Integer overflow.
2017-07-06 apodtele Tweak suggested use of `lsb_delta' and `rsb_delta'.

Created with:
  roll-dep src/third_party/freetype/src
R=wangxianzhu@chromium.org,michaelbai@chromium.org,bungeman@chromium.org,drott@chromium.org

BUG=https://bugs.chromium.org/p/pdfium/issues/detail?id=812

Change-Id: I79d5dba70fe04d4965b80d156c859f3083c5c71f
Reviewed-on: https://chromium-review.googlesource.com/574651Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487151}

In this CL:

 - Remove expectations for tests that are actually passing.
 - Sort recently-added lines.

Change-Id: Idaabc01aef52789a062214aaff6569b8f54ed27b
Reviewed-on: https://chromium-review.googlesource.com/572261Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487150}

The set of valid FrameSinkIds is a concept used for SurfaceSequences
which are deprecated. We cannot remove SurfaceSequence code just yet
but GetValidFrameSinkIds is a publicly exposed method that is used
by FrameSinkManager for some DCHECKs. These DCHECKs are not really
necessary and removing them allows us to delete a public method
in SurfaceManager, simplifying its interface.

Bug: 722935
TBR: piman@chromium.org
Change-Id: I220a591d26e5bcd366eaa9a24404179f7439f49c
Reviewed-on: https://chromium-review.googlesource.com/574575
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487149}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/af47a939971b..6e3bfad0debc

$ git log af47a9399..6e3bfad0d --date=short --no-merges --format='%ad %ae %s'
2017-07-17 ashleymarie Fixing a line break

Created with:
  roll-dep src/third_party/catapult
BUG=717394


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I6002720bd981d8cd871563762578a3eab5e3ddc3
Reviewed-on: https://chromium-review.googlesource.com/574747
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487148}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c6e2620a..2937ab85

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: If5938caf262e2da6c0e3831a9b30f2f338172fa3
Reviewed-on: https://chromium-review.googlesource.com/574653Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487147}

This CL migrates ArcPolicyBridge.

BUG=672829
TEST=Ran try.

Change-Id: Ie649513dede52ff28c0eb54713b1e29cc2e37857
Reviewed-on: https://chromium-review.googlesource.com/572483
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487146}

Bug: 602666
Change-Id: I37f55fd5405456125824b8c4a798fbd8969a5bcb
Reviewed-on: https://chromium-review.googlesource.com/570824
Commit-Queue: mahmadi <mahmadi@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487145}

Bug: 661774
Change-Id: I7af30f80306fc506ab3b0b0b3eeed5b79fbbd845
Reviewed-on: https://chromium-review.googlesource.com/574632
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487144}

Switch to CheckForFirstPartyApps() instead of
GetNativeAppWhitelistManager().

Since this is the last use of the latter, it is removed from
ChromeBrowserProvider API as well.

Note that this depends on
https://chromereviews.googleplex.com/602627013/

Bug: 742617
Change-Id: I2df0461cdcc42b9729e7ae646b0a2fc26557133c
Reviewed-on: https://chromium-review.googlesource.com/570810Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487143}

An upload for sign-in form comes from Password Manager and password value is not set. Without this patch profile.GetMatchingTypes adds EMPTY type in |matching_types| that is not correct and moreover it causes DCHECK failure in https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_metrics.cc?q=autofill_metrics.cc&sq=package:chromium&dr&l=335 and in other places.   

Bug: 742464
Change-Id: Iece3caa40337c15828ab76fcb2ff3e68e659599d
Reviewed-on: https://chromium-review.googlesource.com/570167
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487142}

Removes content::BrowserThread::FILE usage in favor of TaskScheduler
interfaces.

Bug: 689520
Change-Id: Icd77c188320f57e4b8a1810c55bb6172d3093ae1
Reviewed-on: https://chromium-review.googlesource.com/567418Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487141}

Both FrameFetchContextTest and MixedContentCheckerTest deckare a class
named MockLocalFrameClient. That is normally no big deal
but in jumbo builds they can be compiled in the same translation unit
and then the functions will collide. This patch adds a prefix to
the class names to make them more unique.

R=fs@opera.com

Change-Id: I215f7edafa2fa0b229dc5847a1e158df825e8c27
Reviewed-on: https://chromium-review.googlesource.com/574708Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#487140}

It is used only by CompositorFrameSinkSupport so I'm moving it to
components/viz/service/frame_sinks where CompositorFrameSinkSupport is.
This CL also updates all includes, forward declarations and namespaces
as appropriate.

TBR=piman@chromium.org

Bug: 722935
Change-Id: Ibd3548c8a2aada8346c48e7a58b8fd9b35d63c16
Reviewed-on: https://chromium-review.googlesource.com/572589Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487139}

Bug: 
Change-Id: I2d45ac2eafaf6c838056e6070b4830f05a25f1cc
Reviewed-on: https://chromium-review.googlesource.com/569846Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487138}

Bug: 732792
TEST: views_unittests --gtest_filter=*InkDrop*
Change-Id: I44fa192b3c47a611dedf9978f12aed130b871f69
Reviewed-on: https://chromium-review.googlesource.com/558513
Commit-Queue: Ben Ruthig <bruthig@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487137}

By default the view pager only keeps one page to either
side of the current page, which results in the FRE pages
being regenerated.  This causes the search promo to become
invalid as it has been shown and the user successfully choose
an option.  As a two step mitigation, we up the number of pages
kept to be able to support the current FRE.  Then we also add
additional logic that will just skip the page if it is somehow
able to get into the invalid state again.

BUG=740897

Change-Id: I889900ce20d06248ca95765c54dbc84a60be4f5e
Reviewed-on: https://chromium-review.googlesource.com/567420Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487136}

Normally when grit actions are defined during `gn gen`, we don't
include all of the files that the .grd file depends on as inputs,
because we don't need to; grit generates a .d file for dependencies
so that rebuilds will happen correctly. And, computing the 
dependencies is slow (it's equivalent to calling grit).

However, if we don't include the dependencies in the gn build graph,
then `analyze` doesn't know about them, and hence a change to a file
that grit dependencies on will be ignored.

This CL changes things such that when `gn gen` is being run as part
of the `analyze` step, we do set the extra flag to compute the
dependencies. This'll slow GN down, but that's better than 
misreporting dependencies.

In some cases, the .grd files try to include generated files
(which may not exist at GN time). To work around this, you can
mark the grit targets as `source_is_generated = true`; the
downside of that is that that target will be skipped just as if
compute_grit_inputs_for_analyze=False, however, this is still an
improvement over not checking *any* of the grit targets. A better
fix would be to have grit_info ignore any paths in the generated
directory if they don't exist, and I'll try to do that in a 
follow-up patch.

R=brettw@chromium.org
BUG=639328

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9f6702b06f8a41a159e4599bf192db0abf9e77eb
Reviewed-on: https://chromium-review.googlesource.com/545150
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487135}

Added the Safe Browsing Preferences as part of the chrome://safe-browsing page.
Added the respective webui messages/functions.

Bug: 734667
Change-Id: I481a9c930ed1859c2a93ff32670e009fb148ae02
Reviewed-on: https://chromium-review.googlesource.com/566383
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487134}