GitLab

This CL makes the RenderFrameHostChanged observer method behave consistently and as described in the WebContentsObserver header file.

BUG=450799

Review URL: https://codereview.chromium.org/950223006

Cr-Commit-Position: refs/heads/master@{#318792}

R= bradnelson@chromium.org
BUG= none

Review URL: https://codereview.chromium.org/971043002

Cr-Commit-Position: refs/heads/master@{#318791}

When the status bubble is in state kBubbleHidden, its width is now always 1pt.
This prevents us from wasting time resizing and redrawing a hidden bubble.

BUG=454502
TEST=No visible impact.  Status bubble should continue to show when hovering over links and resize properly when the window size is changed.

Review URL: https://codereview.chromium.org/895713002

Cr-Commit-Position: refs/heads/master@{#318790}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/281bf52..b421650

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/967403003

Cr-Commit-Position: refs/heads/master@{#318789}

R=asanka@chromium.org
BUG=442666

Review URL: https://codereview.chromium.org/966983002

Cr-Commit-Position: refs/heads/master@{#318788}

Add callback so that kNoKey can get passed to blink in order
to generate the HTMLMediaElement.waitingforkey event.

BUG=337975
TEST=updated tests pass

Review URL: https://codereview.chromium.org/935243002

Cr-Commit-Position: refs/heads/master@{#318787}

Reverting CreateViewGLSurface to creating a surface that works as expected

Chrome uses the new surfaceless API, all others use the old one

BUG=447798

Review URL: https://codereview.chromium.org/938873002

Cr-Commit-Position: refs/heads/master@{#318786}

BUG=417589
TEST=run ppapi/examples/video_encode/video_encode.html

Review URL: https://codereview.chromium.org/937643006

Cr-Commit-Position: refs/heads/master@{#318785}

BUG=412007

Review URL: https://codereview.chromium.org/650233006

Cr-Commit-Position: refs/heads/master@{#318784}

Revert of Autofill: Disable autofill for fields outside of forms. (patchset #2 id:10006 of https://codereview.chromium.org/964453004/)

Reason for revert:
CL merged to M41/M42. Re-enabling on trunk.

Original issue's description:
> Autofill: Disable autofill for fields outside of forms.
>
> BUG=462375
>
> Committed: https://crrev.com/eb9e20d80c31c2842509e5213d4864eadf84baa1
> Cr-Commit-Position: refs/heads/master@{#318406}

TBR=estade@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462375

Review URL: https://codereview.chromium.org/974613002

Cr-Commit-Position: refs/heads/master@{#318783}

BUG=428903

Review URL: https://codereview.chromium.org/968943004

Cr-Commit-Position: refs/heads/master@{#318782}

BUG=462838

Review URL: https://codereview.chromium.org/969123002

Cr-Commit-Position: refs/heads/master@{#318781}

Restructure it so it is organized by date-added, and delete all migrations that are sufficiently old.

BUG=69995,165672

Review URL: https://codereview.chromium.org/944433002

Cr-Commit-Position: refs/heads/master@{#318780}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f48b013..b517bea

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/969053005

Cr-Commit-Position: refs/heads/master@{#318779}

AppMenu animation is known to be very janky on some low-end devices.
It will be helpful to indentify what devices are having this issue
through UMA.

TBR=isherman@chromium.org
BUG=461066

Review URL: https://codereview.chromium.org/960913003

Cr-Commit-Position: refs/heads/master@{#318778}

BUG=458328

Review URL: https://codereview.chromium.org/973553003

Cr-Commit-Position: refs/heads/master@{#318777}

BUG=460475

Review URL: https://codereview.chromium.org/945293002

Cr-Commit-Position: refs/heads/master@{#318776}

Previous review URL:
https://codereview.chromium.org/953453002

BUG=460859
TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/962143002

Cr-Commit-Position: refs/heads/master@{#318775}

To support dynamically added/removed content scripts in <webview>, we store
these content scripts in the same shared memory where user scripts from
declarative content API are stored, but the decision for injection will
be made in the render once the url pattern is matched. Since render doesn't
need to send IPCs to ask a decision from browser, it makes a precise time
injection possible.

Special to <webview>, once the content scripts are updated (added/removed),
browser will only notify the render process of the given <webview>, rather than
all of the renders (which is the case for user scripts).

BUG=437566

Review URL: https://codereview.chromium.org/906493004

Cr-Commit-Position: refs/heads/master@{#318774}

in GetLoadInfoForAllRoutes.

BUG=455952

Review URL: https://codereview.chromium.org/972773002

Cr-Commit-Position: refs/heads/master@{#318773}

Revert of Add remoting and PPAPI tests to GN build (patchset #6 id:100001 of https://codereview.chromium.org/961323004/)

Reason for revert:
broke windows GN builds as seen in

http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5206/steps/compile/logs/stdio

Original issue's description:
> Add remoting and PPAPI tests to GN build
>
> Reland of https://codereview.chromium.org/965633002/
>
> TBR=dpranke
>
> Committed: https://crrev.com/66c53eef76f7dff97b1bc76d51740c3a9c07844f
> Cr-Commit-Position: refs/heads/master@{#318756}

TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/968243004

Cr-Commit-Position: refs/heads/master@{#318772}

Design: go/chrome-fallback-icons

This adds FallbackIconUrlParser, which will be used to parse the
"explict flow" host chrome://fallback-icon/ to extract size,
FallbackIconStyle, and URL needed to render Fallback icons.

This CL is sliced off from https://codereview.chromium.org/835903005/ .

BUG=455063

Review URL: https://codereview.chromium.org/924063003

Cr-Commit-Position: refs/heads/master@{#318771}

R=inferno@chromium.org
BUG=463217

Review URL: https://codereview.chromium.org/969103002

Cr-Commit-Position: refs/heads/master@{#318770}

This adds tooltips to profile names in both the old and new profile
switcher when they are truncated on OSX.
This lines up with behaviour on Windows.

Also added myself to the AUTHORS file seeing this is my first contribution.

BUG=459572

Review URL: https://codereview.chromium.org/943453003

Cr-Commit-Position: refs/heads/master@{#318769}

Currently, the connect call of the clientPlugin requires a
fetchPinCallback, a fetchThirdPartyTokenCallback, an accessCode and a pairingInfo.

This fields are passed down all the way from crd_connect.js to the plugin via
sessionConnector and clientSession.  As a result, each of the intermediary layers
has its own member variables to cached those properties

This CL creates a new class remoting.CredentialsProvider that represents connection
credentials.  This also eliminates a set of callbacks and useAsyncPinDialog() on the
client plugin interface, which make the credentials negotiation flow between the
plugin and the client session less chatty.

BUG=462383

Review URL: https://codereview.chromium.org/954373002

Cr-Commit-Position: refs/heads/master@{#318768}

BUG=462799
TEST=Resized CrOS Ash-desktop-in-a-window on my local dev workstation to confirm crash is resolved.

Review URL: https://codereview.chromium.org/965093002

Cr-Commit-Position: refs/heads/master@{#318767}

The current implementation has an error in its time delay computation.
It computes negative timedeltas for cache entries that are
> Now(). This causes a CHECK failure in
IncomingTaskQueue::CalculateDelayedRuntime.

BUG=459443
CC=mfoltz@chromium.org

Review URL: https://codereview.chromium.org/937743003

Cr-Commit-Position: refs/heads/master@{#318766}

BUG=459842

Review URL: https://codereview.chromium.org/935223002

Cr-Commit-Position: refs/heads/master@{#318765}

Courgette cannot parse files that have out of order NOBITS sections and instead
will crash. The solution to this is to skip them and encode them as raw bytes.

Also, courgette has a bug where it incorrectly emits ElfRelocationInstruction
instructions even when there are no valid R_386_RELATIVE relocations in the
file.

Added a test file that exhibits both of these symptoms.

BUG=424820,423925
TEST=courgette_unittests
R=dgarrett@chromium.org, tommi@chromium.org

Review URL: https://codereview.chromium.org/664803002

Cr-Commit-Position: refs/heads/master@{#318764}

BUG=462382
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/958123003

Cr-Commit-Position: refs/heads/master@{#318763}

BUG=none
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/969083002

Cr-Commit-Position: refs/heads/master@{#318762}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8f9e816..281bf52

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/969653003

Cr-Commit-Position: refs/heads/master@{#318761}

BUG=463204
TBR=reed@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/969073002

Cr-Commit-Position: refs/heads/master@{#318760}

Presubmit does not contain any tests for the _CheckUserActionUpdate
function. This commit adds a test to check against an action in
actions.xml and one that is not found there. To do this we have to
improve the MockInputApi and MockFile classes.

BUG=462814

Review URL: https://codereview.chromium.org/966703003

Cr-Commit-Position: refs/heads/master@{#318759}

BUG=460638

Review URL: https://codereview.chromium.org/969833002

Cr-Commit-Position: refs/heads/master@{#318758}

Found by Facebook's flint tool:
$ flint ui/gfx/x/x11_error_tracker.cc
ui/gfx/x/x11_error_tracker.cc:6: The associated header file of .cpp
files should be included before any other includes.

Then built with:
$ gn gen out-gn
$ ninja -C out-gn x

BUG=None
TEST=see above
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/966173002

Cr-Commit-Position: refs/heads/master@{#318757}

Reland of https://codereview.chromium.org/965633002/

TBR=dpranke

Review URL: https://codereview.chromium.org/961323004

Cr-Commit-Position: refs/heads/master@{#318756}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c791d841..155278d6

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/969053002

Cr-Commit-Position: refs/heads/master@{#318755}

Make the chrome://extensions page use chrome.developerPrivate API to
select a file path for a crx and to perform the pack job itself.
Also add tests for the api function, and convert it to a
UIThreadExtensionFunction.

BUG=461039

Review URL: https://codereview.chromium.org/958803004

Cr-Commit-Position: refs/heads/master@{#318754}

Update chrome://settings for "automatic timezone detection" option after UI
review.

BUG=461953
TEST=manual

Review URL: https://codereview.chromium.org/944593002

Cr-Commit-Position: refs/heads/master@{#318753}