GitLab

Overriding ShouldAddContentSecurityPolicy() to disable CSP is considered
a bug. Enabling CSP while overriding GetContentSecurityPolicyScriptSrc()
to have relaxed rule is better.

BUG=81636

Review-Url: https://codereview.chromium.org/2003963004
Cr-Commit-Position: refs/heads/master@{#397816}

Dangerous ones still don't show the button.

This was an oversight concerning the difference between malicious and
dangerous.

BUG=616615

Review-Url: https://codereview.chromium.org/2029363002
Cr-Commit-Position: refs/heads/master@{#397815}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/9cdf7a6f..a352c80b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2038093004
Cr-Commit-Position: refs/heads/master@{#397814}

Has only one libfuzzer-related change:
    ffa4b67 [libfuzzer] adding //base to more targets.

No changes to the library.

BUG=

Review-Url: https://codereview.chromium.org/2030763003
Cr-Commit-Position: refs/heads/master@{#397813}

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2032643002
Cr-Commit-Position: refs/heads/master@{#397812}

BUG=None

Review-Url: https://codereview.chromium.org/2037793003
Cr-Commit-Position: refs/heads/master@{#397811}

..\..\courgette\third_party\bsdiff\paged_array_unittest.cc(20,11):
  error: unused variable 'kIterations' [-Werror,-Wunused-const-variable]
const int kIterations = 20;
          ^
..\..\courgette\third_party\bsdiff\paged_array_unittest.cc(21,11):
  error: unused variable 'kSizeBig' [-Werror,-Wunused-const-variable]
const int kSizeBig = 200 * 1024 * 1024 / sizeof(int);  // 200MB
          ^

BUG=82385
TBR=huangs

Review-Url: https://codereview.chromium.org/2036393002
Cr-Commit-Position: refs/heads/master@{#397810}

BUG=617290
TEST=gpu bots
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2032063004
Cr-Commit-Position: refs/heads/master@{#397809}

The default is to strip https:// URLs before submitting them to PAC scripts.

This CL introduces the policy "PacHttpsUrlStrippingEnabled" for disabling this security feature.

Setting the policy to "false" causes Chrome to no longer strip https:// URLs before sending them to PAC scripts. This applies to all profiles, and all PAC scripts (including those discovered through WPAD, and those delivered over an insecure transport).

The intent of this policy is to help enterprises with a compatibility problem transition.

BUG=616396
TBR=isherman@chromium.org

Review-Url: https://codereview.chromium.org/2030193004
Cr-Commit-Position: refs/heads/master@{#397808}

This CL bridges the native WebContents::DownloadImage to Java. We are planning to use the method for fetching artwork images (WIP) in MediaMetadata and show them in Android media notification.

Related CLs:
https://codereview.chromium.org/2013813002/
https://codereview.chromium.org/2015433003/
https://codereview.chromium.org/2009243002/ (most relevant one)

BUG=616411

Review-Url: https://codereview.chromium.org/2014553002
Cr-Commit-Position: refs/heads/master@{#397807}

Removing OfflinePageStorageManager::Client and merging into
OfflinePageModel. Also fixed some related minor issues and tests.

BUG=615165

Review-Url: https://codereview.chromium.org/2026843003
Cr-Commit-Position: refs/heads/master@{#397806}

BUG=616191

Review-Url: https://codereview.chromium.org/2028933002
Cr-Commit-Position: refs/heads/master@{#397805}

BUG=616485

Review-Url: https://codereview.chromium.org/2035743003
Cr-Commit-Position: refs/heads/master@{#397804}

We already call WebCacheManager::ClearCacheForProcess(RPH_id), which
seems to be sufficient in my local testing.
I remember that clearing webview cache didn't seem to work without calling
WCM::Remove() when I implemented it.

After r380598, Calling WCM::Remove also deletes mojo service associated
with the RPH, so the next call to WCM::Remove with the same RPH will
result in a nullptr access.

BUG=615429
Test=Added a test, see http://crbug.com/615429#c2 for repro.

Review-Url: https://codereview.chromium.org/2033993002
Cr-Commit-Position: refs/heads/master@{#397803}

Reland of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (patchset #1 id:1 of https://codereview.chromium.org/2038613003/ )

Reason for revert:
As expected, didn't stop the crashes =)

Original issue's description:
> Revert of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (patchset #1 id:1 of https://codereview.chromium.org/2025103003/ )
>
> Reason for revert:
> Speculatively reverting to fix release-blocking crash.
>
> Original issue's description:
> > ExtensionFunction: don't pass ownership of base::Value by raw pointer.
> >
> > BUG=581865
> > R=rockot@chromium.org
> > TBR=rdevlin.cronin@chromium.org
> >
> > Committed: https://crrev.com/5a01060d89daad34fa1cd8a20a0e4fdb48976a79
> > Cr-Commit-Position: refs/heads/master@{#397284}
>
> TBR=rdevlin.cronin@chromium.org,rockot@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=581865
>
> Committed: https://crrev.com/34661418ac5f137f1dcb72194e76c117308b6c7f
> Cr-Commit-Position: refs/heads/master@{#397533}

TBR=rdevlin.cronin@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865

Review-Url: https://codereview.chromium.org/2038083004
Cr-Commit-Position: refs/heads/master@{#397802}

Created a Drag & Drop client on Mac that bridges between the Views
and native OSX's drag and drop. This approach is based on the Aura
approach.

BUG=599585
TEST= Run the view unit test: DragDropClientMacTest

Review-Url: https://codereview.chromium.org/1964283002
Cr-Commit-Position: refs/heads/master@{#397801}

Apparently true and false are macros!

BUG=581865
R=danakj@chromium.org

Review URL: https://codereview.chromium.org/2036413003 .

Cr-Commit-Position: refs/heads/master@{#397800}

Reland: https://codereview.chromium.org/992483002

When an element in a cell has a percent height and the cell has a fixed height we
currently let the element ignore the height on the cell and instead let its content
determine the height of the cell (and the row).

Instead we should follow FF/Presto/Edge and the rendering agreed on the WG list
and let the element calculate itself as a percentage of its parent, the cell's
height.

https://lists.w3.org/Archives/Public/www-style/2015Mar/0101.html

BUG=465096,468699

Review-Url: https://codereview.chromium.org/2037783002
Cr-Commit-Position: refs/heads/master@{#397799}

The sas.dll was originally added to allow Chromtoing to inject the Secure
Attention Sequence (SAS).  Win7 and later OSes have an API for doing this
however we needed to support this functionality on XP and Vista and using the
redist sas.dll allows this.  Since we no longer need to support OSes earlier
than Win7/W2k8R2, we can call the OS API instead of using the version exposed
in sas.dll.

Removing this dependency also cleans up our code and reduces our pacakge size.

I don't think anyone else is using this dll so I am going to submit a follow-up
CL to remove the higher level GYP variables after this lands.

BUG=606385

Review-Url: https://codereview.chromium.org/2033683003
Cr-Commit-Position: refs/heads/master@{#397798}

BUG=539572

Review-Url: https://codereview.chromium.org/2029323005
Cr-Commit-Position: refs/heads/master@{#397797}

When the text caret is visible, show that highlight, otherwise if something
has focus, show the focus highlight - never both since they too often
overlap.

BUG=314889

Review-Url: https://codereview.chromium.org/2036343003
Cr-Commit-Position: refs/heads/master@{#397796}

BUG=616837,617268
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/2032613009 .

Cr-Commit-Position: refs/heads/master@{#397795}

The createTypeface method (which returned a bare pointer to a reference
counted object) is being replaced with makeTypeface (which returns a
smart pointer to a reference counted object). This removes some manual
reference counting in Chromium and allows for removing the deprecated
createTypeface method.

Review-Url: https://codereview.chromium.org/2037133002
Cr-Commit-Position: refs/heads/master@{#397794}

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2037933002
Cr-Commit-Position: refs/heads/master@{#397793}

The event name used in media_router_container.html for closing routes
was not renamed by the previous change.

BUG=614144
R=apacible@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2036383002
Cr-Commit-Position: refs/heads/master@{#397792}

This is no longer used and has been replaced by the viewporter
interface.

BUG=549781

Review-Url: https://codereview.chromium.org/2030023003
Cr-Commit-Position: refs/heads/master@{#397791}

Fix a bug with the Chrome legacy window at times becoming a top level window with a non functional button in the taskbar.

This bug typically occurs if the legacy window stays around after it is
removed from the original root window.

It looks like a recent change (https://codereview.chromium.org/1996163002)
which ensures that the legacy window is always created exacerbates this
problem by creating the legacy windows early and some of them stay around
after a tab switch. Typical cases include opening a pdf file in chrome
which causes at least two RWVHA instances to be active at any given point
and the legacy window which belongs to the original instance becomes a
button on the taskbar when the tab is switched.

Fix is to never reparent to the desktop window and instead always reparent
to the hidden window.

BUG=616410

Review-Url: https://codereview.chromium.org/2031213002
Cr-Commit-Position: refs/heads/master@{#397790}

There are a few final obstacles to removing Document::layoutView() and
FrameView::layoutView(), and they require the use of a shim to bust
through the block layout API. In LayerClipRecorderTest, it gets a
reference to the document's layout view and later passes it to
LayoutObjectDrawingRecorder::useCachedDrawingIfPossible, which in turn
passes it to DrawingRecorder::useCachedDrawingIfPossible, which is
defined in platform/ and can not have a hard dependency on the block
layout API.

BUG=499321

Review-Url: https://codereview.chromium.org/2036213002
Cr-Commit-Position: refs/heads/master@{#397789}

This patch makes tile manager a non-pointer so that it's clear that
it persists for the lifetime of layer tree host impl.

R=enne
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2036343002
Cr-Commit-Position: refs/heads/master@{#397788}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/80132ac6935a..ccb73566fef2

$ git log 80132ac69..ccb73566f --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2040493002
Cr-Commit-Position: refs/heads/master@{#397787}

The debug build that we're testing against is buggy and crashing on our
buildbot, so we're not able to test against this continuously. I've manually run
java tests against gs://chromium-browser-snapshots/Linux/378110 and don't see
any problems.

BUG=chromedriver:1390
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2029393006
Cr-Commit-Position: refs/heads/master@{#397786}

WebRTC now calls the PortAllocator destructor from the correct thread,
so this is no longer necessary.

Review-Url: https://codereview.chromium.org/1976263002
Cr-Commit-Position: refs/heads/master@{#397785}

With this, all *tests binaries built in the gyp build are also built
in the gn build on Mac (except remoting).

Also remove an unused js2webui rule in the gyp version of the target:
The target doesn't contain any .js files.

BUG=431177

Review-Url: https://codereview.chromium.org/2035083003
Cr-Commit-Position: refs/heads/master@{#397784}

BUG=589168

Review-Url: https://codereview.chromium.org/2041473002
Cr-Commit-Position: refs/heads/master@{#397783}

Revert of Make click targets inside links work. (patchset #1 id:1 of https://codereview.chromium.org/2030413002/ )

Reason for revert:
Failing on Mac 10.11 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/2237

Error message is:

Harness Error. harness_status.status = 2 , harness_status.message = null

Sorry to revert this again. :(

Original issue's description:
> Make click targets inside links work.
>
> There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
> For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
> BUG=615904
> TBR=dmazzoni@chromium.org
>
> Committed: https://crrev.com/f491eb9a53ed36e90ab45c943a0e52247ec00da5
> Cr-Commit-Position: refs/heads/master@{#397760}

TBR=dmazzoni@chromium.org,nektar@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615904

Review-Url: https://codereview.chromium.org/2036943003
Cr-Commit-Position: refs/heads/master@{#397782}

Originally Chrome OS's touch accessibility support was implemented purely
as an event rewriter. Tapping the screen generates a mouse move event,
which announces the object under the finger without clicking it, and then
double-tapping anywhere on the screen generates a click at the last point
where the user tapped. It's also possible to trigger clicks and drags by
more advanced means.

This worked well for touch exploration alone, but it's also possible for
the current accessibility object to move due to a gesture (to move to the
next or previous object on the screen, for example) or due to input focus
moving. In those cases, a double-tap was sending a simulated click to the
wrong point - it was sending it to the last touch exploration point, rather
than to the current accessibility object.

This change fixes this behavior by changing how the touch accessibility
support works.

First, it introduces the concept of the anchor point, which is the point
where the next simulated click will go. Initially this is set via touch
exploration, however now as soon as ChromeVox identifies the object under
the finger, it sends the center point of that object as the new explicit
anchor point, and that point overrides the touch exploration point for the
duration of this touch.

Second, when the user does a discrete gesture to click on the current anchor
point (double-tap, split-tap, or single-tap), it sends a gesture command
to ChromeVox, allowing ChromeVox to directly activate the current object.
However, if the user holds their finger down, it still passes through the
touch events so dragging and long-pressing are possible.

Third, it simplifies "split tap" support where you can tap a second finger
as a shortcut to clicking. That support now only supports a basic click and
not a long-press or drag.

BUG=513713,613694
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2007863004
Cr-Commit-Position: refs/heads/master@{#397781}

In http://crbug.com/493941, it was mentioned that we could fix all current pylint warnings before enabling pylint warnings in the presubmit -- but actually we could also enable warnings in the presubmit now without causing any problems; pylint will only print warnings about lines that are changed in a CL, and turning on warnings now could be potentially helpful in cleaning up the code.

And turning on pylint warnings in check-webkit-style and the presubmit is just a one line change; any reason not to just do it now?

NOPRESUBMIT=true
BUG=493941

Review-Url: https://codereview.chromium.org/2010173003
Cr-Commit-Position: refs/heads/master@{#397780}

After this CL, ResourceRequestBody from ResourceHostMsg_Request
will get sent after a cross-site transfer in FrameMsg_Navigate:

- ResourceDispatcherHostImpl::BeginRequest stores
  ResourceHostMsg_Request::request_body into
  ResourceRequestInfoImpl::body_

- NavigationResourceThrottle::WillStartRequest forwards
  ResourceRequestInfoImpl::body_ into a call to
  NavigationHandleImpl::WillStartRequest, where the body gets stored in
  NavigationHandleImpl::resource_request_body_

- NavigationHandleImpl::WillRedirectRequest takes care to
  reset the body if a redirect changed the method to a non-POST.
  (see also https://crbug.com/582211#c22).

- RenderFrameHostManager::OnCrossSiteResponse forwards
  NavigationHandleImpl::resource_request_body_ into the call to
  NavigatorImpl::RequestTransferURL.  The body is used to set
  the proper method on FrameNavigationEntry and used to populate
  CommonNavigationParams.

BUG=582211, 613004
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1956383003
Cr-Commit-Position: refs/heads/master@{#397779}

-Removed document.setRootScroller and replaced it by making the
document.rootScroller attribute writable.

-Moved the RootScroller object from FrameHost into Document. Now each
Document has its own RootScroller object which manages the rootScroller
for that Document. This means each iframe on the page will have its own
rootScroller. I've allowed setting it from iframes now too, making the
API more composable; setting a rootScroller on an iframe's Document
simply doesn't change any behavior.

-Made the rootScroller "sticky". Previously, if the current rootScroller
becomes invalid (for example, the rootScroller Element becomes
display:none) it would reset to the default element. With this CL, we'll
use the default while the rootScroller is invalid, but we keep the
rootScroller set. When it becomes valid again, we'll use it again. This
is done by making RootScroller::m_rootScroller the Element the page has
set as the root scroller. RootScroller::m_effectiveRootScroller is the
Element we're using internally to handle viewport actions.

-Changed the criteria for a valid rootScroller. Elements in an iframe can
now be used. Only elements that exactly fill the viewport are considered
valid.

BUG=505516

Review-Url: https://codereview.chromium.org/1970763002
Cr-Commit-Position: refs/heads/master@{#397778}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a9e2bf5a..9cdf7a6f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2038103002
Cr-Commit-Position: refs/heads/master@{#397777}