- 30 Mar, 2020 40 commits
-
-
Jeff Yoon authored
MB config was migrated incorrectly for ToTiOS. Should've been ios-simulator for ToTiOS, but was set with iOS device. Change-Id: I24925356843aeccc55d36e7c2a9c52d8e48fd09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125473Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#754573}
-
Robbie McElrath authored
This interface is used by the Site Settings UI to get embedder-specific logic, and will be used to abstract Chrome-specific logic so the rest of the Site Settings UI can be componentized. The Client is set in the Fragment by SettingsActivity. As of this CL, only the ManagedPreferenceDelegate is accessible through this new interface, but other embedder-specific logic will be moved behind it as well in future CLs. See go/weblayer-site-settings for more information. Bug: 1058597 Change-Id: I247cdc14fa6ac7cefd4e1b1d64b275b68ca7889e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119259 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#754572}
-
Peter Kasting authored
This combines both checks for "can the function be created" into one place, saving some code and scoping the error more clearly. HasPermission() only looks at a subset of the fields initialized by CreateExtensionFunction(); it does not care about the additional fields that were subsequently set in the caller. It's therefore not worth it to pull all the additional data into CreateExtensionFunction() that would be needed to hoist those setter calls. Bug: none Change-Id: Ie8169a0c6388245afd399aeca775880bfd891ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125575 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#754571}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 82-4072.0-1583746630-benchmark-82.0.4081.0-r1 to 82-4085.6-1584957322-benchmark-82.0.4085.18-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic142cbfa1f22528ff5e7b389ea4804f912f7af6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127757Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754570}
-
Pavol Marko authored
MetricsServicesManager holds a pointer to local_state, so it should be destroyed before local_state is. Reorder the member variables accordingly. This is usually not an issue because BrowserProcessImpl::StartTearDown ensures this. However, if BrowserProcessImpl::~BrowserProcessImpl() runs without StartTearDown having been called, the order of the member variables matters. Bug: 1064429 Test: See clusterfuzz reproduction line in https://crbug.com/1064429 Change-Id: I98c64efcd52be77a0df944b1a9ee1958000946af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119516 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#754569}
-
Dave Tapuska authored
The image source may not get loaded immediately so the size was reported as 0x0. Turn test into one that waits for the expected condition or timesout. Reland dfdb0486 with the removal of the initial pointer type check since it varies depending on platform. BUG=652536 Change-Id: I6f74c8db8d4f59e5e4d5c6bd6c8b20c8b107ea44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127411Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#754568}
-
Nicolás Peña Moreno authored
Bug: 1065535 Change-Id: Ie708216490b17d03319c5224bbe466cf0b0937d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127730 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#754567}
-
Owen Min authored
Also mention that Android does not support =2 option in the policy description. Bug: 1022678 Change-Id: I29a36b8e86306e19e6ba834241ba429850acd449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125028Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754566}
-
Xianzhu Wang authored
CSS scrolling properties on html/body apply to the view. For example, overflow:hidden on html or body actually means the view is not scrollable. Based on this, using compositing hint on html/body for the view composited scrolling is reasonable. This seems a better way to hint composited scrolling of an iframe's content than hinting on the iframe because this can be controlled by the content document. Change-Id: I78c3683d1c6f3b610161f5ebfb5cd7d2f6129b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125907Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754565}
-
zhaoyangli authored
- When merging profraw to profdata at shard_merge: Accept the test target name arg from input and name the profdata file as {target_name}.profdata. - When merging profdata from different target to one profdata, add support to filter the input with a regex pattern. This will be used to merge only profdata of needed test type. Bug: 1064785 Change-Id: I4c8ff800c7b40adef2cfe8f905204d6d3ec87ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121087 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#754564}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1c29477aa06e..81d8c2ada561 git log 1c29477aa06e..81d8c2ada561 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 cwallez@cwallez-macbookpro3.roam.corp.google.com MetalSurface: set layer.device to a ref of the system default device. Created with: gclient setdep -r src/third_party/swiftshader@81d8c2ada561 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I141ca078b6c0b77f592e683d2f0ae293426fe7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127138Reviewed-by:
-
Stephan Hartmann authored
nullptr_t is defined in namespace std. Bug: 819294 Change-Id: I16fd876b84aff4f3c0ef6d4654b8ad5015e52d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127369Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754562}
-
dpapad authored
Bug: 1026426 Change-Id: Ibabcf4907005ee17936550902341c3bf524a950f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125307 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#754561}
-
Peter Kasting authored
This code jumped through a lot of complex hoops to allow subclasses to provide a TestEnvironment of their own. But no subclasses actually want a test environment with a different lifetime than the parent's. So just allow people to pass in a TestEnvironment instance instead. This, coupled with providing an accessor for calling methods, allows making the TaskEnvironment private instead of protected. Bug: none Change-Id: I923f5b232eb8fc01cc445e4d51cf45707d167ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126093 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#754560}
-
Jonathan Backer authored
Bug: 1065901 Change-Id: If4cf2bcda93791651717a3627686e9b766a49a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127513 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754559}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9472e3eec085..d52066592790 git log 9472e3eec085..d52066592790 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 rharrison@google.com Add support for WebGPU to shaderc (#1021) Created with: gclient setdep -r src/third_party/shaderc/src@d52066592790 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I2bf8b6179a699942685bb69fba7ab1bca5fd0cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127414Reviewed-by:
-
Maksim Sisov authored
This CL configures the testers to run gpu_unittests. Bug: 1029240 Change-Id: I39b098486fb91ee851731bccd7001ecfe9e55bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126687Reviewed-by:
-
John Z Wu authored
Define a provider that needs to be implemented by embedders to provide embedder specific values. Change-Id: I33f929b7a26b997a293dd9e080126214c58fdefe Bug: 1062743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119765Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#754556}
-
Łukasz Anforowicz authored
This reverts commit 4f725946. Reason for reland: I think that the reverted CL cannot be responsible for the observed build error as explained here: https://chromium-review.googlesource.com/c/chromium/src/+/2125472/2#message-57912860a46d2c55efc389357cd193cc1068a76f Original change's description: > Revert "Migrate PolicyContentScriptXHR test to different test suite." > > This reverts commit b7c2f359. > > Reason for revert: This CL caused an issue in Linux ChromiumOS Full > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/159520? > > Original change's description: > > Migrate PolicyContentScriptXHR test to different test suite. > > > > This CL migrates BackgroundXhrWebstoreTest.PolicyContentScriptXHR to the > > CrossOriginReadBlockingExtensionAllowlistingTest test suite (into new > > tests, called ContentScriptVsHostBlockedByPolicy_NoSniffXml and > > ContentScriptVsHostBlockedByPolicy_AllowedTextResource). > > > > This way the tests covers the following setup aspects: > > - CorbAllowlistAlsoAppliesToOorCors feature is enabled or disabled > > - Extension is allowlisted or not > > - OOR-CORS vs InBlinkCors > > > > After this CL the old test can be deleted. Note that the old test > > always tested with: > > - CorbAllowlistAlsoAppliesToOorCors disabled > > - Non-allowlisted extension > > - The default OOR-CORS state (enabled by default since r728462) > > > > Bug: 1061567 > > Change-Id: Ic76ac9e48510953fd130141776e66b1fde11c404 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107431 > > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#754013} > > TBR=lukasza@chromium.org,karandeepb@chromium.org > > Change-Id: Idbd14b4e66190a533669159402389b738546bee6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1061567 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125472 > Reviewed-by: Juanmi Huertas <juanmihd@chromium.org> > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754249} TBR=lukasza@chromium.org,karandeepb@chromium.org,juanmihd@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1061567 Change-Id: I645636564e64256161251c1b187d13586ef3d625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127628Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#754555}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7bd282acce65..c24b6b7815ce git log 7bd282acce65..c24b6b7815ce --date=short --first-parent --format='%ad %ae %s' 2020-03-30 marinaciocea@webrtc.org Introduce TransformableFrameInterface. 2020-03-30 crodbro@webrtc.org Add test for relay bandwidth capping. Created with: gclient setdep -r src/third_party/webrtc@c24b6b7815ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2bce8686601684955b8ae0ebbc7ae5a10f6b0b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127137Reviewed-by:
-
Adithya Srinivasan authored
In certain cases, WebContentsAccessibilityImpl.notifyFrameInfoInitialized needs to refocus an already focused element, and for this to work it needs GestureListenerManager to receive the updated frame info first, otherwise an an accessibility focus event can't be created. This occasionally caused focusing the activated WebContents after a portal activation to fail. Bug: 1064084 Change-Id: I9fdf60a108621334399938895717598678459b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122911Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#754553}
-
Ben Pastene authored
The bots are now successfully downloading the needed test artifacts thanks to luci-context setting up task-specific boto file + env var. Bug: 1000351, 1054340, 1006681 Change-Id: I89abf71b655747b206aeba2fddbdd3d5b2daf740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115774 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#754552}
-
Vasiliy Telezhnikov authored
This CL lazy initializes SkSurface for writing in SharedImageRepresentationSkiaVkAHB and caches it for subsequent writes to optimize performance Change-Id: I6f6d339448e3a864fced0d93864745d21cc369e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127430Reviewed-by:
-
Ben Kelly authored
Field trials shows that using a sequence instead of the IO thread progresses match times by 10% at P95 on windows. Mac shows similar progressions. Android has mixed results and is somewhat neutral in total. ChromeOS, however, shows regressions across the board including a 15% regression at P95 on match times. Therefore, this CL enables the sequence feature on all main platforms except ChromeOS. Further experiments and trials will be run to launch on the remaining platform in the future. This CL also leaves the feature disabled on fuchsia for now. Some failing tests need to be investigated on that platform. Bug: 960012 Change-Id: Ib4d379dff208a5363f73277ed4415d3e94dc17b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124606 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#754550}
-
Xiaoqian Dai authored
Bug: 1063136 Change-Id: I5c0136e77e9b0859aff91bb726b09d0b21ed7360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125298Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#754549}
-
Roman Aleksandrov authored
Add new metrics which are additionally grouped by exit reason. Bug: 1063611 Change-Id: I7fa80bec2b1eb078610ca9b18b42266c798565d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113493Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#754548}
-
Xida Chen authored
Right now the slower thread throughput is simply taking the lower throughput between the main and compositor throughput. This CL improves that. Specifically, when we are expecting and producing main frames, then we count the frames produced from the main thread towards the slower thread. Otherwise, use the numbers from the compositor thread towards the slower thread. Bug: 1002994 Change-Id: Ie2de3ff958f920e6afa5234b7cf40aea05930ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022618Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754547}
-
Rob Buis authored
The linethickness property should be parsed as length-percentage [1, 2], so add a method to CSSParser to parse length-percentage. Negative values are allowed as length-percentage but are clamped to zero by the FractionLineThickness method. Finally, for now we do not accept calc() expressions. [1] https://mathml-refresh.github.io/mathml-core/#dfn-linethickness [2] https://mathml-refresh.github.io/mathml-core/#dfn-length-percentage Bug: 6606 Change-Id: I621d17d6e69cc113016fe1c809f55776c7e357d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098728Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#754546}
-
Nate Fischer authored
No change to logic. This inlines NavigationMenuHelper because the logic should only ever be called from the MainActivity now. This also removes one piece of commented-out code that was accidentally uploaded in a previous CL. Bug: 1017532 Test: Manually confirm navigation is the same Change-Id: I3d574316f8de55d80f5a2a6f5010b6d3f053a424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123646Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754545}
-
Stephen McGruer authored
Tackling the set of calls that avoided the automated refactor (for various reasons). There are about 50 in total, split up into a few CLs to make reviewing it easier. Bug: 1051932 Change-Id: I83ebbfadd97056940fa69d82a2fc8959cdf2eb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083388 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
Ted Choc authored
AutocompleteEditText#testDelete_CommitTextWithSpannableModel ensures deletion updates are processed (and it checks that shouldAutocomplete() is false after deletions). This was an existing test. LocationBarTest#testDeleteButton does isolated testing of the delete button. AutocompleteMediatorUnitTest#onUrlFocusChange_triggersZeroSuggest_* adds more complete zero suggest unit tests to complement onTextChanged_emptyTextTriggersZeroSuggest. BUG=1027549 Change-Id: I71635c615afb2359326aaa82d50223466b836a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125428 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754543}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6a7e234b584e..1c4e06b7d750 git log 6a7e234b584e..1c4e06b7d750 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1c4e06b7d750 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I46cca9922de4153e30643db6c1da6908ca1960fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127136Reviewed-by:
-
Thomas Lukaszewicz authored
Bug: 1056916 Change-Id: I473116523113dd420196af63386da02a16ef1015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123911Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#754541}
-
Mitsuru Oshima authored
Bug: 1050816 Test: covered by unittest Change-Id: Ie5d4ce89870cf6690793e9367ed75ee96bb2021b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126089Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#754540}
-
Roman Sorokin authored
Migrated to Views where needed PreferencesTest.MultiProfiles ForceMaximizeOnFirstRun RestoreOnStartupTestChromeOS DeviceID* ActiveDirectoryLogin OAuth2Tests Bug: 987587 Change-Id: I48d32c20a078e21c6ce9d24d8081037178f1beab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124383Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
zhaoyangli authored
Code coverage recipe module will use this property to determine coverage data of which test types (unit tests, integration tests, all tests, etc) to generate. Bug: 1064785, 943883 Change-Id: I6ced881035b8d182428267486f7a404a44ddaea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122472Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/344bd0889ac9..08c02ced798a git log 344bd0889ac9..08c02ced798a --date=short --first-parent --format='%ad %ae %s' 2020-03-30 johnkslang@users.noreply.github.com Merge pull request #2164 from dj2/unused Created with: gclient setdep -r src/third_party/glslang/src@08c02ced798a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I0222329dab50286895057ca55e4bc993f68620a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127133Reviewed-by:
-
Peter Wen authored
This allows devs to prioritize build speed and easily turn off analysis. Bug: 921686 Change-Id: Ie68368634e779119eb912e5b1342742d5d45d51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122229 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#754536}
-
Nico Weber authored
This is a reland of a7b569e6 Original change's description: > Enable -Wunreachable-code in iOS builds (except for internal builds). > > This requires replacing EARL_GREY_TEST_DISABLED with DISABLED_ prefixes > in cases where the call to EARL_GREY_TEST_DISABLED is unconditional. > earl_grey/disabled_test_macros.h, which defines EARL_GREY_TEST_DISABLED, > says: > > This macro should be used when the configuration for which the > test should be disabled can only be determined at runtime. > Disabling at compile-time is always preferred. > > So this matches the official guidance, and there are many > egtests that use DISABLED_ already. > > Bug: 346399 > Change-Id: Ibe51463ec0e6afbd1b3bef629406163118efa64c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125878 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754468} Bug: 346399 Change-Id: I5c149da6a3a0b9e49caa3e3084015df8c4bb7ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127429 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#754535}
-
Richard Knoll authored
This is a fix after crrev.com/c/2125047 that checks the notification icon instead of the image on macOS. Ran the browser_tests manually on a Mac this time as they don't seem to run on the CQ. TBR=mvanouwerkerk@chromium.org Bug: 1065882 Change-Id: I5e9e7ec544612073258565cc5ce2fa7ac277a91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127033Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754534}
-
