GitLab

Bug: 910739, 974916
Change-Id: I89da31d03b93e3650975a1d0aa23e94970eaea91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696266Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677039}

https://skia.googlesource.com/skia.git/+log/57b0b09dfdb6..690e899cff0c


git log 57b0b09dfdb6..690e899cff0c --date=short --no-merges --format='%ad %ae %s'
2019-07-12 rmistry@google.com [perf_skottiewasm_lottieweb] Use the new "--use_gpu" flag for GPU bots
2019-07-12 rmistry@google.com [perf_skottiewasm_lottieweb] Add flag for use_gpu
2019-07-12 reed@google.com add savelayer flag to promote the later to half-float


Created with:
  gclient setdep -r src/third_party/skia@690e899cff0c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fmalita@google.com

Change-Id: I44018943d3b036b316407a9a591b29f2b1238f1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700344Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#677038}

Refactor browser tests logic so that it can be used by periodic
Background Sync browser tests as well.

Bug: 925297
Change-Id: I3771a8391082943af796a69146ffac12f3c1226c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698464
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677037}

This reverts commit b3bb875d.

Reason for revert:

Causes deterministic failures on bot
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg
of test
CrSettingsGoogleAssistantPageTest.All

More details at http://crbug.com/983568


Original change's description:
> assistant: fix race condition on showing hotword options
> 
> Hotword device detection may take some time for cras. Assistant
> settings page maybe showing before cras has fully discovered all
> audio devices.  This change makes sure we handle cras audio
> device node changes to update with latest information.
> 
> Bug: b/135137356
> Test: locally build and test on device.
> Change-Id: Iea84cd3a9e7e25b324014242799ac88f372a099e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687363
> Reviewed-by: Yue Li <updowndota@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#675922}

TBR=stevenjb@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/135137356
Change-Id: I2dd5ee9af4b777d71e3954365796421010525c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699509Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677036}

This CL refactors VaapiImageDecoder to use
std::unique_ptr<ScopedVASurface>, together with a custom deleter to
destroy the associated context. This ensures the decoder owns and
properly clean the underlying VA surface and VA context. This is useful
because it removes clean-up responsibilities from clients of
ScopedVASurface.

Unfortunately, we have noticed that VaapiWrapper would reduce the manual
ref count of the VaDisplayState upon its demise, which may cause some
ScopedVASurfaces with stale copies of VADisplay to not be able to
self-clean. Therefore this CL introduces a (hopefully) temporary
modification to ScopedVASurface in which it holds a scoped_refptr to the
VaapiWrapper that created it and uses it to self clean.

In addition, the API of image decoders is changed slightly. A
scoped_refptr<VASurface> is no longer returned upon Decode() requests.
Should a client need access to the ScopedVASurface, the API exposes a
GetScopedVASurface(), which returns a const raw pointer to the decoder's
ScopedVASurface. This should feel familiar due to the get() call in
unique_ptrs.

Finally, this CL fixes some of the call-sites that use VaapiJpegDecoder
(i.e. VaapiImageDecoder's new API).

Bug: 877694, 980379
Test: jpeg_decode_accelerator_unittest
Change-Id: I834c3af64813e3004f8a62da4e2ef529585be465
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696012
Commit-Queue: Gil Dekel <gildekel@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677035}

We'll have to limit support to P+, since it's otherwise quite a
chore to get the correct MediaCodec status in the renderer.

This also does the following:
- Strips media:: prefix from media/base/supported_types.cc
- Adds warnings to MediaCodecUtil around methods which can't be
used from the renderer process.
- Moves opus support checks to MediaCodecUtil where they belong.
- Moves hevc support checks to MimeUtilInternal::PlatformInfo where
they belong. Expands unit test for this. Updates MediaCodecUtil.java
to accommodate this.
- Removes a unreachable statements from IsCodecSupportedOnAndroid.
- Switches MimeUtil to use base::NoDestructor for MimeUtilInternal,
required adding const to a few more methods in MimeUtilInternal.

BUG=980091, 980682
TEST=passes locally now.
R=chcunningham

Change-Id: Ib59dce569a5198754e8f5a0df7ee28241f76a5fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694241
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677034}

When the banner "Your changes will take effect the next time you relaunch Chrome"
appears on the page, the screen reader will be alerted.

Bug: 982886
Change-Id: Ib148b8a3bc2c2949771ca5e949b9e42b2b182d19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696355Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#677033}

This CL adds the "scamble_message_ids = false" to the mojom_platform
target to unscramble message IDs. This CL is a replacement of this
CL[1], aims at unscrambling DocumentInterfaceBroker message IDs
without build failure.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1688224

Bug: n/a
Change-Id: Ieee5d19a8e9e650b402a163606bdd6556d99500b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693810
Commit-Queue: Suzy Li <suzyli@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677032}

Tests are largely the same as PrefetchFeedFlowTest with a couple of
changes in external code and in the test itself so it works in Reduced
Mode.

Bug: 959957
Change-Id: I75bdf3e149460e8734572f0b7fe6aaae61b796b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669656
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677031}

This reverts commit c6b8b53b.

Reason for revert: Fixing the debugging issues.

Original change's description:
> Revert "[Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set."
> 
> This reverts commit ffa05b99.
> 
> Reason for revert: This breaks a lot of debugging workflows.
> 
> Original change's description:
> > [Logging] Disable always-log-ERRORs-to-stderr unless LOG_TO_FILE is set.
> > 
> > logging::LogMessage has a special-case to write LOG_ERROR messages
> > to stderr, even if LOG_TO_STDERR is not enabled, to make ERROR and
> > FATAL messages more visible, especially in tests.
> > 
> > Restrict this behaviour to apply only if LOG_TO_FILE is set, so that
> > binaries which only LOG_TO_SYSTEM_DEBUG_LOG will never emit logspam
> > to stderr.
> > 
> > Tested by adding a unit test for this case.
> > 
> > Bug: 968387
> > Change-Id: Icfe094e7d7bf9697a70a589eab48edbe79c36091
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638782
> > Commit-Queue: Sharon Yang <yangsharon@chromium.org>
> > Reviewed-by: Wez <wez@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#666507}
> 
> TBR=wez@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org
> 
> Change-Id: I857fd9bc95afedf204a5e981e6a362cd8990b4a8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 968387
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647361
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666753}

TBR=dcheng@chromium.org,wez@chromium.org,kmarshall@chromium.org,yangsharon@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 968387
Change-Id: Id656bff53e3b53e4df981ca8e819f33900c966f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682954Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Auto-Submit: Aidan Wolter <awolter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677030}

TBR=kbr

Bug: 982086
Change-Id: I63123b0d6daece31a88bc9a672fda6f652b750cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700461Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677029}

Bug: 981191
Change-Id: I5a2f21226a1d8f72ed2b151df383cf9888dce49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699799Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677028}

We currently depend on the IS_FULLSCREEN property being set
in TouchlessDialogPresenter. This should always be set, but in
case we miss a spot, I've added code to fail gracefully and have
added an assert so we can spot these failures in debug.

Bug: None
Change-Id: I7d210b53c7489cb4757e9b56c9aaa75538266314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699788Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677027}

Check that the icon is valid and within the size limits, and also that
the launch URL is valid and belongs to the renderer's origin.

Remove the `SERVICE_WORKER_UNAVAILABLE` error since it's unused.

Bug: 973844
Change-Id: I59f47602174fe5310713460adf50c5f85ebe1459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698405
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677026}

Antony is no longer doing Chromium reviews.

Bug: None
Change-Id: I18eaba51859e55a512a351bc873387693f856de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700283Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677025}

Will enable the tests in a follow-up CL

Bug: 911154
Change-Id: I9741e55cacb4522fdcfedb4c090b7007ef50b9fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697608Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677024}

https://dawn.googlesource.com/dawn.git/+log/06ab6e5b1330..2a1d8c2b1d32


git log 06ab6e5b1330..2a1d8c2b1d32 --date=short --no-merges --format='%ad %ae %s'
2019-07-12 cwallez@chromium.org Remove ShaderStage that doesn't exist in WebGPU.


Created with:
  gclient setdep -r src/third_party/dawn@2a1d8c2b1d32

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Change-Id: Id1e17c2ad8ef6966c17063f6850752834bbd20f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699296Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#677023}

https://chromium.googlesource.com/catapult.git/+log/7c146083d510..214323b343e9


git log 7c146083d510..214323b343e9 --date=short --no-merges --format='%ad %ae %s'
2019-07-12 vapier@chromium.org [Typ] fix artifact test encoding
2019-07-12 vapier@chromium.org [Typ] clean up obsolete codereview.settings


Created with:
  gclient setdep -r src/third_party/catapult@214323b343e9

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:983432,chromium:983432
TBR=zhanliang@google.com

Change-Id: Iee8a560f09253ebdb96272e75f1a851a328e9133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699408Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#677022}

In addition, this CL hides the tab switcher button on the top toolbar
when duet and clank to start are enabled.

Change-Id: Id7f24a5708e9f6136c71346e19e0cd9715d877f7
Bug: 979325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700282Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677021}

https://webrtc.googlesource.com/src.git/+log/01d04fac7548..24192c267a40


git log 01d04fac7548..24192c267a40 --date=short --no-merges --format='%ad %ae %s'
2019-07-12 ivoc@webrtc.org Revert "Add plumbing of RtpPacketInfos to each AudioFrame as input for SourceTracker."
2019-07-12 mbonadei@webrtc.org Revert "Remove the injectable bitrate allocation strategy API."
2019-07-12 philipel@webrtc.org Use nalus_length instead of is_first_packet_in_frame to insert startcodes in the H264SpsPpsTracker.
2019-07-12 mbonadei@webrtc.org Use -Wno-undef to compile jsoncpp.
2019-07-12 henrika@webrtc.org Minor modifications for ADM2 on Windows.
2019-07-12 ilnik@webrtc.org Partially revert of ColorSpace information copying around decoders
2019-07-12 mbonadei@webrtc.org Revert "Reland "Add ability to set RTCP sender ssrc at construction time""


Created with:
  gclient setdep -r src/third_party/webrtc@24192c267a40

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:982260,chromium:none,chromium:982486
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib59f3238d9051158b0b573e4680ae2bee012dbef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699407Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#677020}

This histogram is no longer useful.

Bug: 975798
Change-Id: I12ee0e9316e3a0739a10722d3273b4ed85b1aaf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693815Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677019}

This change adds an API to accessibility private called
getDisplayLanguage(str), which translates an abbreviated
language code into the human-readable string. For example,
when calling getDisplayLanguage('fr'), the API would
return 'francais'. This change is large and does the following:

1. Adds hooks for accessibilityPrivate API in the renderer to
support synchronous calls and returns.

2. Adds unit tests for new API.

3. Adds end-to-end tests for new API.

4. Hooks up the API to ChromeVox, where we prepend the
human-readable language string to output when the
language switches.

5. Adds tests in ChromeVox to assert new behavior.

Bug: 923068
Change-Id: Ie1b9fa446a1b5e2893899dd8ee283dbb462010c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659131
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677018}

https://pdfium.googlesource.com/pdfium.git/+log/2420af4d84b1..8a1cca44b936


git log 2420af4d84b1..8a1cca44b936 --date=short --no-merges --format='%ad %ae %s'
2019-07-12 tsepez@chromium.org Push some page object logic back into appropriate files.
2019-07-12 thestig@chromium.org Roll third_party/freetype/src/ 8cf046c38..b110acba9 (4 commits)
2019-07-12 thestig@chromium.org Add the ability for pdfium_test to use FPDF_LoadMemDocument().
2019-07-12 thestig@chromium.org Roll third_party/skia/ 520f85b55..34d63e6b4 (801 commits; 178 trivial rolls)
2019-07-12 thestig@chromium.org Update skcms.h includes to its new location.
2019-07-12 thestig@chromium.org Use more Google-style C++ variable names in RenderPdf().


Created with:
  gclient setdep -r src/third_party/pdfium@8a1cca44b936

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=pdfium-deps-rolls@chromium.org

Change-Id: Id9e68f5031c3326edb8bf98874c838efea661e3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699595Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#677017}

No change to logic, only docs.

This resolves a TODO to explain how to determine device API level.

Bug: 956316
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I00df52d2930b145d5569b4bc5b97064ded24647a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699259Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677016}

Bug: 975077
Change-Id: Ia8eda9dab4e6fde47470bc5417ad5cc947307556
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692156Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677015}

A nested Run() wouldn't auto-advance time as expected. This is an edge
case but it's surprising when it doesn't. Turns out we didn't need the
SetAutoAdvanceOnIdle(false) logic as RunUntilIdle()'s relies strictly
on RunUntilIdle() which already quits when idle per the request to
MaybeFastForwardToNextTask(/* quit_when_idle_requested */ true).

Also removed the new extra large comment on what happens in nested
FastForwardBy(). It detracted from the main purpose of the method and
99.9% of the time, there's no nesting.

R=fdoray@chromium.org

Bug: 946657
Change-Id: I8f2141c36023a577336bdb7301fd841068bb9313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698651
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677014}

Stylesheets defined in html import is not incorporated into master
document. So we need to handle them separately.

Bug: 981196
Change-Id: I6e1d94e59df6d0a57a17570405de119b5192106c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698983
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677013}

When generating a license we scan the third_party directories
for their README.chromium files. Before this change any directory
that was missing either a special exception or a README.chromium
file would lead to an unhandled LicenseError. Now we simply
message that a particular directory was missing the file
and exit cleanly.

GenerateLicenseFile only ever returned success, so I removed
the boolean return value in favor of just using exception
handling.

Bug: 983599
Change-Id: I8f9db3787cbfc527639f047e5388bcc63749b46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699729
Commit-Queue: Eli Ribble <eliribble@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677012}

MessageLoopCurrent::task_runner() is depecated.
This CL replaces it with with ThreadTaskRunnerHandle::Get().
A small step towards deleting MessageLoop.

This CL was generated with git cl split.
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1631693

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=pfeldman@chromium.org

Bug: 616447
Change-Id: Id2576315fc6e0315be1375351fdbd9aabc9e8325
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636062
Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677011}

Bug: 943593
Change-Id: Ie5197a5a491c30758179b1af279b9c0374f2b9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700115Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677010}

Updates the VR HTTP/HTTPS golden images to pick up a change in the
capitalization of "Site Settings".

The N updates are handled in crrev.com/c/1700047.

TBR=alcooper@chromium.org

Bug: 983569
Change-Id: I3cc4981d53c333cae4c947f04667bf3e9452fa9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700301Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677009}

If intermediate download file was deleted during resumption, we need
to generate the file path again. Currently Android always overwrite
the existing file on resumption, and non-dangerous intermediate file
is simply generated by appending ".crdownload" to the final target.
So this CL just implements the above logic in reduced mode.

BUG=983228

Change-Id: Ib856eadbd0fe1252e76ea5547c9edcbb423da45f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699365
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677008}

Instead of registering the pageAction and browserAction API functions
manually in ExtensionActionAPI's ctor, have them registered through the
typical generated code by telling the schema compiler where the
functions are implemented.

Bug: None
Change-Id: Ice1e0e4d2e9f2acb246b00e07d2a7d68c11b691a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691786
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677007}

This test is flaky on all platforms for non-obvious reasons. Disable on all platforms.

Bug: 983586
Change-Id: I942274fbe62c1b25533ecc1e68cdf83107a3bdde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700262Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677006}

As part of large refactoring in X11 code, crrev.com/c/1695008 introduces
ui::XWindow, a reusable X11 Window class extracted from
views::DesktopWindowTreeHostX11, it also modified DWTHX11 to leverage
ui::XWindow, making it more like DesktopWindowTreeHostPlatform, which uses
Ozone/PlatformWindow to abstract platform-specific window implementation.

This CL does an initial refactoring in X11WindowOzone, so that it starts
using ui::XWindow to back its PlatformWindow implementation, which
already fixes previous broken functionality, such as window activation.
Other improvements/fixes will be addressed in followup patches.

Bug: 981606, 789065
Change-Id: I9f7f686bbcaa51d391e77ce77b5dcfd15c91dc0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698263Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#677005}

Bug: 967484
Change-Id: Ic497e75c48c491f0ac0f58e373757beb684ddf1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691246Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677004}

That CL added a check that forces all code paths that query the list
of locale paks to have explicitly set the list of pak locales.

Test: chromium_linker_test_apk runs successfully.
Bug: 960025
Change-Id: I622b3b0679ea385bc8fa4b6848b2f7623f27cb59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699510
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677003}

I'm trying to eliminate causes of crbug.com/978183.

- References in ToolbarManager and TopToolbarCoordinator can be made
final, they are set in ctor and never changed.
- Reference in TopToolbarController cannot be null. I'm removing checks
for nullness.

R=twellington@chromium.org

Change-Id: I4bcf9072fc63c023a0c912cd536ad51203d8b46b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700289Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677002}

If native DownloadManagerService is  created, we should use
GetDownload() to retrieve the DownloadItem. As that method
works safely in reduced mode.

BUG=983073

Change-Id: I2a63217d85ed49b672980de45e7712447b2bc2b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699792Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677001}

See issue 970324 for details. The new keyboard shortcuts are:

Search+Shift+=  : New desk.
Search+Shift+-  : Remove desk.
Search+]        : Activate desk on the right (if any).
Search+[        : Activate desk on the left (if any).
Search+Shift+]  : Move active window (or highlighted window in
                  overview) to desk on the right (if any).
Search+Shift+[  : Move active window (or highlighted window in
                  overview) to desk on the left (if any).

for minor change in c/b/ui/ash:
TBR=sky@chromium.org
BUG=866622, 970324

Change-Id: I4ba22219e35f1a07b6714ae88710ed46b06e44dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696903Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#677000}