- 20 Aug, 2020 40 commits
-
-
Chris Harrelson authored
There are already hit tests and animations entirely in the impl thread for such scrollbars. Bug: 1116800 Change-Id: I2714258717c89e0ea41232eb86abe12570526d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364972 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800302}
-
Elaine Chien authored
Bug: 1057764 Change-Id: I0a585d6b98a0a6323a50220b16a90d004f2af24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363306 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#800301}
-
Olesia Marukhno authored
Fixed a11y for remove suggestion button and buttons in dedicated row (set role to be list box option and set correct accessible name). Fixed selection event not being triggered for dedicated row buttons (GetSecondaryButton wasn't returning buttons from dedicated row). Fixed value changed event triggering extra time when switching selection from button to button. Bug: 1104264 Change-Id: If5fc4692ac4e86f50e1a1d1b754feec795b76c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366758 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#800300}
-
Justin Donnelly authored
Follow up to https://crrev.com/c/2363852, which added Omnibox.SuggestionUsed.Pedal. Tested manually with chrome://histograms. Bug: 893183, 1117634 Change-Id: I9033ea200d820f74cb2d5fd0162383496128bd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367472Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#800299}
-
Sven Zheng authored
First adds the target with one test file in it. Now it can compile and run on device, and fails. I will get the target pass in the following work. Bug: 1117345 Change-Id: If3acc03e002a5ec23f1bcac5bff0ff7b1e3403a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360598 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#800298}
-
Joanmarie Diggs authored
AXSelection::Select has logic meant to handle selection within an native text field. But when the selection is being set, the base and extent may be the static text descendant of the AXObject associated with the field. In this instance, the logic for text fields is not being used. Fix this by retrieving the native text control ancestor AXObject. Then, to ensure there is no behavior change, set focus on the element after the selection range was successfully set. Bug: 1113650 AX-Relnotes: N/A Change-Id: I5b1db3dcf7d01baf971d5858c936a4e5d168543e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352898 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800297}
-
Thomas Guilbert authored
This CL changes the behavior of VideoEncoder to make an internal copy of frames passed in through encode(), before destroying the passed frame. This means that users don't need to call destroy() after passing frames to encode(), which could result in a frame being invalidated before we send it to the internal encoder. It also means we can destroy the frame internally when we no longer need it without risking that it might still be in use by the user. Users that which to keep their frames alive after giving them to the encoder can send a cloned copy instead. Bug: 1108023 Change-Id: Ie5cd98d688a53314ac16a6a3ac7afe2a65d742f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363863 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#800296}
-
Yao Xiao authored
When the feature is enabled: the 1st floc computation condition will not only be first-sync-enabled-seen, but would also require first-blocklist-loaded-seen, as both conditions are likely to occur after a while after browser start. When floc is computed from history, invalidate it if it's in the blocklist; invalidate any floc when the blocklist is not yet loaded / has error in loading. Bug: 1062736 Change-Id: I81dcfc27b0d2a7023ba1559d30131de41d5842ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365396Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#800295}
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/5e7ef27ca7b1..b08e25388629 $ git log 5e7ef27ca..b08e25388 --date=short --no-merges --format='%ad %ae %s' 2020-08-17 sarahmashay [validation] Validates if return statement type matches function return type 2020-08-17 sarahmashay [validation] Validates function name uniqueness 2020-08-13 sarahmashay [validation]: Add disabled test for validating return statement type matches function types 2020-08-13 sarahmashay [validation] Validates return statement 2020-08-13 rharrison Fix handling of .spvasm inputs Created with: roll-dep src/third_party/tint/src Change-Id: I3b34649e3994f4d894f298d96f9d7a0bcfafe471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359748 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#800294}
-
Xianzhu Wang authored
Use the new compositing reason instead of kWillChangeTransform to distinguish from will-change:transform specified in web pages which implies that the transform may change to any arbitrary value. Bug: 1114504 Change-Id: I8a1b4e5fa909dd50f3ae6465cb40d9336c9cd640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367446Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800293}
-
Erik Chen authored
The transition to Lacros is intended to be transparent to websites. As such, Lacros needs to set the ChromeOS user-agent. However, in some contexts (e.g. chrome://settings) Lacros must behave like the Linux browser. The problem is that webUI makes the assumption that user-agent uniquely identifies platform, and that there is only one browser per platform. Thus, setting the ChromeOS user-agent triggers ChromeOS settings behavior, which uses ChromeOS-only private extension APIs, which crashes the renderer. The appropriate long-term fix to this is to correctly plumb additional information into WebUI so that it can distinguish between Linux, ChromeOS and Lacros browsers. This is currently not possible without refactoring a substantial number of tests. This CL is a stopgap measure to allow chrome://settings to be usable in Lacros. Bug: 1096590, 1111985 Change-Id: Iabb8691e37ba6db4baba680e3d624248e8647321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367473Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800292}
-
Chris Cunningham authored
Change-Id: I82a28a93cdec01e587c2f281561af041010b9446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364075 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#800291}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I33fcd43f4524d498142c5a49e3a508b4c3797b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366671Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#800290}
-
Dan Sanders authored
Previously AudioDecoder would read the whole buffer, rather than the provided view of it. Bug: 1094084 Change-Id: Ibdf601e1d01114456093230c5daa137807566f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367641Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#800289}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c4db0322. With Chromium commits locally applied on WPT: 3b705a74 "WPT: Service Worker: Add unexpected state check to wait_for_state()" 9f52c7e4 "COOP: add reporting to redirects" f3b221b0 "[COOP] access reporting: Extend report.body.type values." f3c8d8d0 "Move WebRTC insertable streams web tests to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I4f6e723f1a210780235b822d7e4e6ce21b5ce1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367453Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800288}
-
Sammie Quon authored
We are getting some pushback from system services team. Disable for M86 :(. Test: manual Bug: 1111479 Change-Id: Ifce10b92081a7c162758273221fedfe8de76563b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367118 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800287}
-
Prashant Nevase authored
After crrev.com/c/2352251, the code added for storing cache result after doing initial classification, is not required. This patch removes it. Bug: 1094005 Change-Id: I010bfeba0d97e9360482a57ba83bae43e178c88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364383Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#800286}
-
Shakti Sahu authored
Bug: 1114883 Change-Id: I4b067fd6fa31feb0673186170f116134619f6e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347915 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800285}
-
Sadrul Habib Chowdhury authored
The dropped-frame counter needs to be reset after navigation to avoid showing (or reporting) dropped-frame count from the previous page. BUG=1115376 Change-Id: Id9fd54df5fcaf31b6d69e7e7d1190ac29581b6df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366613 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#800284}
-
Sky Malice authored
Bug: 1103476 Change-Id: Iabfeafad5641f6735dfc243e5000369bc416338e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366653Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#800283}
-
Dan Sanders authored
This is implemented in terms of an |is_closed_| state, which prevents reentrancy during shutdown. Bug: 1045247 Change-Id: I69e8bd095979f6571fbe95b298f91166b61dc9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363998 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#800282}
-
Garrett Beaty authored
Some CI builders are mirrors for CQ try builders despite not being a part of the main waterfall. These builders are handled by separate sheriffing rotations for trunk, but the branches only have a single rotation, so make sure that when config is generated for the branch, they appear on the main console. Change-Id: I6e7370606968d9a255eb08b5a7c4d2c0fef90220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367635Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800281}
-
Nick Burris authored
Add the body view to complete the secure payment confirmation UI. This patch adds the title text and the merchant, instrument, and total rows. Bug: 1110322 Change-Id: Ied9d2c36cf3581108f811d82aab73c207c37dbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365364 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#800280}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c58b2beba89..e592b36b32d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xialinyan@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1113326 Tbr: xialinyan@google.com,mohsen@google.com Change-Id: I3247007ef560f1dce015779b1f60c46751d0888b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367280Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800279}
-
Tommy Martino authored
Change-Id: Ie7416541017fcb2a8dcbfaa61477319b48c1e50f Bug: 1061949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364223 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#800278}
-
Thomas Guilbert authored
This CL front-loads the configuration parsing and codec support verification into the Configure() method. This means that and invalid or unsupported config should immediately throw an exception, rather than being reported in the error callback. This CL also allows encoders to be re-configured. Bug: 1116783, 1094166 Change-Id: I88df452cfa2a1b0fcfeb4da6c279665661d7380f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363711 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#800277}
-
Luca Hunkeler authored
Bug:b/165589862 Change-Id: I997f539bace25aecd3ca6c4e50ff307f27a06964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364612 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#800276}
-
Evan Stade authored
It's not used. Moving these files and deps to the enable_extensions branch of the build target matches what's done in //chrome/browser/media/router/BUILD.gn Bug: 1057100 Change-Id: I5c3cb21071776a3a22bedbef00ebe998e43e4253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364557Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#800275}
-
Becca Hughes authored
We should change the string conversion from UTF8 instead of ASCII. BUG=1119506 Change-Id: I202e36568125c6a52d99db60e4101130421833f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363843 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#800274}
-
Victor Hugo Vianna Silva authored
After this CL, when DecoupleSyncFromAndroidMasterSync is enabled, Chrome will no longer be in the list of auto-sync apps. In particular this toggle will disappear [1]. Users who previously disabled that toggle will remain with Chrome Sync disabled until they enable it again on Chrome settings. [1] https://screenshot.googleplex.com/9uR0qxTzVzK Context: the Android APIs setIsSyncable(..., int) and setSyncAutomatically(..., bool) control 2 *independent* settings per (account, app) pair, "syncable"[2] and "enabled"[3], persisted to an XML file. The first one controls whether the toggle in the screenshot will exist. A value >0 means yes, =0 means no and <0 means an unknown state (where the toggle isn't shown either)[4]. What the CL does is basically set "syncable" to 0 for any Chrome account. "enabled" can continue to be set safely and will still mirror the sync.requested pref [5], as happens today. [2] https://cs.android.com/android/platform/superproject/+/eed78aea1f49cba01c737220a6f834bca7feeef7:frameworks/base/services/core/java/com/android/server/content/SyncStorageEngine.java;l=283 [3] https://cs.android.com/android/platform/superproject/+/eed78aea1f49cba01c737220a6f834bca7feeef7:frameworks/base/services/core/java/com/android/server/content/SyncStorageEngine.java;l=282 [4] https://developer.android.com/reference/android/content/ContentResolver#setIsSyncable(android.accounts.Account,%20java.lang.String,%20int) [5] https://source.chromium.org/chromium/chromium/src/+/master:components/sync/base/sync_prefs.h;l=90 The CL also: a) Replaces code that checked specifically whether "syncable" valued 1, 0 or -1 with more generic checks for >0, =0 or <0. 1, 0 and -1 do have special meanings in SyncStorageEngine, but that's an implementation detail of a lower layer. The layer where the APIs live (ContentResolver) never ensures those values. b) Modifies the implementation of MockSyncContentResolverDelegate to be more consistent with the real Android behavior. E.g. one should be allowed to set "enabled" before "syncable". In next CLs the DecoupleSyncFromAndroidMasterSync feature toggle will be renamed to mention auto-sync rather than master sync. Bug: 1105795 Change-Id: I091981506ff64c33a6c259862eee07d28825527f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366895 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#800273}
-
Nicolas Ouellet-Payeur authored
This is a reland of fdb80c24 Original change's description: > [Traffic Annotations] Roll traffic_annotation_auditor > > Following the change that adds the grouping.xml check: > https://chromium-review.googlesource.com/c/chromium/src/+/2303313 > > Also updates grouping.xml to make sure the test passes on CQ. > > Bug: 1107860 > Change-Id: Icb4eea6540c6ddeb95dcd5efa9ea86ccec2afc13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362988 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799619} TBR=rhalavati@chromium.org Bug: 1107860 Change-Id: Iab0616ab9302ac6c00dd4607f5c3b97c9efcafcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364818 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#800272}
-
Rushan Suleymanov authored
While removing all user bookmarks the call site of UrlIndex::Remove is collecting all |removed_urls|. Each next call already contained all previously deleted urls. These |removed_urls| were used to check if there are other bookmarks with the same URL. This led to quadratic number of iterations over |removed_urls| as each next call iterated over all previously deleted URLs. This CL slightly changes behaviour of UrlIndex::Remove. It doesn't read |removed_urls| anymore, hence it's safe to pass non-empty value. Bug: 1096984 Change-Id: I4a9aadefe94e6becdc7c6c08ccc7b8d7b98f27f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362966Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#800271}
-
Jeroen Dhollander authored
Log with |AssistantDebugging| enabled: Assistant: OnTextResponse: [PII](What do cats eat for breakfast?) Log without that flag: Assistant: OnTextResponse: [Redacted PII] This flag also controls the LibAssistant back-end, as using the LibAssistant beta back-end might also log some PII. Bug: b/162894119 Change-Id: Ie888a9b4bf636f1cd0ad6f54df58012b782136c4 Tests: Ran with and without this flag. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366073 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#800270}
-
David Maunder authored
CriticalPersistedTabData is a redesign/replacement of TabState and has been integrated behind a flag. Being a redesign/replacement of TabState, this has increased the binary size. When TabState is deprecated it is expected the binary size will reduce by a similar amount. Binary-Size: Increase is temporary. Bug: 1114312 Change-Id: I01053eed2ca2179b86f436a2685660fd422399c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359371 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#800269}
-
Charlie Hu authored
This reverts commit 9c2422bd. Reason for revert: Fixed root cause that caused deterministic build failure. The reason was make_document_policy_features_util.py was not included in build input. The change of the script alone will not cause re-generation of output files, which caused incremental build to differ with fresh build. Original change's description: > Revert "Add bool constructor with type for PolicyValue" > > This reverts commit 30d9990c. > > Reason for revert: Suspected cause of build failure on ilder Deterministic Linux (dbg) Build 18293: > https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/18293?blamelist=1#blamelist-tab > > Checking libblink_common.so difference: (10672 deps) > obj/third_party/blink/common/common/document_policy_features.o > > Original change's description: > > Add bool constructor with type for PolicyValue > > > > Previously, boolean PolicyValue is missing a constructor with type > > specification on PolicyValue class. It caused some inconvenience > > on code generation and testing. With the introduction of enum > > PolicyValue, this becomes more obvious because enum type's constructor > > also comes with a type parameter. > > > > In order to simplify the codegen and testing logic, this CL adds a dummy > > constructor for boolean type PolicyValue. > > > > Note: the constructor with type parameter aims to distinguish policy > > values that have same C++ type representation but different policy value > > type, e.g. IncDouble and DecDouble, Enum and Int. > > > > Change-Id: I11ba793c73a770d7211e21c6a94d29f5557ac284 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347365 > > Commit-Queue: Charlie Hu <chenleihu@google.com> > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > > Reviewed-by: Ian Clelland <iclelland@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798714} > > TBR=iclelland@chromium.org,foolip@chromium.org,chenleihu@google.com > > Change-Id: I79f53710b14f22a7c81b4c757cbee03160c6addb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360796 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798853} TBR=iclelland@chromium.org,foolip@chromium.org,thomasanderson@chromium.org,chenleihu@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If27e29103d61220e82b1cab769d695a955222e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364053Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Charlie Hu <chenleihu@google.com> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#800268}
-
Moe Ahmadi authored
Bug: 1110077 Change-Id: Ie167aa8a1d9317b431769f009e01a5550c8e371c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364119Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800267}
-
Collin Baker authored
This gives equivalent functionality, but avoids the need to construct a complex object for each params object. Plus, it makes the params copy-constructible. Bug: 1106523 Change-Id: If35476314b33cdaf19703d58a084370c95a5f709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353574Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#800266}
-
Garrett Beaty authored
Bug: 1109276 Change-Id: I907d30149f06355e35a372127064ef01d2b2c87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366670 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#800265}
-
Anastasia Helfinstein authored
This is a reland of a5f47e82 Original change's description: > [Switch Access] Convert event handler into event rewriter > > Switch Access is not receiving some key events that it should be when > certain UI elements are focused. The events are instead passed directly > to those UI elements (e.g. Launcher text field, omnibar), effectively > trapping the user and leaving them unable to use the device. > > This change converts the SwitchAccessEventHandler into an event > rewriter, so that Switch Access will receive events before any other > source. > > AX-Relnotes: n/a. > Bug: 1106573 > Change-Id: Ib34de857acc8d6985e769fb83adb93b9ea41649e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317833 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798766} Bug: 1106573 Change-Id: I082484d1e414dc8c5508d28a0c2f07dfd2675dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363487 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#800264}
-
Asanka Herath authored
R=caraitto@chromium.org Bug: 1108942 Change-Id: I2bd72849d79a64d85cb9b61e87efe226d48a0cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366662 Auto-Submit: Asanka Herath <asanka@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#800263}
-