- 16 Apr, 2018 40 commits
-
-
Weiliang Chen authored
Surface Aggregator uses render surface to apply opacity. This CL uses an epsilon value to determine when opacity is close enough to 1.f to be considered opaque. R=enne Bug: 831779 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic5f11429e4679c0990a9e441358701b8e3b5c7d2 Reviewed-on: https://chromium-review.googlesource.com/1008129Reviewed-by:
enne <enne@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#551115}
-
Eric Karl authored
This change makes the ResizeDueToAutoResize messages for child frames transactional, with a begin/end. It also ensures that during a transaction we don't allocate new LocalSurfaceIds, instead waiting for the transaction to complete. Bug: 789259,805073 Change-Id: I585ac6d14b9978280847f49205d03bf49b9bb4f8 Reviewed-on: https://chromium-review.googlesource.com/960981 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551114}
-
Mike Wittman authored
When rbp was less than the offset, the check was underflowing and incorrectly passing. Add a check for rbp < offset to detect this situation. Bug: 831448 Change-Id: I4f780c1573782af3ca29b0f814e93ff2dca839f2 Reviewed-on: https://chromium-review.googlesource.com/1013213Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551113}
-
Joone Hur authored
When the build flag enable_native_notifications = false, link errors happen. This CL adds ENABLE_NATIVE_NOTIFICATIONS guard to fix this problem. Bug: None Change-Id: I5bc5a3770a7d15b2f2f9de32c92722ec4fad0946 Reviewed-on: https://chromium-review.googlesource.com/1014182Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#551112}
-
https://chromium.googlesource.com/angle/angle.git/+log/20fa8d5cfe9e..a4fa9c2782da $ git log 20fa8d5cf..a4fa9c278 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 lucferron Vulkan: drawElements with GL_LINE_LOOP and an offset Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I36c26e9275fe90c139ea6fafa36c611117dac2ef Reviewed-on: https://chromium-review.googlesource.com/1014199Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551111}
-
Jeremy Roman authored
This is now allowed across the Blink API, and also removes the need to write manual "delete this;" code. Change-Id: Iea4589d9ba5b826f6d7bd5d1dd08a1cf12228593 Reviewed-on: https://chromium-review.googlesource.com/1013063Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch refactors functions in ng_caret_rect.h/cc so that: 1. Functions stop passing around the containing NG inline formatting context. 2. Part of ComputeNGLocalCaretRect() is wrapped into a new overload of ComputeNGCaretPosition() taking PositionWithAffinity parameter. This is a preparation patch for implementing NG line-related functions in crrev.com/c/1008631 Bug: 822575 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I9ee8d90b327fec9684c0bdbf52bee6dad6fafb7f Reviewed-on: https://chromium-review.googlesource.com/1011217 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#551109}
-
Kai Ninomiya authored
WebGL (Blink) now delegates the validation of the stencil state to lower levels. This updates the command buffer to implement the new validation rules. ANGLE already implements the new validation rules, so the passthrough command buffer already passes. Patch started by kbr here: https://chromium-review.googlesource.com/c/chromium/src/+/890606 Test: conformance/misc/webgl-specific-stencil-settings.html Bug: 806557 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1d2bc0fd346c5d3fa1d736638e39d97297915a91 Reviewed-on: https://chromium-review.googlesource.com/992862 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#551108}
-
Victor Costan authored
The test was disabled due to crashing on the Linux CFI bot. The test was using the following class hierarchy: * SimpleDerivedElement (SDE) - base class for our purposes * SimpleDerivedElementConstructMagicNumberOne (SDE1) - derived from SDE * SimpleDerivedElementConstructMagicNumberTwo (SDE2) - derived from SDE The test was doing the following steps: 1) Create a ListContainer<SDE1> and a ListContainer<SDE2> 2) Create an SDE1 instance in the ListContainer<SDE1> 3) Move the SDE1 instance in the ListContainer<SDE2> 4) Access the SDE2 instance via ListContainer<SDE2>::back() The CFI bot (correctly) crashed because step 4 is undefined behavior. SDE2 is not on SDE1's ancestor chain. ListContainer's templated definition is "ListContainer<BaseElementType>", suggesting that the list's templated type should be a base class for all elements. This CL fixes the undefined behavior by switching both ListContainers to ListContainer<SDE>, and verifies that both an SDE1 and an SDE2 instance are moved correctly between containers. Bug: 832726 Change-Id: Ic94acde5bd1a981d6bb763170a70a24f4306f409 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1013617 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Hector Carmona authored
Bug: 812491 Change-Id: I54005b49e976eeffd98a1a3f5b258fc4f9efe8ce Reviewed-on: https://chromium-review.googlesource.com/1008623Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#551106}
-
Shenghua Zhang authored
chrome-release bot is facing with flatten_buildspec.gclient flatten exception which failed at running command 'cipd describe chromium/third_party/android_sdk/public/tools -version version:26.1.1-cr0'. It is suspected that double tags of the instance version causing the issue. This CL try to resolve the problem by updating the package of tools to a new version. Bug: 833123 Change-Id: Ibf23dfeb2dc5bb2008454d82bfaedb6b0603e97c Reviewed-on: https://chromium-review.googlesource.com/1013743Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#551105}
-
Sergey Berezin authored
R=estaab@chromium.org Bug: 790168 Change-Id: I235165c89ed2d0e63bfce9676e9e4d66caaf713f Reviewed-on: https://chromium-review.googlesource.com/1011599Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551104}
-
mark a. foltz authored
This continues the cleanup of the Presentation API typemaps by removing two more content:: types and replacing them with blink::mojo types defined in presentation.mojom. Some refactoring of code and tests was required as Mojo callbacks converted from base::Optional to blink::mojom::PresentationErrorPtr, which is move-only. Bug: 817903 Change-Id: I46136114a4afa4c14d989f2fbac341ccffe56740 Reviewed-on: https://chromium-review.googlesource.com/1012984Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#551103}
-
Jamie Madill authored
Unblocks the Vulkan roll. Bug: angleproject:2482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9577f331977e9add28bb7875e70260d428ad0cd5 Tbr: kbr@chromium.org No-try: True Reviewed-on: https://chromium-review.googlesource.com/1014322Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#551102}
-
Kai Ninomiya authored
TBR=zmo@chromium.org Bug: none Change-Id: Ib539beaf7662203c1a985a0ae707dc0761a45a03 Reviewed-on: https://chromium-review.googlesource.com/1013052Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#551101}
-
Saman Sami authored
The behaviour changed in crrev.com/c/995915 and some headless tests are failing as a result. Bug: 815187 Change-Id: Iff689a1a8ef0d0b464cf13701034bcca94ef0cf2 Reviewed-on: https://chromium-review.googlesource.com/1014015Reviewed-by:
-
Min Qin authored
To report download updates to extensions, chrome holds a json object in memory so it can compare what has been changed since last update. However, this json object is never released and it could cause memory issues. This CL removes the json object when download complete, and special handle the case that the file is deleted after download completion. Bug: 813055 Change-Id: I350ae6269f7ea27a47cf61dc3c38445190f35397 Reviewed-on: https://chromium-review.googlesource.com/982741Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a7328562..38262cca Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7788b95aa434670e3beb10b0161bc834c7127675 Reviewed-on: https://chromium-review.googlesource.com/1012866Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#551098}
-
Yuwei Huang authored
iOS doesn't allow app executing OpenGL commands after it goes to the background. Disabling the video stream on the host isn't good enough as the coming video frame will still arrive. This CL fixes the crash by destroying the OpenGL context when the app becomes inactive, and recreates the context when the app becomes active again. Note that even after we fix the crash, the session will still be disconnected, since the app will eventually enter the Suspended state and stop processing network events. See link about an iOS app's lifecycle: https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/TheAppLifeCycle/TheAppLifeCycle.html#//apple_ref/doc/uid/TP40007072-CH2-SW3 Bug: 829449 Change-Id: I507b8e2a856b3e019db99faff188bd5f312c5a51 Reviewed-on: https://chromium-review.googlesource.com/1013244 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#551097}
-
Justin Novosad authored
This reverts commit b096dcaa. Reason for reland: This was not the right CL to revert (it was not even in the failure regression range). The source of the regression is https://chromium-review.googlesource.com/c/chromium/src/+/1014140, which was just reverted so that this can reland. The CL adds the test that was regressed by the other CL. Because these two CLs were in CQ at the same time, the problem only got caught on the main waterfall. Original change's description: > Revert "Fix alpha-unpremultiply overflow in WebGL+toDataURL" > > This reverts commit dcffdac6. > > Reason for revert: > Breaks fast/webgl/canvas-toDataURL-premul-overflow.html on > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/43191 > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17758 > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20(dbg)/11632 > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/45887 > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/31889 > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20(retina)/328 > > Original change's description: > > Fix alpha-unpremultiply overflow in WebGL+toDataURL > > > > This change fixes a regression that was introduced in > > https://chromium-review.googlesource.com/c/chromium/src/+/780279 > > Fixing the issue by switching sensitive use cases back to using > > SkImage::readPixels for safely performing the unpremul conversion > > > > BUG=826878 > > > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: Ie4bc9ced4d7175ab308529f7dd7119f93378e34c > > Reviewed-on: https://chromium-review.googlesource.com/1003320 > > Commit-Queue: Justin Novosad <junov@chromium.org> > > Reviewed-by: Fernando Serboncini <fserb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#550979} > > TBR=junov@chromium.org,fserb@chromium.org,xlai@chromium.org > > Change-Id: Ib53e4ac4573894ff93424b50af6314a51fee217a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 826878 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/1014321 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551050} TBR=avi@chromium.org,junov@chromium.org,fserb@chromium.org,xlai@chromium.org Change-Id: I01758853007f982b81f99494be2be717c7ff6096 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 826878 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1014423Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551096}
-
Eric Karl authored
After discussion with mariakhomenko@, we decided to leave this feature enabled despite some expected regressions. This change will allow us to disable this feature via Finch if any unexpected results appear as this rolls to stable. Bug: 825589 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I46506aa8807e1c10f0833e414253d1df11cf1382 Reviewed-on: https://chromium-review.googlesource.com/1014285Reviewed-by:
-
Anita Woodruff authored
- Previously when displaying and getting notifications the promise resolver was always converted to callbacks, for the legacy IPC code which needed to store these callbacks in a map. - Mojo renders a callback map unnecessary, so this patch refactors the code to avoid the conversion when the Mojo pathway is taken. Bug: 796991 Change-Id: I216730c06fdb42a3c2c9fe21708252cb652e8b6b Reviewed-on: https://chromium-review.googlesource.com/1011422 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551094}
-
Justin Novosad authored
This reverts commit 613f5543. Reason for revert: Breaks fast/webgl/canvas-toDataURL-premul-overflow.html on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/43191 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17758 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20(dbg)/11632 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/45887 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/31889 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20(retina)/328 Original change's description: > Reland "Use new Skia GPU read/write pixel code paths" > > This reverts commit 56044665. > > Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData. > > Original change's description: > > Revert "Use new Skia GPU read/write pixel code paths" > > > > This reverts commit f17c70fe. > > > > Reason for revert: > > > > It looks like this change: > > > > slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne (crbug.com/825594) > > > > slowed down getImageData and putImageData for the HTML5 Canvas across the board (crbug.com/825585) > > > > Bug: 825594 > > Bug: 825585 > > > > Original change's description: > > > Use new Skia GPU read/write pixel code paths > > > > > > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992 > > > Reviewed-on: https://chromium-review.googlesource.com/973267 > > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#544777} > > > > TBR=bsalomon@chromium.org,robertphillips@google.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565 > > Reviewed-on: https://chromium-review.googlesource.com/980292 > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Commit-Queue: Robert Phillips <robertphillips@google.com> > > Cr-Commit-Position: refs/heads/master@{#545787} > > TBR=bsalomon@chromium.org,robertphillips@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 825594, 825585 > Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093 > Reviewed-on: https://chromium-review.googlesource.com/1014140 > Reviewed-by: Brian Salomon <bsalomon@chromium.org> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551022} TBR=bsalomon@chromium.org,robertphillips@google.com Change-Id: I0dd6db48f1c55d869de88e2fbca963c2c0cde0ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825594, 825585 Reviewed-on: https://chromium-review.googlesource.com/1012796Reviewed-by:
-
Sidney San Martín authored
This crashes consistently on 10.12 when draggingFrame isn't set. Bug: 826632 Change-Id: I9b1aec6804c0f5205cd2a471787cc296d943ff91 Reviewed-on: https://chromium-review.googlesource.com/1014361Reviewed-by:
-
James Cook authored
This is part of moving ash out-of-process for mustash. * Introduce FirstRunHelper mojo interface * Make ash::FirstRunHelper object owned by ash::Shell * Add explicit create/close widget methods because object is now persistent * Add system tray test API to check if bubble is open Next step is to move the widget creation into chrome. Bug: 756057 Test: ash_unittests, browser_tests Change-Id: Ie3994bd36b6dfeecd1c685773c5ce8e19394052e Reviewed-on: https://chromium-review.googlesource.com/998181 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551091}
-
Peng Huang authored
Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia388f02926202777ac9c7461715947ed97e2082b Reviewed-on: https://chromium-review.googlesource.com/1011675Reviewed-by:
-
rbpotter authored
Chrome OS local destinations need to be set up before they can be selected. Add the logic to request setup from the handler and select the destination only when configuration is complete. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iccfacad27bac15182abbfeb47f4ec9f274b46fa6 Reviewed-on: https://chromium-review.googlesource.com/1012191 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551089}
-
Steven Bennetts authored
Bug: None Change-Id: I93b4d00f99cf355c41365de52e5288219d47258a Reviewed-on: https://chromium-review.googlesource.com/1014292Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#551088}
-
Antoine Labour authored
They are only created in ResourceProviderTest, not used in production. Also remove ScopedWriteLockGpuMemoryBuffer and helper functions in LayerTreeResourceProvider. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8ddd10fe5c0f86f994dbfeb966200154304d8432 Reviewed-on: https://chromium-review.googlesource.com/1011558 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#551087}
-
khmel@google.com authored
This prevents crash when user tries to download pdf document from Play Store ToS. Test: Manually Bug: b:64117707 Change-Id: I965a760b0bdef2c1167a8007822ed7c9a2b353c6 Reviewed-on: https://chromium-review.googlesource.com/1009111 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#551086}
-
Jiaquan He authored
This commit is a preflight CL for app list search migration. It passes into every search result a pointer to the model updater, so that changes to search results can be synced to Ash. Bug: 733662 Change-Id: I6ff93636248e48ed0d012da512e440b8511a9d22 Reviewed-on: https://chromium-review.googlesource.com/999295 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Charlie Harrison authored
This CL changes the test to: - Use the default timer to push load state updates, which should deflake the test. This is accomplished using a WebContentsDelegate. - Tests the actual LoadState, not just the host. The test was currently flaking due to the update + ACK refactor which wasn't compatible with the test. Bug: 830991 Change-Id: I4d788e7a7388617af39f0981bd84fc7d1da6a87c Reviewed-on: https://chromium-review.googlesource.com/1009287Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Greg Thompson authored
This CL provides an OsStackTraceGetterInterface implementation for Google Test that uses Chromium's base::debug. This allows Google Test to emit stack traces to make debugging test failures a bit easier. As a result, failures that once looked like the following will now include stack traces: [ RUN ] UpgradeDetectorImplTest.TestPeriodChanges unknown file: error: Uninteresting mock function call - returning directly. Function call: OnUpgradeRecommended() [ FAILED ] UpgradeDetectorImplTest.TestPeriodChanges (3 ms) BUG=none R=dpranke@chromium.org Change-Id: I992d807cc654104d0bad461fda8cb82c86e6e9f8 Reviewed-on: https://chromium-review.googlesource.com/1009947 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551083}
-
Manuel Rego Casasnovas authored
This reverts commit 092113c3. Reason for revert: It's causing big performance regressions on CSS Grid Layout perftests. BUG=832078 Original change's description: > [css-grid] Initialize OverrideContainingBlock size for grid items > > This patch removes the grid logic from > LayoutBox::ContainingBlockLogicalWidth|HeightForContent(). > Instead it initializes the OverrideContainingBlock size to zero > in LayoutGrid::UpdateBlockLayout(). > > For grid items we don't want to use the grid container size > (which would be the regular containing block size), > so we want to use the overridden value. > And while we don't have such value, it's better we use zero > (so percentages are not resolved against the wrong thing). > > This change is covered by existent tests. > > Change-Id: If6a96abe7148203a2cdb9ffb2b9dd487239f7aae > Reviewed-on: https://chromium-review.googlesource.com/989734 > Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Sergio Villar <svillar@igalia.com> > Cr-Commit-Position: refs/heads/master@{#549461} TBR=jfernandez@igalia.com,rego@igalia.com,svillar@igalia.com,ikilpatrick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I17fb8ebc78e88c0c91c5802862402ea3689385d9 Reviewed-on: https://chromium-review.googlesource.com/1014120Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#551082}
-
Ria Jiang authored
Bug: 833234 Change-Id: I814fc6c736f2fb89cbe32a336fd32a97ac4f4f28 Reviewed-on: https://chromium-review.googlesource.com/1014353Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551081}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4de5d3e6. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15652 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I5b07544cec805ab34c86f3f690c7581b0fa52189 Reviewed-on: https://chromium-review.googlesource.com/1012867 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551080}
-
Toni Barzic authored
Removes the following events: systemPrivate.onVolumeChanged systemPrivate.onBrightnessChanged systemPrivate.onScreenUnlocked systemPrivate.onWokeUp None of them seem to be used. Additionally, code that dispatches all listed events except systemPrivate.onVolumeChanged has been unreachable for some time. Bug:658006 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I104873a45b3274a7105215dd906881065a962527 Reviewed-on: https://chromium-review.googlesource.com/967421Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#551079}
-
Khushal authored
When using an unaccelerated canvas with a compositor using Gpu raster, each canvas update is rasterized to a bitmap pushed into a paint recording. This bitmap is uploaded and cached by cc's GpuImageDecodeCache. Since the canvas is frequently updated, it is common for the Gpu cache to use and keep the discardable texture memory to capacity. Avoid the above situation by actively deleting canvas snapshots in the Gpu cache. PaintImages from a canvas instance use a stable PaintImage::Id and update the PaintImage::ContentId when an updated snapshot is created. This patch ensures that the Gpu cache keeps the max 2 ContentId entries for the same PaintImage::Id (pending and active tree), effectively ensuring we only have the last 2 canvas snapshots. Note that BitmapImage, for encoded images in blink, also uses an updated ContentId as more data is fetched for an image. This change will also ensure that we evict previous partially decoded frames for the same image. For play:media:soundcloud test case on my linux machine, this reduced cc's cache size from 236M to 30M. R=enne@chromium.org, ericrk@chromium.org Bug: 814219 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I888155ae5504ece6ab73981f320515478d87917d Reviewed-on: https://chromium-review.googlesource.com/987194 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#551078}
-
Erik Chen authored
Change-Id: I3fad62b20d8cde691625d56d24639551bc00483b Reviewed-on: https://chromium-review.googlesource.com/1014362Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551077}
-
Parastoo Geranmayeh authored
Problem: On the last run to determine heuristics we do not consider the overall server type detections, and we only rely on field types detected by heuristics. Since the ultimate filling decisions are based on the overall detection, we need to use overall type detection. As in section identification this can sometimes cause an incorrect output. Exp: In the cabelas.com payment section, the heuristics detect card holder name as the address name, whereas the overall type is detected correctly. The sections are thus wrong. Solution: Update the form from the cache, before determining the heuristics for the last time. Test added. Bug: 831739 Change-Id: Ifdecfa442a21d38b53169c8dafc981ca5447629b Reviewed-on: https://chromium-review.googlesource.com/1012980Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551076}
-
