- 09 Oct, 2020 40 commits
-
-
Collin Baker authored
Adds two metrics logged every 5 minutes: * Per-thumbnail compressed data memory usage * Total compressed data memory usage The former has a sample for each thumbnail every 5 minutes, while the latter has exactly one every 5 minutes. Bug: 11261624 Change-Id: I1595c6a6b771f73e3be9a5497d1cf6f6ec3d1af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462685Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#815714}
-
Monica Basta authored
For the profiles that use generic colored avatar, 'OnProfileAvatarChanged' needs to fired for the avatar icon to be updated across different UIs on theme color changes. This CL doesn't handle the switch between light/dark mode that also has an effect on the avatar icon. Bug: 1136851 Change-Id: I11acfffea825bcc87f41640986bb1e3f1858bc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461320 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#815713}
-
Lijin Shen authored
TBR=twellington@chromium.org Bug: 1136923 Change-Id: Ideaca2e918c8e70ea42cebd9011b858be344439e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462949Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#815712}
-
James Cook authored
browser_tests disable all crosapi calls and do not call LacrosChromeService::Init(). LacrosChromeServiceImpl::init_params_ is therefore "null". However, because LacrosInitParams is a small mojo struct, it is an InlinedStructPtr, and init_params_.get() returns a non-null pointer. This means existing code in lacros can call LacrosChromeServiceImpl::init_params() and get a non-null value. A later CL increases the size of LacrosInitParams, so it cannot be inlined. This causes browser_tests failures because init_params() starts returning null. We want some value for InitParams in tests. Therefore create a default-constructed version in tests. Bug: none Change-Id: I3ee0b15a276d0f04fc024ba3fbd7d2d1a892a72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463568 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815711}
-
Gouarb Kundu authored
This change removes the pp::Var dependency from core PDF code by replacing pp::Var with base::Value and converting it to pp:Var at the caller end. This consists of modifying the PDFEngine::GetBookmarks() and the related methods to use base::Value instead of pp::Var. Bug: 1113523 Change-Id: Ia5fbf216b840bee138202e891200e51c10fc6594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428353 Commit-Queue: Gourab Kundu <gourabk@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815710} -
Kartik Hegde authored
Match the mojom definition. TEST=none Bug: chromium:956783 Change-Id: Ie662c3af2776556cdf96aa05928b9e7cf7dc2e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462298Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#815709}
-
Martin Kreichgauer authored
It wrongly asserted that the key size equals the shared secret size, when Authenticate() may also be called with a pinUvAuthToken, which can be any multiple of 16 bytes in legth. Also tighten up parsing of authenticator responses to ensure pinUvAuthTokens are of a valid length for the chosen protocol version. Bug: 1129946 Change-Id: I6d96307159d4e543e1a4f2bf7efa5e2ddefe7382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463236Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#815708}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0ad07c924552..815983783a76 2020-10-09 treehugger-gerrit@google.com Merge "Fix missing __libc_posix_memalign symbol." 2020-10-09 treehugger-gerrit@google.com Merge "Build heapprofd_preload when building heapprofd." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If911b8552fe7ecde3d9585c19d830b0081380e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815707}
-
Hoch Hochkeppel authored
Finishing the implementation for navigator.share() on Windows. Updating the existing tests for basic exercising of this functionality and adding new tests for the Windows-specific functionality checks. Bug: 1035527 Change-Id: Ibc2c50e85109fd1739124c40966b353c5db2c00f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443757 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815706}
-
Ryan Heise authored
Bug: chromium:1135819 Change-Id: Idff85d150838110e32b103b3bf3bb3368693d6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461699 Commit-Queue: Ryan Heise <heiserya@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Ryan Heise <heiserya@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815705}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Id29c886835fd9cfd229e768c4dbd410b1eeedf65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458851Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815704}
-
Guillaume Jenkins authored
The previous way of checking whether the searchPhrase property existed on the SearchInChrome intent object was respondsToSelector:, which didn't work. This fix uses valueForKey: instead, which appears to be a safe way to check whether searchPhrase exists on the intent object. Bug: 1133825 Change-Id: I82242e2398359f1955fd93b06ecdc4648fcaf5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459566 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815703}
-
Mason Freed authored
The Web Components v0 removal is now here, with M88. The origin trial was causing the console error message to be somewhat misleading, since the OT enables the runtime features, and causes different error messages (e.g. at [1]) to be generated, even though the features are actually not supported. This CL should cause the correct messages to be shown. This CL also has a small cleanup of other obsolete use counters. Per offline conversation, I'm TBR'ing asvitkine for the one UKM file components/page_load_metrics/browser/observers/use_counter/ukm_features.cc TBR=asvitkine@chromium.org [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/html_link_element.cc;l=78?q=%22HTML%20Imports%20is%20deprecated%22%20-f:txt$&ss=chromium Bug: 937746 Change-Id: Iae53402e3ade09795af44ac5e582b785ce9ad6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458126 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#815702}
-
Yuwei Huang authored
This CL attempts to make the official build bot upload remoting debug symbols, so that we can use them to decipher stack traces coming from an official build remoting Linux host. Bug: 1136663 Change-Id: I5669140b3b63399d521644de3b8524def6092560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462547Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#815701}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8ce5f5261ab7..84bd221ed748 2020-10-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-09 morg@google.com Add grunt-arc-r board to PFQ (experimental) 2020-10-08 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ibc3f777315de0f38adab46737f90dee6eb12ebc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462505Reviewed-by:
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Ic61630a22fda8a25377fbe2c9dd9818c1c5ec72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458849Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815699}
-
Alison Maher authored
Currently, we wait to layout fragmented OOF elements until they've reached the fragmentation context root. In the case of nested fragmentation, we need to wait until that fragmentation context root has finished layout to ensure that the containing block has also finished layout. This change delays layout of fragmented OOF elements until we've reached a fragmentation context root that is not itself fragmented. This results in OOF elements being added as children to the outermost fragmentainer that it is found in rather than the innermost. We will need to bubble up some extra information about the innermost fragmentainer in order to properly position the OOF elements. This will be done in a follow-up CL. Bug: 1079031 Change-Id: Ia2d5ed3af2a99f5c091d1cd9c399cc34bc580038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462048 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815698}
-
Aaron Krajeski authored
Has become a straightforward revert of this commit. https://chromium-review.googlesource.com/c/chromium/src/+/2216591 For as yet unknown reasons, not using CopySubTexture can cause rapid flickering between pixellated and non-pixellated rendering. Considering this is negatively effecting many users right now, it may be worth pushing this change through as a quick fix. Bug: 1134799 Change-Id: Ia25b312f3755063b1fdeaa39be5057b7654b7548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450842Reviewed-by:
Jonah Chin <jochin@microsoft.com> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#815697}
-
Wez authored
Enable test packages to be made wholly or partially hermetic through use of "fuchsia.test" facets in their package manifests. - Remove the unused //build/fuchsia/exe_runner.py script. - Rename run_package.py to run_test_package.py, and similarly for the methods and types it publishes. - Update the RunTestPackage() API to support launching the component using the 'run_test_component' command, rather than 'run', if requested. Bug: 1038786, 1132032 Change-Id: I42aaf996324542a2d6c6d6d93ea8bd1d0a878730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997698 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#815696}
-
Scott Violet authored
BUG=none TEST=test only change Change-Id: I704dc578dabef22c991ffa1873f7951f3e7dd08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462389 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815695}
-
Yuki Shiino authored
Relaxes a restriction of use_allocator != "partition" a little so that we can specify use_allocator = "partition" for testing purposes. Note that use_allocator never be "partition" unless we explicitly specify it, so there is no change on all bots (until we will actually ship it). Bug: 1121427 Change-Id: Ib06997385f864f1ba097edb46eeed3a215105911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463088Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#815694}
-
Keren Zhu authored
Bug: 1130078 Change-Id: Ic5253a9024038fe204076c2c5ab744b1e5275f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462099 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#815693}
-
Becca Hughes authored
This flag is turned on because originally Kaleidoscope + NTP modules were launching at the same time. Now NTP modules is launching earlier which means we need to turn this flag off. BUG=1136904 Change-Id: Ie20a8650f9621dfa85803a397d55a0873f54496d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463330 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815692}
-
Alex Gough authored
Bug: 1130762 Change-Id: I0c003e2f5d17dbea3653f47508a4e47eff7cf61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458906Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#815691}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I808b5a1ee49e56e51e21961d3e7d1a4b937a1c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458867Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815690}
-
Yulun Wu authored
This addresses changes from: https://chromium-review.googlesource.com/c/chromium/src/+/2417653 Note that SearchIcon and Assistant buttons are different colors in classic UI. Bug: 1134800 Change-Id: I409bc4bde13331766dc8aa8c54dfeda082c653d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462044Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5291cbadc02e..b2ff69f856d9 2020-10-09 jmadill@chromium.org Suppress Mac/GL test failures with standalone runner. 2020-10-09 gbiv@chromium.org fix an instance of bugprone-unused-return-value If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1134714 Tbr: timvp@google.com Change-Id: I7cbefc64c5d6e377a6255df0a1a3a3177e93e5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463259Reviewed-by:
-
Yulun Wu authored
This addresses a change in this CL https://chromium-review.googlesource.com/c/chromium/src/+/2382222 Bug: 1134854 Change-Id: I3970a260b534dabed6dd8bbba849812f5edfaddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462053Reviewed-by:
-
Yulun Wu authored
This CL addresses changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2417241 Bug: 1134800 Change-Id: I9ce7301dcdfe9940a10f3920e2901a051ff0f0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462556Reviewed-by:
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I9802951e5f8d4d77d0c0ae2a3f69134f93b548df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459427Reviewed-by:
-
Mohamed Adel authored
Moving it to where the bridges are stored as NotificationImageRetainer will be used in the NPB Mac UNNotification, making it not unique to windows builds only. Bug: 1136930 Change-Id: I496f9295d18665a27d39f8d0aced293a1f076a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460903 Auto-Submit: Mohamed Adel <adelm@google.com> Commit-Queue: Mohamed Adel <adelm@google.com> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#815684}
-
Roberto Moura authored
Bug: 1127604 Change-Id: I48460b30fc37119e31f595359e31803d13475f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461736Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#815683}
-
minch authored
Check the spec in the crbug. Bug: 1128755 Change-Id: I91cf16ee49317deea14556d04ff9c933f3a6556c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462354Reviewed-by:
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. In this case, everything (including the definition for this function) spelled this `has_complete_suggestion`, so go with that. Bug: 1136209 Change-Id: I41b6f21a9b675e9e5817e2b563293c91c95a462a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459110 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815681}
-
Clark DuVall authored
This reverts commit 022292aa. Reason for revert: Breaking clank builds: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/230952 Original change's description: > Split out minimal target for PaymentDetailsUpdateService > > We are investigated using isolated splits for Chrome, and splitting > //chrome code into a DFM. Due to b/169196314, all service classes must > be present in the base module. See go/isolated-splits-clank for more > details. > > This change creates a new minimal target for PaymentDetailsUpdateService > which the base module will depend on. > > Bug: 1126301 > Change-Id: Ib4396073bbc4254c0400bccec1f4acac3ba88ad8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459508 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815649} TBR=agrieve@chromium.org,danyao@chromium.org,maxlg@chromium.org,cduvall@chromium.org Change-Id: I8eea37376fcbd13b78774cf4c4fb2480c309d150 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463803Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815680}
-
Ramin Halavati authored
Updates a few chrome/browser/ui/views/* classes for compatibility with ephemeral Guest profiles. This change is behind disabled |EnableEphemeralGuestProfilesOnDesktop| flag. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ie4f8e4aaf1f981ba6575fe8cc38b62a009289626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461375 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
Animated cursor assets were not being loaded because GetCursorDataFor was used for all cursors, instead of using GetAnimatedCursorDataFor when the cursor was animated. With this CL, both set of cursors are merged so they can be retrieved with a single call. To ease these changes, ImageCursor, which was a very thin layer over CursorLoader, was merged into the latter. This change has the benefit of unifying the cursor loading code path of Ash with the one of the other Aura platforms and changing Ash on Linux to use the Chromium assets instead of the platform cursors, as when running on Chrome OS devices. The only behavior change with respect to ImageCursors is that the cached cursors will be removed on display changes, instead of reloaded. Bug: 1135515 Change-Id: Iedf84290bf3792c3ce06cfad0be1b5c0e2d96946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440760 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815678}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I3af15a8ff257a242396a8cc58ba8c0b1df74c934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459387Reviewed-by:
-
Alice Wang authored
This CL dismisses the account picker bottom sheet when the bottom sheet controller is null. Bug: 1136799 Change-Id: I9814c10f6becb07c3e95ab93f0d81b69af936853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463307 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#815676}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09f602317f2b..b3c2e9be46bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC flackr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1114729 Tbr: flackr@google.com Change-Id: Ic51bdf7fffe793afd40e6d26f30755c04c95dd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463258Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815675}
-
