GitLab

MouseWheelEventQueueTest uses a non-existent #define for ChromeOS,
defined(CHROME_OS), we should replace it with defined(OS_CHROMEOS).

Bug: 1121653
Change-Id: Ia6ee5adf638aad3d25d03f36d0903c509d793ecd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433304Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811346}

In 6f15f17c the audio focus
was inadvertently being adjusted the Activity, Fragment, and
Service, but we just want the Activity.

Bug: internal b/169078948
Test: verify audio works for Cast and Bluetooth content

Change-Id: Ia0e8991f82d2b44618307b67b9541f953d53f659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431409Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Mike Dodd <mdodd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811345}

Error:
  File "build/lacros/test_runner.py", line 129, in _remove_unused_ash_chrome_versions
    age = time.time() - os.path.getatime(os.path.join(p, 'chrome'))
  File "/usr/local/google/home/svenzheng/.vpython-root/000cad/lib/python2.7/genericpath.py", line 67, in getatime
    return os.stat(filename).st_atime
OSError: [Errno 2] No such file or directory: 'build/lacros/prebuilt_ash_chrome/for_bots/chrome'

Bug: 1131739
Change-Id: I78dbaa624956a4e9019598eae3c07270907792bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429590Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811344}

The AudioDecoder tests are no longer broken on Android, and can be
re-enabled.

See:

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8868055132639161312/+/steps/cast_unittests_on_Android_device_Nexus_5__with_patch_/0/stdout

Bug: 831999
Change-Id: I1d7cbd3adbd1734adc04bd5f0fb6c713815986e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433664Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811343}

This is phase 4 on the design document [1].

[1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/

BUG=787252
R=guidou@chromium.org, haraken@chromium.org

Change-Id: If7d88ea6be23d46dd78a9c9bbdc564762ae86a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435922Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#811342}

Add this metric to help us understand usage and plan
improvements.

Add ClipboardHistory.ContextMenu.NumberOfItemsShown.
This metric will help UX see if we should increase the
size of multipaste, or whether 5 is enough. It will also
function as a heartbeat metric for the feature.

Add UserJourneyTime to understand usage.

Bug: 1099338
Change-Id: If3253db5da7ba22554a806d8903929de3e81f17a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425005
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811341}

static_cast is better suited for downcasting since it can check that the
types are related.

/content/browser/web_contents/web_contents_view_mac.mm
This CL was uploaded by git cl split.

R=ellyjones@chromium.org

Change-Id: I23958320fc719b9b5f8179110aa789441313f251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435312
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811340}

This is a small workaround. Root cause is crbug.com/1132767, which is
not as easily solved.

Bug: 1129763
Change-Id: Ifa7daa12a0d36c99b4eacdc35c9dd2bb70b4e1c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434891
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811339}

The old code is undesirable, because:

1. It was not following go/totw/28 advice about using the following
   pattern:

      VideoDecodeAccelerator::Client* client = nullptr;
      using std::swap;
      swap(client, client_);

2. Is not really needed, because the swap is with a known constant.

3. Might not compile if in the future, hypothetically the type of
   |client_| becomes |base::CheckedPtr<VideoDecodeAccelerator::Client>|.
   (this last issue may be fixable either by: A) using the new pattern
   or B) implementing |swap(T*&, CheckedPtr<T>&)| function in the base
   namespace).

Bug: 1080832
Change-Id: I937a60cae6d9d164b088227cca209f4bcc0473a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435171
Auto-Submit: Bartek Nowierski <bartekn@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811338}

By default, the host tools have the same architecture as the target cpu. Provide a variable to indicate when that's not the case.
Add GN SDK scripts to data.

Bug: 1080854
Change-Id: Ia2d55d7f95ddc2574cdd4ba0446ba2e4448a9da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433417Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#811337}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/ui/views/webauthn
This CL was uploaded by git cl split.

R=nsatragno@chromium.org

Change-Id: I0d2cf195336da3a9bcb34465d2e5e8e144807ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435881
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811336}

Mozilla fixed two tests that had bad expectations.

Change-Id: I3ca6a508d55a5b6f886f01145d779f88e82555aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433092
Auto-Submit: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811335}

Remove the feature flag enable-streamlined-usb-printer-setup as the
feature has been successfully released.

Original tracking bug: crbug/951135

Bug: 1128737
Change-Id: I71faa115bc743aa9ff5e361cc6c6035809a98e6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412832Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811334}

Roll Chrome Win64 PGO profile from chrome-win64-master-1601098956-2811654f54d3946c8e0477e7d77d36d5dbdfab8f.profdata to chrome-win64-master-1601304808-a0959ded2b2639d64197cdec426ae296818dc3ae.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Id7913a61214b06a6cb5002b5f154ebf23bd4bc7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435908Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811333}

The Convert*ToDIP() and Convert*ToPixel() functions are problematic in
that they hide what decision is being taken in the underlying code
when moving from floating point to integer, and consumers should be
thinking about what they want for correctness. They also act in
inconsistent ways when converting a Rect vs its components. This
removes the functions that perform float->int conversions in order to
have callers show what they intend to happen and make it clear that
data is being lost in some fashion.

R=ccameron@chromium.org, sky@chromium.org

Bug: 1130050
Change-Id: Icb49a8a392c50cfe85a646afe30528d9d7207057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426366
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811332}

ChromeVersionInfo is now responsible only for showing the
Chrome version, while PlayServicesVersionInfo for Play Services.

Bug: 1131982
Change-Id: Ie6bc77f10a47c0d5379c3eb244f9b025f52e0d75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428628
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811331}

static_cast is better suited for downcasting since it can check that the
types are related.

/content/browser/appcache
This CL was uploaded by git cl split.

R=mek@chromium.org

Change-Id: Ic95365fb8db7002cb97aa7b2a3a22ac6173e37d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435700
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811330}

Now it looks like this:

7 outbound dependencies from .c.b.tabmodel.TabWindowManager may need to be broken (omitted 11 cleared dependencies):
    [chrome_java]
        -> .c.b.app.tabmodel.ChromeTabModelFilterFactory
        -> .c.b.multiwindow.MultiInstanceManager
        -> .c.b.multiwindow.MultiWindowUtils
        -> .c.b.tabmodel.AsyncTabParamsManager
        -> .c.b.tabmodel.TabModelSelectorImpl
        -> .c.b.tabmodel.TabPersistencePolicy
        -> .c.b.tabmodel.TabbedModeTabPersistencePolicy

Used to be:

Printing class dependencies for .c.b.tabmodel.TabWindowManager:
18 outbound dependency(ies) from .c.b.tabmodel.TabWindowManager:
    [chrome_java]
        -> .c.b.app.tabmodel.ChromeTabModelFilterFactory
        -> .c.b.multiwindow.MultiInstanceManager
        -> .c.b.multiwindow.MultiWindowUtils
        -> .c.b.tabmodel.AsyncTabParamsManager
        -> .c.b.tabmodel.TabModelSelectorImpl
        -> .c.b.tabmodel.TabPersistencePolicy
        -> .c.b.tabmodel.TabbedModeTabPersistencePolicy
7 dependencies above may need to be broken, ignored others.

Change-Id: I78d7ff99316bbe213cee68f97846ffff54877818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432663
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811329}

https://chromium.googlesource.com/angle/angle.git/+log/059781eddd4e..7930477fba50

2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from e7fcc14d450b to 2bfd6a752dc6 (1 revision)
2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 8ab1c000aaa0 to db992e60cc7a (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: jonahr@google.com
Change-Id: I54cdac9d5a0eedbf0400b6ec5d4fadabf5c77f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434227Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811328}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/ui/app_list/arc
This CL was uploaded by git cl split.

R=lgcheng@google.com

Change-Id: I3a6915dc3a04977b760d9555352831f81a7081a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435351
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Long Cheng <lgcheng@google.com>
Commit-Queue: Long Cheng <lgcheng@google.com>
Cr-Commit-Position: refs/heads/master@{#811327}

This is a small workaround. Root cause is crbug.com/1132767, which is
not as easily solved.

Bug: 1129763
Change-Id: I3a96f9aa7ca7bfebd7b410097f32a871df3abff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435145
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811326}

static_cast is better suited for downcasting since it can check that the
types are related.

/components/offline_pages
This CL was uploaded by git cl split.

R=jianli@chromium.org

Change-Id: Ifff21514df23ac39f13dff3228bd619760d8a679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434628
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811325}

https://skia.googlesource.com/skia.git/+log/59d660c075bd..defd223d4023

2020-09-28 robertphillips@google.com Add correctness checks to GrThreadSafeViewCache tests
2020-09-28 brianosman@google.com Revert "Support out parameters that use a swizzle."
2020-09-28 michaelludwig@google.com Update SkClipOp::kMax_EnumValue to match non-deprecated values
2020-09-28 herb@google.com remove unused call from remote glyph cache API
2020-09-28 johnstiles@google.com Simplify IsAssignable to only support one assignable var.
2020-09-28 kjlubick@google.com [fuzz] Add CIFuzz taskdriver
2020-09-28 kjlubick@google.com [canvaskit] Use linear metrics in shaping demo
2020-09-28 johnstiles@google.com Support out parameters that use a swizzle.
2020-09-28 kjlubick@google.com [canvaskit] Increase timeout for RenderSKPs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1108408,chromium:1132687
Tbr: brianosman@google.com
Change-Id: I3b88e6e637e4dcb0257ba6b4c1d7778ff7bee3e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435502Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811324}

This CL adds a new menu observer to add an item to the context menu
that when selected, copies the selected text and a URL to the selected
text to the user's clipboard.

Bug: 1105862
Change-Id: Ic827c6f6441f0af4d3df1958a285f90f59204448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429584
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811323}

Also has fixes for issues discovered during integration testing with backend.

Bug: 1130939
Change-Id: If92a34a451892d49dc4920643313896986a456d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423355
Commit-Queue: Robin Lewis <wrlewis@google.com>
Reviewed-by: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#811322}

static_cast is better suited for downcasting since it can check that the
types are related.

/content/browser/sms
This CL was uploaded by git cl split.

R=reillyg@chromium.org

Change-Id: I2ec4c07a65a3452bc23982b31d5b0e8f08068838
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435999
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811321}

Remove //chrome/browser from the friend list for
//net/dns:host_resolve.  gn check passes without it now because all of
//chrome/browser's usage has been fixed to use //net/dns/public.

Also had to fix one last unused dns_config.h include.

Fixed: 1129993
Change-Id: I405ecb969398972ed335fa6b3674dc659ad033b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427346
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811320}

Roll ChromeOS Broadwell AFDO profile from 87-4247.0-1600681610-benchmark-87.0.4275.0-r1 to 87-4258.0-1601290734-benchmark-87.0.4275.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I29c7c0a2a654abe576a0e33100ce5423a2d1df7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435915Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811319}

Adding a wrapper function around Window's Share operation to allow using
it like a traditional async operation.

Adding tests (and one more test-helper class) that verify the behavior
of the wrapper function.

Bug: 1035527
Change-Id: I71cc7aaa6826d53cc1273c99b603db89612f1544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402293
Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811318}

This reverts commit a5707a7d.

Reason for revert: Likely the cause of test failure in AccountPickerDialogFragmentTest on android builders:
* https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel/2755
* https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2363

The error said:
Attempt to invoke virtual method 'boolean org.chromium.base.ObserverList.c(java.lang.Object)' on a null object reference
	at org.chromium.components.signin.identitymanager.IdentityManager.addObserver(IdentityManager.java:95)
	at org.chromium.chrome.browser.signin.ProfileDataCache.addObserver(ProfileDataCache.java:211)

Original change's description:
> [Android][Signin] Add observer to listen to monogram update
>
> This CL adds an observer to update ProfileDataCache when user's profile
> photo(include monogram) from IdentityManager is updated.
>
> Bug: 1127886
> Change-Id: I0c70f72708e50dceb63eb122055315f7818cba06
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430984
> Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Commit-Queue: Alice Wang <aliceywang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811237}

TBR=msarda@chromium.org,bsazonov@chromium.org,aliceywang@chromium.org

Change-Id: I91562cb8017c2a74afd391fede5d9b206e7e6b5d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1127886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435151Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#811317}

This CL marks marcheu@ as legacy OWNER (a.k.a. OWNER of last resort)
and proposes dcastagna@ to step up.

Change-Id: I430e02174a02fae85a95b87e9ee0d1728520d98a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432967Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811316}

Bug: 1131340
Change-Id: Idfe1fc338fabcb9d35840a00aaf3517ab26ef17c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433255
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811315}

Fetch weather separately with dedicated weather API. Also change
it to a different timer so we don't need to fetch it as frequently
as the photos.

Bug: b:166160411
Test: unittest and manual test
Change-Id: Ib0bd1ca271b1b4ac8daabadf9ee72c4899231551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425344
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811314}

Enable safety check and settings utils unittests.

Switch safety check to grouped style.

Switch to mediator unittests instead of view controller.

Remove unneeded call to resetCheckStartItemIfNeeded.

Bug: 1078782
Change-Id: I16a1c188182747634f8af108bcb72f01bbc20985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435646
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811313}

This reverts commit b37c27dc.

Reason for revert: the test is failing on many waterfall bots: https://bugs.chromium.org/p/chromium/issues/detail?id=1132945

Original change's description:
> Enable test for persistent overlays
>
> The test has been implemented in [1] and now, when DevTools rolled,
> it can be enabled.
>
> [1]: crrev.com/c/2400478
>
> Bug: 1109224
> Change-Id: I43e4dffbf7d50eae856b5c78290768079094ab69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435188
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811260}

TBR=mathias@chromium.org,alexrudenko@chromium.org

Change-Id: I2b94a3927529be3977c21c960b75d09b7e76ff79
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1109224, 1132945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435780Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811312}

Roll ChromeOS Airmont AFDO profile from 87-4262.0-1600690455-benchmark-87.0.4275.0-r1 to 87-4265.0-1601286022-benchmark-87.0.4275.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ifdfe01a95263cce38f7afda9c7168686f1d46225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435917Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811311}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/ui/ash/launcher
This CL was uploaded by git cl split.

R=skuhne@chromium.org

Change-Id: I4e9943d6a465583be28cb3bf940ad65499ed33e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434774
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811310}

This reverts commit 45e2dc4e.

Reason for revert: not the cause of the perf regression

Original change's description:
> Revert "[Sampling profiler] Move ENABLE_ARM_CFI_TABLE to profiler header"
>
> This reverts commit 74826cab.
>
> Reason for revert: testing whether this is responsible for rendering.mobile perf regression
>
> Original change's description:
> > [Sampling profiler] Move ENABLE_ARM_CFI_TABLE to profiler header
> >
> > ENABLE_ARM_CFI_TABLE is in service of the sampling profiler on Android,
> > and is unrelated to any debugging functionality, so move it to a
> > buildflag header under base/profiler.
> >
> > Also add the required includes to the files that use it.
> >
> > Bug: 1129939
> > Change-Id: I884b2128fc2ab2f6f1bec2343c59134448328529
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421443
> > Commit-Queue: Mike Wittman <wittman@chromium.org>
> > Commit-Queue: Lei Zhang <thestig@chromium.org>
> > Auto-Submit: Mike Wittman <wittman@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#809167}
>
> TBR=thestig@chromium.org,wittman@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1130974, 1129939
> Change-Id: I00050d0bf8cd7988d0ad8969f0b8a29e8accf669
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432308
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810801}

TBR=thestig@chromium.org,wittman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1130974
Bug: 1129939
Change-Id: I3180fd8161b3df701d467d1a028d0e504938dfe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435778Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811309}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/685e35de..3860f7c6

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3897e7c1877287633addafcc4a7d31bd404874dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435664Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#811308}

static_cast is better suited for downcasting since it can check that the
types are related.

/chrome/browser/paint_preview
This CL was uploaded by git cl split.

R=ckitagawa@chromium.org

Change-Id: If816d7c4d2d7d898688497b0d368d6145eeaaf68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435998
Auto-Submit: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811307}