GitLab

This is the first step in removing WebVR. This change removes WebVR
from about://flags and also removes the separate command-line switch
that was used. In order to keep the tests running for the time being,
this change modifies the blink webvr feature to be set to "test." The
browser tests for WebVr have been updated to set the new flags that will
turn on WebVr.

This also removes the Origin Trial flag for WebVr, and as such deletes
the origin trial layout tests as well.

Bug: 960132
Change-Id: Ia625e3ae9986183ef2746dcb69e595cab49fd981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862855
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708005}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c61f5295030..0ce6d876771d

git log 8c61f5295030..0ce6d876771d --date=short --no-merges --format='%ad %ae %s'
2019-10-21 lamontjones@chromium.org config: add R79 to luci-scheduler.

Created with:
  gclient setdep -r src/third_party/chromite@0ce6d876771d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I348c232627a58e6e1653d8c23850c07148173af1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872923Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#708004}

This patch includes a lot of namespace moves and general name cleanup
for the Open Screen platform code.

Change-Id: I00b12810dd2828fe178d48f21032f25be6e5030c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867450
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Auto-Submit: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708003}

Also renames it to AsyncDomStorageDatabase 'cause that's what it be.

Bug: 1000959
Change-Id: I4bc29a722155b4bb890353b83efdc4100917bf33
Tbr: avi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870110
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708002}

Bug: 1008189
Change-Id: Iab2a10cb9e8e6a5f3737b0515308ad5213a41776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864624Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708001}

Keeping track of whether a user verification attempt ends with a success, a
"not allowed" error, or a different error.

Bug: 949269
Change-Id: Icc50d85e0d1bb56a1c575dc5ee86af86d4276ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864402
Commit-Queue: Manas Verma <manasverma@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708000}

BUG=965215

Change-Id: I06b867c8adcdeae00dcde4d603e0e16eb0a0820d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869020
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707999}

Chime is a notification library pulled in downstream clank repo, which
needs to ship in Android DFM.

This CL sets up the boilerplate for chime DFM module.

Bug: 1013386
Change-Id: I161613ca16adf5131d55b1803b6ad9e5821c80eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867379
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707998}

This CL removes the need for defining a custom unordered comparison
method for vectors of RequestAction

Bug: 1015642
Change-Id: Iac7f0366e832dd58a8fbd921461fd534d3d453b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870053
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707997}

Fix delayloads_unittests to properly handle is_multi_dll_chrome set to
false and when run on win7. A previous change to modify behavior based
on CHROME_MULTIPLE_DLL_BROWSER was not correct since is_multi_dll_chrome
was not checked in the tests BUILD.gn.  Also, Windows7 will load user32
due to static dependencies starting from oleaut32.dll which are not
present on windows 10.  Unfortunately oleaut32 is pulled in from many
dependencies during dll load of chrome (when merged) or chrome_child.

Change-Id: If364f08c35e6c881249b2be3ce092eb2ddd48a68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872563
Commit-Queue: Chris Davis <chrdavis@microsoft.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Cliff Smolinsky <cliffsmo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707996}

https://android.googlesource.com/platform/external/perfetto.git/+log/dd6606f6cee7..88adfb7aa2e6

git log dd6606f6cee7..88adfb7aa2e6 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 dproy@google.com Merge "processor: Walk up stack to find matching begin event"

Created with:
  gclient setdep -r src/third_party/perfetto@88adfb7aa2e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I4cbeac4e71614fa2aa803780ee7838eff25b7270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872836Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707995}

This CL addresses cases when no favicon is shown for some credentials.
This may happen when the credential has been saved in a different app,
as in this case credential origin is an opaque URL for which no favicon
can be obtained. To work around this, this CL adds plumbing to pass the
URL of the page for which TouchToFill has been triggered. If the
credential origin is opaque, TouchToFillController requests a favicon
for the frame origin.

Bug: 1012646, 1016486
Change-Id: I6d803734460279b3f079db77d05992c39a43ac02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865338
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707994}

(~3 remain that seem to need somewhat more attention)

Bug: 1016512
Change-Id: Iebec6305b440a33b611773730727df4d3c725260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872412Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707993}

TBR=govind@chromium.org

Change-Id: I580879e2dc32f13383b5d9d2b4dc44a7fdd3460e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872160Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707992}

If a dialog/sheet is constructed and destroyed having never been shown, the normal tear-down sequence never happens. This change ensures that the underlying NSWindow had actually been invoked as a sheet. If not, immediately initiate destruction.

Bug: 1000893
Change-Id: I9a7947db38bd1edcdda64627507fdfc834b127ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869403Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707991}

For the case that the snap point is the same as the scroll position, we
set the snap_at_gesture_scroll_end flag to be true, but there is no
scroll snap animation happen, We pass a callback of setting hover
state dirty to snap function, and when the snap point is the same as
the scroll position, the callback will be executed to update the hover
state right away.

Majid's CL to change SnapCoordinator::PerformSnapping to return true
when the snap point is the same as the scroll position:
https://chromium-review.googlesource.com/c/chromium/src/+/1769044

Bug: 877132
Change-Id: I4cfc1bf03ee980b4b68e74aad79a8bec6a906da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790259
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707990}

Individual classes now extend from Microsoft::WRL::RuntimeClass.

BUG=1014283

Change-Id: Ic56344114a2b0432d0d29992a3dab8896ab2ae39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863551
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707989}

Bug: 1002733
Change-Id: I6254d5d5feeb1e6fa1fcb72b8109453523683b97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867094Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707988}

Bug: 968542
Change-Id: I5f2846630bb5ff1a4f648b59bbe332c7e557b121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871330Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707987}

This adds basic support for persisting encryption keys on disk using a
dedicated file (intentionally outside sync's directory), containing an
encrypted protocol buffer as introduced in this very patch.

Bug: 1012660
Change-Id: Ie9fedae86799f412703914dbfec53e3d0b85a2c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865324
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707986}

While testing the WebRTC component build in [1], there was a problem
with some testonly code Chromium depends on (which cannot be part of the
WebRTC component).

In order to support this use case, [2] will make the testonly code
needed by Chromium depend on the WebRTC component and this CL is needed
in order to land everything in an incremental fashion.

[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1868961
[2] - https://webrtc-review.googlesource.com/c/src/+/157427

Bug: webrtc:9419
Change-Id: Ie995af67a7ab4ba1a2e5bb012f2e9b33be056acb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872937Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707985}

Caused regression in attached bug. UX still wants this will try to
possibly re-enable this for M-80. But for M-79 we should disable it.

TBR=oshima@chromium.org

Test: none
Bug: 1016047
Change-Id: I41bee546750b712b575ff3ed70a6245009bcf0c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872767
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707984}

This DCHECK was caused because the Embedded Assistant UI tried to grab
the focus while it was being closed.

This |RequestFocus| call was added explicitly to fix a bug where the
input text field in the Assistant UI would lose focus when submitting
a query while in tablet mode.

And this was happening because we tried to dismiss the virtual on-screen
keyboard.

I added unittests to test for these 3 scenarios, and I fixed it by dismissing
the virtual keyboard using a |HideKeyboard| method instead of dismissing it
by dropping the focus of the text field.

Bug: b/141945964
Change-Id: I3aca9e08ab0e2b7419cfe53c1f4dc831130cd0df
Tests: Added unittests and verified manually
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848796
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707983}

These log messages aren't generally interesting, and sometimes can be
confusing, especially to developers of WebView apps who see these
printed by their own applications and may not understand them.

Reduce their log levels to debug (which causes them to be stripped in
official release builds) or otherwise make them conditional.

Fixes: 1016010
Change-Id: I5f2375e87c9bc007723dc41c5e1276693fd5ddcc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869288
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Richard Coles <torne@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707982}

Change-Id: I22cf05ba9b9e7230c2a993e7aed9cceeecce6b1a
Bug: 1009630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835181Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Auto-Submit: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707981}

https://skia.googlesource.com/skia.git/+log/4f50bdda1019..4036a6d8ac64

git log 4f50bdda1019..4036a6d8ac64 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-21 bsalomon@google.com Simplify sk_gpu_test::MakeTextureProxyFromData.
2019-10-21 halcanary@google.com SkPDF: simplify Producer metadata logic
2019-10-21 kjlubick@google.com [canvaskit] roll to v0.8.0

Created with:
  gclient setdep -r src/third_party/skia@4036a6d8ac64

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Bug: None
Change-Id: I5538e0081db1f88d025c248fad349d7b4f9acb8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872834Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707980}

In tablet mode, swiping up from hot seat when an app window is active
is expected to transition to home screen, with app window bounds
collapsing into associated app item bounds within the home screen
(if the app is shown on the home screen). If the app item is not
visible on the home screen (e.g. it's not in selected page, or if
it's in a folder), the app window bounds collapse into the center of
the apps grid.

To achieve that, home screen controller has to expose the expected
app list item bounds for an aura window that is being swiped off the
screen (similar how it's done for shelf icon position, that is used
when minimizing windows in clamshell).

In addition to logic for getting an item bounds in the apps grid, this
adds kAppIDKey property to aura::Window. The property is used to map
a aura window to an app ID.
It's similar to kShelfIDKey,which is used to map a window to a shelf
item.
Generally, the app ID in shelf ID and app ID should be equal, but they
handle (unpinned) browser shortcut items differently - if a  browser
window app item is not present in the shelf, ShelfID key will change to
chrome item (so the browser bounds collapse into the chrome icon).
kAppIDKey will always contain the app ID that is associated with the
active browser web contents.

BUG=997885

Change-Id: Iec3c80ba02c6a5f277eaa44f01f6b370275fe3dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864360
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707979}

When no arrow button shows, the app icons are chopped under RTL. The
reason is that |available_space_| is not adapted to RTL. The issue
is not reproducible under overflow mode. Because in overflow mode,
|available_space_| happens to be the same with the mirrored one.

This CL fixes such an issue by mirroring |available_space_| for the
horizontal shelf under RTL.

Bug: 1016271
Change-Id: I76ec521048b34da9fad97b8d0af6bfd3b8ebb327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872800
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707978}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c4835b8523b1..488a0bd3c7d3

git log c4835b8523b1..488a0bd3c7d3 --date=short --no-merges --format='%ad %ae %s'
2019-10-21 rharrison@google.com Rolling 4 dependencies, small script fix and updating expectation files (#844)

Created with:
  gclient setdep -r src/third_party/shaderc/src@488a0bd3c7d3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I29aa35538eb74b1bad865b5597a2c1cb37f634e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872919Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707977}

Extend the hotseat in overview mode, and hide it in split view mode.

Bug: 1009550, 1009716
Change-Id: I2494c07a2d9bf486ffd4be5a0da4779c855cd59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872189Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707976}

The added tests exercise the construction of PerformanceMark objects
and make sure that simple script values can round-trip through the
"detail" attribute.

An unnecessary parameter was also removed from PerformanceMark's
constructor.

Bug: 805566
Change-Id: I63e7980235a1d8f9c3b79ba06131bbbe5aee5ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872455
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707975}

R=avi

Bug: 1016011
Change-Id: I609c2958e52d837e1f43b0fd7497ba2013314086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872561Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Federico Paredes <fedpar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707974}

This converts TODO(foo@) to TODO(crbug.com/XXX) in the Mirroring Service code.
It also ensures that TODOs reference an open crbug.

No functional change.

Change-Id: I34ea1dfea02d016fba87bf7125a90e08be92a8de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867092Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707973}

UpdateDefaultTarget can be used to update the default target value
that will be used to complete the observation if the controller
is destroyed before CompleteObservation is called.  A default value
may be added, changed, or removed.

Change-Id: I700ad31cb56e60a15e31c43367377336f4c1ad74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863593
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707972}

Improve accessbility for system info subpage of Feedback by
marking empty cells in the table as aria-hidden. This really does
improve the navigation experience.

BUG=chromium:1005567
TEST=Ran system info under ChromeVox. Navigated around page, expanded
and collapsed sections, etc

Change-Id: I6397357552b6c4a78afaafc56a3fd1b4db5e8c1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869888Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707971}

CL has no user visible changes.

Restructuring TasksSurface with AppBarLayout.
Adapting StartSurface and sub components to work with new layout.

Before: RecyclerView inside NestedScrollView did not recycle views.
Now: RecyclerView recycles views inside CoordinatorLayout.

Bug: 1000295

Change-Id: I73b01f1f4efcb7e263894b64e2b0f81a07229f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865399
Commit-Queue: Mia Glaese <glamia@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707970}

DCHECK(arc_is_booting_) in ABPTO::OnArcInitialStart() was
consistently being hit in debug mode. This is because OnBootCompleted()
is actually called before OnArcInitialStart(), so arc_is_booting_ is
already set to false by the time OnArcInitialStart() is run.

Bug: b:133417350
Test: ABPTO unittests
Change-Id: I023ee2841e7ed986b68bab06df1a57d1ac6ac8be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872415
Commit-Queue: Willie Koomson <wvk@google.com>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Auto-Submit: Willie Koomson <wvk@google.com>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707969}

These two metrics are no longer in use.

Bug: 988654
Change-Id: I736e104afcc5741b315f5e974fe741758710351b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872760Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707968}

This allows some statistics to be gathered about them.

Bug: 1015682
Change-Id: I7a67c284f5a71b7280e69259b91553a90cbdb5d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870010Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707967}

This CL changes the status bar colour used by TWAs when in night mode.
This CL makes TWAs use the default theme colour instead of the toolbar
colour provided in the TWA launch intent.

This CL also:
- Adds TabThemeColorHelper#isDefaultColorForced() in order to
discriminate between reasons why
TabThemeColorHelper#isDefaultColorUsed() returns true:
  - Using the default theme colour because using the default theme
    colour is forced (e.g. previews, night mode)
  - Using the default theme colour because the web contents do not
    specify a custom theme colour
- Adds TabObserver#onDidChangeForcedThemeColor() to listen to changes
  in TabThemeColorHelper#isDefaultColorForced().

BUG=997796

Change-Id: I490e8ebe6c28b4dbe3b01112acd327e307efedb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795571Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707966}