- 31 Jul, 2018 40 commits
-
-
sczs authored
Implements showBrowsingHistoryRemovedDialog on ClearBrowsingDataTableVC. Screenshots: https://drive.google.com/open?id=1uMyVYUqzdikwfP7V-ka0xD3ImteYbKO2 https://drive.google.com/open?id=1blljYShc0UYPVOWeuZszFpWk1z3Es8ke https://drive.google.com/open?id=1J2r0pyARZtMOzjzffdL8B-S1ek8lBwXK Bug: 868363 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie0a20e07e64a3d14017e87edfa2dc05a874345f1 Reviewed-on: https://chromium-review.googlesource.com/1155479 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#579507}
-
Mike Dougherty authored
The tests were mistakenly also disabled for simulator in crrev.com/c/1155793. TBR=marq@chromium.org Bug: 869176 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I794468b78f4259ed10e230074c54a5ed0552e1f4 Reviewed-on: https://chromium-review.googlesource.com/1157109 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#579506}
-
Emil A Eklund authored
Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I82a2ee42527cd7186173d476826654125bbea876 Tbr: kojii@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1157001Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#579505}
-
dpapad authored
- Add a new html_out_files_polymer2 optional parameter. - When specified, causes both the Polymer 1 and Polymer 2 HTML bundles to be generated. The parameter will be used in follow-up CLs. Bug: 862472 Change-Id: Iaa015d3cc7091b1b2f4e84aa36fae7b039b58846 Reviewed-on: https://chromium-review.googlesource.com/1155474 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#579504}
-
Michael Spang authored
No functional change. This is needed prior to some refactoring. Bug: 869206 Change-Id: I2db96c903b64b50ac8e33739263cdbb0297bde2f Reviewed-on: https://chromium-review.googlesource.com/1155910 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#579503}
-
Chris Hamilton authored
This partially reverts commit 93cd24be. Reason for revert: This inadvertently changes the definition of several core session restore metrics when the PageAlmostIdle feature is enabled. Original change's description: > Update SessionRestoreStatsCollector to use TabLoadTracker. > > This is necessary in order for it to work when the PageAlmostIdle > feature is enabled. > > BUG=829933 > > Change-Id: Ic3158a984713ceef849788eaa758ecaa255eba5a > Reviewed-on: https://chromium-review.googlesource.com/1097421 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567484} Bug: 829933 Change-Id: I23b54578084ef8c55b5c47d3a29880e15be3afec Reviewed-on: https://chromium-review.googlesource.com/1153145 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#579502}
-
Andres Medina authored
Added virtual-channel field to be able to filter crash reports by this it. Bug: internal b/64942730 Change-Id: I5375d574f6095a689e89d0c543df20da2b281b33 Reviewed-on: https://chromium-review.googlesource.com/1026150 Commit-Queue: Andres Medina <medinaandres@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#579501}
-
Bence Béky authored
Add Net.SpdySession.ServerSupportsWebSocket histogram to track server support of WebSockets over HTTP/2. Bug: 801564 Change-Id: I1cd63e5bdca17106487c48ce6c1734e4d6591985 Reviewed-on: https://chromium-review.googlesource.com/1152486Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579500}
-
Matt Menke authored
ContentBrowserClient has had that method for a while, but it hasn't been used. I'm adding a use of it, so am implementing it in subclasses. Bug: 841445 Change-Id: I9826cabdfdb2493d96583c1b7a2c0e2710ec07e8 Reviewed-on: https://chromium-review.googlesource.com/1151456Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#579499}
-
Dan Harrington authored
I stumbled onto an obscure failure by calling OfflineContentAggregator from an IO thread, when it actually needs to be used from the UI thread. Using SEQUENCE_CHECKER fails under invalid use faster and more clearly. I chose to add it to OfflineContentAggregator because that's the API I was using at the time. I chose to add it to TaskQueue because many public offline_pages APIs result in adding tasks, so it's likely to catch incorrect calls. Change-Id: I40080b4e56cb000dc30acee36d4aa01d3806a6f3 Reviewed-on: https://chromium-review.googlesource.com/1148998 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#579498}
-
Renjie authored
Bug: 621751 Change-Id: I4e13f470fc688cd8ccb073764a14f9d1cea40ea4 Reviewed-on: https://chromium-review.googlesource.com/1155475Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Mao Huang authored
Original CL: - https://codereview.chromium.org/281613004 Don't let tcmalloc read all kinds of env vars at startup. The env vars are still used in profiling=1 builds, by such illustrious figures as the deep memory profiler bot and willchan. Reading from the environment variables uses static initializers, so this change will eliminate those static initializers in profiling=0 builds. As discussed in the chromium-dev thread "Does anyone use tcmalloc's debugging envvars?". BUG=94925 NOTRY=true BUG=724399,b:70905156 Change-Id: Ic143dfca456a3475be0938af53c0eb4308f457d1 Reviewed-on: https://chromium-review.googlesource.com/1130780Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#579496}
-
Johannes Henkel authored
And a small refactoring for readability of finding an xhr breakpoint. I introduced IsEmpty in this PR: https://chromium-review.googlesource.com/c/chromium/src/+/1154038 Change-Id: I7b02c9d4d4ae1e051688790f5043d8710cf1c692 Reviewed-on: https://chromium-review.googlesource.com/1154190Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#579495}
-
Weidong Guo authored
1. Currently expand arrow exists in AppsContainerView, so opening search results page will move it off screen. To make it stay where it is and fade it out, we need to move it to ContentsView. 2. Make expand arrow focusable only in peeking state. Demo: https://drive.google.com/open?id=1hgSqEDgEW1wZr5Dxw8WQmGpEosy4sDgP Bug: 866690,868107 Change-Id: I965703041f498f8ad1e64c6db47718e7bf69c8f8 Reviewed-on: https://chromium-review.googlesource.com/1150900 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#579494}
-
Bence Béky authored
Bug: 807724 Change-Id: I065796ef6b9f954f3e623b0c5db800b24889d95b Reviewed-on: https://chromium-review.googlesource.com/1155088Reviewed-by:
-
Moe Ahmadi authored
iOS: https://drive.google.com/file/d/198YXGP4TW8VcZ-scZy6jf-8GPHLRQc2U/view?usp=sharing Desktop: https://drive.google.com/file/d/1ouJGiWYjg-IfIaMdxKPXGh1sN3EDrYxQ/view?usp=sharing Bug: 855088 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I92786a9aa33e228297352b9dfaf5730b00daf629 Reviewed-on: https://chromium-review.googlesource.com/1155484 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579492}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: I682964caf24da1b14570dbfacbc59e9257fa1ab2 Reviewed-on: https://chromium-review.googlesource.com/1154222Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#579491}
-
Ben Wagner authored
The related Skia change has rolled into Chromium and the fix in Skia can now be turned on and rebaselined. Change-Id: I8a799896bc743932d37ea62ba8e62cc0582fc55a Reviewed-on: https://chromium-review.googlesource.com/1156627Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579490}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e8e10fdf..8b8cc1cc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2247a14f81593c17916bd8eb32ba3d9e13df235c Reviewed-on: https://chromium-review.googlesource.com/1156992Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579489}
-
Mike Dougherty authored
TBR=marq@chromium.org Bug: 869477 Change-Id: I74a659e745f2480e2a35535085e837b6b5e5bc73 Reviewed-on: https://chromium-review.googlesource.com/1157066Reviewed-by:
-
Bret Sepulveda authored
All tests should be using MD for secondary UI by default, so this call is now a no-op. Bug: 867557 Change-Id: Ia0d6f774543425c56084894f15f4d262f9071f7c Reviewed-on: https://chromium-review.googlesource.com/1155632Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#579487}
-
Koji Ishii authored
Currently, 50 to 60% of CollectInlines are spent in ExpandCapacity to reallocate the vector buffer. This patch makes rough estimation from the number of direct children to reduce the number of reallocations. Currently, slow tests such as storage/indexdb/* creates more than 1,000 items by appending the test results in <span></span><br> structure. This patch reduces vector allocation in such cases to once or twice. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2b5b1462dc59091cc534a2f143b54567d31b863a Reviewed-on: https://chromium-review.googlesource.com/1155268Reviewed-by:
-
Boris Sazonov authored
This CL moves mSigninAccessPoint from SigninFragmentBase to SigninFragment. SigninFragmentBase will be used for as the base class for the consent bump fragment and for the consent bump there's no notion of the access point. This CL also reimplements how SigninFragmentBase determines the text for the cancel button, because it's been using mSigninAccessPoint. Bug: 869426 Change-Id: I8361965a9c9df62d86e058b01f4a06f88e7bfbda Reviewed-on: https://chromium-review.googlesource.com/1156701Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#579485}
-
Derek Cheng authored
Follow-up to http://crrev.com/579256 Bug: 869112 Change-Id: Ie8d560bf0a01fa811dfa5529269a9756ae81447b Reviewed-on: https://chromium-review.googlesource.com/1156996 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579484}
-
Michael Spang authored
Since these types were moved back to DRM, we can use DrmDevice* instead of GbmDeviceLinux* again. Bug: 869206 Test: compile Change-Id: I61d69e16c4e8d93f5bc913698ee0fab410c3db2e Reviewed-on: https://chromium-review.googlesource.com/1155909 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579483}
-
Lan Wei authored
Currently on MacOS the pen behaves like a mouse input, because we generate mouse events for the pen input. We agreed that the pen input should behave like a touch input, so we now send touch events instead. Bug: 854354 Change-Id: Iac7910e250020a8125a57fb6055fb282db3faf0e Reviewed-on: https://chromium-review.googlesource.com/1136721 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579482}
-
Kenneth Russell authored
See whether passing --disable-features=UseSurfaceLayerForVideo improves the reliability of these tests. Tbr: kainino@chromium.org Tbr: dalecurtis@chromium.org Bug: 830901 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id56d57c331ae416b5492a25609d869ebdba26ec3 Reviewed-on: https://chromium-review.googlesource.com/1155940 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#579481}
-
tzik authored
An upcoming change to base::Bind rejects binding ref counted objects if their ref count is zero, as this is an error prone pattern. And DevToolsDeviceDiscovery::DiscoveryRequest hits the check, as its first reference is made in its constructor through base::Bind, though its usage is valid and the check failure is a false positive case. To avoid the check failure, this CL moves base::Bind out from the constructor, and keeps a reference to the instance separately. Bug: 866456 Change-Id: Ic90d78981ac03accbb98e5536b64b576f8147f09 Reviewed-on: https://chromium-review.googlesource.com/1156328Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#579480}
-
sczs authored
- Changes ReadingListTableVC section rowAnimation to UITableViewRowAnimationMiddle and UITableViewRowAnimationFade. - Constraints were breaking while animating, this because of a known bug that was fixed in other headers (crbug.com/854117). In order to fix this all the padding constraints priority was lowered. Video: https://drive.google.com/open?id=1jf1n56P4apUCHjC6ZqZlLe0mCEORsIzG Bug: 868228 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5580fe7377f16070fc43b1bc283754d4b00d60ef Reviewed-on: https://chromium-review.googlesource.com/1155923 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#579479}
-
Zach Helfinstein authored
Also add tests for Dictation Bug: 866521 Change-Id: I551b97cdc9d7f0374985438b94c538c45daddf52 Reviewed-on: https://chromium-review.googlesource.com/1152514Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#579478}
-
Chris Kuiper authored
The new Cast streamType kOther maps to STREAM_VOICE_CALL in Android, which doesn't allow a volume of 0 (i.e., volume index=0). Basically we need to honor the minimum volume index in the VolumeMap/Control logic. For VolumeMap, all volumes below min_volume share the same dB value as the min_volume one. For VolumeControl, when setting a new volume, we round it up to min_volume if necessary. Bug: internal b/111838985 Test: No more exeption triggered. Change-Id: I67315bfa877875d9de3cc06d37e8a1fa72994004 Reviewed-on: https://chromium-review.googlesource.com/1154145Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#579477}
-
Evan Stade authored
Bug: 854704 Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d Reviewed-on: https://chromium-review.googlesource.com/1153777 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#579476}
-
Sergey Ulanov authored
1. Removed mapped_paths_cstr in LaunchProcess() - it wasn't used. 2. Updated base::fuchsia::GetHandleFromFile() to handle fdio_transfer_fd() failures properly: fdio_transfer_fd() consumes FD on failure, but GetHandleFromFile() was still trying to close it. Change-Id: If9283fd0271128659dc4ab7633d7b9ec0a093a1f Reviewed-on: https://chromium-review.googlesource.com/1155966Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#579475}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b53ef1e52d40..cede561c5ae6 git log b53ef1e52d40..cede561c5ae6 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 tsepez@chromium.org Remove CXFA_Corner downcasts from cxfa_rectangle.cpp Created with: gclient setdep -r src/third_party/pdfium@cede561c5ae6 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic9b907abf3ace1d653ee280d0c42c4f3fc41448c Reviewed-on: https://chromium-review.googlesource.com/1156906Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579474}
-
Saman Sami authored
Early-out in OnSwapCompositorFrame if video_consumer_ exists. Don't do this in OnSynchronousSwapCompositorFrame because video capture doesn't work with Android WebView and we still have to call CopyFromSurface. Bug: 865430 Change-Id: I4b59848b2c288fc06708187b8d48e86c1fd19237 Reviewed-on: https://chromium-review.googlesource.com/1156871Reviewed-by:
-
Koji Ishii authored
Unlike normal layout cases, hit-testing, canvas, etc. may call ShapeResult functions with 0-length text. In this case, ShapeResult has no RunInfo. It is also possible that there are no glyphs for the given text, but in normal code path, HarfBuzzShaper should still generate a run without glyphs. Bug: 868893 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia86f4627c74122c915986858bc974fc2e18d3b3d Reviewed-on: https://chromium-review.googlesource.com/1155275Reviewed-by:
-
Jérôme Lebel authored
Command ids in CollectionViewTextItem are used in GoogleServicesSettingsViewController. The command id lets the view controller knows which command to send to the command handler when the cell is tapped. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iafa070c38362d0295a0100f99033972da26d435e Reviewed-on: https://chromium-review.googlesource.com/1156692Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#579471}
-
Mark Cogan authored
New tabs opened from the grid were shown as white as they animated open, because they were only showing the cell's snapshot, not the snapshot taken from the BVC that will be displayed. This was because the gird animation only shows the BVC snapshot if it thinks there will be a difference between it and the cell snapshot -- specifically when there's been a device rotation. This CL lets the grid view controller flag the active cell in the animation as "appearing" so that the animation can always show the BVC's snapshot in that case. Bug: 865978 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iede4af004e89e5fda1395c4257c3d74fd2a682c7 Reviewed-on: https://chromium-review.googlesource.com/1156685 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Weidong Guo authored
When apps-grid-gap feature is enabled, dragging last item on a page to another single-item page to create a folder will cause a crash. This is caused because we delete the dragged item view in AppListItemView::SetMouseDragging() before setting state, so swap the two parts. Bug: 869135 Change-Id: I99e466bc0ff3ddd6846fcd4f5cb9e14fd9522ac3 Reviewed-on: https://chromium-review.googlesource.com/1155723Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#579469}
-
Sergio Villar Senin authored
This unit test is supposed to test that deleting the SimpleURLLoader in the OnRedirectCallback was safe. Taking a look at the code, it seems that nothing is deleted in the callback so it might look like the test is actually not testing anything. However there is a subtle reason why the test is working, and that's because a unique_ptr is passed to the callback which is actually deleted once out of scope. Making the deletion explicit + checking the passed in attributes looks like an improvement in this case. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5f10b660f19b5951b7ddb37c57228dca4cdf497c Reviewed-on: https://chromium-review.googlesource.com/1156702 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#579468}
-
