- 01 Nov, 2019 40 commits
-
-
Antonio Gomes authored
This is a fixup CL of [1] spotted and report by hbos@chromium.org on [2]. [1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences) [2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1 Basically the original CL was supposed to replace the code that used to bound PeerConnectionTracker to its associated mojom::Receiver instance in [3] by the corresponding code in Blink. However, the replacement code got accidentally missing while rebasing the CL over and over. [3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777 This CL amends the original CL with the proper code in blink/renderer/modules/modules_initializer.cc@RegisterInterfaces(). TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \ --run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001 Manual test= Open Chromium load about:webrtc-internals and [4]. It is expected that WebRTC statistics appear. [4] https://codepen.io/anon/pen/JQLEqR?editors=1010 R=haraken@chromium.org TBR=guidou@chromium.org, hbos@chromium.org BUG=787254 Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#711647}
-
Daniel Cheng authored
The JSON files that are merged by the helper script generally contain a lot of values. The regex matcher in Python is quite optimized, so it's faster to combine identical cases with '|' rather than adding multiple merge helpers that execute the same thing. Savings when run locally on my dev machine are around 500ms-1000ms. Bug: 1014845 Change-Id: I36af02140b5efa2cbd306f7f1fb6c26f93f37a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894416Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711646}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie4d22e3f2fc9bbdc1396cc26343d036cfd317063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893299Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711645}
-
Maggie Cai authored
This CL adds a method to add a preferred app with specific intent filter to ARC. Currently the existing method uses the previous queried intent info in the ARC code base, however, with the new intent handling implementation, the query happened in Chrome OS and ARC does not have this information anymore, we need to send the corresponding intent filter to ARC to be able to set the preferred app. BUG=853604 Change-Id: I7b3bf11deb920aadd9f6421d9f05d313bbdd8850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882194 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711644}
-
Ken Rockot authored
This switches extensions code to the new DataDecoder API. As a result none of this stuff depends on the Service Manager anymore so a bunch of Connector plumbing and awkward test setup is also deleted here. Bug: 977637 Change-Id: Ib4e995c75673e349c165aeb375bd78d4d7eb43af Tbr: poromov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881807 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711643}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d2fe3087. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 9be931cb "[WPT/common/security-features] Refactor navigable tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bokan@chromium.org: external/wpt/visual-viewport NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I00d5adb0041cc07638610503b024321c35c81d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893298Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711642}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I2094369240b2174bf2cc874a79bec1f4222bc3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893113Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#711641}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf5ec7271d5c..98f3379d14d4 git log bf5ec7271d5c..98f3379d14d4 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 akeshet@chromium.org sysmon: add getty to the list of named counted processes 2019-10-31 vapier@chromium.org gs: drop ts_mon usage 2019-10-31 andrewlamb@chromium.org Add replication_util, which implements ReplicationConfig proto 2019-10-31 lamontjones@chromium.org gs: add "can't start new thread" transient error. 2019-10-31 saklein@chromium.org depgraph.proto: Compile newest version. 2019-10-31 tcwang@google.com afdo: Fix the AFDO names to check on afdo verify builders. Created with: gclient setdep -r src/third_party/chromite@98f3379d14d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iecf1818c3257b0a229865f3607c80c3356431124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894800Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711640}
-
Marina Sakai authored
This CL removes macro-generated fucntions for private properties of SCRIPT_PROMISE_PROPERTIES, and replaces them with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Bug: 715418 Change-Id: I0f511b0cf8286ac133e473d32b44620d9d799dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893128Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Alice Boxhall authored
TBR=dmazzoni@chromium.org Bug: 1020456 Change-Id: I0cc01b417380f0ebdaae528cdd4dca0dbe720f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893489Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711638}
-
Zhongyi Shi authored
When path degrading is detected, QUIC connection migration cannot start until a new network becomes available. This change collect how long it takes to have the new network become available after detecting path degrading. And it can be used to help provide feedback to: 1. platform: decide how aggressive network switch should happen; 2. cronet embedders: decide how fast it should pull up the cellular network when connection migration is enabled. Change-Id: I746d80dfd0bd1e1db8856a939aa06067b1a9577d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894044Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711637}
-
Jonathan Ross authored
This test is often causing a crash in the test runner. With an incorrect message sent to third_party/blink/tools/blinkpy/common/message_pool.py TBR=backer@chromium.org TEST= compositing/overflow/scrollbar-layer-placement.html vulkan_native_blink_web_tests Bug: 1018884 Change-Id: I1f61196f0c247e33574f7b0d46a3d2691ebb0028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893378Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#711636}
-
Yusuke Sato authored
This allows unit tests that uses FakeConciergeClient to test the case where base::nullopt response is passed to these callbacks without needing to modify the existing tests at all. BUG=b:136128691 TEST=try Change-Id: I25b31be7f060b419184e891413d21b5a645ac46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894042Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#711635}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/10d5ae79..5bb0ce8e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie712fb29c2bf0ab94432857667d4e88a3f9496bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893297Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711634}
-
Mason Freed authored
This CL removes (except for the enums) three unused RAPPOR metrics. There are equivalent UKM metrics for these Web Components features. Bug: 1016906 Change-Id: I13c14ab3113c5f39502ee00ec2b41140cbeaa19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893519 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#711633}
-
Yoshifumi Inoue authored
This patch changes |{Start,End}PositionForLine()| to utilize |NGInlineCursor| for prepeation of migraiting to |NGFragmentItem|. This patch moves implementations of |Line{Start,End}Point()| to |NGInlineCursor| from |NGPhysicalLineBoxFragment| to share code for improving code health. Bug: 982194 Change-Id: I899c2ff9f1a38a5da74665d2208732c5de324c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888241 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: -
Gyuyoung Kim authored
This CL converts old Mojo types of Connector interface to new Mojo types. Major changes are as below, - Rename BindConnectorRequest to BindConnectorReceiver - Apply mojo::PendingReceiver to Connector::Create - Convert FooRequest to mojo::PendingReceiver - Convert FooPtr to mojo::PendingRemote or mojo::Remote Bug: 955171 Change-Id: I51bfc5611f421f1754c3bda98b67d0d44b08745b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887250 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#711631}
-
Alex Danilo authored
Adds percentage complete string for translation. Bug: 1014771 Change-Id: I043b9f8127fe51732eb65ccbb68ed1257c02d901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890401 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#711630}
-
David Benjamin authored
I don't have any immediate evidence that these are called on empty strings or vectors, but this was an easy enough regex to write so just fix them. Bug: 923166 Change-Id: Iea616099c2ce755e2783e4929911e5844049bba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894623Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711629}
-
Matt Falkenhagen authored
When uploading form data in a subresource request that goes through a service worker, ServiceWorkerSubresourceLoader::DispatchFetchEvent() converts network::ResourceRequest(=network.mojom.URLRequest) to blink::mojom::FetchAPIRequest which means the body is converted from network::ResourceRequestBody(=network.mojom.URLRequestBody) to blink::mojom::FetchAPIRequestBody, which means each body element is converted from network::DataElement(=network.mojom.DataElement) to blink::FormDataElement(=blink.mojom.FetchAPIDataElement). The conversion of files was incorrectly assuming Latin-1 file paths. Use blink::FilePathToString() instead for less breakage. Bug: 1017184 Change-Id: Iabf96f3dda129f60bb03fbe98dc33d89f0d0bb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888855Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#711628}
-
Marina Sakai authored
This CL removes a macro-generated fucntion for a private property of PopStateEvent, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol. Bug: 715418 Change-Id: Iaabcd308a18c20eabfa5c4c53ec32d5b72cd4fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893481Reviewed-by:
-
Marina Sakai authored
"kPrivatePropertyXXX" should be much easire to understand what the variables are for those who are not experts of bindings than "kSymbolKeyXXX". So, this CL renames the keys. Bug: 715418 Change-Id: I81d1a840a252184f80c6b4ddf61079fbe144a51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893597Reviewed-by:
-
nancy authored
BUG=1011235 Change-Id: Id3db4f6c2415009b33b6b1023270fde8a493c0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893595 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium bb5c6687. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I0da62a896e691d3028d0c3519cf84a9fd1d8c76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894812Reviewed-by:
-
Meredith Lane authored
Simple follow up CL to add a comment and link to bug that was mistakenly omitted during sheriffing. See: https://chromium-review.googlesource.com/c/chromium/src/+/1880408 TBR=tobyhuang@chromium.org Change-Id: I4d63454c6e9f960907bfa45a05cdc92fe54f5f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891812Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#711623}
-
Dmitry Gozman authored
Regressed by crrev.com/83d5d416. DidObserveLoadingBehavior should come after DispatchDidCommitLoad, and the order got reversed while moving DispatchDidCommitLoad call a bit later in the navigation commit process. Bug: 1020082 Change-Id: I0c636f8d64b917a49902e560a38b1f0cb3c7bfe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893688Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#711622}
-
Justin Cohen authored
This reverts commit 856b8913. Reason for revert: This breaks iOS downstream. Original change's description: > Limit GN visibility of libxml for security audit control. > > This splits the libxml_utils helper classes into xml_reader and > xml_writer targets. The xml_writer can be safely used from any target. > The xml_reader has strictly limited visibility to locations that are > audited by the Security Team. Direct access to the libxml target is now > also limited. > > Bug: 699306 > Change-Id: I141de7d855f5cb8e886e99403e048cf331f7320c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884750 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711536} TBR=rohitrao@chromium.org,dcheng@chromium.org,davidben@chromium.org,thakis@chromium.org,reillyg@chromium.org,zmin@chromium.org,rsesek@chromium.org Change-Id: Iaeae81ddebcf43482fbd3c26b806147a8147d0fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 699306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893967Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#711621}
-
Kevin Qin authored
There are 3 more OpenXR events that require actions: 1. XrEventDataInstanceLossPending: Destroy instance and exit presentation 2. XrEventDataInteractionProfileChanged: change WebXR input profiles 3. XrEventDataReferenceSpaceChangePending: Update Local to Stage Space transform Fixed: 1020354 Change-Id: I03ac3ef5fe4fcd70d4f1943c389456ca72ef1a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842615 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#711620}
-
Nick Diego Yamane authored
Since non-Ozone X11 PlatformEvent implementation is meant to be migrated soon to use ui::Event, as ozone path currently does, it makes sense to move it to a separate class. This is what this CL does, and in a follow-up change, tests will be modified to re-use this new class so that we can ensure ui::EVent's construction is equivalent to the one used in current Aura/X11 code. Also, this prepares X11EventSource delegate implementations to be refactored to use the same interfaces to comunicate about X11 events (e.g: event translation, XEventDispatcher, etc). Such change will be sent soon in separate CL. Bug: 965991, 1008755 Change-Id: I6153ad7ff1e3c2f5baf4b94df6a13af4ca7fe71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866752Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#711619}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ia5a262a69e0e2000ff371afd8a6ea9dd4cdf341d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893966Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711618}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/283ec65f632a..7f680a638e96 git log 283ec65f632a..7f680a638e96 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@7f680a638e96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: I8691c653ccdfdbbcae1c207abdd4bb66a6faf8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894856Reviewed-by:
-
Peter Kotwicz authored
This CL makes WebappActivity use CustomTabActivityNavigationController This requires: - Introducing a webapp specific implementation of CustomTabActivityTabController (WebappActivityTabController) - Adding a parameter to SingleTabModel so that SingleTabModel#closeTab() uses CustomTabActivityNavigationController's fancy logic for finishing the activity BUG=1016650 Binary-Size: Methods added/removed measured by binary size trybot are due to function inlining Change-Id: Ibb60d28298e20c51bebbdd73d10f77106acf7f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877600 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711616}
-
Anand K. Mistry authored
This option is either ignored by cros-disks, or ineffective. cros-disks now takes an opinionated, mount-specific approach to unmounting. Bug: 1019975 Change-Id: Ib85d2cf450fd943fd28b063254f5f7628ed5fe03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866092Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#711615}
-
Mingjing Zhang authored
This CL provides a basic level of debug info for a DCHECK failures in frame sequence tracker. The debug info is helpful to determine the tracker type when DCHECK failure occurs. Related to Bug: 1017291 Change-Id: I65e90697d283e0540d7d11dfbece278d25e0be6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893523 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a936069d60ce..385f3caebd48 git log a936069d60ce..385f3caebd48 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 oysteine@google.com Merge "Do not add samples/callstack which reference invalid data" Created with: gclient setdep -r src/third_party/perfetto@385f3caebd48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1661f9591b60d941de29671a245ab005f4bfb56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894855Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cdc22769d474..fb03935bedd7 git log cdc22769d474..fb03935bedd7 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 enga@chromium.org Add a GetInstanceProcAddr helper for the native Vulkan backend. 2019-11-01 enga@chromium.org Revert "Implement readonly storage buffer - validation at API side" 2019-10-31 yunchao.he@intel.com Implement readonly storage buffer - validation at API side Created with: gclient setdep -r src/third_party/dawn@fb03935bedd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I40b0bb56af6efeade53e3f8366dd6acc080bf652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894854Reviewed-by:
-
Jay Harris authored
This was caused because PendingAppManager's shortcut_manager_ was not being initialized in SetSubsystems. It was not caught by existing tests because we disable shortcut creation in tests, as it's hard to clean up afterwards. In a followup CL I'm going to try and push shortcuts being disabled further down the stack. Bug: 1019319 Change-Id: I91d8b22eb5cdba67a23481db778e0c4f9724e632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890394Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#711611}
-
Regan Hsu authored
Currently, if you tap on some sections (see Before screenshot), the focus highlight is chopped, because only those pixels can trigger the link. This CL extends the link to fill the space that was previously missing, which also extends the focus highlight to fill the missing space. Before screenshot: https://screenshot.googleplex.com/8d5h2kok95m After screenshot: https://drive.google.com/drive/folders/1fKpbwx3C0_REo1McC3JyYX68ng3b-sTA?usp=sharing Bug: 1008361 Change-Id: Ibc89b79294e7ee7c9b9285ab8f80ce3b3768689e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879445Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711610}
-
John Lee authored
- Track thumbnails only if they are currently in view or are just a standard finger swipe away. - Do not track thumbnails for pinned tabs. - Do not track thumbnails when the tab strip is closed. Note that this CL does not implement actually untracking thumbnails. It merely calls the method in the C++ side that will eventually do it. Bug: 1015132 Change-Id: I16cce4a71ad3e6e887555be27e1525cdef9beb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894245Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711609}
-
Abigail Klein authored
Use the accessibility event recorder to capture events fired on a page, and display the log on chrome:accessibility. This log isn't particularly meaningful for now, but follow-up CLs will make this be more useful. Bug: 785493 Change-Id: I5bf88bc070ac7df322cb41847a86642cbf038483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823617 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711608}
-
