- 21 Oct, 2019 40 commits
-
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I580879e2dc32f13383b5d9d2b4dc44a7fdd3460e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872160Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#707992}
-
Allen Bauer authored
If a dialog/sheet is constructed and destroyed having never been shown, the normal tear-down sequence never happens. This change ensures that the underlying NSWindow had actually been invoked as a sheet. If not, immediately initiate destruction. Bug: 1000893 Change-Id: I9a7947db38bd1edcdda64627507fdfc834b127ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869403Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#707991}
-
Lan Wei authored
For the case that the snap point is the same as the scroll position, we set the snap_at_gesture_scroll_end flag to be true, but there is no scroll snap animation happen, We pass a callback of setting hover state dirty to snap function, and when the snap point is the same as the scroll position, the callback will be executed to update the hover state right away. Majid's CL to change SnapCoordinator::PerformSnapping to return true when the snap point is the same as the scroll position: https://chromium-review.googlesource.com/c/chromium/src/+/1769044 Bug: 877132 Change-Id: I4cfc1bf03ee980b4b68e74aad79a8bec6a906da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790259 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707990}
-
Robert Liao authored
Individual classes now extend from Microsoft::WRL::RuntimeClass. BUG=1014283 Change-Id: Ic56344114a2b0432d0d29992a3dab8896ab2ae39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863551 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#707989}
-
minch authored
Bug: 1002733 Change-Id: I6254d5d5feeb1e6fa1fcb72b8109453523683b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867094Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#707988}
-
Sophie Chang authored
Bug: 968542 Change-Id: I5f2846630bb5ff1a4f648b59bbe332c7e557b121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871330Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707987}
-
Mikel Astiz authored
This adds basic support for persisting encryption keys on disk using a dedicated file (intentionally outside sync's directory), containing an encrypted protocol buffer as introduced in this very patch. Bug: 1012660 Change-Id: Ie9fedae86799f412703914dbfec53e3d0b85a2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865324 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707986}
-
Mirko Bonadei authored
While testing the WebRTC component build in [1], there was a problem with some testonly code Chromium depends on (which cannot be part of the WebRTC component). In order to support this use case, [2] will make the testonly code needed by Chromium depend on the WebRTC component and this CL is needed in order to land everything in an incremental fashion. [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1868961 [2] - https://webrtc-review.googlesource.com/c/src/+/157427 Bug: webrtc:9419 Change-Id: Ie995af67a7ab4ba1a2e5bb012f2e9b33be056acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872937Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#707985}
-
Sammie Quon authored
Caused regression in attached bug. UX still wants this will try to possibly re-enable this for M-80. But for M-79 we should disable it. TBR=oshima@chromium.org Test: none Bug: 1016047 Change-Id: I41bee546750b712b575ff3ed70a6245009bcf0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872767 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#707984}
-
Jeroen Dhollander authored
This DCHECK was caused because the Embedded Assistant UI tried to grab the focus while it was being closed. This |RequestFocus| call was added explicitly to fix a bug where the input text field in the Assistant UI would lose focus when submitting a query while in tablet mode. And this was happening because we tried to dismiss the virtual on-screen keyboard. I added unittests to test for these 3 scenarios, and I fixed it by dismissing the virtual keyboard using a |HideKeyboard| method instead of dismissing it by dropping the focus of the text field. Bug: b/141945964 Change-Id: I3aca9e08ab0e2b7419cfe53c1f4dc831130cd0df Tests: Added unittests and verified manually Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848796 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#707983}
-
Torne (Richard Coles) authored
These log messages aren't generally interesting, and sometimes can be confusing, especially to developers of WebView apps who see these printed by their own applications and may not understand them. Reduce their log levels to debug (which causes them to be stripped in official release builds) or otherwise make them conditional. Fixes: 1016010 Change-Id: I5f2375e87c9bc007723dc41c5e1276693fd5ddcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869288 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#707982}
-
Nick Harper authored
Change-Id: I22cf05ba9b9e7230c2a993e7aed9cceeecce6b1a Bug: 1009630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835181Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#707981}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f50bdda1019..4036a6d8ac64 git log 4f50bdda1019..4036a6d8ac64 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-21 bsalomon@google.com Simplify sk_gpu_test::MakeTextureProxyFromData. 2019-10-21 halcanary@google.com SkPDF: simplify Producer metadata logic 2019-10-21 kjlubick@google.com [canvaskit] roll to v0.8.0 Created with: gclient setdep -r src/third_party/skia@4036a6d8ac64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I5538e0081db1f88d025c248fad349d7b4f9acb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872834Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707980}
-
Toni Barzic authored
In tablet mode, swiping up from hot seat when an app window is active is expected to transition to home screen, with app window bounds collapsing into associated app item bounds within the home screen (if the app is shown on the home screen). If the app item is not visible on the home screen (e.g. it's not in selected page, or if it's in a folder), the app window bounds collapse into the center of the apps grid. To achieve that, home screen controller has to expose the expected app list item bounds for an aura window that is being swiped off the screen (similar how it's done for shelf icon position, that is used when minimizing windows in clamshell). In addition to logic for getting an item bounds in the apps grid, this adds kAppIDKey property to aura::Window. The property is used to map a aura window to an app ID. It's similar to kShelfIDKey,which is used to map a window to a shelf item. Generally, the app ID in shelf ID and app ID should be equal, but they handle (unpinned) browser shortcut items differently - if a browser window app item is not present in the shelf, ShelfID key will change to chrome item (so the browser bounds collapse into the chrome icon). kAppIDKey will always contain the app ID that is associated with the active browser web contents. BUG=997885 Change-Id: Iec3c80ba02c6a5f277eaa44f01f6b370275fe3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864360 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#707979}
-
Andrew Xu authored
When no arrow button shows, the app icons are chopped under RTL. The reason is that |available_space_| is not adapted to RTL. The issue is not reproducible under overflow mode. Because in overflow mode, |available_space_| happens to be the same with the mirrored one. This CL fixes such an issue by mirroring |available_space_| for the horizontal shelf under RTL. Bug: 1016271 Change-Id: I76ec521048b34da9fad97b8d0af6bfd3b8ebb327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872800 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#707978}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c4835b8523b1..488a0bd3c7d3 git log c4835b8523b1..488a0bd3c7d3 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 rharrison@google.com Rolling 4 dependencies, small script fix and updating expectation files (#844) Created with: gclient setdep -r src/third_party/shaderc/src@488a0bd3c7d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I29aa35538eb74b1bad865b5597a2c1cb37f634e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872919Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707977}
-
Manu Cornet authored
Extend the hotseat in overview mode, and hide it in split view mode. Bug: 1009550, 1009716 Change-Id: I2494c07a2d9bf486ffd4be5a0da4779c855cd59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872189Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#707976}
-
Tom McKee authored
The added tests exercise the construction of PerformanceMark objects and make sure that simple script values can round-trip through the "detail" attribute. An unnecessary parameter was also removed from PerformanceMark's constructor. Bug: 805566 Change-Id: I63e7980235a1d8f9c3b79ba06131bbbe5aee5ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872455 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#707975}
-
Federico Paredes authored
R=avi Bug: 1016011 Change-Id: I609c2958e52d837e1f43b0fd7497ba2013314086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872561Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Federico Paredes <fedpar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707974}
-
mark a. foltz authored
This converts TODO(foo@) to TODO(crbug.com/XXX) in the Mirroring Service code. It also ensures that TODOs reference an open crbug. No functional change. Change-Id: I34ea1dfea02d016fba87bf7125a90e08be92a8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867092Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707973}
-
liberato@chromium.org authored
UpdateDefaultTarget can be used to update the default target value that will be used to complete the observation if the controller is destroyed before CompleteObservation is called. A default value may be added, changed, or removed. Change-Id: I700ad31cb56e60a15e31c43367377336f4c1ad74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863593 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#707972}
-
Ian Barkley-Yeung authored
Improve accessbility for system info subpage of Feedback by marking empty cells in the table as aria-hidden. This really does improve the navigation experience. BUG=chromium:1005567 TEST=Ran system info under ChromeVox. Navigated around page, expanded and collapsed sections, etc Change-Id: I6397357552b6c4a78afaafc56a3fd1b4db5e8c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869888Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#707971}
-
Mia Glaese authored
CL has no user visible changes. Restructuring TasksSurface with AppBarLayout. Adapting StartSurface and sub components to work with new layout. Before: RecyclerView inside NestedScrollView did not recycle views. Now: RecyclerView recycles views inside CoordinatorLayout. Bug: 1000295 Change-Id: I73b01f1f4efcb7e263894b64e2b0f81a07229f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865399 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#707970}
-
Willie Koomson authored
DCHECK(arc_is_booting_) in ABPTO::OnArcInitialStart() was consistently being hit in debug mode. This is because OnBootCompleted() is actually called before OnArcInitialStart(), so arc_is_booting_ is already set to false by the time OnArcInitialStart() is run. Bug: b:133417350 Test: ABPTO unittests Change-Id: I023ee2841e7ed986b68bab06df1a57d1ac6ac8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872415 Commit-Queue: Willie Koomson <wvk@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Willie Koomson <wvk@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#707969}
-
Ella Ge authored
These two metrics are no longer in use. Bug: 988654 Change-Id: I736e104afcc5741b315f5e974fe741758710351b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872760Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#707968}
-
Stephen Martinis authored
This allows some statistics to be gathered about them. Bug: 1015682 Change-Id: I7a67c284f5a71b7280e69259b91553a90cbdb5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870010Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#707967}
-
Peter Kotwicz authored
This CL changes the status bar colour used by TWAs when in night mode. This CL makes TWAs use the default theme colour instead of the toolbar colour provided in the TWA launch intent. This CL also: - Adds TabThemeColorHelper#isDefaultColorForced() in order to discriminate between reasons why TabThemeColorHelper#isDefaultColorUsed() returns true: - Using the default theme colour because using the default theme colour is forced (e.g. previews, night mode) - Using the default theme colour because the web contents do not specify a custom theme colour - Adds TabObserver#onDidChangeForcedThemeColor() to listen to changes in TabThemeColorHelper#isDefaultColorForced(). BUG=997796 Change-Id: I490e8ebe6c28b4dbe3b01112acd327e307efedb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795571Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707966}
-
Tatiana Buldina authored
Bug: chromedriver:3155 Change-Id: I545ab145a03eef9e79b38560767bda05608f12f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872626Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#707965}
-
Ella Ge authored
In scroll prediction, we set the resampled event time to the prediction_time (frame time or the timestamp we try to predict to). However some predictor (linear resampling) may change the sample time. LinearResampling changes it to frame_time - 5ms. This causes the prediction metrics (introduced in crrev.com/c/1764409) comparing the predicted result with wrong interpolated point. This CL makes the predictors' return value (InputData type) also applies the actual predict time. Change-Id: Ib84db552f7e41976b9418e57056d9948781c2c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848111Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#707964}
-
Xianzhu Wang authored
The difference is caused by our recent change of layer tree dump format. TBR=wangxianzhu@chromium.org Change-Id: I7fd67b06ca19d723f395963d15eeb870c266d712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872765Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707963}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a0aed87f7121..62b68fec1b2c git log a0aed87f7121..62b68fec1b2c --date=short --no-merges --format='%ad %ae %s' 2019-10-21 lindsayw@google.com Pin mac_toolchain to 9a1adc55bf4a1173784da3ba2f8cb06421606748 2019-10-21 machenbach@chromium.org Presubmit: Fix relative owners check 2019-10-21 ehmaldonado@chromium.org depot_tools: Clean up auth.py Created with: gclient setdep -r src/third_party/depot_tools@62b68fec1b2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:978867,chromium:1015444,chromium:1001756 Change-Id: I7be7089266d49aa4f918f42cddce7bc455b665d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872763Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707962}
-
Michael Spang authored
Fontconfig APIs that use the default config (config == nullptr) trigger periodic automatic updates of font lists. When fontconfig is used on multiple threads, as in Chromium, such a scan is able to free the default config while it's being used by another thread. Disable background scans to avoid this issue. This doesn't have any effect on call sites that pass the config explicitly, including those that pass the result of gfx::GetGlobalFontConfig(). Bug: 1004254 Change-Id: If7aa1b3d7b5823c3c93717557349a9d327ca2672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872467Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707961}
-
Henrique Ferreiro authored
Convert the implementation and all users of the url::mojom::UrlTest interface. Bug: 955171 Change-Id: I2a074fb44c0fa3c761fb16404e1c473cf9d4b53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864778Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#707960}
-
Tom Anderson authored
Roll wanted for cd51cb2, which makes changes to FONTCONFIG_SYSROOT that Chromium uses in testing. https://chromium.googlesource.com/external/fontconfig.git/+log/65087ac7ce4c..cd51cb241aad $ git log 65087ac7c..cd51cb241 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 akira Take effect sysroot functionality to the default config file 2019-10-08 akira Warn as well if no directory name for cachedir provided Created with: roll-dep src/third_party/fontconfig/src R=spang,dnicoara TBR=thestig Bug: None Change-Id: I4e153b770761421695b27726c841bda66904a88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871813 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707959}
-
Sam Goto authored
Per instructions on the Unido design doc [1], this is the (2-4) step in the process of creating a new Unido feature: 1) Add a new SharingMessage to the proto and update metrics mapping 2) Add your new SharingFCMHandler in SharingService constructor 3) Add a new feature in DeviceInfoSpecifics.EnabledFeatures 4) Add your enabled feature to SharingDeviceRegistration 5) Use SharingService to list device candidates, and use the new SendMessageToDevice to send messages Step (1) is here: https://chromium-review.googlesource.com/c/chromium/src/+/1867444 Steps (5) will follow in separate CLs, to ease reviewing and ease other features tracking how to integrate. Design Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit?userstoinvite=himanshujaju%40google.com&ts=5da89bb1&actionButton=1 Bug: 1015645 Change-Id: Ia1ca925c107fb9ffe2e148ed0a82997268464657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867125Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#707958}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/91b5a03b..56dc7021 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I390276168fe6863094fa2a81e653a45ca643dccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871894Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707957}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::EngineFileRequests interface. Bug: 955171 Change-Id: Ia3c314bb521e11a60c3562b976f4a70870977a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852248Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#707956}
-
Martin Kreichgauer authored
While at the CTAP layer, the excludeList parameter is optional, omitting it is equivalent to sending an empty array. Furthermore, an absent PublicKeyCredentialCreationOptions.excludeCredentials at the Blink layer is translated into an empty list at the Authenticator mojo interface (where the corresponding field is non-optional), which demonstrates that we don't care about the distinction anyway. Note that while previously, a present-but-empty CTAP excludeList was marshaled into an empty CBOR Array (inside `AsCTAPRequestValuePair(const CtapMakeCredentialRequest& request)`), this CL changes it to be omitted instead. Change-Id: I8cb72be56351057766c83eb097f9c780fb1567ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867385Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#707955}
-
Nicolás Peña Moreno authored
This CL removes window.location.href usage in element-timing tests and uses window.location.origin instead, which makes the pathname computation cleaner. It also adds t.step_func where it is missing. Change-Id: Iabaac33eb65f9ed24f68e7fa583c8de05d1264c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872762Reviewed-by:
Tom McKee <tommckee@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#707954}
-
Jordan Bayles authored
This patch uncomments out and updates/fixes the ChromeUdpSocket class, part of Open Screen's embedder platform code. Change-Id: Ia66f2e92336f99202b33be7c2636f805e2e0dca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851230Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#707953}
-