GitLab

Converting BookmarkModel and HistoryService to ProfileKeyedServices. This just performs the initial conversion. Separate CLs to take care of the removal of profile_->Get<Serivce> will follow.

BUG=97804,112525
TEST=no new, passes existing unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138867

Review URL: https://chromiumcodereview.appspot.com/10399087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141294 0039d316-1c4b-4281-b951-d872f2087c98

Printing.

BUG=131026
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10538059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141293 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit tests
BUG=131743


Review URL: https://chromiumcodereview.appspot.com/10535073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141292 0039d316-1c4b-4281-b951-d872f2087c98

This change adds the logic to release paused mediaplayers when another player requests for decoder.
Also, it addresses a NPE problem that RenderViewImpl could go away before WebMediaPlayerAndroid when closing tabs

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10533049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141291 0039d316-1c4b-4281-b951-d872f2087c98

- "Search" key to toggle app list;
- Remove old "Ctrl+Search" shortcut for app list;
- Remove ShellDelegate::Search since it no longer in use;

BUG=131703
TEST=Verify "Search" key toggles app list and old "Ctrl+Search" stops working.


Review URL: https://chromiumcodereview.appspot.com/10534053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141290 0039d316-1c4b-4281-b951-d872f2087c98

- We only take into account visible password fields now.
- We won't show an icon for forms that don't have a valid PasswordFormData.
  These forms would not be saved by the PasswordManager anyway.

BUG=130833,131317
TEST=Ran PasswordGenerationManagerTest


Review URL: https://chromiumcodereview.appspot.com/10540069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141289 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10541078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141288 0039d316-1c4b-4281-b951-d872f2087c98

Show Datalist elements in the new Autofill UI, properly separated from the other data and fully selectable.

BUG=51644
TEST=The datalist elements can be selected like normal autofill elements and unit tests pass.


Review URL: https://chromiumcodereview.appspot.com/10443084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141287 0039d316-1c4b-4281-b951-d872f2087c98

This is being submitted on behalf of shanhan@google.com, original CL at https://chromiumcodereview.appspot.com/10537037/ .

BUG=None
TEST=Built successfully using GCC-4.7 under linux
Review URL: https://chromiumcodereview.appspot.com/10543080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141286 0039d316-1c4b-4281-b951-d872f2087c98

Geolocation.

BUG=131026
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10543079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141285 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r133151.

BUG=124105
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10544015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141284 0039d316-1c4b-4281-b951-d872f2087c98

Previously it would always scan 150 lines, even if the file had more includes than that.

Also, break out of the loop once we reach the end of the file, rather than looping and testing the empty string until we hit the limit.

BUG=131315
TEST=In a file with lots of includes, introduce an illegal one at the end.  Run checkdeps.


Review URL: https://chromiumcodereview.appspot.com/10537069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141283 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10539015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141281 0039d316-1c4b-4281-b951-d872f2087c98

Fixed the above behavior. $$ is now parsed properly.

BUG=127243
TEST=browser_tests --gtest_filter=ExtensionApiTest.I18N


Review URL: https://chromiumcodereview.appspot.com/10544066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141280 0039d316-1c4b-4281-b951-d872f2087c98

Normal channel shutdown (as for navigation) goes via RemoveRoute(),
which removes the channel from the cache.  It looks like
OnChannelError() is expected to call RemoveRoute() at some point
during cleanup, but sometimes the channel is left in the cache and
re-vended (as measured by previous instrumentation).  Defensively
rename channels which see an error so that they aren't found in the
cache in the future.

BUG=97285
TEST=no user-visible change


Review URL: https://chromiumcodereview.appspot.com/10544075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141279 0039d316-1c4b-4281-b951-d872f2087c98

Previously the hook would try to use reply_message, despite it being
owned by a scoped_ptr in the NavigationNotificationObserver. This
resulted in a segfault when the page was already loaded, as the
scoped_ptr was deleting the object when the observer was deleted.

BUG=None
TEST=functional/apptest.py


Review URL: https://chromiumcodereview.appspot.com/10535081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141278 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130751
TEST=manual, prints #EOF on success but not failure


Review URL: https://chromiumcodereview.appspot.com/10538063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141277 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131260
TEST=gpu win debug bots
TBR=kbr
Review URL: https://chromiumcodereview.appspot.com/10545089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141275 0039d316-1c4b-4281-b951-d872f2087c98

Safe Browsing.

BUG=131026
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10539066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124914
TEST=System trya bubble views and borders should look the same.

Review URL: https://chromiumcodereview.appspot.com/10532071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141273 0039d316-1c4b-4281-b951-d872f2087c98

This switch controls use of NativeTextfield[Win|Views].

Enable and fix NativeTextfieldViewsTest on Windows.
Add switch&strings; hook up NativeThemeWin FocusableBorder colors.
Create InputMethodWin for --enable-views-textfield (or USE_AURA).
Consolidate NativeTextfieldWrapper::CreateWrapper impls.

TODO(followup): Fix 2*RequestFocus in unit test setup.
TODO(followup): Also toggle OmniboxView[Win|Views].

BUG=131660
TEST=NativeTextfieldViewsTest.*, use the flag to flip the find bar, bookmark bubble/edit, etc. (not omnibox yet)

Review URL: https://chromiumcodereview.appspot.com/10535046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141272 0039d316-1c4b-4281-b951-d872f2087c98

Remove widgets related to restoring the default browser from uninstall view when default settings cannot be restored.


BUG=123320
TEST=N/A


Review URL: https://chromiumcodereview.appspot.com/10453048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141270 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141269 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
CID=104188


Review URL: https://chromiumcodereview.appspot.com/10546075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141268 0039d316-1c4b-4281-b951-d872f2087c98

Remove old code that uses command-line passed to NaCl loader to find this
switch.

BUG= 131381
TEST= manual


Review URL: https://chromiumcodereview.appspot.com/10545085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141267 0039d316-1c4b-4281-b951-d872f2087c98

Password Manager.

BUG=131026
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10542078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141266 0039d316-1c4b-4281-b951-d872f2087c98

R=eroman@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10532067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141265 0039d316-1c4b-4281-b951-d872f2087c98

Do not add it to Dtrace and LogmanTrace yet since it requires more surgery. So
only enable the smoke test on linux.

R=cmp@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10541064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141264 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10540081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141263 0039d316-1c4b-4281-b951-d872f2087c98

This is part 1 of converting public synchronous functions in GDataFileSystem to asynchronous. 

Eliminate the helper class GDataFileProperties and the public synchronous function GetFileInfoByPath().
    
BUG=127048
TEST=unit_tests, browser_tests

Review URL: https://chromiumcodereview.appspot.com/10543037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141262 0039d316-1c4b-4281-b951-d872f2087c98

As part of the effort to build unit-tests on Android, this CL abstracts out
references to the Browser object from the extension install ui code.
For this, ExtensionInstallUI has been renamed ExtensionInstallPrompt and the
UI specific bits have been moved to a new class that took the old name
ExtensionInstallUI.

BUG=None
TEST=You should be able to install an extension.
     All browser tests/unit tests should pass.


Review URL: https://chromiumcodereview.appspot.com/10388252

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141261 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141260 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10544079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141259 0039d316-1c4b-4281-b951-d872f2087c98

Currently all VideoDecodeAccelerator::Clients use GL_TEXTURE_2D as their texture target.

Unfortunately the Mac decoder only supports GL_TEXTURE_RECTANGLE_ARB texture targets.

This CL allows decoders to choose which texture target they want.

BUG=127414
TEST=


Review URL: https://chromiumcodereview.appspot.com/10392141

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141258 0039d316-1c4b-4281-b951-d872f2087c98

Lifetime.

BUG=131026
TEST=no change


Review URL: https://chromiumcodereview.appspot.com/10537079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141257 0039d316-1c4b-4281-b951-d872f2087c98

crrev.com/140552 fixed the leak.

BUG=121450
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10534068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141256 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141255 0039d316-1c4b-4281-b951-d872f2087c98

r1410 Fix bug in ninja/msvs/scons generator when there's no default action.
r1411 Make backends robust to rules and actions containing slashes
r1412 ninja windows: support alternative entrypoints.
r1413 Fix make backend to correctly handle rules with output files of the same name

Review URL: https://chromiumcodereview.appspot.com/10536070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141254 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dominich@chromium.org
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10533066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141253 0039d316-1c4b-4281-b951-d872f2087c98

bartfab ran into this as a result of an unrelated patch he was testing. The logic in ScreenLocker should match that in LoginUtils, and not send this notification out if the password is blank.

BUG=chromium-os:31600
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10544043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141252 0039d316-1c4b-4281-b951-d872f2087c98