- 08 Jul, 2017 3 commits
-
-
Tien-Ren Chen authored
This CL reworks PaintChunksToCcLayer to handle effect grouping properly. Prior to this CL each paint chunk applies its property state all the way from the layer state then pop all the way back. This CL implemented an algorithm to lazily pop states so that contiguous paint chunks enclosed by the same effect will apply the effect atomically. As an optimization, clip region is also popped lazily. Note that this doesn't mean AA-clips are applied as a group but still apply to individual draw commands separately. It does improve performance by reusing previously generated clip region when a complex clip region applies to multiple chunks repeatedly. Rounded clip support is also added as a side change. Transforms are always applied on the spot. This is because we can compute the matrix between arbitrary nodes in O(1). Also this automatically handles "transform inversion" cases as we don't even need to detect the relationship between nodes. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I64657b657fad3e19132b9eb0d64db494955f2139 Reviewed-on: https://chromium-review.googlesource.com/540737 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#485109}
-
Jian Li authored
When the user open the downloaded page, a specific offline header is added in the request to mean to load the offline snapshot. In this case, the service worker interceptor should fall back in order for the subsequent offline page interceptor to bring up the offline snapshot. BUG=736917 TEST=new tests added Change-Id: I5e57ed437d7534bd54f6406d4d527c4599bd9a41 Reviewed-on: https://chromium-review.googlesource.com/557479 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#485108}
-
weidongg authored
If mouse press/release occurs between search key down and up, avoid toggling app list. This is helpful when user is chromoting from chromeos to other system which uses 'Win+Click' as a gesture. BUG=665897 TEST= ash_unittests --gtest_filter= 'AcceleratorControllerTest.GlobalAcceleratorsToggleAppList' ash_unittests --gtest_filter= 'AcceleratorFilterTest.ToggleAppListInterruptedByMouseEvent' Review-Url: https://codereview.chromium.org/2923723002 Cr-Commit-Position: refs/heads/master@{#485107}
-
- 07 Jul, 2017 37 commits
-
-
Qiang Xu authored
changes: Extracting a private method CalculateTransitionOffset for a view's current page. For new launcher, not only the all apps tiles, but also the new added views (indicators, suggested apps) should have transition offset. Change-Id: I8b65332f06ea7aea107b9b77081d8dbdf54c47d7 Bug: 735702 TEST: no functional/UI change Reviewed-on: https://chromium-review.googlesource.com/562589Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#485106}
-
eroman authored
Instead use an internally created sequenced task runer. BUG=689520 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2966283002 Cr-Commit-Position: refs/heads/master@{#485105}
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/554098. This shouldn't change the behavior. Bug: 686281 Change-Id: I8f98349b2ecbd8ba972189256f0dbf1c07ad73bd Reviewed-on: https://chromium-review.googlesource.com/557363 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485104}
-
pkotwicz authored
The check is no longer necessary after https://codereview.chromium.org/1354323003 BUG=713655 Review-Url: https://codereview.chromium.org/2973103003 Cr-Commit-Position: refs/heads/master@{#485103}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c2d9d2f7f16e..9a5b75ed3609 $ git log c2d9d2f7f..9a5b75ed3 --date=short --no-merges --format='%ad %ae %s' 2017-07-07 eakuefner [Tracing] Move Python DiagnosticRef into tracing.value.diagnostics 2017-07-07 benjhayden Formalize reserved diagnostic names. 2017-07-07 simonhatch Dashboard - Add tests for api/oauth.py. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3ada15db7730b24e7bc88fe04e8adec4c8c651b3 Reviewed-on: https://chromium-review.googlesource.com/564079 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485102}
-
Noel Gordon authored
Test is using two levels of runAfterLayoutAndPaint and is failing on the some bots (see bug 713049). Try using one runAfterLayoutAndPaint since that's all that should be needed after changing the element box-reflection CSS style. Bug: 713049 Change-Id: I448b6908044786cb9da45945b2aed370336c1353 Reviewed-on: https://chromium-review.googlesource.com/558540Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#485101}
-
Hiroshige Hayashizaki authored
According to the spec: Step 8 of "execute a script block": https://html.spec.whatwg.org/#execute-the-script-block This CL stops firing load events for - parser-inserted inline module scripts without async in HTML, i.e. those fall into 1st Clause of Step 23 of "prepare a script" (Issue 715369; This CL and [1] stop firing load events of all inline module scripts) - parser-inserted inline classic scripts that fall into 5th Clause of Step 23 of "prepare a script" (Issue 739514) [1] https://chromium-review.googlesource.com/c/557978/ Bug: 686281, 739514, 715369 Change-Id: Ia1a2e9653bccb99ff47faa1d8b8186c043e83770 Reviewed-on: https://chromium-review.googlesource.com/557972 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485100}
-
Aleksandr Derbenev authored
All build configurations except windows with msvc now output diagnostics with paths relative to the build directory. But msvc build uses absolute paths for diagnostic messages and __FILE__ macro. It also makes test launcher and gtest produce absolute paths to source code locations in the logs and summaries (it looks very weird for swarmed binaries and makes harder to find out where is the real location). I've switched to relative paths and checked that: 1. MSVC can correctly generates relative paths in diagnostics. 2. MSVS can correctly parse relative paths and use them to navigate the code in case of creating solution with gn gen --ide=vs (that was an issue to use absolute paths earlier). Switching to the relative paths makes build more determenistic also ( path to the build directory will not be included to the compiled object files when __FILE__ macro is used). To enable absolute paths back use gn argument: msvc_use_absolute_paths=true Bug: Change-Id: I4599fb4869849d5b9b6550406777a3d1e4476bf1 Reviewed-on: https://chromium-review.googlesource.com/558871 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#485099}
-
edchin authored
TabCollectionTabCell lazily retrieves snapshot images from SnapshotCache. This CL adds this capability and unit tests. This CL does not plumb the cache into the tab cell. This CL does not modify SnapshotCache to handle multiple image sizes. BUG=686770 Review-Url: https://codereview.chromium.org/2967083002 Cr-Commit-Position: refs/heads/master@{#485098}
-
zijiehe authored
DesktopCaptureOptions impacts which underlying DesktopCapturer implementation is used. But there is no guarantee that different DesktopCapturer implementations would eventually return the same SourceList, or a Source in the SourceList represents the same output content on the system. So DesktopCaptureBase and DesktopCaptureDevice should use same DesktopCaptureOptions. BUG=732224 Review-Url: https://codereview.chromium.org/2961193002 Cr-Commit-Position: refs/heads/master@{#485097}
-
chaopeng authored
Currently we don't support using ScopedFeatureList::* in SetUp for InProcessBrowserTest since we clear FeatureList at the beginning of InProcessBrowserTest::SetUp. In this patch, we remove the FeatureList::ClearInstanceForTesting() and move the feature change in InProcessBrowserTest to ScopedFeatureList. So we are able to move all feature list change calls SetUp and use ScopedFeatureList::*. BUG=713390 Review-Url: https://codereview.chromium.org/2876153002 Cr-Commit-Position: refs/heads/master@{#485096}
-
arthursonzogni authored
In every method of ChildProcessSecurityPolicyImpl, this CL makes url.scheme() being called only once. BUG=None Review-Url: https://codereview.chromium.org/2966203002 Cr-Commit-Position: refs/heads/master@{#485095}
-
erikchen authored
BUG=669240 Review-Url: https://codereview.chromium.org/2976533002 Cr-Commit-Position: refs/heads/master@{#485094}
-
chrome://media-internalssandersd authored
Buttons now contain: [player src or ID] [frame title] - [frame url] [resolution, codecs] [last event] Screenshot: http://i.imgur.com/ue2ibQJ.png Also removes the kCreated event from PipelineImpl. After this change, the first event reported by every MediaLog is WEBMEDIAPLAYER_CREATED, and we will be able to use that to improve log expiry. BUG=551065 Review-Url: https://codereview.chromium.org/2964713004 Cr-Commit-Position: refs/heads/master@{#485093}
-
kerrnel authored
Calls SetApplicationIsDaemon() to prevent crashing if LaunchServices cannot be connected to. This CL also allows the com.apple.lsdb.mapdb service which exposes the LaunchServices database. BUG=689306 Review-Url: https://codereview.chromium.org/2944623003 Cr-Commit-Position: refs/heads/master@{#485092}
-
sandersd authored
This class wraps a gpu::gles2::GLES2Decoder* to provide utility functions for VDAs. BUG=522298 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2938543005 Cr-Commit-Position: refs/heads/master@{#485091}
-
Adrienne Walker authored
This is pre-refactoring for a future patch where PaintFlags stores PaintShader directly. As PaintFlags is often copy constructed, it doesn't make a ton of sense to have a unique_ptr PaintShader. This makes it an sk_sp ref counted time for similiarities to all of the other paint type refcounting. Bug: 737629 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0b4ea8285f375180f8abceb86c984d42491ff41a Reviewed-on: https://chromium-review.googlesource.com/560669Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#485090}
-
Fady Samuel authored
This CL moves: cc/resources/resource_format.h => components/viz/common/quads cc/resources/resoure_format_utils.{cc|h} => components/viz/common/resources cc/resources/platform_color* => components/viz/common/resources. This CL also moves out the functions in resource_format to resource_format_utils. The rest of the changes are just updating includes, namespaces and DEPS. TBR=piman@chromium.org, reveman@chromium.org, junov@chromium.org Bug: 722935 Change-Id: I4b861448df64f08733dac254525f1770336f9254 Reviewed-on: https://chromium-review.googlesource.com/563737 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#485089}
-
holte authored
BUG=739971,734091 Review-Url: https://codereview.chromium.org/2976453002 Cr-Commit-Position: refs/heads/master@{#485088}
-
smut authored
Bug: 738255 Change-Id: Ib00bbc4e7ca58868ed29dd72111042b29c74aa56 Reviewed-on: https://chromium-review.googlesource.com/562566Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#485087}
-
Alexei Filippov authored
Bug: 727780 Change-Id: I57046e86809b4f515b6856bf072c11cadd1bd45f Reviewed-on: https://chromium-review.googlesource.com/562976 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#485086}
-
Alexei Filippov authored
It was caused by the stale timeToPixel ratio during zoom animation. Request the actual ratio from the chart viewport. Bug: 735584 Change-Id: I52a39c9377c9ae770a51e7f962426fc92dec8ec6 Reviewed-on: https://chromium-review.googlesource.com/562545Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#485085}
-
Jeff Carpenter authored
This is to verify recent changes to the exporter are functioning properly. Bug: 740176 Change-Id: I1fb68dafff0c3b760f3f50abe8300d3ead5124f4 Reviewed-on: https://chromium-review.googlesource.com/563958Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#485084}
-
Hiroshige Hayashizaki authored
Follow-up of https://chromium-review.googlesource.com/c/554098. This shouldn't change the behavior. Bug: 686281 Change-Id: Ia8ba4ac41aafc2851ba58389b4dd8d7d5910a226 Reviewed-on: https://chromium-review.googlesource.com/557381 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#485083}
-
Sky Malice authored
Bug: 740221 Change-Id: I59bcfd1a9a6a27b00d41ba9fee65f24b7dd0fc73 Reviewed-on: https://chromium-review.googlesource.com/564177Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#485082}
-
Peter Beverloo authored
We added this check many years ago in response to a security issue where sender IDs weren't appropriately checked on the server. The check is the reason that extensions cannot use GCM Topic Messaging (because the `from` field for such messages is set to the topic, not the sender), and we may be missing out on unsubscription opportunities for Web Push too. The server-side issue has since been fixed, as confirmed by the GCM team. The check adds complexity and blocks a reasonably popular feature from being used by extensions, so let's just drop it. BUG= Change-Id: I1208548a583b97210628c5c72588587b2df48e72 Reviewed-on: https://chromium-review.googlesource.com/559145Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#485081}
-
Tommi authored
BUG=689520 Change-Id: Ida4b4b15a265d3a5bec6484d5dc4922df7f7334b Reviewed-on: https://chromium-review.googlesource.com/563359Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#485080}
-
Alexei Filippov authored
Change-Id: I1b54003924e3c35c04fb9781820dced4830afde7 Reviewed-on: https://chromium-review.googlesource.com/545238 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#485079}
-
hcarmona authored
BUG=737739 Review-Url: https://codereview.chromium.org/2965493003 Cr-Commit-Position: refs/heads/master@{#485078}
-
Bret Sepulveda authored
TBR=guidou@chromium.org Bug: 740251 Change-Id: I8bd65c5fdf55437778ee21ed4f98b74a60c11589 Reviewed-on: https://chromium-review.googlesource.com/563774Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#485077}
-
Chris Harrelson authored
for the clip mask. The actual PaintLayer that the mask applies to may have a much smaller visual rect (or even empty), but nevertheless have a child which is not empty. If the visual rect were too small, some paint ops may not be rastered. Bug: 736661 Change-Id: Ib61766057e36f83cfab2be35d08c7773d2b676e1 Reviewed-on: https://chromium-review.googlesource.com/562614 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#485076}
-
Brett Wilson authored
This brings the first part of the .cc file in line with the header, as promised in the patch that ordered the header. Remove 2 obsolete items in the header that had no definition, and re-sort one thing added in the wrong place. TBR=pkasing@chromium.org Change-Id: I6427c182d11cd164d3a0ac42fc0280d8bd806730 Reviewed-on: https://chromium-review.googlesource.com/562646 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#485075}
-
Bruce Dawson authored
pe_summarize.py is used to summarize the sizes of the sections in a PE file (a DLL or EXE). It can also summarize the differences between two PE files which is handy when investigating size regressions. The original version of this script assumed that section names matched exactly but this assumption does not always hold. This assumption breaks when comparing 32-bit PE files to their 64-bit counterparts, and it breaks if the size regression includes some new sections being added. So, this change updates the script to handle these mismatches, to increase flexibility and prevent confusion. I tested this change with the before/after versions of chrome_watcher.dll associated with crbug.com/717103. It listed all the changed sections and gave consistent total differences. BUG: 717103 Change-Id: I923e2655605333a72f0c9e3b9eecf6f7ec2a62d3 Reviewed-on: https://chromium-review.googlesource.com/563763Reviewed-by:
Stanislav Chiknavaryan <stanisc@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#485074}
-
rdevlin.cronin authored
Setting the lastError property is implemented natively with native bindings, and the JS version should never be used. Don't load the lastError module when native bindings are enabled to enforce this. BUG=653596 Review-Url: https://codereview.chromium.org/2959583002 Cr-Commit-Position: refs/heads/master@{#485073}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/ec045b431211..9b80ffc77b80 $ git log ec045b431..9b80ffc77 --date=short --no-merges --format='%ad %ae %s' 2017-07-07 ethannicholas converted GrCircleBlurFragmentProcessor to sksl 2017-07-07 borenet Add infra OWNERS Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ib606ef3d5bd97425b622220520af5673b3efcb48 Reviewed-on: https://chromium-review.googlesource.com/563469Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485072}
-
Sorin Jianu authored
Also, make the clean up of stale jobs more aggressive. TBR=waffles Bug: 737730 Change-Id: I61bf9831aa5f753003c10ef50169a81a2545792a Reviewed-on: https://chromium-review.googlesource.com/563765 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#485071}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1e3b1949cdcd..c2d9d2f7f16e $ git log 1e3b1949c..c2d9d2f7f --date=short --no-merges --format='%ad %ae %s' 2017-07-07 kraynov Android systrace: Process dump agent and importer scaffolding. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I69109dce7b4f7d91d0985d6511222796980aad7d Reviewed-on: https://chromium-review.googlesource.com/563646 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#485070}
-