GitLab

This CL aligns time zone dropdowns to match the radio buttons labels.

Bug: 800597
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I231f970d90ff3d6fd47d97aeded2ec58ecd31173
Reviewed-on: https://chromium-review.googlesource.com/898398
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534587}

This doesn't actually fix anything, but logs a message instead of crashing.

Bug: 805864
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If377b859a173b79cd30d01fb71624d376a50902e
Reviewed-on: https://chromium-review.googlesource.com/887578
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534586}

This is appearing in crash reports, but should not happening. The
CHECKs can help narrow this down.

Bug: 805726
Change-Id: I248ac37c310824c5764c902f6e70c7b37fc5ceaa
Reviewed-on: https://chromium-review.googlesource.com/892385
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534585}

This reverts commit 58ff4fa5.

Reason for revert: crbug.com/808934

Original change's description:
> Remove browser side GPU info collection on Android.
>
> The last bit is pre-lollipop Android blacklisting for accelerated_video_decode.
> To handle this, we query it on renderer startup from GPU process (through
> GpuChannelHost). This will cause slight renderer startup perf regression, but
> only on older Android systems.
>
> This is the LAST piece of this refactoring.
>
> BUG=744658
> TEST=bots
> R=​piman@chromium.org,kbr@chromium.org
>
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ie2773a15ed10d27e04364a18f1aa49cd0843280c
> Reviewed-on: https://chromium-review.googlesource.com/894734
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Commit-Queue: Zhenyao Mo <zmo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533772}

TBR=sky@chromium.org,boliu@chromium.org,zmo@chromium.org,kbr@chromium.org,piman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 744658,808934
Change-Id: I0ab7be945b1b069e4ff34500bd5e0868da14aabe
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/902682
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534584}

No intended behavior change. Makes it a bit easier to see what's left to do.

Bug: 177475
Change-Id: I314ba2f05db5ebbf8a8cb8cbfaad049f5b34e581
Reviewed-on: https://chromium-review.googlesource.com/902843Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534583}

Since 10.13, a trip to the runloop seems to be been necessary to ensure
[NSApp orderedWindows] updates inside WidgetTest::IsWindowStackedAbove().

Unforunately, flushing the runloop exposes the test to window server
events which can cause asynchronous activation events to be interleaved
with other parts of the test. To deflake, run the test interactively,
and sync with the window server whenever a new window is raised.

Earlier attempt in https://crrev.com/c/590332 caused flakes on 10.12.

Bug: 749905
Change-Id: Ifde8800e0966233cfeea41515b66b0fc2926317d
Reviewed-on: https://chromium-review.googlesource.com/899806Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534582}

This CL does two things:
1. Makes the completion callback a OnceCallback.
2. Allocates a single callback on the heap, rather than binding one with
   the call to Core::StartURLCheck, and then copying one on the heap.

This shouldn't affect memory use, but it does make the memory usage
of the callback more apparent, and avoids copying it around.

Bug: 806981
Change-Id: I8830f5e4e8379ebfd4d67c5333877d5532e12428
Reviewed-on: https://chromium-review.googlesource.com/902862Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534581}

This CL changes the ownership of base::Clock and base::TickClock from
injectee-owned to injecter-owned. Before this CL, these instances are
owned by the owner of the injectee or one of the injectees themselves.
That makes the ownership handling complex.

After this CL, the injectee of clocks never own the clock. Instead,
injecters owns a clock for testing, and a shared clock is used on the
production code.

Bug: 789079
Change-Id: Ia4fdba667a6e93cfa1cd9e982fb18b012dac6ada
Reviewed-on: https://chromium-review.googlesource.com/899323Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534580}

ShelfWidget and StatusAreaWidget have a complex shutdown dance.
Eliminate the StatusAreaWidget::Shutdown() pass. Make StatusAreaWidget
and its child views explicitly owned to make the lifetime management
more clear.

multiple monitors, shutdown with system tray bubble open

Bug: 700255
Test: ash_unittests, manually test add/remove monitor, shutdown with
Change-Id: Ib218cdafe27799945760056d7bac8ce06f795f12
Reviewed-on: https://chromium-review.googlesource.com/902819Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534579}

https://skia.googlesource.com/skia.git/+log/d0b9c5093e04..f7b659ab3ce2

$ git log d0b9c5093..f7b659ab3 --date=short --no-merges --format='%ad %ae %s'
2018-02-05 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 22294b041..b54206643 (2 commits)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bsalomon@chromium.org

Change-Id: Ibf47bdcfcf421a0d921d6cc79d142515bf847dd7
Reviewed-on: https://chromium-review.googlesource.com/903074Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534578}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2aef9c11251f..a0d25d76f116

$ git log 2aef9c112..a0d25d76f --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I794edaa63d9ea08a7db5beb8bc736d79131bed60
Reviewed-on: https://chromium-review.googlesource.com/903184
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534577}

Bug: 800970
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifdfa802f6eb36414bc51d0442f572eafbf089a54
Reviewed-on: https://chromium-review.googlesource.com/887728
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534576}

Content type "message/rfc822" is interpreted as MHTML on Windows.
Google Drive and some other appes choose to serve "message/rfc822" for
MHTML files. So we should also support opening this type of content.

Since now "message/rfc822" can be rendered in Blink, we also force
downloading it if from the remote server.

Bug: 758690
Change-Id: I8cbe1a16f35239e805492a2abf381e2b04602f8e
Reviewed-on: https://chromium-review.googlesource.com/898249Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534575}

Resizable window's border should not be considered the target
by default, because overlay can become the target if the mouse is
at the edge.

BUG=b/72711995
TEST=Covered by unittest

Change-Id: Id68b8ee4b3976d370b289032b88749a896ed5e3b
Reviewed-on: https://chromium-review.googlesource.com/900499Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534574}

On Mac, material design ripples are disabled. This causes a bug where the
highlight that shows up when a normally-ripple-enabled button is hovered
suddenly disappears when the button is clicked. This is especially noticeable on
long-pressing buttons, where there is no visual indicator to show the button is
still pressed, even when the mouse button is still being held down.

Fix by allowing the highlight to show on ripple on Mac.

Bug: 795224
Change-Id: Ibc5a0cce4d50c3b4e6a77763ec50af264c1db2d0
Reviewed-on: https://chromium-review.googlesource.com/896724Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534573}

Bug: chromium:807886
Change-Id: I2f5cad8e023c8a6f7e27a29a8579c0a5070754c7
Reviewed-on: https://chromium-review.googlesource.com/902562Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534572}

Calls from Android framework can be made after ContentViewCore
is destroyed. This CL adds null check against mWebContents when
getting WebContentsAccessibility instance to avoid NPE when
it happens.

Bug: 803244
Change-Id: Ic45932b2d378cfb557aaec3d23ae615d2e13a322
Reviewed-on: https://chromium-review.googlesource.com/899406Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534571}

https://chromium.googlesource.com/catapult.git/+log/ef4265e56abb..6d0f862d8710

$ git log ef4265e56..6d0f862d8 --date=short --no-merges --format='%ad %ae %s'
2018-02-02 dtu [pinpoint] Remove _MAX_REPEAT_COUNT. Add Attempts one Change at a time.
2018-02-05 mcdavid Fix NamedDeviceTemporaryDirectory leak with contextlib_ext.Optional
2018-02-05 eakuefner [Telemetry] Simplify and test HtmlOutputFormatter
2018-02-05 eakuefner [Telemetry] Use ShouldAddValue to filter histograms

Created with:
  roll-dep src/third_party/catapult
BUG=809192


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I52864e65189f7e09ceebcc9c59d45c7e50860925
Reviewed-on: https://chromium-review.googlesource.com/902960
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534570}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a58470f2..03c145da

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I0531dacb75cb5dfb1a56b9d5c703090552d27480
Reviewed-on: https://chromium-review.googlesource.com/902726Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534569}

This patch Introduces |VisibleUnitsWordTest.NextWordPunctuation| test to record
current behavior of |NextWordPosition()| as a preparation of the patch[1].

[1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify
word/paragraph selection

Change-Id: I022926f5b725626b98e51f2a2b698bfefc6986ab
Reviewed-on: https://chromium-review.googlesource.com/901102Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534568}

This reverts commit 2d2b87e5.

Reason for revert: Causes build failure on Google Chrome Linux x64:
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/27255

Original change's description:
> Add support for Switch Pro Controller on Linux
> 
> BUG=749295
> 
> Change-Id: I939cc7ab58cc9a8196fe728c926341f4ccebea20
> Reviewed-on: https://chromium-review.googlesource.com/887253
> Reviewed-by: Brandon Jones <bajones@chromium.org>
> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534563}

TBR=bajones@chromium.org,mattreynolds@chromium.org

Change-Id: Ie3b35357e131dd10291fec0b4ec06227b03f0c7b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 749295
Reviewed-on: https://chromium-review.googlesource.com/903103Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534567}

Change-Id: If11cfc47b3ad2f242ca3bd1a0d7690321bfad386
Reviewed-on: https://chromium-review.googlesource.com/902952
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534566}

This is a follow-up of crrev.com/c/900602 to verify that offset mapping
works in these cases.

Bug: 699017
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iee9ebe758786bd1f3b8ff309b3f227404057f18a
Reviewed-on: https://chromium-review.googlesource.com/902932Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534565}

https://webrtc.googlesource.com/src.git/+log/0501e1cd971f..7092368982d3

$ git log 0501e1cd9..709236898 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I57889576fbbcc23a19c86173187b618bce7af539
Reviewed-on: https://chromium-review.googlesource.com/902930
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534564}

BUG=749295

Change-Id: I939cc7ab58cc9a8196fe728c926341f4ccebea20
Reviewed-on: https://chromium-review.googlesource.com/887253Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534563}

Using memcpy() to serialize a POD struct is highly discouraged. Just use
the standard IPC param traits macros for doing it.

Bug: 779428
Change-Id: I48f52c1f5c245ba274d595829ed92e8b3cb41334
Reviewed-on: https://chromium-review.googlesource.com/899649Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534562}

Adds use_titlecase entries for USB device selection, Bluetooth pairing
and device permissions.

Bug: chromium:807886
Change-Id: I355d944e151c14967998d283d5ad578ba512ae9d
Reviewed-on: https://chromium-review.googlesource.com/898246Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534561}

* Splits Audits2Dialog into separate file
* Cleans up Audits2Panel UI refresh logic

Change-Id: Ida6f1b83309e0e90820001a1d96adf823bd918c8
Reviewed-on: https://chromium-review.googlesource.com/877401
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534560}

It was missed in r533917.

Bug: 808182,808943
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3e6774385b6fe2484f7f92042e2442e4bf1e6267
Reviewed-on: https://chromium-review.googlesource.com/902771Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534559}

Browser uses DirectLayerTreeFrameSink::SubmitCompositorFrame to submit
its compositor frame. We need to prepare and submit hit-test data along
with the compositor frame.

This CL prepares the hit-test data for browser, which contains bounds
and flags for itself, and contains hit-test data for the renderers that
this browser embeds in the hit-test regions list - by walking through
every DrawQuad in browser's RenderPassList to find SURFACE_CONTENT ones.

Bug: 806144
Test: viz_unittests
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I11fab7857360a7d589879308ff74ebdd24958469
Reviewed-on: https://chromium-review.googlesource.com/888200Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534558}

To fix the warning from cl/184235490, we need to add the missing
Chromium field trial config.

Bug: 808935
Change-Id: I2624b09a27175a2d24f631ac77175dfc69c5ff1f
Reviewed-on: https://chromium-review.googlesource.com/901042Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534557}

A new chrome option extensionLoadTimeout is added, to control how long
ChromeDriver waits for extension background pages to appear, in units of
milliseconds. If this value is set to 0, then ChromeDriver skips waiting
for the extension background page.

Bug: chromedriver:2235, b/69736143
Change-Id: I035835834f751f7a18bdd198355e69a498498806
Reviewed-on: https://chromium-review.googlesource.com/883962Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534556}

BUG=angleproject:2161

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic059f9672708b9bce9a5ada5d05807e2875466bf
Reviewed-on: https://chromium-review.googlesource.com/899483Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534555}

I ran 'autoninja -c out/Default' and hit compile errors in app_list_demo.
AFAICT, app_list_demo is not built in gn_all (there's no path between them):
  gn path -C out/Default/ :gn_all //ui/app_list:app_list_demo
So, this target probably isn't built by the CQ and thus can break easily.

I fixed the errors and added the target to gn_all.

Bug: NONE
Test: 'autoninja -c out/Default' works; app_list_demo is built by bots
Change-Id: Ia1fb66e182a1dca2f1cd5abc236b20f98a3649a6
Reviewed-on: https://chromium-review.googlesource.com/902742Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534554}

Also modified embed_mobile_devices_in_cpp.py, so users can use both old
device names such as 'iPhone 6', and new names such as 'iPhone 6/7/8'.

Bug: chromedriver:2231
Change-Id: I476527d223bd6d3e440bef3823edba65b214b1fd
Reviewed-on: https://chromium-review.googlesource.com/879467Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534553}

This reverts commit 4180e560.

Reason for revert: Speculative; might've broken win-msvc-rel builds: https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-rel%2F48085%2F%2B%2Frecipes%2Fsteps%2Fcompile__with_patch_%2F0%2Fstdout Will reland if it's unrelated.

Original change's description:
> [NaCl SDK] Fix SDK build breakage due to [[clang::fallthrough]]
> 
> This was broken by: https://chromium-review.googlesource.com/891900
> but went unnoticed because the bots were all red anyway.
> 
> Turns out we acutally compile this code with many different
> compilers, including the PNaCl version of clang which
> doesn't seem to have this attribute :(
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk
> BUG=177475
> 
> Change-Id: Iac06aa0ba1c63a758c666d207c2495edd3352abc
> Reviewed-on: https://chromium-review.googlesource.com/900314
> Commit-Queue: Derek Schuff <dschuff@chromium.org>
> Reviewed-by: Derek Schuff <dschuff@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534534}

TBR=dschuff@chromium.org,sbc@chromium.org,thakis@google.com

Change-Id: I1617a0fc5b8b0e20ccdea9ff94e0a8211d9e8f2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 177475
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_nacl_sdk
Reviewed-on: https://chromium-review.googlesource.com/902845Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534552}

BUG=704209

Change-Id: I4e3841d9252954d1084f0abfe87ace99f254fc01
Reviewed-on: https://chromium-review.googlesource.com/902959Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534551}

This change allows callers of fuchsia_executable_runner() to provide
deps, as a substitute for the previous support for caller-provided
"data_deps" rules. Standalone data_deps rules were removed because
they could lead to the case where data dependencies are specified but
not reflected in the actual build dependency graph.

Change-Id: I48c4cf8b130fa1fd33bccb0c1a45f29559b88cdd
Reviewed-on: https://chromium-review.googlesource.com/902944
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534550}

BridgedNativeWidgetUITest.FullscreenSynchronousState currently fails on 10.13.
AppKit used to be able to start a new fullscreen transition inside the
windowDidEnterFullScreen: observer/delegate callback. Now it fails and just
prints text to stdio like "not in a fullscreen state".

To fix, post the call to -[NSWindow toggleFullScreen:] asynchronously.

Bug: 749939
Change-Id: I3426c961c77db8eef2cf418aedc5df7e17aac468
Reviewed-on: https://chromium-review.googlesource.com/900610Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534549}

https://skia.googlesource.com/skia.git/+log/85c8b493ebdf..d0b9c5093e04

$ git log 85c8b493e..d0b9c5093 --date=short --no-merges --format='%ad %ae %s'
2018-02-05 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 338abb469..22294b041 (1 commit)
2018-02-05 bsalomon Make edge equations be flat interpolated in GrTextureOp
2018-02-05 reed gpu impl for compose and combine maskfilters
2018-02-02 herb Collapse metrics and image into a single call.
2018-02-05 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 14cb42c04..338abb469 (1 commit)
2018-02-05 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ a8aa0a6f7..1ea5993d9 (1 commit)
2018-02-05 kjlubick Clarify XSAN instructions
2018-02-05 penghuang Fix link error with compoent build
2018-02-02 herb Generate cache traffic each iteration

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bsalomon@chromium.org

Change-Id: I924da56028bfb8a7381b43d56aa161189a2004c2
Reviewed-on: https://chromium-review.googlesource.com/902824Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534548}