- 07 Aug, 2020 40 commits
-
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: I5d24e01cc4480190ac7db75535e6ec16b177dd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332714 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#795848}
-
Kateryna Prokopenko authored
Doc: https://docs.google.com/document/d/1hmC2R-f2_024I3urdEpKm34V5tSWeIk8MuRts7rggso/edit# Bug: chromium:1082628 Change-Id: I41aa7243473a7e7d4ef6da7fec4cef0336a27ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316098 Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#795847}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5fd92a7e0c84..7b2dd11dda7a 2020-08-06 antonikarp@google.com spirv-fuzz: TransformationReplaceAddSubMulWithCarryingExtended (#3598) 2020-08-06 andreperezmaselco.developer@gmail.com spirv-fuzz: Add TransformationMakeVectorOperationDynamic (#3597) 2020-08-06 andreperezmaselco.developer@gmail.com spirv-fuzz: iterate over blocks in replace linear algebra pass (#3654) 2020-08-06 stefanomil@google.com spirv-fuzz: make outliner pass use additional transformations (#3604) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: Ieeef1b49dc021050fe555b6e9b23aa9e1fbdd51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795846}
-
Greg Thompson authored
Metrics show that a big surge of cleanups happened when the code shipped, and that there are now diminishing returns. This reverts commit 6cd33735, modulo histogram definitions. BUG=980487,1097919 Change-Id: Ib47cfbc402e6a73afa36e08209eaf5faa69e6592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340051Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#795845}
-
Maxim Kolosovskiy authored
As password scripts have a confirmation step, we don't need to validate an intent to change a password. We still need to check whether a running script is a password script (if yes, the password manager should be notified that a script is running). For that, we will check whether |TriggerContext| has PASSWORD_CHANGE_USERNAME param. (For convenience, this CL moves that parameter's name and also kOverlayColorsParameterName to trigger_context.cc). This CL also changes what origin is used for password store request. If a password script is started from Settings, GetLastCommittedURL is not set yet. So, we have to use the deep url provided. Bug: 1086109 Change-Id: I7c38388b06f433dc51bce1a2b54a7d48bb322bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332594 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#795844}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3831ac2043e4..3c7f144a738e 2020-08-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from ef36eedb0d09 to aba3ab0ce72f (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ib60a4c24213840b0bcea765fc697ada95d08c599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342759Reviewed-by:
-
Pavol Marko authored
PK11_ListCertsInSlot can return nullptr. One of the cases is that the PKCS#11 token that is backing the slot has been removed. Treat the nullptr return value at all call sites as no certs on the slot. Rationale: This happens e.g. during browsertest shut down. Also, re-enable PlatformKeysServicePerUnavailableTokenBrowserTest which was disabled due to this. Bug: 1109635, 1059434 Test: 400 repetitions of PlatformKeysServicePerUnavailableTokenBrowserTest don't crash Change-Id: I585bd6872ca91e9c10cc9fd49265afbaf414756e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317801Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#795842}
-
arthursonzogni authored
Check what is the reported sourceFile depending on the script's origin. Currently, the full URL isn't exposed in the case of a cross-origin script. This is an issue. See https://crbug.com/1113163 TODO: Add checks with redirects. Bug: 1113163 Change-Id: I8bbd1234a485568127a21c6abfbd4d4a623494f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341125 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#795841}
-
Tanmoy Mollik authored
This cl adds the SyncOffPreference in the ManageSyncSettings page. It also adds "Advanced" category after the Preference. The preference is only shown after the user has signed in. So it is not shown in the advanced sync consent flow. The code for ClearDataProgressDialog from AccountManagementFragment is reused here. Bug: 1092410 Change-Id: I0b70ad5cfc32d4c8325680f9929aaae6ccfca65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273193 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#795840}
-
Ewann authored
This CL removes icons that are no longer supported. It also updates some icons and add a new safety_check icon. Bug: 1078782 Change-Id: I5ad94555379d850f53190185b997f6115dfd5c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340965Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#795839}
-
Renato Silva authored
Make the error message on the login screen more generic. Change the subject of the message from 'password' to 'PIN or password' to be reused for the upcoming PIN auto submit feature. UX Writer Document: http://doc/1dyo1BsQ3o7IyDFGvEgWqH1wiZJlEeUuny1G9IQk2r6M Bug: 663982 Change-Id: Idf8f0363b10a9982bdaec42a345a010bf0388e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339358Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#795838}
-
Maksim Moskvitin authored
SecureBoxKeyPair::CreateByPrivateKeyImport() now accepts span<const uint8_t> instead of span<uint8_t> to allow passing const containers. SecureBoxPrivateKey::CreateByImport() now reuses ImportECPrivateKey(), that used to duplicate its logic. This CL is a pure refactoring. Bug: 1101813 Change-Id: Id99edd3f069a7742474a17b73cb5fe69d528eb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340971 Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Andrey Zaytsev authored
* Removed bulk_leak_check_controller_android classes, as they were part of the temporary API for the password check and never actually got used * Used an instance of the PasswordCheck class to manage the lifecycle of the password check in Safety check * Changed the initialization logic to account for the asynchronous availability of the # of saved and compromised passwords * Added logic to block displaying successful states without compromises on fetching the data from disk (# of saved and compromised passwords) * Added unit tests to verify various asynchronous timing scenarios Bug: 1070620 Change-Id: Ia4aee1b06ba820f551a4f66c923174d20b5f8007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336078Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#795836}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8d4d469c0e498bc61dd8955687f34f208c3981da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342757Reviewed-by:
-
David Jean authored
Force resize of content when the content doesn't detect it by itself. Bug: 1091515, 1073446, 1071811 Change-Id: I1d548c3b11ad95b8c26998cf189b0cdc72095f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339459 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795834}
-
Koji Ishii authored
With r795011 <crrev.com/c/2313736>, |NGInlineCursor| supports enumerating all fragments across fragmentainers, and that it made workarounds in |NGFragmentItems| unnecessary. Bug: 829028, 982194 Change-Id: If387d2882b9e599fb0f3f4f72a513cc3b19e5c3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342526 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#795833}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I7703ae5bb3dfe0aa0916ccf6d6b207375ecc6647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342307Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795832}
-
Yunke Zhou authored
Change-Id: I9fc4a070413fbcca01f0edf7236879f2a0caa31a Bug: 1101318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276414 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8221fb43a117..e163bc182576 2020-08-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2be38c3c4d8d6697e63e05a2432444df63c8c35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342745Reviewed-by:
-
dpapad authored
Specifically, modify ExtensionProtocolTestResourcesHandler() to look in both chrome/test/data/ and out/<out_folder>/gen/chrome/test/data/ when trying to resolve _test_resources/ URLs. This is in preparation of using the generated test_browser_proxy.m.js, test_util.m.js and other such files from the PDF Viewer extension tests. Bug: 1111459 Change-Id: I3d925e45f930e890237351688b8c94d11b75bee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337258 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#795829}
-
Vasilii Sukhanov authored
This reverts commit 9b3d32d9. Reason for revert: Broke AcceleratorsCocoaBrowserTest.MappingAcceleratorsInMainMenu on Mac https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/53228 Original change's description: > Tab Search: Setup keyboard shortcut > > Setup ctrl(cmd on Mac) + shift + e as tab search keyboard shortcut > for all desktop platforms > > Bug: 1099917,1112558 > Change-Id: I6c50b26714d678d0f89d2c846909ff0b802e4f0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329944 > Commit-Queue: Yuheng Huang <yuhengh@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795750} TBR=sky@chromium.org,robliao@chromium.org,yuhengh@chromium.org Change-Id: I9fea6a70396d5fd017e76ade2a57984bc7025dd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099917 Bug: 1112558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341635Reviewed-by:
-
Irina Fedorova authored
This CL adds support for multiple IDs to changeSavedPassword. It allows to change saved password for account and device IDs. Bug: 377410 Change-Id: Iaac317006f4086c32b8a007c04c21f3fd753d7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338797 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Mason Freed authored
HTML Imports will be removed from the codebase in M88. Please don't add more usage. Bug: 937746 Change-Id: Ie89325bbe15b643e6af0ed9b8f9d2de60a824757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340496 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#795826}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a202c209bc91..59b4828f293e 2020-08-07 swiftshader.regress@gmail.com Regres: Update test lists @ a202c209 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5be9d15bdcfe23dc7e0e79a7711d4a79ee77520b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342083Reviewed-by:
-
Joel Hockey authored
Bug: 1113607 Change-Id: I0b5ee050412a88ef3a13ff5648bdb912d52b4c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341266 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#795824}
-
Alexander Cooper authored
This change moves files that only talked to each other and the ArCore SDK out of chrome/browser/android/vr and into device/vr, so that they can be more easily re-used in other directories for upcoming prototypes. In addition to this move, the ArCore device code was made into it's own component, as this matches the desired structure of the device/vr directory, and will enable easier (and small binary-size) integration of AR as part of the core content API when ready. One small change was made to convert a GLuint type to an int32_t, as this matches the API surface exposed by ARCore, and thus places the responsibility of ensuring accuracy on callers, while preventing an additional "ui" dependency in device code. Bug: 843374 Change-Id: Id8c3721346284cd5d7e9d78f2352e1d105d3806c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341811Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#795823}
-
Hugo Benichi authored
Change-Id If3e511212f491a5ec6533c8fb259c49eab29295b introduced a regression when the last connected network is disconnected: depending of the exact order of internal callback events in ArcNetHostImpl, it can happen that ARC never learns about the disconnection event. This patch ensures that when the list of active networks becomes empty, ARC receives an event about it. BUG=b:162904019 BUG=b:159667565 TEST=Compiled, flashed rammus, tested disconnecting wifi with no ethernet connected and confirmed that ARC disconnects the network inside Android. Change-Id: Ifcb984f5942d0d132e277a8699fb1f3b43e5b72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336245 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#795822}
-
Marijn Kruisselbrink authored
This not only saves memory, but also makes the (blocking) BlobUrlStore.Registry mojom call faster by not having to set up the blob mojo binding context at that point. On the other hand this makes blob url resolution slightly less efficient, but this seems like the right trade-off. Bug: 1112410 Change-Id: Ic8e97fbcc313ae053f55166d1bad5479a856b8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335402 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#795821}
-
Viviane Yang authored
This CL renames the enum PushDeliveryStautus defined in push_messaging_status.mojom to PushEventStatus. The enum is no longer sorely used for push message delivery events (`push` events) but also for tracking the status of `pushsubscriptionchange` events, which is why a more general name PushEventStatus is more appropriate to report the event dispatch status. Please refer to CL:2332708 for more information. Change-Id: Icbb98dc66b680aa5f194c7dddbd51323918938f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339474Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#795820}
-
Jose Dapena Paz authored
GCC build fails because of missing include: ../../components/payments/core/error_message_util.h:20:16: error: ‘vector’ in namespace ‘std’ does not name a template type 20 | const std::vector<std::string>& skipped_apps); | ^~~~~~ Bug: 957519 Change-Id: Icb7c5b0e9b136d14eb088884f8d4f8ee312b9460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340967Reviewed-by:Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#795819}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/679763691656..ff9cb9b4ed1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: patricialor@google.com Change-Id: I4ed01705382e2d75a25fdccc961337662598bb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342081Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795818}
-
Jiewei Qian authored
Chromium browser grants some permissions to all websites by default. Most WebUIs will expect to have these permissions. However, users can block them if they are not registered with WebUIAllowlist for chrome-untrusted:// pages. This CL registers these permission to the chrome-untrusted:// part of sample system web app, as a reference for future chrome-untrusted:// WebUI implementations. Bug: 1101060 Change-Id: I66e84519ea4d8fc2b3cf759e8f147ad1111c752d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342490 Commit-Queue: Jiewei Qian <qjw@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#795817}
-
Zufeng Wang authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/CUU63VsXItsrBlNDrRhMgCrIBW8n5Lch_BLHRTfvmNUC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008060800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I5a13fbd907624b64977c733eac49088ff5efc98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342427Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#795816}
-
Yves Arrouye authored
Since we only want a new name to run parameterized tests, and no new behavior, we can alias the type rather than create a new class. Bug: None Test: unit_tests --gtest_filter=*AutoEnrollmentClientImplFRETo* Change-Id: Id5c6d80a458baa2dfee382a201b5256d686da6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341171 Auto-Submit: Yves Arrouye <drcrash@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Cherie Cheung authored
This is a reland of 4702a75d Original change's description: > ARCVM SharePath() to use correct seneschal port > > During the processing of ARCVM SharePath() request, it was retrieving > the seneschal port via some Crostini functions. This was incorrect and > would trigger a Crostini restart. This change will properly fix this > by retrieving the correct seneschal port from ArcSessionManagerVmObserver. > > BUG=b:147618164 > TEST=tast run <DUT> arc.Drivefs.vm > > Change-Id: I4f20ffb3101a17b51044e71c7d164bde78ec634d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320908 > Commit-Queue: Cherie Cheung <cherieccy@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794973} Bug: b:147618164 Change-Id: I9570d8b18f05ea0ef629b19144b910dd4380cd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341086Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Cherie Cheung <cherieccy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795814}
-
Fergus Dall authored
This gives the user much more ability to debug failures. Bug: 1110165 Change-Id: I5815a6cba3ac947b07a62fee1f1969118eb8b940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340352 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#795813}
-
My Nguyen authored
As we currently only needs autocorrect marker, we should only request suggestion types. Bug: 1109074 Change-Id: I81ed0fb146b1b37b4ec3159510405f1253a0f78c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342328Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795812}
-
nancylingwang authored
When the scale is not 1.0, e.g. 2.0, the web apps generated icon can't apply the mask correctly, because the web apps icons use the scaled ImageSkiaReps, which don't match the mask imageskia loaded from the ResourceBundle, and CreateMaskedImage reports error due to mismatched scale and pixel size. Add a mask cache to cache the mask ImageSkiaReps for different scale, pixel size, and when loading the mask, check the current image's scale, pixel size to generate the mask imageskia to match the image. BUG=1083331 Change-Id: If16c3603db888e73bb272e6cbdd409ba8d0d4468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336387 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795811}
-
My Nguyen authored
Following UX writing review, update the relevant strings and layout. See go/cros-assistive-input-ux-writing-review. Current view: http://screen/9cXRfLiVR9M Add icon-secondary-color as specified in http://go/cros-ux-icon-color. Added a TODO to rename the rest of the files and strings in code. Bug: 1113612, 1113611 Change-Id: I4360a23addbc7e92bb6eca614e7dd543470f9792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341023Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#795810}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a1495ff04c6..8221fb43a117 2020-08-07 nidhijaju@google.com Revert "Removing "other origins" UI from DevTools Service Worker tab" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112894 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia690cb80328807cea533de5659dfd901e9b57a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342079Reviewed-by:
-
