- 16 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ced0044c7c5c..832dab01db1d 2020-07-16 alexrudenko@chromium.org Quote font family names in single quotes 2020-07-16 tvanderlippe@chromium.org Remove checks for generated files from devtools_entrypoint 2020-07-16 tvanderlippe@chromium.org Cleanup usages of resources_out_dir 2020-07-16 bmeurer@chromium.org [bindings] Fix useless use of `Promise.resolve()`. 2020-07-16 aerotwist@chromium.org Asserts that all devtools_module files are listed in all_typescript_modules 2020-07-16 aerotwist@chromium.org Asserts that each entrypoint is listed in devtools_module_entrypoints If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1105861,chromium:1106221 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3df2cff6728e7193265395f33f076f5634ff335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302678Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789156}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9674de2630535a6e3538c7b2a99f7b3318c78613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302935Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789155}
-
Alex Newcomer authored
Clipboard history did not previously read bitmaps in the initial CL. Bitmaps are read async, just needed some basic refactoring to handle it. Bug: 1102906 Change-Id: I488a0ad239f07c08dec5f93b8d2f03b5cc256e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293464 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#789154}
-
Wan-Teh Chang authored
"Displayable frame" is the term used in libgav1 to refer to an AV1 video frame that can be output and is in the selected operating point. "Displayable buffer" is less clear. Change-Id: I1cfe176d6595e0cea37a2abf7f11e017d85e7eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302738Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#789153}
-
Xiaohan Wang authored
PlayerTracker used to serve two purposes: notify when new usable key is available and when the CDM is destructed. The latter is not needed since the CDM will always outlive the media element now (in fact we pass base::DoNothing() for that). The standard way to notify new key is via CdmContext::EventCB. This CL removes PlayerTracker and use CdmContext::EventCB for new key notification, as the rest of media pipeline does. Bug: 413413,821288 Change-Id: I08b81a8e63902632d516bb8542b5b70d42038afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296268Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789152}
-
chrome://appsAngela Yoeurng authored
Clicking Switch To Tab on chrome://settings just opened chrome://settings in current page, rather than switching to the previously open tab. This fix reverts back to intended behavior. Bug: 1105788 Change-Id: Ied4d19567b2c7da604a57de142d27d53cbdc887b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301122Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Angela Yoeurng <yoangela@chromium.org> Cr-Commit-Position: refs/heads/master@{#789151}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ic7558a96d95314011ae81ad1c62e27bd82aef63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295815 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789150}
-
K. Moon authored
Various small changes to simplify the copy of PaintManager in pdf/: 1. Unify PaintAggregator::ReadyRect and PaintManager::ReadyRect. 2. Drop |ReadyRect::offset| field, which is always (0, 0). 3. Drop |is_always_opaque| option, which is always true. 4. Move PaintAggregator and PaintManager into chrome_pdf::. R=dhoss@chromium.org Bug: 1099020 Change-Id: Ic68d9c32ff24baac5d5a63185da688b11556b93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300989 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: K. Moon <kmoon@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789149}
-
Vladimir Levin authored
This patch refactors SurfaceAggregator::RemapPassId into a separate class. The intent of this is to clean up the code a bit, and to allow the remapper to be extended in the future by allowing persistent ids for certain render passes. R=kylechar@chromium.org, weiliangc@chromium.org Bug: 1106418 Change-Id: I4ffffd15dd4fcd6a51df88f4d14666a5ff320d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280262 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#789148}
-
Peter Wen authored
Removed //net* from the allowlist and added missing deps. Replaced javax annotations with androidx annotations to avoid adding unnecessary deps on //third_party/android_deps:com_google_code_findbugs_jsr305_java. Bug: 1082904 Change-Id: Ib41144c3eff11f5b6321db0b7cd7bdea96ac40f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302491 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789147}
-
Xiaohan Wang authored
The EME spec says that the expiration time should stay NaN if no such time exists or if the license explicitly never expires, which is the case for Clear Key. Therefore, AesDecryptor never needs to update the expiration. Currently we didn't update it in UpdateSession(), and the update in RemoveSession() pretty much has no effect. To avoid confusion, this CL removes the call in RemoveSession() as well. Change-Id: I3439ef9ecb31b5b788880a2b352f45b0bf494030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297692 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#789146}
-
Alfonso Garza authored
Bug: 1099862 Change-Id: Iff787baa5cc7c65a39e23a4f20a77d710cee9ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264610Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Cr-Commit-Position: refs/heads/master@{#789145}
-
Sonny Sasaka authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/6b977833f062..b582eea93ac1 $ git log 6b977833f..b582eea93 --date=short --no-merges --format='%ad %ae %s' 2020-07-13 sonnysasaka system_api: bluetooth: Add Battery interface constants Created with: roll-dep src/third_party/cros_system_api Bug: b:160905767 Change-Id: I453f0eeb68044d67c6316b9ff426fec62aeda80f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301045Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#789144}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b4404b14b04..7fe0359130f9 2020-07-16 rmistry@google.com Add Canary task driver and bots for Android/Chromium/Flutter 2020-07-16 jlavrova@google.com Revert "ICU API: only in SkParagraph, simplified (relanding reverted)." 2020-07-16 adlai@google.com Migrate MakeTextureImage to take GrDirectContext 2020-07-16 jlavrova@google.com ICU API: only in SkParagraph, simplified (relanding reverted). 2020-07-16 jcgregorio@google.com Add more tests to the Pixel4 R Preview devices. 2020-07-16 rmistry@google.com Rename G3 framework bot to Canary-G3 2020-07-16 mtklein@google.com add HALF support to PixelFormat 2020-07-16 herb@google.com SkSpan cleanup 2020-07-16 reed@google.com Revert "Revert "remove support for serialized pictures before aug 2019"" 2020-07-16 robertphillips@google.com Clean up GrContext references in the src/gpu If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I360c172151d75098d0d0ffe9863e8568944c3e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302677Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789143}
-
Steve Becker authored
Increases the Win32 app user model ID max length assert from 64 to 128. 128 is the documented limit that applies to Win7, Win8 and Win10. See https://docs.microsoft.com/en-us/windows/win32/shell/appids#how-to-form-an-application-defined-appusermodelid Bug: 1096850 Change-Id: I42ed9e211421fb5837b1f6ecfcb3b0e57e285502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280591Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789142}
-
Chris Hamilton authored
Subsequent CLs will migrate Shared and Service workers to use similar tokens. This is in support of the performance.measureMemory API, endowing workers with tokens that can be used as an identifier when communicating information regarding V8 memory usage. BUG=1085129, 1096617 Change-Id: I184eabcd1a421ffcfb561f388f620eaf9471d9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297702Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#789141}
-
Anastasia Helfinstein authored
Do not navigate to a node which Switch Access users can't interact with. Fixes a bug where users were entering the dropdown options in a combo box without the options being shown. AX-Relnotes: n/a. Bug: 1095221 Change-Id: Ia7418ca610bc065f525ea5fc9684489f506196d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295802Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#789140}
-
Archana Simha authored
This is the first stage in a larger refactor, which adds support for better typing in prefs while allowing extension prefs to remain agnostic. This CL implements the getter and setter methods for profile wide ExtensionPrefs with string, integer and boolean values. Design Doc: http://go/extprefrefactor Bug: 1069560 Change-Id: I6b8901bd1856d9afbadf358229377fc2db665cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276497 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789139}
-
Justin Cohen authored
Change-Id: Ia74705629553f7070108f76642d40cdbb7838dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300868 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#789138}
-
Brian Sheedy authored
Refactors the GPU Telemetry code to do the following: 1. Move arguments that are used more than once to constants in a new file. 2. Standardize how browser arguments are determined. Now, tests only call either CustomizeBrowserArgs() or RestartBrowserIfNecessaryWithArgs() with any non-default args to use. The base class now handles application of child class-specific default arguments using the GenerateBrowserArgs() class method. 3. Move the --disable-metal-test-shaders argument to be applied to all GPU tests, not just WebGL ones. Bug: 1085899, 1090480 Change-Id: I9f73d5953420cb5b5c8bd3f71d4b091751a92595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300801 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#789137}
-
Scott Violet authored
ThumbnailDatabase takes a HistoryBackendClient, but it doesn't actually use it. This removes the unnecessary argument/field. BUG=1076463 TEST=covered by tests Change-Id: Ib1566a8ec2cd5eb5e3c61c2d3d3950eb20ca05d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299856 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789136}
-
Marijn Kruisselbrink authored
Adds an assertion to idlharness to check the name attribute of methods, and fixes the bindings code to make sure we actually set the name correctly. Bug: 1106097, 1097814 Change-Id: I73dea7b96a94a9b2925c23156e6ef8146291cbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300824Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#789135}
-
Yue Zhang authored
This CL adds e2e test to cover item 1.6.2 and 1.6.3 in https://testtracker.googleplex.com/testplans/details/32981. Bug: 1105511 Change-Id: I029399c0ccbbc0d64975042c2a4915fdbe172bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289937 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789134}
-
Kristi Park authored
This should be OS_CHROMEOS, not OS_LINUX. TBR=reillyg@chromium.org Bug: 1069695 Change-Id: Ib1c3e42ee0110fca5a14d256ca00db2ff737a5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303032Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#789133}
-
Robert Ma authored
Manual import due to https://crbug.com/1106413. Manual changes in disable-site-isolation-trials: * Add two expectations for two new tests * Drive-by: clean up some stale expectations Using wpt-import in Chromium 39d5e00d. With Chromium commits locally applied on WPT: 1adfdd4d "[COOP] Fix typo in test name" f19f3404 "[Sheriff] Revert "Deflake preservesPitch tests"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org: external/wpt/fullscreen foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools ksakamoto@chromium.org, npm@chromium.org, yoavweiss@chromium.org: external/wpt/resource-timing mek@chromium.org: external/wpt/webmessaging mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Bug: 933880, 1106413 Change-Id: Ie829dbb479195ebe94ab9f662578db453b6841ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303349Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#789132}
-
Henrique Nakashima authored
Tweak values so that the movement starts faster and is not clunky while dragging a node. Bug: 1093962 Change-Id: Iff07bf983919315b1b62f4cf629408ca25df07ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300809 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789131}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/59d6160bf267..71892ba52d17 2020-07-16 cduvall@chromium.org Revert "Set WebView implementation for any WebView APK" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105096,chromium:1106385 Tbr: oysteine@google.com Change-Id: Ic823e81f40839c8067f24136ba30e7e018321ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303089Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789130}
-
Anastasia Helfinstein authored
Show options for text input before options for scrolling. AX-Relnotes: n/a. Bug: None Change-Id: Ic477d71cd19274da5ccbe71cff68a3b2e5bab4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292701 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#789129}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 85-4181.3-1594028802-benchmark-85.0.4183.22-r1 to 85-4181.3-1594639678-benchmark-85.0.4183.26-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie259fd70251726208087ad8e19f72476553bfa2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789128}
-
Harry Cutts authored
These mice's HID descriptors claim that they have full keyboards, when actually they're just normal mice. On tablets, this meant that the on-screen keyboard didn't show up with one of the mice connected, preventing text from being entered. Adding them to the blocklist fixes the issue. Tested with all the Microsoft and Logitech mice except the M500s and M185/M187. (The others had been previously identified by Works with Chromebook testing.) (Yes, the mouse is actually just called "Microsoft Bluetooth Mouse", I'm not just being vague: https://microsoft.com/en-us/p/microsoft-bluetooth-mouse/8qbx2w3xsp2h ) appears. Bug: none Test: Connect mouse, touch a text box, and check the on-screen keyboard Change-Id: I7913aebf685334dedafaef90943e9e62d630cde8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298327Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#789127}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I4ce5e2e67ab7bb52036f1dbd264ea1af01c694ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789126}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I95687570d1d473b562ad19c37d3b8b3686b87e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302234Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789125}
-
Henrique Nakashima authored
Move them to chrome/browser/tab:java, from where they can be used by other modules. Bug: 1090048 Change-Id: I6a99ffa0974d426b6cc3e8304d30f76242eacf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246983 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#789124}
-
Colin Blundell authored
Bug: 1082230 Change-Id: Iac0fc26a34858508ba1730ed5985c24de56b764b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302989Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#789123}
-
Oriol Brufau authored
Grid items can get an override for their containing block size, which for example can affect percentage resolution. However, sometimes we need to clear such overrides, which can be checked using ShouldClearOverrideContainingBlockContentSizeForChild. That's already done in LogicalHeightForChild, used by MinContentForChild and MaxContentForChild. But when the min track sizing function is 'auto', the code may use MinLogicalSizeForChild instead of LogicalHeightForChild. And MinLogicalSizeForChild didn't check if the override had to be cleared. This patch makes it perform the check. Bug: 1103592 Change-Id: Ie6012b5099c4988217228352dc552f7437f738d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299354Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#789122}
-
Tomasz Wiszkowski authored
This change pushes existing overscroll detection mode further up the call chain to allow OmniboxSuggestionsRecyclerView to call up keyboard on overscroll if the suggestions list does not contain enough elements to be scrollable in full-screen mode. Bug: 1106150 Change-Id: Icabd061b7a118516bdd9af6364f00761ab32edd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301180Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#789121}
-
Alex Gough authored
High level sandbox policy is now housed in //sandbox/policy. This is part of moving the service manager back into //content. Bug: 1097376 Change-Id: If71f2097d54eb440325e1705e0045d943fe4df39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289219Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Auto-Submit: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#789120}
-
Albert J. Wong authored
This is necessary to prevent reduce refcount thrashing when AtomicStrings become threadsafe. This CL is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 See this design doc for more details on the larger motivation for this change: https://docs.google.com/document/d/1hp7h6zfD5S6mnMI4cHe1PpacRnb2rNpRRkn1gBBJHuQ/edit#heading=h.erv1bv18t616 Bug: 1083392 Change-Id: Ib6f3a71d0153cc8cff178597e4e9cbd18cd38ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285518 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789119}
-
Clark DuVall authored
Note: I will convert base::Bind calls to base::BindOnce all at once once all the uses of Callback and Closure are converted in //chromeos/network. Bug: 1007660 Change-Id: I252be683ed8119d412314dc4ead072518f846aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288340 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#789118}
-
Ben Pastene authored
This reverts commit 3f4100fe. Reason for revert: crbug.com/1106435 Original change's description: > Reland "Split the cros_boards gclient var into two for fetching QEMU images." > > This is a reland of 8f372d5f > > Reason for reland: > - All hand-rolled DEPS-consuming apps have been updated. > - No changes in this CL between original & reland. > > Original change's description: > > Split the cros_boards gclient var into two for fetching QEMU images. > > > > This will help with the TODO at: > > https://source.chromium.org/chromium/chromium/src/+/master:build/config/chromeos/rules.gni;drc=ded9eb5153bb13b3f8821a6fa6fac6b3f0f590fd;l=22 > > > > It will also remove the need for hard-coding the names of all these > > QEMU-compatible boards. > > > > Bug: 937821 > > Change-Id: Iab180fc012bd694b4908ba0654da93d42e2274fa > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265498 > > Commit-Queue: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#786005} > > Bug: 937821, 1103538 > Change-Id: I6124b41f5032d9daffd4b9747ec3a974b19c6db4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299469 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788734} TBR=thakis@chromium.org,dpranke@google.com,erikchen@chromium.org,bpastene@chromium.org Change-Id: I9b3b7d8a2f8b5b91211bf74fdd7d609766068196 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937821 Bug: 1103538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303037Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#789117}
-