GitLab

Reviewed by Geoff Garen.

And remove some uncalled functions from JSImmediate.h

* jit/JITInlineMethods.h:
(JSC::JIT::emitTagAsBoolImmediate):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_not):
* runtime/JSImmediate.h:
(JSC::JSImmediate::makeInt):
(JSC::JSImmediate::makeBool):
(JSC::JSImmediate::intValue):
(JSC::JSImmediate::boolValue):
(JSC::JSImmediate::asInt32):
(JSC::JSImmediate::toDouble):
(JSC::JSValue::asInt32):
(JSC::JSValue::isUInt32):
(JSC::JSValue::asUInt32):



git-svn-id: svn://svn.chromium.org/blink/trunk@83192 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Carlson.

        Add tests for parsing codecs parameter in video-can-play-type.html
        https://bugs.webkit.org/show_bug.cgi?id=53275

        * media/video-can-play-type-expected.txt:
        * media/video-can-play-type.html:
2011-04-07  Nancy Piedra  <nancy.piedra@nokia.com>

        Reviewed by Eric Carlson.

        Parse quotes from content type parameters
        https://bugs.webkit.org/show_bug.cgi?id=53275

        This functionality is tested in video-can-play-type.html layout test
        where I've added codecs parameter with good and bad formatting.

        * platform/ContentType.cpp:
        (WebCore::ContentType::parameter):

git-svn-id: svn://svn.chromium.org/blink/trunk@83191 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: remove "enabled" from the setBreakpoint protocol.
        https://bugs.webkit.org/show_bug.cgi?id=58047

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::hasBreakpoint):
        * bindings/v8/DebuggerScript.js:
        ():
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::setBreakpoint):
        * inspector/Inspector.json:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::buildObjectForBreakpointCookie):
        (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::continueToLocation):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/ScriptBreakpoint.h:
        (WebCore::ScriptBreakpoint::ScriptBreakpoint):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.callback):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
        (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled.afterUpdate):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
        (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpointsFromSettings):
        (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype._reset):
        (WebInspector.PresentationBreakpoint):

git-svn-id: svn://svn.chromium.org/blink/trunk@83190 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=58059

Adding this test to the mac-wk2 skipped list to get the bots green.

* platform/mac-wk2/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@83189 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57862
 
Reviewed by Adam Roben.

Part 3: Implement checkSpellingOfString

In WebCore, checkTextOfParagraph is only defined and used on platforms where
WTF_USE_UNIFIED_TEXT_CHECKING is defined (which right now is only non-Leopard and non-Tiger
Mac builds).
 
On other platforms, checkSpellingOfString and checkGrammarOfString (coming in a separate
patch in an attempt to keep things easier to review) are used.

* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/TextChecker.h:
Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING).
(WebKit::WebPageProxy::checkSpellingOfString):
Call through to the client.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.

* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::checkSpellingOfString):
Call through to the WebTextCheckerClient.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING) for clarity.
(WebKit::TextChecker::checkSpellingOfString):
Add a call to notImplemented.
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::checkSpellingOfString):
Ditto, and remove the implementation for checkTextOfParagraph.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::checkSpellingOfString):
Ditto.

* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkSpellingOfString):
* UIProcess/win/WebTextCheckerClient.h:

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::checkSpellingOfString):
Send a sync message to the UI Process (similar to the sync message used for
checkTextOfParagraph).



git-svn-id: svn://svn.chromium.org/blink/trunk@83188 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [chromium] Unreviewed, now that bug 57975 is fixed, mark test as passing.

        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83187 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/mac-leopard/fast/blockflow/text-orientation-basic-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@83186 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Martin Robinson.

        [GTK] Need a way to get the path to a WebKitWebPlugin
        https://bugs.webkit.org/show_bug.cgi?id=57968

        Expose the path of the plugin through the WebKitWebPlugin object.

        * webkit/webkitwebplugin.cpp:
        (webkit_web_plugin_get_path):
        * webkit/webkitwebplugin.h:
        * webkit/webkitwebpluginprivate.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@83185 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Benjamin Poulain.

        [Qt] QWebFrame::setUrl works only from second time if url fragment is present
        https://bugs.webkit.org/show_bug.cgi?id=32723

        When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
        use an invalid URL (the begin() without arguments). Clearing the document
        with the same URL was causing problems when we had a fragment because it assume that
        only scrolling was enough and did not loaded the document again.

        When setUrl() is called but fails, url() is expected to return the requested value. The
        begin(url) guaranteed that before. This patch adds a member to track the URL, which is
        updated when the URL changes and also when setUrl() is called.

        KURL was used for the member so that when setUrl() is called, and then url() is checked
        before the page gets loaded, we perform the same conversion that will be performed by a
        successful load, e.g. add trailing '/' to an address. This behavior is checked by
        tst_QWebFrame::requestedUrl() test.

        For the record: the second QWebPage::setUrl() worked because the load was considered a
        FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
        needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.

        * Api/qwebframe.cpp:
        (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal.
        (clearCoreFrame):
        (isCoreFrameClear):
        (QWebFrame::setUrl):
        (QWebFrame::url):
        (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change
        the baseURL, e.g. by using the <base> tag.
        * Api/qwebframe_p.h:

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
        (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::setUrlWithFragment): unskip test.

git-svn-id: svn://svn.chromium.org/blink/trunk@83184 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [chromium] Unreviewed, rebaseline tests changed in r82947.

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
        * platform/chromium-linux/svg/text/text-midpoint-split-bug-expected.png: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
        * platform/chromium-win/svg/text/text-midpoint-split-bug-expected.png: Added.
        * platform/chromium-win/svg/text/text-midpoint-split-bug-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83183 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Flagging platform/chromium/compositing/huge-layer-rotated.html a bug.

        * platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        editing/inserting/6633727.html should be renamed and converted into a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=58037

        Renamed 6633727.html to insert-paragraph-at-end-of-line.html and converted it to a dump-as-markup test.

        * editing/inserting/6633727-expected.txt: Removed.
        * editing/inserting/6633727.html: Removed.
        * editing/inserting/insert-paragraph-at-end-of-line-expected.txt: Added.
        * editing/inserting/insert-paragraph-at-end-of-line.html: Copied from LayoutTests/editing/inserting/6633727.html.
        * editing/inserting/script-tests/6633727.js: Removed.


git-svn-id: svn://svn.chromium.org/blink/trunk@83181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Adam Roben.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes): No need to compare line gap values, as
this is covered by the earlier hasIdenticalAscentDescentAndLineGap() check.



git-svn-id: svn://svn.chromium.org/blink/trunk@83180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Enable webkit build with GCCE on Symbian.
        https://bugs.webkit.org/show_bug.cgi?id=57841

        * wtf/MathExtras.h: GCCE compiler doesn't support those std static functions.
2011-04-07  Liang Qi  <liang.qi@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Enable webkit build with GCCE on Symbian.
        https://bugs.webkit.org/show_bug.cgi?id=57841

        * WebCore.pri: Thanks for Norbert Leser  <norbert.leser@nokia.com> who checked RVCT part.
        --rw-base value in QMAKE_LFLAGS.ARMCC and -Tdata value in QMAKE_LFLAGS.GCCE are updated
        to 0x1000000 together. They need to be updated in the future when WebKit grows.

git-svn-id: svn://svn.chromium.org/blink/trunk@83179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Laszlo Gombos.

        [Qt][WK2][Symbian] Temporary build fix until native Symbian IPC is done. Implement fake socketpair() as it's not available.
        https://bugs.webkit.org/show_bug.cgi?id=57877

        * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
        (WebKit::socketpair): socketpair() which returns -1

git-svn-id: svn://svn.chromium.org/blink/trunk@83178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Maciej Stachowiak.

        WebKit2: Memory leak in decodeResourceError
        https://bugs.webkit.org/show_bug.cgi?id=58004

        Release the local NSError after it is used to create a ResourceError
        object assigned to the reference argument.

        * Shared/mac/WebCoreArgumentCodersMac.mm:
        (CoreIPC::decodeResourceError):


git-svn-id: svn://svn.chromium.org/blink/trunk@83177 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: get rid of Breakpoint.js.
        https://bugs.webkit.org/show_bug.cgi?id=57949

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/Breakpoint.js: Removed.
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint.didLoadSnippet):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
        (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpoint):
        (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
        (WebInspector.DebuggerModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerModel.prototype._breakpointResolved):
        (WebInspector.DebuggerModel.prototype.reset):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didSetBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
        (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype._reset):
        (WebInspector.PresentationBreakpoint):
        (WebInspector.PresentationBreakpoint.prototype.get sourceFile):
        (WebInspector.PresentationBreakpoint.prototype.get url):
        (WebInspector.PresentationBreakpoint.prototype.get resolved):
        (WebInspector.PresentationBreakpoint.prototype.loadSnippet):
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel):
        (WebInspector.ResourceTreeModel.prototype._onResourceStarted):
        (WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._breakpointUpdated):
        (WebInspector.ScriptsPanel.prototype.reset):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:

git-svn-id: svn://svn.chromium.org/blink/trunk@83176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: console messages names should adhere to the common naming style
        https://bugs.webkit.org/show_bug.cgi?id=58042

        * inspector/protocol/console-agent-expected.txt:
2011-04-07  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: console messages names should adhere to the common naming style
        https://bugs.webkit.org/show_bug.cgi?id=58042

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        (WebCore::ConsoleMessage::updateRepeatCountInConsole):
        * inspector/Inspector.json:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared):
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):

git-svn-id: svn://svn.chromium.org/blink/trunk@83175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.

git-svn-id: svn://svn.chromium.org/blink/trunk@83174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed, unskip a fast/xmlhttprequest test passing on GTK.

        * platform/gtk/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@83173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/qt-wk2/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@83172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
        https://bugs.webkit.org/show_bug.cgi?id=57957

        There is not a significant difference between  inspector messages spec and and JSON-RPC 2.0 messages spec.
        Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
        It was decided that we will use it.

        the list of renames:
        1) type-> /dev/null
        2) domain + '.' + event => method // for events
        3) domain + '.' + command => method // for requests
        4) requestId => id // for responses
        5) arguments => params // for requests
        6) data => params // for events
        7) body => result // for responses

        protocolErrors and error properties will be converted to JSON-RPC error format.
        The order of properties in messages also will be adjusted.
        The only thing that looks unnecessary is jsonrpc property.

        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/runtime-agent-expected.txt:
        * inspector/report-API-errors-expected.txt:
        * inspector/report-API-errors.html:
        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2011-04-06  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
        https://bugs.webkit.org/show_bug.cgi?id=57957

        There is not a significant difference between  inspector messages spec and and JSON-RPC 2.0 messages spec.
        Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
        It was decided that we will use it.

        the list of renames:
        1) type-> /dev/null
        2) domain + '.' + event => method // for events
        3) domain + '.' + command => method // for requests
        4) requestId => id // for responses
        5) arguments => params // for requests
        6) data => params // for events
        7) body => result // for responses

        protocolErrors and error properties will be converted to JSON-RPC error format.
        The order of properties in messages also will be adjusted.
        The only thing that looks unnecessary is jsonrpc property.

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: svn://svn.chromium.org/blink/trunk@83171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
(Unfortunately the buildbot documentation does not make this clear.) finished() is the only
hook we have, so we have to do our work there. I added a new addCustomURLs method which can
be overridden by subclasses to provide extra URLs before we call up to the base class (after
which adding more URLs is no longer possible).

Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
bot results page

Reviewed by John Sullivan.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
(ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
method is never called for MasterShellCommands.
(ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
with this method (which is).

git-svn-id: svn://svn.chromium.org/blink/trunk@83170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not reviewed: rolling chromium DEPS 80421:80767.

        * DEPS:


git-svn-id: svn://svn.chromium.org/blink/trunk@83169 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This matches how most of our other build steps work, so is good just for improving
consistency between build steps. It should also make it possible for
ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
trying to do this in finished() after we had called up to the base class, but that was
apparently too late to add more URLs.)

Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
results page

Reviewed by John Sullivan.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ExtractTestResults): Added a descriptionDone property so that we don't have to manually
call setText to get the right text to show up for this step. This matches how most of our
other build steps work.
(ExtractTestResults.commandComplete): Replaced our override of finished with this function.
This is how most of our other build steps work.
(ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
function, to match the base class.

git-svn-id: svn://svn.chromium.org/blink/trunk@83168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Rename didReceiveData2 to didReceiveData as part of enabling transfer size support.
        https://bugs.webkit.org/show_bug.cgi?id=58036

        Renamed didReceiveData2 to didReceiveData.

        * public/WebURLLoaderClient.h:
        (WebKit::WebURLLoaderClient::didReceiveData):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::didReceiveData):

git-svn-id: svn://svn.chromium.org/blink/trunk@83167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Migrate didReceiveData in upstream for plugins as part of enabling transfer size support.
        https://bugs.webkit.org/show_bug.cgi?id=58034

        Migrated didReceiveData to support new lengthReceived parameter.

        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):

git-svn-id: svn://svn.chromium.org/blink/trunk@83166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        Add functions to update left and right offsets to LineOffsets
        https://bugs.webkit.org/show_bug.cgi?id=58028

        Added update() and shrinkWidthForNewFloatIfNeeded(FloatingObject*) to LineOffsets,
        which are used to update m_left and m_right. Also added m_block and m_isFirstLine
        member variables to LineOffsets so that users of LineOffsets don't have to pass them around.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::skipLeadingWhitespace): No longer passes firstLine to positionNewFloatOnLine.
        (WebCore::LineOffsets::LineOffsets): Takes RenderBlock* and isFirstLine instead of left and right offsets.
        (WebCore::LineOffsets::update): Extracted from findNextLineBreak and positionNewFloatOnLine.
        (WebCore::LineOffsets::shrinkWidthForNewFloatIfNeeded): Extracted from positionNewFloatOnLine.
        (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
        (WebCore::RenderBlock::positionNewFloatOnLine): Calls shrinkWidthForNewFloatIfNeeded and update and
        no longer passes firstLine around.

git-svn-id: svn://svn.chromium.org/blink/trunk@83165 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: migrate debugger domain to the unified breakpoint location notion.
        https://bugs.webkit.org/show_bug.cgi?id=57928

        * inspector/Inspector.json:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::buildObjectForBreakpointCookie):
        (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
        (WebCore::InspectorDebuggerAgent::setBreakpoint):
        (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
        (WebInspector.DebuggerModel.prototype._breakpointResolved):

git-svn-id: svn://svn.chromium.org/blink/trunk@83164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [Chromium] Move Leopard-specific images to chromium-mac-leopard, and
        unify text results common in chromium-mac.

        * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
        * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
        * platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
        * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@83163 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Rohde Christiansen.

        Build fix when using Phonon as a backend for the multimedia support.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        * WebCoreSupport/ChromeClientQt.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@83162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        Convert insert-div-021.html to a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=58019

        Converted the test.

        * editing/inserting/insert-div-021-expected.txt: Added.
        * editing/inserting/insert-div-021.html:
        * platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum: Removed.
        * platform/chromium-linux/editing/inserting/insert-div-021-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-div-021-expected.checksum: Removed.
        * platform/chromium-win/editing/inserting/insert-div-021-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-div-021-expected.txt: Removed.
        * platform/gtk/editing/inserting/insert-div-021-expected.checksum: Removed.
        * platform/gtk/editing/inserting/insert-div-021-expected.png: Removed.
        * platform/gtk/editing/inserting/insert-div-021-expected.txt: Removed.
        * platform/mac/editing/inserting/insert-div-021-expected.checksum: Removed.
        * platform/mac/editing/inserting/insert-div-021-expected.png: Removed.
        * platform/mac/editing/inserting/insert-div-021-expected.txt: Removed.
        * platform/qt/editing/inserting/insert-div-021-expected.txt: Removed.

git-svn-id: svn://svn.chromium.org/blink/trunk@83161 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Benjamin Poulain.

        [Qt] Mask the QStyle::State_Horizontal hint for vertical scrollbars.

        When initializing a QStyleOptionSlider from a widget, the State_Horizontal
        hint may get set depending on how that widget is laid out in its parent.
        If this happens when drawing a vertical scrollbar, the hint is never
        cleared and we end up painting a vertical scrollbar with horizontal arrows.

        Covered by pixel tests which should no longer paint silly scrollbars.

        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::styleOptionSlider):


git-svn-id: svn://svn.chromium.org/blink/trunk@83160 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        script-src should block inline script
        https://bugs.webkit.org/show_bug.cgi?id=58012

        Test that script-src blocks inline script.  This test uses a different
        approach than the existing tests for variety.

        * http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/inline-script-blocked.html: Added.
        * http/tests/security/contentSecurityPolicy/resources/document-write-alert-fail.js: Added.
        * http/tests/security/contentSecurityPolicy/resources/dump-as-text.js: Added.
2011-04-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        script-src should block inline script
        https://bugs.webkit.org/show_bug.cgi?id=58012

        Block inline scripts at the ScriptElement layer.  This should catch
        exactly the scripts we want to catch.

        Test: http/tests/security/contentSecurityPolicy/inline-script-blocked.html

        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
            - This patch also adds the ability to supply a CSP policy via a
              <meta> tag.  We'll update the name of the header once we've
              finished implementing the spec.
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::executeScript):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowInlineScript):
        * page/ContentSecurityPolicy.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@83159 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Maciej Stachowiak.

        webkit-patch shouldn't state the whole working copy when calling check-webkit-style
        https://bugs.webkit.org/show_bug.cgi?id=58022

        Previously, we were ignoring the args variable!  This patch fixes the
        regression introduced in http://trac.webkit.org/changeset/82771.

        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/checkstyle.py:

git-svn-id: svn://svn.chromium.org/blink/trunk@83158 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Barth.

        Remove temporary WebProcess sandbox rules that are unnecessary now that plugins are in their own process
        https://bugs.webkit.org/show_bug.cgi?id=58023

        * WebProcess/com.apple.WebProcess.sb:


git-svn-id: svn://svn.chromium.org/blink/trunk@83157 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        [Chromium] Update Linux x86-64 results for the Skia rounding rect change.

        * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
        * platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.png:

git-svn-id: svn://svn.chromium.org/blink/trunk@83156 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Skip platform/mac/fast/forms/input-appearance-spinbutton-up.html on Mac WebKit2.
        https://bugs.webkit.org/show_bug.cgi?id=56298

        * platform/mac-wk2/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@83155 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Update spinbutton test results for r83145.

        * platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
        * platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
        * platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
        * platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
        * platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
        * platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
        * platform/chromium/test_expectations.txt:
        * platform/win/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@83154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ryosuke Niwa.

        Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
        https://bugs.webkit.org/show_bug.cgi?id=57921

        Moves the MouseEventWithHitTestResults::targetNode() method on to EventHandler, so
        that the same logic can be used for a HitTestResult.

        No visible changes, just cleanup, so no tests.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::selectClosestWordFromMouseEvent):
        (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
        (WebCore::EventHandler::handleMousePressEventTripleClick):
        (WebCore::EventHandler::handleMousePressEventSingleClick):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseDraggedEvent):
        (WebCore::EventHandler::handleMouseReleaseEvent):
        (WebCore::EventHandler::subframeForHitTestResult):
        Made public static member, so that it can access targetNode(), and be accessed by
        webkitwebview in gtk.
        (WebCore::EventHandler::selectCursor):
        (WebCore::EventHandler::targetNode):
        (WebCore::EventHandler::handleMouseDoubleClickEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::updateDragAndDrop):
        (WebCore::EventHandler::sendContextMenuEvent):
        * page/EventHandler.h:
        * page/MouseEventWithHitTestResults.cpp:
        (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
        * page/MouseEventWithHitTestResults.h:
        * page/android/EventHandlerAndroid.cpp:
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        * page/brew/EventHandlerBrew.cpp:
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        * page/chromium/EventHandlerChromium.cpp:
        (WebCore::EventHandler::passMousePressEventToSubframe):
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        * page/efl/EventHandlerEfl.cpp:
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        * page/gtk/EventHandlerGtk.cpp:
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        * page/haiku/EventHandlerHaiku.cpp:
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        (WebCore::EventHandler::passSubframeEventToSubframe):
        * page/wx/EventHandlerWx.cpp:
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
2011-04-07  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Ryosuke Niwa.

        Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
        https://bugs.webkit.org/show_bug.cgi?id=57921

        * webkit/webkitwebview.cpp:
        (webkit_web_view_forward_context_menu_event):
        Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode()
        method has moved on to EventHandler.

git-svn-id: svn://svn.chromium.org/blink/trunk@83153 bbb929c8-8fbe-4397-9dbb-9b2b20218538