- 25 Oct, 2016 14 commits
-
-
luoe authored
Before, switching devices in Device Mode would set the zoom scale to fit the window. Now, devices will remember their last used mode. BUG=656020 Review-Url: https://codereview.chromium.org/2431823002 Cr-Commit-Position: refs/heads/master@{#427196}
-
mahmadi authored
BUG=653836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2428083002 Cr-Commit-Position: refs/heads/master@{#427195}
-
xidachen authored
Most of these tests are testing conformance for TypedArrays, ArrayBuffer, bufferData, and some basic WebGL functions. I believe all these tests are upstreamed in Github, so there is no reason to keep it here. Note that I didn't delete all tests under this dir, only the ones I can quickly locate its duplicates on conformance test suite. BUG=none Review-Url: https://codereview.chromium.org/2447493002 Cr-Commit-Position: refs/heads/master@{#427194}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2442953002 Cr-Commit-Position: refs/heads/master@{#427193}
-
yusukes authored
Also, add GetAppIndex() to ArcNavigationThrottle and use it from ArcExternalProtocolDialog to reduce code duplication. BUG=None TEST=try Review-Url: https://codereview.chromium.org/2443313002 Cr-Commit-Position: refs/heads/master@{#427192}
-
warx authored
BUG=658124 TEST=self sustained Review-Url: https://codereview.chromium.org/2442933002 Cr-Commit-Position: refs/heads/master@{#427191}
-
rockot authored
Changes serviceConnectionError() to be a no-op if Platform::current() is null. This can happen because MessageLoop destruction may invoke the callback after Blink shutdown. TBRing since this precise change was recommended by haraken@ and I'd like to make sure the fix lands ASAP. BUG=650637 TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2446723002 Cr-Commit-Position: refs/heads/master@{#427190}
-
dougt authored
Revert of Add threadsafe version of PermissionManager::GetPermissionStatus (patchset #5 id:80001 of https://codereview.chromium.org/2439673004/ ) Reason for revert: Going to address a number of issues that Raymes pointed out including: 1) It's unclear the purpose the overloaded GetPermissionStatus function (see https://google.github.io/styleguide/cppguide.html#Function_Overloading). It could be good to name it something that reflects its usage from a background thread. 2) In PermissionManager, it's unclear that it is threadsafe while the rest of the class isn't - we should add a comment. 3) It's unclear why HostContentSettingsMap needs to be passed in - it's already available in the PermissionContextBase. 4) I feel like it would be better to leave the default implementation empty in the PermissionContextBase and have NOTREACHED. Then if someone really wants to support querying a permission safely from a background thread, they have to think about it. Original issue's description: > Add threadsafe version of PermissionManager::GetPermissionStatus > > Add a version of GetPermissionStatus that takes a host_content_settings_map. > This method is guaranteed to be threadsafe. > > BUG=658020 > > R=jochen, mlamouri > > Committed: https://crrev.com/d6b19d48cf91f89c1ec414485b781f2ef2434521 > Cr-Commit-Position: refs/heads/master@{#427078} TBR=mlamouri@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=658020 Review-Url: https://codereview.chromium.org/2446863002 Cr-Commit-Position: refs/heads/master@{#427189}
-
xidachen authored
The transferToImageBitmap is an API in OffscreenCanvas. This API could throw exception in certain cases, which means that the OffscreenCanvas::transferToImageBitmap() method has a ExceptionState& parameter. In our current implementation, we do all the exception check in the above method. However, we still pass the ExceptionState& parameter to the CanvasRenderingContext::transferToImageBitmap() method, and this method is overriden by OffscreenCanvasRenderingContext2D, WebGLRenderingContext, and WebGL2RenderingContext. So this method in all these sub-classes also take a ExceptionState& parameter but do nothing with it. We should not need to pass this parameter to CanvasRenderingContext::transferToImageBitmap. TBR=kbr@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2440213003 Cr-Commit-Position: refs/heads/master@{#427188}
-
mattdr authored
Added by mistake in https://chromiumcodereview.appspot.com/2436913003 BUG=webrtc:6376 Review-Url: https://codereview.chromium.org/2450553002 Cr-Commit-Position: refs/heads/master@{#427187}
-
dougarnett authored
BUG=656099 Review-Url: https://codereview.chromium.org/2440733002 Cr-Commit-Position: refs/heads/master@{#427186}
-
bashi authored
Memory coordinator should update renderers' memory state when their visibility have changed. For a visible (foreground) renderer, the state is set to NORMAL. For background renderers, the states are set to the global state. BUG=617492 Review-Url: https://codereview.chromium.org/2443093002 Cr-Commit-Position: refs/heads/master@{#427185}
-
shrike authored
When compiling against the 10.9 SDK, IOBluetoothAddServiceDict() and IOBluetoothRemoveServiceWithRecordHandle() generate deprecation errors. This cl removes the instances of this old API. R=isherman@chromium.org BUG=650836 Review-Url: https://codereview.chromium.org/2393723002 Cr-Commit-Position: refs/heads/master@{#427184}
-
mmenke authored
The new ResourceHandler's OnWillStart was never being called, which violates the ResourceHandler's API contract, and has caused at least one crash previously (Though that fixed by another CL). BUG=650717 Review-Url: https://codereview.chromium.org/2436163002 Cr-Commit-Position: refs/heads/master@{#427183}
-
- 24 Oct, 2016 26 commits
-
-
agrieve authored
Some targets (e.g. unit_tests_apk) are starting to hit the limit! BUG=658782 Review-Url: https://codereview.chromium.org/2445883002 Cr-Commit-Position: refs/heads/master@{#427182}
-
rouslan authored
BUG=600808 Review-Url: https://codereview.chromium.org/2444493002 Cr-Commit-Position: refs/heads/master@{#427181}
-
csharrison authored
For most regular fetches, we apply the user agent twice: - addAdditionalRequestHeaders - prepareRequest This patch changes FrameLoader::applyUserAgent to FrameLoader::applyUserAgentIfNeeded which first checks if the user agent is set. This avoids going to the embedder to calculate the override twice. BUG=348655 Review-Url: https://codereview.chromium.org/2445653003 Cr-Commit-Position: refs/heads/master@{#427180}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/9488f450ac9e1b5cf503cd1bb76a964dab60fc57 Add WebView Ui Test to chromium.fyi (yolandyan@chromium.org) https://crrev.com/3a8bfe4caf559c1126a5761154c778dd7ff887de Support xctests (smut@google.com) https://crrev.com/fc06b185bc76c25108800aa40525268d42da6deb Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/284d0f102f55bf7c629a297d89c04b8fde110020 Disable galaxy and new mac perf bots for SOM (martiniss@chromium.org) https://crrev.com/b9e5951f09ad926b5cb8e0563c5c56b3f4e678e6 Revert "Support xctests" (smut@google.com) https://crrev.com/997541305c3617899e17a76fe9c0e5d9a517bdd0 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/1fdfcb63166412adae9361acf85705c5290523c6 Refactoring: Extract helper functions from CMDtry in git_cl.py. (qyearsley@chromium.org) https://crrev.com/037edb823f045ca3e6a13217efd0fcbdcfb2a384 Remove SVN support from apply_issue (agable@chromium.org) https://crrev.com/83faed04862b6c6b7b2034bb256687afeb9d31c0 Remove unnecessary rev_str variable from gclient_scm (agable@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2447913002 Cr-Commit-Position: refs/heads/master@{#427179}
-
dtseng authored
In Ash, there is logic to close menus then asynchronisly perform an accelerator command. However, the accelerator that opens the context menu itself can and does trigger the close path depending on how a person executes the command. On Chrome OS, the shortcut to open a context menu is Search+Shift+Volume Up. Any of these keys should leave the menu as is otherwise, the context menu is effectively a no-op when triggered from the keyboard. TEST=on device, hit search; verify apps list opens. Press Search+Shift+Volume up; verify context menu opens. Press Search+m with ChromeVox on, verify context menu opens. BUG=621331,616130 Review-Url: https://codereview.chromium.org/2434483003 Cr-Commit-Position: refs/heads/master@{#427178}
-
wangxianzhu authored
When mapping from a fixed to an absolute ancestor, mapLocalToAncestor() deals with the case that the ancestor is skipped by fixed's container, but forgot to adjust fixed-position offset. Also fix the similar issue of mapAncestorToLocal(). BUG=656172 TEST=MapCoordinatesTest.FixedPosIn(Fixed|Absolute)PosScrollView TEST=paint/invalidation/fixed-with-border-under-composited-absolute-scrolled.html NOTRY=true (to workaround OOM of android bot) Review-Url: https://codereview.chromium.org/2436283002 Cr-Commit-Position: refs/heads/master@{#427177}
-
oshima authored
Renamed method to reflect what it does, instead of how it's implemented. BUG=None Review-Url: https://codereview.chromium.org/2433233005 Cr-Commit-Position: refs/heads/master@{#427176}
-
falken authored
Now enable/disable are propagated to browser-side ServiceWorkerRegistration and the promises are resolved renderer-side. But it doesn't yet * write to disk * propagate to ServiceWorkerVersion * implement NavigationPreloadManager.getState Tests will be added when getState is implemented. BUG=649558 Review-Url: https://codereview.chromium.org/2433273003 Cr-Commit-Position: refs/heads/master@{#427175}
-
jam authored
BUG=504347 Review-Url: https://codereview.chromium.org/2449533002 Cr-Commit-Position: refs/heads/master@{#427174}
-
rockot authored
Changes BroadcastChannel::close() to be a no-op if Platform::current() is null. This can happen because MessageLoop destruction may invoke this function indirectly, after Blink has been shut down. TBRing since this precise change was recommended by haraken@ and I'd like to make sure the fix lands ASAP. BUG=658726 TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2444103002 Cr-Commit-Position: refs/heads/master@{#427173}
-
dmazzoni authored
When linearly navigating through nodes in the accessibility tree, don't treat a leaf node with text as interesting if the text is only whitespace. Also fix an issue where requesting the first "interesting" node from the root of the tree could sometimes return the root itself, leading to a cycle. BUG=656779 Review-Url: https://codereview.chromium.org/2427813002 Cr-Commit-Position: refs/heads/master@{#427172}
-
groby authored
Default to always pausing tiny content. Removing fieldtrial config as well, since it's redundant. BUG=608886 Review-Url: https://codereview.chromium.org/2434333002 Cr-Commit-Position: refs/heads/master@{#427171}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2443753003 Cr-Commit-Position: refs/heads/master@{#427170}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/e0679d945 BUG=651511 TBR=chrishtr@chromium.org Review URL: https://codereview.chromium.org/2448683002 . Cr-Commit-Position: refs/heads/master@{#427169}
-
krasin authored
Revert of Remove CFI blacklists entries for the fixed bug. (patchset #1 id:1 of https://codereview.chromium.org/2445033002/ ) Reason for revert: Broke 'CFI Linux Full' bot: https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/657/steps/blink_heap_unittests/logs/HeapTest.VectorDestructorsWithVtable Original issue's description: > Remove CFI blacklists entries for the fixed bug. > > BUG=568891 > > Committed: https://crrev.com/08f73f5e954340b0c0b5e29f75568ffdebb80588 > Cr-Commit-Position: refs/heads/master@{#427126} TBR=pcc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=568891 Review-Url: https://codereview.chromium.org/2446803004 Cr-Commit-Position: refs/heads/master@{#427168}
-
twellington authored
Record opening downloads in CCT and fix histogram for download counts. BUG=657542, 657539 Review-Url: https://codereview.chromium.org/2443623002 Cr-Commit-Position: refs/heads/master@{#427167}
-
stevenjb authored
Move remaining ui/chromeos/network code to to ash/common/system/chromeos/network This includes moving the associated resources to src/ash. It also eliminates material_design_icon_controller.cc. BUG=657127 Review-Url: https://codereview.chromium.org/2435903002 Cr-Commit-Position: refs/heads/master@{#427166}
-
achuith authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/88592741eef1..39f0ff99d0cc $ git log 88592741e..39f0ff99d --date=short --no-merges --format='%ad %ae %s' 2016-10-13 hungte cbuildbot: Stop calling make_factory_toolkit. 2016-10-23 akeshet completion_stages: turn a debug log into info 2016-10-17 davidriley cbuildbot: Update constants.py 2016-10-21 davidriley cbuildbot: Do not invoke UploadTestArtifacts with --nobuild or --notests. 2016-10-22 dgarrett Revert "cbuildbot: tie the cache for chrome src per branch" 2016-10-19 achuith cros_vm: Don't use sudo for --disable-kvm. 2016-10-09 akeshet venv: use it for summarize_build_stats 2016-10-21 akeshet completion_stages: debug logging about submitted change metrics 2016-10-19 hungte cbuildbot: Optimize factory branch build time and space. 2016-10-13 yueherngl cbuildbot: tie the cache for chrome src per branch 2016-10-18 sbasi Revert "chromeos_config: temporarily mark guado_moblab-paladin experimental" 2016-10-19 xixuan auto-updater: modify the logic of matching build version. 2016-10-20 nxia Set right dryrun mode in CleanUpStage.CancelObsoleteSlaveBuilds 2016-10-12 cmtice [cbuildbot] update llvm-toolchain config to use bvt-pool. 2016-10-20 akeshet export_to_gcloud: limit batch size to 500 2016-10-19 ayatane [sysmon] Skip virtual network interfaces 2016-10-13 nxia Add scheduled_slaves to metadata in the master build. 2016-10-14 nxia Fix and refactor SearchAllBuilds in Buildbucket_lib. 2016-10-19 dshi gs should retry on SSL handshake timeout 2016-10-17 nxia gs should retry on SSL read-operation-timed-out error. 2016-10-18 akeshet topology: add datastore creds path key 2016-10-18 chrome-bot Update config settings by config-updater. 2016-10-18 hshi chromite: remove nyan_freon board 2016-10-18 chrome-bot Update config settings by config-updater. 2016-10-07 nxia Refactor buildbucket_lib 2016-10-14 aaboagye gs: Add a new SSL error to RetryFilter. 2016-10-12 semenzato chromite: log retries of debug symbol file uploads 2016-09-26 norvez chromeos_config: Enable cyan VM tests, AU tests disabled 2016-09-29 dgarrett chromeos_config: Explicitly assign to trybot waterfall. 2016-10-11 dgarrett binhost_test: Ignore WATERFALL_TRYBOT only boards. 2016-10-13 dgarrett upload_symbols: Report total upload retry attempts. 2016-10-13 dgarrett retry_stats: Expose raw stats numbers. 2016-10-17 stevenjb Revert "deploy_chrome: Remove special handling for mash" 2016-10-13 vapier gs: handle failed compile of crcmod 2016-10-05 pprabhu cbuildbot: Mark skipped and repeated stages clearly. 2016-10-11 agable Remove --transitive flag from gclient invocation 2016-10-12 aaboagye gslib: ignore_no_match ignores NotFoundExceptions. 2016-10-06 sadrul deploy_chrome: Remove special handling for mash 2016-10-11 akeshet venv: use the contents of requirements.txt rather than timestamp 2016-10-04 akeshet lib: move a bunch of libraries to lib/ 2016-10-13 nxia Disable cancelling builds via Buildbucket in CleanUp stage. 2016-10-04 nxia Cancel obsolete paladin slave builds. 2016-10-11 achuith cros_vm: Support for --disable-kvm 2016-10-13 cmtice [toolchain waterfall] Make the amd64 gcc builder use 'peppy'. BUG= Review-Url: https://codereview.chromium.org/2445813002 Cr-Commit-Position: refs/heads/master@{#427165}
-
sebsg authored
Review-Url: https://codereview.chromium.org/2445073002 Cr-Commit-Position: refs/heads/master@{#427164}
-
dmazzoni authored
Revert of Add the shortcut to toggle high contrast mode to the keyboard overlay (patchset #1 id:20001 of https://codereview.chromium.org/2379673002/ ) Reason for revert: http://crbug.com/653330 This shortcut conflicts with some web pages, and there's no consensus on the proper fix (let web pages override, or switch to another key). Original issue's description: > Add the shortcut to toggle high contrast mode to the keyboard overlay > > Screenshot https://drive.google.com/a/google.com/file/d/0B6G_-uQnf1_LMUpQRG02OXRYU1k/view?usp=sharing > > BUG=644758 > TEST=open keyboard overlay, hit Ctrl+Alt, and look at the H key. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/23f688e8fe28d1b260cedba104bf0783331126d4 > Cr-Commit-Position: refs/heads/master@{#421587} TBR=xiyuan@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=644758 Review-Url: https://codereview.chromium.org/2443303002 Cr-Commit-Position: refs/heads/master@{#427163}
-
warx authored
BUG=316738 TEST=tested on device Review-Url: https://codereview.chromium.org/2442033002 Cr-Commit-Position: refs/heads/master@{#427162}
-
flackr authored
BUG=649111 TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2432043007 Cr-Commit-Position: refs/heads/master@{#427161}
-
jamescook authored
Under mash code in chrome cannot directly access the ash aura window hierarchy. Instead it must pass an ash window container id when a new window is being opened. Create a new NetworkConfigView::ShowForType to allow passing a container id. Also clean up some unnecessary code around static initializers. BUG=657021 TEST=open "join other" from system tray menu at login screen and after login Review-Url: https://codereview.chromium.org/2445843002 Cr-Commit-Position: refs/heads/master@{#427160}
-
kylechar authored
WindowServerTestBase already implements the WindowManagerDelegate interface to be a WM client. Instead of connecting to service:ui as a WM client, it connects using mojom::WindowTreeHost. This interface is only used in tests and doesn't exercise the real display codepath in service:ui. Change WindowServerTestBase to connect WM client. The first response that it receives will be in OnWmNewDisplay() instead of OnEmbed(), so move call QuitRunLoop() to OnWmNewDisplay() as well. BUG=none Review-Url: https://codereview.chromium.org/2438193003 Cr-Commit-Position: refs/heads/master@{#427159}
-
pfeldman authored
TBR=dgozman NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2440953003 Cr-Commit-Position: refs/heads/master@{#427158}
-
Krishna Govind authored
Cr-Commit-Position: refs/heads/master@{#427157}
-