- 16 Apr, 2020 40 commits
-
-
Jesse McKenna authored
This change adds a field-trial testing config for the experiment SlowDCTimerInterruptsWin so that it can be enabled on 50% of the Beta channel. Background on the SlowDCTimerInterruptsWin experiment: Windows implements timers (e.g., sleep(50), wait(100)) by polling at some frequency for any waiting timers that may have finished. This is called the 'timer-interrupt frequency', and effectively limits the actual granularity of timers. Chrome frequently raises Windows' global timer-interrupt frequency to make timers more responsive. However, raising the timer-interrupt frequency increases system power consumption, so should be done sparingly. Chrome currently sets the following timer-interrupt frequency limits: Default, not raised: 64 Hz Raised, on wall power: 1000 Hz (MinTimerIntervalHighResMs = 1) Raised, on battery power: 250 Hz (MinTimerIntervalLowResMs = 4) This experiment halves the raised frequency on battery power: Raised, on battery power: 125 Hz (MinTimerIntervalLowResMs = 8) This level has been reported to result in a ~4% power savings and minimal negative impact on performance (per crbug.com/927165). Bug: 927165 Change-Id: I1db7cbacac2697f382d815dc2a48ece905d58871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145761Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#759776}
-
Daniel McArdle authored
Bug: 1071327 Change-Id: Icf4189905dc5c95854b5af4b3e5e25e0607dd39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153325Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#759775}
-
Caroline Rising authored
Mac offers overlay scrollbars that become transparent when not in use. When transparent, the scrollbar still exists and takes click and hover events. This causes a visual bug for the ExtensionsToolbarMeunuView where a button sits partially under the overlay scrollbar. This change updates the scrollbar ability to process events with the subtree when the scrollbar is transparent. Bug: 1016578 Change-Id: I64c363943167a31f39308eacf7863977ab47d2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134648 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#759774}
-
Rafael Cintron authored
Freeing DComp resources such as visuals and surfaces causes the device to become 'dirty'. We must commit the changes to the device in order for the objects to actually be destroyed. Leaving the device in the dirty state for long periods of time means that if DWM.exe crashes, the Chromium window will become black until the next Commit. Bug: 1071288,1011655 Change-Id: I7d118e5bc5f1e4fc6959661b1902939ba7dc83f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152784Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759773}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cca5c49d45e0..b8265f103a9a git log cca5c49d45e0..b8265f103a9a --date=short --first-parent --format='%ad %ae %s' 2020-04-16 demorri@microsoft.com Add cpplint support for space before [[attributes]] Created with: gclient setdep -r src/third_party/depot_tools@b8265f103a9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I65a1c195b7385832e01c8d8c974cf0f3b30c6349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759772}
-
Xiaoqian Dai authored
Bug: 1031766 Change-Id: Ie810de835b2abccaff53bed44ea007836e7fb667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151245Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#759771}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/897e7631c5c8..9b3cba4056fc $ git log 897e7631c..9b3cba405 --date=short --no-merges --format='%ad %ae %s' 2020-04-16 nharper Check for nullptr before calling OnProofVerifyDetailsAvailable 2020-04-16 quiche-dev Fix implicit includes through string_piece.h 2020-04-15 nharper gfe-relnote: Refactor TLS QUIC tests. Test-only change. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I125192a3b820816c94e7b63599347e5f5de6ce72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153332Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759770}
-
David Schinazi authored
It looks like the older MOCK_METHODxx (where xx is the number of arguments) are being deprecated upstream. This CL exists to confirm that they now work well in Chromium (they didn't 6 months ago). Once this lands I'll make changes to allow using them in QUICHE. Change-Id: Ia39c234951679e865acc13bcb66d920052ba522d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152991 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759769}
-
Bo Liu authored
Read default encoding from components_locale_settings, same as chrome. Bug: 1052496 Change-Id: I24e0205ab94e71a3412783d322563ababd64e42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147684 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#759768}
-
Kurt Horimoto authored
This is an AlertOverlayCoordinator subclass that aggregates all the mediator types used for the supported OverlayRequests for alerts shown in OverlayModality::kWebContentArea, allowing for the removal of the boilerplate coordinator code for these overlays. After this CL, new alerts shown over the web content area simply need a new mediator that is added to the coordinator's |supportedMediatorClasses| array. This CL also creates a new util function to instantiate an appropriate mediator for other OverlayRequestCoordinators that support multiple mediator types. InfobarBannerOverlayCoordinator was updated to use this function as well, since it also supports multiple banner mediator classes. Bug: none Change-Id: I360b0f94bb2eb76709074f826854a262fc82ce80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149687 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759767}
-
Evan Stade authored
This struct should more or less mirror LoadURLParams, or at least as much of that struct as necessary. For now it only contains mShouldReplaceCurrentEntry. This makes replace() obsolete. Since this is designed to be merged back to 83, replace() was added in 82, and 82 did not make it to stable, replace() can be removed without the normal deprecation process. Bug: 1070851 Change-Id: I0845bab184a182e9a616b01b6115615275422fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150968Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#759766}
-
Elly Fong-Jones authored
This change removes the overrides of Accept and Cancel on this dialog. Cancel is straightforward; for Accept, a semantic change to the dialog is needed. Right now, this dialog stays open after Accept() is pressed, and normally gets closed as part of the browser teardown process when relaunch succeeds. This change has the dialog close on Accept(), as is best practice. The dialog currently says it stays open so that the user can retry the relaunch operation. That doesn't seem like a good idea - most dialogs don't behave that way. Bug: 1011446 Change-Id: I0725a3d357f7a71a8e27a569acd0cf1cc165ed38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153340 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#759765}
-
Tim Volodine authored
Add a kTypeForTesting to the safe_browsing_blocking_page and a check in the browser test to make sure the correct insterstitial is shown. Also remove unnecessary logging in the test. BUG=1015418,1034546,1071519 TEST=run_weblayer_browsertests --gtest_filter=SafeBrowsingBrowserTest* Change-Id: Ia184557ab08f811dcd0903ba06b185b3d6c2d896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142273 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#759764}
-
Robert Liao authored
Change-Id: Ib66426dadaaa68800c818d00457ebafe73d0e4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153572 Commit-Queue: Robert Liao <robliao@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
SiteSettingsHelper is implemented in //chrome. This removes the dependency of PageInfoController on this class so it can be componentized. Bug: 1052375 Change-Id: I0a80f93d0314a2202e4f3c77a55731759516caf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152368 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759762}
-
Ian Prest authored
Skia takes a precision value when generating strokes as an optimization. When rendering, we pass a value derived from the scale-factor in the CTM, but when hit-testing we were passing a hard-coded value. This worked reasonably well for solid strokes at moderate scales. However, at sufficiently high scales and especially for dashed strokes, the stroke generated for hit-testing was noticeably different from the rendered stroke. This change passes the CTM through to the hit-testing code, so that we can use the same high precision for hit testing as rendering. Bug: 964614 Change-Id: I8dfcb3ade86b9e7b63c7415baab5814ac2286ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112955Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759761}
-
Koji Ishii authored
This patch sipmlifies |IsFirstForNode| for |NGInlineItemResult| by using all information in it. This was originally addded in r754815 <crrev.com/c/2111158>. Bug: 1043787 Change-Id: I3acccd6fd7f53f7eeff955025397216680565850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152336 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#759760}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dff792591fb9..efdff53176d6 git log dff792591fb9..efdff53176d6 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 terelius@webrtc.org Limit BWE drops from probes to 85% of the throughput estimate. 2020-04-16 sprang@webrtc.org Limits size of payload padding packets to 2x target size. 2020-04-16 hta@webrtc.org Remove deprecated ssl_identity methods 2020-04-16 srte@webrtc.org Cleanup: Removes unused BBR congestion controller. 2020-04-16 eshr@google.com Unify AdaptationReason and AdaptReason enums. Created with: gclient setdep -r src/third_party/webrtc@efdff53176d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I245585f978fde779110c27f1a69d100c251c073b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152883Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6cb05cce..e42feaad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I45946d253d33bb23140a18a0a73dbf8f5c926839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153266Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759758}
-
Brian Sheedy authored
Disables VrBrowserWebInputEditingTest#testFullscreenVideoControls on P due to it failing 100% of the time. TBR=alcooper@chromium.org Bug: 1071466 Change-Id: Ibc96c1a726f7b021f52e69942a4992f1e9b58c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153336Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#759757}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/514232c46d65..7b1ae2b1188f git log 514232c46d65..7b1ae2b1188f --date=short --first-parent --format='%ad %ae %s' 2020-04-16 digit@google.com Fuchsia: Add LLVM 10.0 configuration headers. 2020-04-16 amaiorano@google.com CMake: fix PowerVR_Examples build 2020-04-16 amaiorano@google.com Don't fail build if Vulkan headers are different 2020-04-16 amaiorano@google.com CMake: fix add_subdirectory(SwiftShader) when CMAKE_BUILD_TYPE is set in parent project 2020-04-16 amaiorano@google.com CMake: make submodule initialization work for add_subdirectory(SwiftShader) 2020-04-16 amaiorano@google.com CMake: fix add_subdirectory(SwiftShader) 2020-04-16 amaiorano@google.com CMake: use directory variables consistently 2020-04-16 amaiorano@google.com CMake: make root compile options and link libraries private Created with: gclient setdep -r src/third_party/swiftshader@7b1ae2b1188f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ice2f0ff32ef588cfdade96462b891429b40ddf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152876Reviewed-by:
-
Maggie Chen authored
After completing DxDiag, DX12/Vulkan and DevicePerfInfo requests, the info-collection GPU process will shut down atomically. Before this CL, the info-collection GPU process always goes through the slow non-atomic shutdown procedure, which causes a crash when an exception is raised during shutdown. Bug: 1045920 Change-Id: I4dc3041fc940301735e248a52184749be0ef2e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151829Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759755}
-
Brian Sheedy authored
Removes the chrome-gold@ service account from android-kitkat-arm-rel-swarming and android-marshmallow-arm64-rel-swarming, which run tests on chromium-swarm-dev. This is a temporary fix to prevent task triggering from failing while a -dev version of chrome-gold@ is created. Bug: 1071301 Change-Id: I6b532f0c32f3f34f7852ff7e1b23552b7664a8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152782 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#759754}
-
Tibor Goldschwendt authored
Before, the left (almost) semi circle was a bit narrower than the right one. This regressed because the semi circle width was expressed in absolute units and didn't adapt to changes of the overall theme icon size. This CL changes the semi circle width to percentages and thus makes it robust to future theme icon size changes. Fixed: 1070588 Change-Id: I5eab8a2ebce1646a5f4f54e2c3191c3b3751c757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152773 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759753}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66792cf7d6a9..7339a08855d5 Created with: gclient setdep -r src-internal@7339a08855d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1069072 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: Iddee3e058c1d62483722a1b6e8b365d33245dce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152875Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759752}
-
Wenbin Zhang authored
[benchmarking] disable the flaky test system_health.memory_desktop/browse:social:tumblr_infinite_scroll:2018 The test has been flaky and will be disabled for now. Bug: chromium:1068684 Change-Id: I2ad1ffe7554d626b1ce998b4a3e259ef971dcd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153308 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#759751}
-
Victor Hugo Vianna Silva authored
Previously every user of PasswordManagerClient::TriggerReauthForAccount had to retrieve the primary account id to pass it to the API. This is now done internally in the new helper class and the client API is renamed accordingly. Bug: 1070944 Change-Id: If19d5ccdd26c84961a2a90f56ace6b30e370098c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151869 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759750}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7027d3e67c45..9bd480acdcad git log 7027d3e67c45..9bd480acdcad --date=short --first-parent --format='%ad %ae %s' 2020-04-16 hjd@google.com ui: Fix map/parseInt bug 2020-04-16 hjd@google.com Merge "Combine async slices in a single track" Created with: gclient setdep -r src/third_party/perfetto@9bd480acdcad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I17fdf4516e7485fb8762d5885d0bf900076ba7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152881Reviewed-by:
-
Ayu Ishii authored
This change adds browser side check for opaque origins. Related to CL: https://crrev.com/c/2137926/2 Change-Id: Idc1be35b44012b46f9df706392bb0d10aef38b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142773Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#759748}
-
Elly Fong-Jones authored
This dialog's Accept method could return false under two circumstances: if the dialog's app info had not yet been loaded, or if the accept button was disabled. When the accept button is disabled there's no way to hit the Accept() code path, so one of these was dead. For the other, this dialog now disables the accept button when the app info is not available. Bug: 1011446 Change-Id: Ic6dd8bdd6fd2bba2c092004c0dde5f98bf98ea54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151309 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Lei Zhang authored
Test all the possible enum ColorModel values. Bug: 1069537 Change-Id: Ie4fe38a0d97eeea14ad36644fe661936788042de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150979 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#759746}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc5e10322119..cca5c49d45e0 git log fc5e10322119..cca5c49d45e0 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 estaab@google.com Add timestamp info to presubmit logs for easier debugging. Created with: gclient setdep -r src/third_party/depot_tools@cca5c49d45e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iba6653edef157cc7ccdcf806f0808c0ffbccdf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152882Reviewed-by:
-
Devlin Cronin authored
Bug: None Change-Id: I5d7c3aee3fe228c709c0bcbbffe3070333542fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151527Reviewed-by:
-
Kevin Babbitt authored
AccessibilityHitTestingBrowserTest.*WithPinchZoom are still flaking after landing https://crrev.com/c/2140198. This CL adds more logging on failure to help identify the problem. Bug: 1069850, 1070647 Change-Id: I258b17e9b08614cfb5faf4d686f20994230a95a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149905Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759743}
-
Ben Pastene authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/14245e8100e9..de5575dc8a09 git log 14245e8100e9..de5575dc8a09 --date=short --first-parent --format='%ad %ae %s' 2020-04-16 vapier@chromium.org cbuildbot: switch to python3 only via virtualenv wrapper [reland] 2020-04-16 cjmcdonald@chromium.org pytest: Remove 'passes_when_run_alone' marker 2020-04-16 cjmcdonald@chromium.org pytest: Mark all tests that leak processes & skip them 2020-04-16 cjmcdonald@chromium.org pytest: Add autouse fixture to assert that tests don't leak processes 2020-04-16 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-16 uekawa@google.com cros_mark_android_as_stable: Update GIT_COMMIT_MESSAGE to pass lint. 2020-04-16 morg@google.com Add Android arm64 support for cbuildbot_run 2020-04-16 lamontjones@chromium.org toolchain_util: recipes benchmark afdo profile creation 2020-04-16 lamontjones@chromium.org api: freshen python bindings. 2020-04-16 vapier@chromium.org config_lib: delete unused CQ/PreCQ constants 2020-04-15 chrome-bot@chromium.org Update config settings by config-updater. 2020-04-15 navil@google.com Support a dry run of payload generation. 2020-04-15 andrewlamb@chromium.org Revert "Add Android arm64 support for cbuildbot_run" 2020-04-15 bpastene@chromium.org Reland: device: Don't assume '--device=localhost' means VM. Created with: gclient setdep -r src/third_party/chromite@de5575dc8a09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Change-Id: I59e7e9c15606bbc183f5809f0090a3938fe15efe Tbr: chrome-os-gardeners@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152867 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Kurt Horimoto authored
InfobarUIDelegate will not be necessary once we move to the overlay- based implementation. The only functionality needed from the UI delegate necessary with overlays is the InfobarType. This CL adds InfoBarIOS::infobar_type() to access this type, as well as a constructor that does not take an InfobarUIDelegate. This CL also updates the password infobar to be created with this new constructor if the overlay feature is enabled. Bug: 1033228 Change-Id: I3080bc2e5bb9e2e3db23dfe437ada90b70bb1661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150125 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#759741}
-
Brian Salomon authored
Bug: skia:10139 Change-Id: I1cb9b0a79fdce8104db5c9249c364a1f14b0b1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151332 Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#759740}
-
Nicolás Peña Moreno authored
This CL changes the SyntaxErrors to TypeErrors when 'type' and 'entryTypes' are both present or not present. It also adds a UseCounter for when 'entryTypes' is present and 'buffered', the only other member in the dictionary, is also present. Currently this causes a console warning whereas it should instead also throw a TypeError, so once this mistake is proved to be very infrequent, we can proceed to change it to TypeError. See related PR: https://github.com/w3c/performance-timeline/pull/164 Change-Id: Ic9399bf54895e3723b0ca2e513161a7e0638b681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144686 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#759739}
-
Brandon Jones authored
Bug: 1070819 Change-Id: Ia7d32b68864cea37788bc086520e51a0f828c7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149892Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
As the code uses types from CoreImage (CIFilter, CIImage, ...), it needs to declare a dependency. Currently the build works because this dependency comes from Firebase SDK, but it will become required once Firebase is provided through the internal framework. Bug: 1049042 Change-Id: Ib5cda246ab82b7492c6462564006230862dcd019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153068 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#759737}
-
